mjsax opened a new pull request, #15517:
URL: https://github.com/apache/kafka/pull/15517
- add missing section to TOC
- add default value for client.id
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
[
https://issues.apache.org/jira/browse/KAFKA-16356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17825439#comment-17825439
]
Greg Harris commented on KAFKA-16356:
-
[~linu] I have given you permissions to assign tickets. You
chia7712 commented on code in PR #15474:
URL: https://github.com/apache/kafka/pull/15474#discussion_r1520206161
##
core/src/test/scala/integration/kafka/admin/ListOffsetsIntegrationTest.scala:
##
@@ -36,40 +37,79 @@ class ListOffsetsIntegrationTest extends
jolshan commented on code in PR #15364:
URL: https://github.com/apache/kafka/pull/15364#discussion_r1520381484
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupMember.java:
##
@@ -528,27 +478,6 @@ public Map>
jolshan commented on code in PR #15364:
URL: https://github.com/apache/kafka/pull/15364#discussion_r1520414314
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/CurrentAssignmentBuilder.java:
##
@@ -170,72 +127,122 @@ public CurrentAssignmentBuilder
mjsax commented on code in PR #15419:
URL: https://github.com/apache/kafka/pull/15419#discussion_r1520482326
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -546,8 +546,9 @@ public ConsumerGroupHeartbeatRequestData
Greg Harris created KAFKA-16364:
---
Summary: MM2 High-Resolution Offset Translation
Key: KAFKA-16364
URL: https://issues.apache.org/jira/browse/KAFKA-16364
Project: Kafka
Issue Type: New Feature
[
https://issues.apache.org/jira/browse/KAFKA-16291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17825467#comment-17825467
]
Greg Harris commented on KAFKA-16291:
-
[~claudio.benfatto] That's a good idea, I agree that the
CalvinConfluent commented on code in PR #15470:
URL: https://github.com/apache/kafka/pull/15470#discussion_r1520495884
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -2184,9 +2178,139 @@ void handleFailure(Throwable throwable) {
junrao commented on code in PR #15474:
URL: https://github.com/apache/kafka/pull/15474#discussion_r1520506664
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -52,20 +53,24 @@ public class GetOffsetShellTest {
private final int topicCount = 4;
hgeraldino commented on PR #15506:
URL: https://github.com/apache/kafka/pull/15506#issuecomment-1989568163
Thanks @chia7712 for your review
@gharris1727 does this looks good to you? It's the final PR to consider the
`WorkerSinkTaskTest` migration done done
--
This is an automated
jolshan commented on code in PR #15474:
URL: https://github.com/apache/kafka/pull/15474#discussion_r1520542402
##
core/src/test/scala/integration/kafka/admin/ListOffsetsIntegrationTest.scala:
##
@@ -36,40 +37,79 @@ class ListOffsetsIntegrationTest extends
jolshan commented on code in PR #15364:
URL: https://github.com/apache/kafka/pull/15364#discussion_r1520152684
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1400,35 +1440,35 @@ private void
JobseRyan closed pull request #15514: User/rjobse/add xinfra identifier check
URL: https://github.com/apache/kafka/pull/15514
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
JobseRyan opened a new pull request, #15514:
URL: https://github.com/apache/kafka/pull/15514
Pull request to add a check for the client type and library version to check
if the client which is accessing this broker is a xinfra client
### Committer Checklist (excluded from commit
jolshan commented on code in PR #15476:
URL: https://github.com/apache/kafka/pull/15476#discussion_r1520300581
##
core/src/test/scala/integration/kafka/api/OffsetOfMaxTimestampTest.scala:
##
@@ -0,0 +1,77 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or
jolshan commented on code in PR #15476:
URL: https://github.com/apache/kafka/pull/15476#discussion_r1520299410
##
core/src/test/scala/integration/kafka/api/OffsetOfMaxTimestampTest.scala:
##
@@ -0,0 +1,77 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or
[
https://issues.apache.org/jira/browse/KAFKA-16363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17825402#comment-17825402
]
Igor Soarez commented on KAFKA-16363:
-
cc [~pprovenzano]
> Storage crashes if dir is unavailable
>
JobseRyan opened a new pull request, #15515:
URL: https://github.com/apache/kafka/pull/15515
dummy PR
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation
mimaison opened a new pull request, #15516:
URL: https://github.com/apache/kafka/pull/15516
Based on https://github.com/apache/kafka/pull/5927
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build
[
https://issues.apache.org/jira/browse/KAFKA-15841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17825454#comment-17825454
]
Greg Harris commented on KAFKA-15841:
-
[~henriquemota] Okay I think i understand better what you're
chia7712 commented on code in PR #15476:
URL: https://github.com/apache/kafka/pull/15476#discussion_r1520520996
##
core/src/test/scala/integration/kafka/api/OffsetOfMaxTimestampTest.scala:
##
@@ -0,0 +1,77 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
jolshan commented on code in PR #15364:
URL: https://github.com/apache/kafka/pull/15364#discussion_r1520171958
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1796,12 +1834,12 @@ public void onLoaded() {
wcarlson5 commented on code in PR #15421:
URL: https://github.com/apache/kafka/pull/15421#discussion_r1520361134
##
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java:
##
@@ -170,9 +170,6 @@ public void init(final ProcessorContext context,
artemlivshits commented on code in PR #15470:
URL: https://github.com/apache/kafka/pull/15470#discussion_r1520443872
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -2184,9 +2178,139 @@ void handleFailure(Throwable throwable) {
CalvinConfluent commented on code in PR #15470:
URL: https://github.com/apache/kafka/pull/15470#discussion_r1520495884
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -2184,9 +2178,139 @@ void handleFailure(Throwable throwable) {
JobseRyan closed pull request #15515: dummy PR to check acls
URL: https://github.com/apache/kafka/pull/15515
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
cherylws commented on PR #15518:
URL: https://github.com/apache/kafka/pull/15518#issuecomment-1989345872
@mjsax
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
jolshan commented on code in PR #15364:
URL: https://github.com/apache/kafka/pull/15364#discussion_r1520383812
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/CurrentAssignmentBuilder.java:
##
@@ -33,49 +33,6 @@
* The CurrentAssignmentBuilder
bachmanity1 commented on PR #15475:
URL: https://github.com/apache/kafka/pull/15475#issuecomment-1989425275
@kirktrue @mimaison kind reminder. Could you please have a look at the KIP?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
jolshan commented on code in PR #15364:
URL: https://github.com/apache/kafka/pull/15364#discussion_r1520418403
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/MemberState.java:
##
@@ -0,0 +1,76 @@
+/*
+ * Licensed to the Apache Software Foundation
[
https://issues.apache.org/jira/browse/KAFKA-15841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17825454#comment-17825454
]
Greg Harris edited comment on KAFKA-15841 at 3/11/24 9:46 PM:
--
hgeraldino opened a new pull request, #15520:
URL: https://github.com/apache/kafka/pull/15520
This is the last remaining Kafka Connect test that needs migration from
PowerMock/EasyMock to Mockito.
Following the same approach as the `WorkerSinkTaskTest` migration, which was
migrated
Igor Soarez created KAFKA-16365:
---
Summary: AssignmentsManager mismanages completion notifications
Key: KAFKA-16365
URL: https://issues.apache.org/jira/browse/KAFKA-16365
Project: Kafka
Issue
Igor Soarez created KAFKA-16363:
---
Summary: Storage crashes if dir is unavailable
Key: KAFKA-16363
URL: https://issues.apache.org/jira/browse/KAFKA-16363
Project: Kafka
Issue Type: Sub-task
[
https://issues.apache.org/jira/browse/KAFKA-16363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Soarez reassigned KAFKA-16363:
---
Assignee: Igor Soarez
> Storage crashes if dir is unavailable
>
jolshan commented on code in PR #15364:
URL: https://github.com/apache/kafka/pull/15364#discussion_r1520383812
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/CurrentAssignmentBuilder.java:
##
@@ -33,49 +33,6 @@
* The CurrentAssignmentBuilder
mjsax opened a new pull request, #15519:
URL: https://github.com/apache/kafka/pull/15519
For static member, the `group.instance.id` cannot change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
mjsax commented on PR #15519:
URL: https://github.com/apache/kafka/pull/15519#issuecomment-1989525897
Follow up from https://github.com/apache/kafka/pull/15419/files#r1513841644
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
CalvinConfluent commented on code in PR #15470:
URL: https://github.com/apache/kafka/pull/15470#discussion_r1520498085
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -2184,9 +2178,139 @@ void handleFailure(Throwable throwable) {
jolshan commented on code in PR #15364:
URL: https://github.com/apache/kafka/pull/15364#discussion_r1520191884
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Utils.java:
##
@@ -37,4 +42,28 @@ public static OptionalInt ofSentinel(int value) {
public
VictorvandenHoven commented on code in PR #14426:
URL: https://github.com/apache/kafka/pull/14426#discussion_r1520201655
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java:
##
@@ -230,8 +234,19 @@ private void emitNonJoinedOuterRecords(
cherylws opened a new pull request, #15518:
URL: https://github.com/apache/kafka/pull/15518
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of
[
https://issues.apache.org/jira/browse/KAFKA-16357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-16357:
Priority: Critical (was: Major)
> Kafka Client JAR manifest breaks javac linting
>
[
https://issues.apache.org/jira/browse/KAFKA-16357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax resolved KAFKA-16357.
-
Resolution: Duplicate
> Kafka Client JAR manifest breaks javac linting
>
mjsax commented on code in PR #15189:
URL: https://github.com/apache/kafka/pull/15189#discussion_r1520626385
##
streams/src/test/java/org/apache/kafka/streams/integration/RelaxedNullKeyRequirementJoinTest.java:
##
@@ -71,11 +71,21 @@ void afterEach() {
@Test
void
showuon commented on code in PR #15474:
URL: https://github.com/apache/kafka/pull/15474#discussion_r1520857036
##
clients/src/main/java/org/apache/kafka/common/record/MemoryRecordsBuilder.java:
##
@@ -263,13 +262,8 @@ public RecordsInfo info() {
} else if (maxTimestamp
mjsax commented on code in PR #15519:
URL: https://github.com/apache/kafka/pull/15519#discussion_r1520582633
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -529,10 +529,9 @@ public ConsumerGroupHeartbeatRequestData
showuon commented on code in PR #15474:
URL: https://github.com/apache/kafka/pull/15474#discussion_r1520858564
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -52,20 +53,24 @@ public class GetOffsetShellTest {
private final int topicCount = 4;
chia7712 commented on code in PR #15474:
URL: https://github.com/apache/kafka/pull/15474#discussion_r1520575467
##
core/src/test/scala/integration/kafka/admin/ListOffsetsIntegrationTest.scala:
##
@@ -36,40 +37,79 @@ class ListOffsetsIntegrationTest extends
Matthias J. Sax created KAFKA-16366:
---
Summary: Refactor KTable source optimization
Key: KAFKA-16366
URL: https://issues.apache.org/jira/browse/KAFKA-16366
Project: Kafka
Issue Type:
mjsax commented on code in PR #15510:
URL: https://github.com/apache/kafka/pull/15510#discussion_r1520612406
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java:
##
@@ -223,9 +223,9 @@ private void emitNonJoinedOuterRecords(
jolshan commented on code in PR #15364:
URL: https://github.com/apache/kafka/pull/15364#discussion_r1520772129
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##
@@ -338,7 +338,6 @@ public void
mjsax commented on PR #15508:
URL: https://github.com/apache/kafka/pull/15508#issuecomment-1989699015
What Bruno says. Git history if you friend :)
https://github.com/apache/kafka/pull/6602/files#r278810522
I think we should keep the code as-is and close this PR w/o merging (or
ChrisAHolland commented on PR #15507:
URL: https://github.com/apache/kafka/pull/15507#issuecomment-1990325002
@chia7712 @cadonna Hi, saw you approved some recent PR's, wondering if you
could take a look at mine or suggest someone better suited that I can ask?
Thanks!
--
This is an
chia7712 commented on code in PR #15519:
URL: https://github.com/apache/kafka/pull/15519#discussion_r1520683129
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -529,10 +529,9 @@ public ConsumerGroupHeartbeatRequestData
[
https://issues.apache.org/jira/browse/KAFKA-16360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax resolved KAFKA-16360.
-
Resolution: Invalid
Please don't use Jira to ask questions. Jira tickets are for bug
[
https://issues.apache.org/jira/browse/KAFKA-16359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17825496#comment-17825496
]
Matthias J. Sax commented on KAFKA-16359:
-
Just to clarify: we cannot re-publish a 3.7.0
jolshan commented on code in PR #15364:
URL: https://github.com/apache/kafka/pull/15364#discussion_r1520772129
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##
@@ -338,7 +338,6 @@ public void
showuon commented on PR #15476:
URL: https://github.com/apache/kafka/pull/15476#issuecomment-1990459827
Please also address this comment in this PR:
https://github.com/apache/kafka/pull/15474#discussion_r1520262997 . Thanks.
--
This is an automated message from the Apache Git Service.
To
showuon commented on code in PR #15474:
URL: https://github.com/apache/kafka/pull/15474#discussion_r1520862105
##
core/src/test/scala/integration/kafka/admin/ListOffsetsIntegrationTest.scala:
##
@@ -69,6 +97,15 @@ class ListOffsetsIntegrationTest extends
KafkaServerTestHarness
showuon commented on code in PR #15474:
URL: https://github.com/apache/kafka/pull/15474#discussion_r1520861572
##
core/src/test/scala/integration/kafka/admin/ListOffsetsIntegrationTest.scala:
##
@@ -60,6 +63,31 @@ class ListOffsetsIntegrationTest extends
KafkaServerTestHarness
chia7712 commented on code in PR #15519:
URL: https://github.com/apache/kafka/pull/15519#discussion_r1520572340
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -529,10 +529,9 @@ public ConsumerGroupHeartbeatRequestData
mjsax commented on code in PR #15189:
URL: https://github.com/apache/kafka/pull/15189#discussion_r1520627804
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/StreamStreamJoinUtil.java:
##
@@ -25,36 +25,46 @@
public final class StreamStreamJoinUtil {
-
mjsax commented on code in PR #15189:
URL: https://github.com/apache/kafka/pull/15189#discussion_r1520671475
##
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamWindowCloseTest.java:
##
@@ -0,0 +1,150 @@
+/*
+ * Licensed to the Apache Software
jolshan commented on code in PR #15364:
URL: https://github.com/apache/kafka/pull/15364#discussion_r1520774849
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##
@@ -931,17 +920,14 @@ public void
calmera commented on PR #12742:
URL: https://github.com/apache/kafka/pull/12742#issuecomment-1987893614
Nice job @mjsax @wcarlson5! Sorry I couldn't spend more time on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
sjhajharia commented on code in PR #15486:
URL: https://github.com/apache/kafka/pull/15486#discussion_r1519327877
##
core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala:
##
@@ -228,11 +232,17 @@ class AddPartitionsToTxnManager(
val tp = new
[
https://issues.apache.org/jira/browse/KAFKA-16114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17825153#comment-17825153
]
wangliucheng edited comment on KAFKA-16114 at 3/11/24 6:00 AM:
---
Hello, are
[
https://issues.apache.org/jira/browse/KAFKA-10199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna updated KAFKA-10199:
--
Fix Version/s: 3.8.0
(was: 3.7.0)
> Separate state restoration into
[
https://issues.apache.org/jira/browse/KAFKA-10199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna reopened KAFKA-10199:
---
> Separate state restoration into separate threads
>
sjhajharia commented on code in PR #15486:
URL: https://github.com/apache/kafka/pull/15486#discussion_r1519322254
##
clients/src/test/java/org/apache/kafka/clients/producer/internals/SenderTest.java:
##
@@ -3151,6 +3152,45 @@ public void testInvalidTxnStateIsAnAbortableError()
sjhajharia commented on PR #15486:
URL: https://github.com/apache/kafka/pull/15486#issuecomment-1987900169
> I took a quick skim of the tests -- just wanted to confirm we have a test
for the old produce request + invalid txn state returned?
@jolshan , if you have a look at
[
https://issues.apache.org/jira/browse/KAFKA-16285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna closed KAFKA-16285.
-
> Make group metadata available when a new assignment is set in async Kafka
> consumer
>
[
https://issues.apache.org/jira/browse/KAFKA-15649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Viktor Somogyi-Vass reassigned KAFKA-15649:
---
Assignee: Viktor Somogyi-Vass
> Handle directory failure timeout
>
KrishVora01 closed pull request #15509: Doi testing
URL: https://github.com/apache/kafka/pull/15509
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
KrishVora01 opened a new pull request, #15509:
URL: https://github.com/apache/kafka/pull/15509
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of
sjhajharia commented on code in PR #15486:
URL: https://github.com/apache/kafka/pull/15486#discussion_r1519333893
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -1007,7 +1010,8 @@ class ReplicaManager(val config: KafkaConfig,
transactionalId,
satishd commented on PR #15201:
URL: https://github.com/apache/kafka/pull/15201#issuecomment-1987943134
Merging the changes as the test failures are unrelated to this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
satishd commented on code in PR #15201:
URL: https://github.com/apache/kafka/pull/15201#discussion_r1519366268
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -865,7 +865,8 @@ class LogManager(logDirs: Seq[File],
try {
satishd merged PR #15201:
URL: https://github.com/apache/kafka/pull/15201
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
VictorvandenHoven opened a new pull request, #15510:
URL: https://github.com/apache/kafka/pull/15510
Sloppy bug: moved the outerJounBreak-flags out of the loop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
showuon commented on code in PR #15474:
URL: https://github.com/apache/kafka/pull/15474#discussion_r1519665612
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -52,20 +55,30 @@ public class GetOffsetShellTest {
private final int topicCount = 4;
showuon commented on PR #15474:
URL: https://github.com/apache/kafka/pull/15474#issuecomment-1988370290
> Also, [#15476
(comment)](https://github.com/apache/kafka/pull/15476#discussion_r1518413083)
applies here too. We just need to fix it in one of the PRs.
Let's fix it in #15476.
Phuc-Hong-Tran commented on code in PR #15188:
URL: https://github.com/apache/kafka/pull/15188#discussion_r1519707860
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1730,6 +1744,21 @@ private void subscribeInternal(Pattern
[
https://issues.apache.org/jira/browse/KAFKA-16350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna reassigned KAFKA-16350:
-
Assignee: Bruno Cadonna
> StateUpdater does not init transaction after canceling task
showuon commented on code in PR #15474:
URL: https://github.com/apache/kafka/pull/15474#discussion_r1519662867
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogValidator.java:
##
@@ -417,8 +422,14 @@ public ValidationResult
cadonna commented on PR #15497:
URL: https://github.com/apache/kafka/pull/15497#issuecomment-1988260873
Test failures are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
Jeremy Norris created KAFKA-16359:
-
Summary: kafka-clients-3.7.0.jar published to Maven Central is
defective
Key: KAFKA-16359
URL: https://issues.apache.org/jira/browse/KAFKA-16359
Project: Kafka
showuon commented on code in PR #15474:
URL: https://github.com/apache/kafka/pull/15474#discussion_r1519669214
##
core/src/test/scala/integration/kafka/admin/ListOffsetsIntegrationTest.scala:
##
@@ -36,65 +37,149 @@ class ListOffsetsIntegrationTest extends
[
https://issues.apache.org/jira/browse/KAFKA-16359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17825313#comment-17825313
]
Gaurav Narula commented on KAFKA-16359:
---
This is likely because of the shadow jar plugin
cadonna commented on PR #15508:
URL: https://github.com/apache/kafka/pull/15508#issuecomment-1988235647
@ableegoldman I had a quick look at the code and theoretically
`ProcessorRecordContext` is mutable because `headers()` returns a reference to
the object of `Headers` stored internally.
cadonna merged PR #15497:
URL: https://github.com/apache/kafka/pull/15497
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-16350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17825278#comment-17825278
]
Bruno Cadonna commented on KAFKA-16350:
---
Thanks for the report [~mjsax]!
I think the bug is in
[
https://issues.apache.org/jira/browse/KAFKA-16359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17825333#comment-17825333
]
Apoorv Mittal commented on KAFKA-16359:
---
Hi [~norrisjeremy] , thanks for reporting the issue. As
[
https://issues.apache.org/jira/browse/KAFKA-16359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Apoorv Mittal reassigned KAFKA-16359:
-
Assignee: Apoorv Mittal
> kafka-clients-3.7.0.jar published to Maven Central is
cadonna commented on PR #15491:
URL: https://github.com/apache/kafka/pull/15491#issuecomment-1988816400
> LGTM! I think it's a good solution in the current architecture, though
arguably a bit smelly.
Agree on the arguable smell. The alternative would be to use locks which I
disliked
cadonna commented on code in PR #15491:
URL: https://github.com/apache/kafka/pull/15491#discussion_r1519991935
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchCollector.java:
##
@@ -278,32 +278,48 @@ private CompletedFetch handleInitializeSuccess(final
[
https://issues.apache.org/jira/browse/KAFKA-16359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17825373#comment-17825373
]
Gaurav Narula commented on KAFKA-16359:
---
[~apoorvmittal10] I stumbled upon
kaushik srinivas created KAFKA-16360:
Summary: Release plan of 3.x kafka releases.
Key: KAFKA-16360
URL: https://issues.apache.org/jira/browse/KAFKA-16360
Project: Kafka
Issue Type:
1 - 100 of 128 matches
Mail list logo
