Re: [PR] KAFKA-15899 Move kafka.security package from core to server module [kafka]

nizhikov commented on code in PR #15572: URL: https://github.com/apache/kafka/pull/15572#discussion_r1542439635 ## core/src/test/scala/integration/kafka/api/BaseAdminIntegrationTest.scala: ## @@ -183,12 +184,13 @@ abstract class BaseAdminIntegrationTest extends

Re: [PR] KAFKA-14588 ZK configuration moved to ZkConfig [kafka]

nizhikov commented on PR #15075: URL: https://github.com/apache/kafka/pull/15075#issuecomment-2024632660 @OmniaGM Thanks for noticing. https://github.com/apache/kafka/pull/15614/files prepared -- This is an automated message from the Apache Git Service. To respond to the message, please

[PR] MINOR: Rename PROP to CONFIG in ZkConfigs [kafka]

nizhikov opened a new pull request, #15614: URL: https://github.com/apache/kafka/pull/15614 This is clean up for #15075 which renames PROP to CONFIG to make naming consistent. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ]

Re: [PR] MINOR: Remove the client side assignor from the ConsumerGroupHeartbeat API [kafka]

aiven-anton commented on code in PR #14469: URL: https://github.com/apache/kafka/pull/14469#discussion_r1542514661 ## clients/src/main/resources/common/message/ConsumerGroupHeartbeatRequest.json: ## @@ -43,21 +43,6 @@ "about": "null if it didn't change since the last

Re: [PR] KAFKA-15729: Add KRaft support in GetOffsetShellTest [kafka]

chia7712 commented on code in PR #15489: URL: https://github.com/apache/kafka/pull/15489#discussion_r1542532419 ## tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java: ## @@ -48,13 +52,14 @@ import static org.junit.jupiter.api.Assertions.assertTrue;

Re: [PR] KAFKA-16323: fix testRemoteFetchExpiresPerSecMetric [kafka]

chia7712 commented on code in PR #15463: URL: https://github.com/apache/kafka/pull/15463#discussion_r1542616917 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -1460,10 +1460,8 @@ class ReplicaManager(val config: KafkaConfig, warn("Unable to fetch data

[jira] [Commented] (KAFKA-10409) Refactor Kafka Streams RocksDb iterators

[ https://issues.apache.org/jira/browse/KAFKA-10409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831704#comment-17831704 ] Matthias J. Sax commented on KAFKA-10409: - I don't think anybody worked on this ticket (not sure

Re: [PR] KAFKA-15899 Move kafka.security package from core to server module [kafka]

OmniaGM commented on code in PR #15572: URL: https://github.com/apache/kafka/pull/15572#discussion_r1542488524 ## server-common/src/main/java/org/apache/kafka/server/util/Utils.java: ## @@ -0,0 +1,24 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] KAFKA-16156: beginningOrEndOffsets does not need to build an OffsetAndTimestamps object upon completion [kafka]

lucasbru commented on PR #15525: URL: https://github.com/apache/kafka/pull/15525#issuecomment-2024835245 @philipnee Okay, thanks for creating the ticket. Not sure if it's blocker priority though. If it's a quick thing, you could address it in this PR. Are you going to implement

Re: [PR] KAFKA-15899 Move kafka.security package from core to server module [kafka]

nizhikov commented on PR #15572: URL: https://github.com/apache/kafka/pull/15572#issuecomment-2024577072 @OmniaGM @ijuma All comments resolved. Please, take a look one more time. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Assigned] (KAFKA-16263) Add Kafka Streams docs about available listeners/callback

[ https://issues.apache.org/jira/browse/KAFKA-16263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-16263: --- Assignee: Kuan Po Tseng > Add Kafka Streams docs about available

[jira] [Assigned] (KAFKA-16434) ForeignKey INNER join does not unset join result when FK becomes null

[ https://issues.apache.org/jira/browse/KAFKA-16434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayoub Omari reassigned KAFKA-16434: --- Assignee: Ayoub Omari > ForeignKey INNER join does not unset join result when FK becomes

Re: [PR] KAFKA-15853: Move KafkaConfig log properties and docs out of core [kafka]

OmniaGM commented on PR #15569: URL: https://github.com/apache/kafka/pull/15569#issuecomment-2024620566 rebased the pr -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] KAFKA-16407: Fix foreign key join on change of FK from/to a null value [kafka]

AyoubOm opened a new pull request, #15615: URL: https://github.com/apache/kafka/pull/15615 This fixes both KAFKA-16407 and KAFKA-16434. Summary of existing issues: - We were ignoring new left record when its **previous** FK value is null - We do not unset foreign key join

[jira] [Commented] (KAFKA-16434) ForeignKey INNER join does not unset join result when FK becomes null

[ https://issues.apache.org/jira/browse/KAFKA-16434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831702#comment-17831702 ] Ayoub Omari commented on KAFKA-16434: - I submitted a bug fix for this in the same PR as KAFKA-16407:

[jira] [Assigned] (KAFKA-15951) MissingSourceTopicException should include topic names

[ https://issues.apache.org/jira/browse/KAFKA-15951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-15951: --- Assignee: sanghyeok An > MissingSourceTopicException should include topic names >

[jira] [Commented] (KAFKA-15951) MissingSourceTopicException should include topic names

[ https://issues.apache.org/jira/browse/KAFKA-15951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831701#comment-17831701 ] Matthias J. Sax commented on KAFKA-15951: - Sorry for late reply. I was traveling. Of course you

Re: [PR] KAFKA-15899 Move kafka.security package from core to server module [kafka]

nizhikov commented on code in PR #15572: URL: https://github.com/apache/kafka/pull/15572#discussion_r1542627362 ## core/src/main/scala/kafka/admin/AclCommand.scala: ## @@ -486,7 +486,8 @@ object AclCommand extends Logging { private def validateOperation(opts:

[jira] [Commented] (KAFKA-16310) ListOffsets doesn't report the offset with maxTimestamp anymore

[ https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831658#comment-17831658 ] Chia-Ping Tsai commented on KAFKA-16310: {quote} I think the easiest way to fix the

[jira] [Commented] (KAFKA-16263) Add Kafka Streams docs about available listeners/callback

[ https://issues.apache.org/jira/browse/KAFKA-16263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831695#comment-17831695 ] Matthias J. Sax commented on KAFKA-16263: - Absolutely. If a ticket is not assigned to anybody,

Re: [PR] KAFKA-15899 Move kafka.security package from core to server module [kafka]

nizhikov commented on code in PR #15572: URL: https://github.com/apache/kafka/pull/15572#discussion_r1542486534 ## server-common/src/main/java/org/apache/kafka/server/util/Utils.java: ## @@ -0,0 +1,24 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] MINOR: Remove redundant ApiVersionsResponse#filterApis [kafka]

chia7712 commented on PR #15611: URL: https://github.com/apache/kafka/pull/15611#issuecomment-2024745523 That’s just my two cents. It is a trivial patch but I'm fine to merge it due to following reasons. 1. this cleanup does not burn out kafka ( In fact, I feel we do need more

[jira] [Commented] (KAFKA-16344) Internal topic mm2-offset-syncsinternal created with single partition is putting more load on the broker

[ https://issues.apache.org/jira/browse/KAFKA-16344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831700#comment-17831700 ] Janardhana Gopalachar commented on KAFKA-16344: --- Hi [~gharris1727]  We tried to perform

Re: [PR] KAFKA-15899 Move kafka.security package from core to server module [kafka]

nizhikov commented on code in PR #15572: URL: https://github.com/apache/kafka/pull/15572#discussion_r1542620928 ## server/src/main/java/org/apache/kafka/security/authorizer/AclEntry.java: ## @@ -0,0 +1,215 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-14588 ZK configuration moved to ZkConfig [kafka]

OmniaGM commented on PR #15075: URL: https://github.com/apache/kafka/pull/15075#issuecomment-2024606943 @nizhikov it would be nice if we have a followup cleanup on this to change PROP suffix to CONFIG as this seems to be the pattern for others and am doing the same for the rest of

[jira] [Updated] (KAFKA-16407) ForeignKey INNER join ignores FK change when its previous value is null

[ https://issues.apache.org/jira/browse/KAFKA-16407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayoub Omari updated KAFKA-16407: Affects Version/s: 3.6.1 3.5.2 3.4.1 > ForeignKey

[jira] [Updated] (KAFKA-16407) ForeignKey INNER join ignores FK change when its previous value is null

[ https://issues.apache.org/jira/browse/KAFKA-16407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayoub Omari updated KAFKA-16407: Affects Version/s: 3.3.2 3.2.3 3.1.2

Re: [PR] KAFKA-15899 Move kafka.security package from core to server module [kafka]

nizhikov commented on code in PR #15572: URL: https://github.com/apache/kafka/pull/15572#discussion_r1542637640 ## clients/src/main/java/org/apache/kafka/common/utils/Utils.java: ## @@ -1675,6 +1675,15 @@ public static Map entriesWithPrefix(Map map, String pr return

Re: [PR] KAFKA-15899 Move kafka.security package from core to server module [kafka]

nizhikov commented on code in PR #15572: URL: https://github.com/apache/kafka/pull/15572#discussion_r1542518584 ## server-common/src/main/java/org/apache/kafka/server/util/Utils.java: ## @@ -0,0 +1,24 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] KAFKA-15899 Move kafka.security package from core to server module [kafka]

OmniaGM commented on code in PR #15572: URL: https://github.com/apache/kafka/pull/15572#discussion_r1542478487 ## server-common/src/main/java/org/apache/kafka/server/util/Utils.java: ## @@ -0,0 +1,24 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[jira] [Commented] (KAFKA-16310) ListOffsets doesn't report the offset with maxTimestamp anymore

[ https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831683#comment-17831683 ] Chia-Ping Tsai commented on KAFKA-16310: {quote}I think the easiest way to fix the

[jira] [Updated] (KAFKA-16434) ForeignKey INNER join does not unset join result when FK becomes null

[ https://issues.apache.org/jira/browse/KAFKA-16434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayoub Omari updated KAFKA-16434: External issue URL: https://github.com/apache/kafka/pull/15615 > ForeignKey INNER join does not

[jira] [Updated] (KAFKA-16434) ForeignKey INNER join does not unset join result when FK becomes null

[ https://issues.apache.org/jira/browse/KAFKA-16434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayoub Omari updated KAFKA-16434: External issue URL: (was: https://github.com/apache/kafka/pull/15615) > ForeignKey INNER join

Re: [PR] KAFKA-16323: fix testRemoteFetchExpiresPerSecMetric [kafka]

showuon commented on code in PR #15463: URL: https://github.com/apache/kafka/pull/15463#discussion_r1542760219 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -4164,16 +4164,13 @@ class ReplicaManagerTest { mock(classOf[FetchDataInfo])

Re: [PR] KAFKA-15951: MissingSourceTopicException should include topic names [kafka]

chickenchickenlove commented on code in PR #15573: URL: https://github.com/apache/kafka/pull/15573#discussion_r1542765807 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java: ## @@ -523,7 +523,17 @@ private RepartitionTopics

Re: [PR] KAFKA-15951: MissingSourceTopicException should include topic names [kafka]

chickenchickenlove commented on code in PR #15573: URL: https://github.com/apache/kafka/pull/15573#discussion_r1542765807 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java: ## @@ -523,7 +523,17 @@ private RepartitionTopics

Re: [PR] KAFKA-15951: MissingSourceTopicException should include topic names [kafka]

chickenchickenlove commented on code in PR #15573: URL: https://github.com/apache/kafka/pull/15573#discussion_r1542822737 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java: ## @@ -523,7 +523,17 @@ private RepartitionTopics

Re: [PR] KAFKA-15951: MissingSourceTopicException should include topic names [kafka]

chickenchickenlove commented on code in PR #15573: URL: https://github.com/apache/kafka/pull/15573#discussion_r1542822737 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java: ## @@ -523,7 +523,17 @@ private RepartitionTopics

Re: [PR] KAFKA-16103: commitSync should await pending async commits [kafka]

lucasbru commented on code in PR #15613: URL: https://github.com/apache/kafka/pull/15613#discussion_r1543066981 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java: ## @@ -1164,7 +1176,8 @@ public void maybeAutoCommitOffsetsAsync(long

Re: [PR] Image test improvements [kafka]

mimaison merged PR #15373: URL: https://github.com/apache/kafka/pull/15373 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] KAFKA-16424: remove truncated logs after alter dir [kafka]

FrankYang0529 opened a new pull request, #15616: URL: https://github.com/apache/kafka/pull/15616 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

[jira] [Updated] (KAFKA-16382) Kafka Streams drop NULL values after reset

[ https://issues.apache.org/jira/browse/KAFKA-16382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stanislav Spiridonov updated KAFKA-16382: - Description: Kafka Streams (KTable) drops null values after full reset. See

[jira] [Comment Edited] (KAFKA-16310) ListOffsets doesn't report the offset with maxTimestamp anymore

[ https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831741#comment-17831741 ] Luke Chen edited comment on KAFKA-16310 at 3/28/24 11:45 AM: - {quote}Did you

[jira] [Commented] (KAFKA-16310) ListOffsets doesn't report the offset with maxTimestamp anymore

[ https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831741#comment-17831741 ] Luke Chen commented on KAFKA-16310: --- {quote}Did you mean that we should change the schema to have a

Re: [PR] KAFKA-15951: MissingSourceTopicException should include topic names [kafka]

chickenchickenlove commented on code in PR #15573: URL: https://github.com/apache/kafka/pull/15573#discussion_r1542775368 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java: ## @@ -523,7 +523,17 @@ private RepartitionTopics

Re: [PR] KAFKA-15951: MissingSourceTopicException should include topic names [kafka]

chickenchickenlove commented on code in PR #15573: URL: https://github.com/apache/kafka/pull/15573#discussion_r1542775368 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java: ## @@ -523,7 +523,17 @@ private RepartitionTopics

Re: [PR] KAFKA-16103: commitSync should await pending async commits [kafka]

lucasbru commented on code in PR #15613: URL: https://github.com/apache/kafka/pull/15613#discussion_r1543063391 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java: ## @@ -229,7 +229,11 @@ private GroupRebalanceConfig

Re: [PR] KAFKA-15951: MissingSourceTopicException should include topic names [kafka]

chickenchickenlove commented on code in PR #15573: URL: https://github.com/apache/kafka/pull/15573#discussion_r1543099933 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java: ## @@ -523,7 +523,17 @@ private RepartitionTopics

[jira] [Assigned] (KAFKA-10549) Add topic ID support to ListOffsets, OffsetForLeaders

[ https://issues.apache.org/jira/browse/KAFKA-10549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Omnia Ibrahim reassigned KAFKA-10549: - Assignee: Omnia Ibrahim > Add topic ID support to ListOffsets, OffsetForLeaders >

Re: [PR] KAFKA-15899 [1/2] Move kafka.security package from core to server module [kafka]

OmniaGM commented on code in PR #15572: URL: https://github.com/apache/kafka/pull/15572#discussion_r1543154424 ## server/src/main/java/org/apache/kafka/security/authorizer/AclEntry.java: ## @@ -0,0 +1,209 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-15899 [1/2] Move kafka.security package from core to server module [kafka]

chia7712 commented on code in PR #15572: URL: https://github.com/apache/kafka/pull/15572#discussion_r1543172408 ## server/src/main/java/org/apache/kafka/security/authorizer/AclEntry.java: ## @@ -0,0 +1,209 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-7663: Reprocessing on user added global stores restore [kafka]

wcarlson5 commented on PR #15414: URL: https://github.com/apache/kafka/pull/15414#issuecomment-2025500658 Test configuration issues in the build is in `core:test' and not related to this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] KAFKA-14133: Move StreamTaskTest to Mockito [kafka]

clolov commented on PR #14716: URL: https://github.com/apache/kafka/pull/14716#issuecomment-2025540351 Okay, enjoy your time off! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Comment Edited] (KAFKA-16310) ListOffsets doesn't report the offset with maxTimestamp anymore

[ https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831834#comment-17831834 ] Jun Rao edited comment on KAFKA-16310 at 3/28/24 3:04 PM: -- [~chia7712] :

Re: [PR] KAFKA-15899 Move kafka.security package from core to server module [kafka]

nizhikov commented on PR #15572: URL: https://github.com/apache/kafka/pull/15572#issuecomment-2025466888 @OmniaGM @chia7712 @ijuma CI seems OK for me. Please, take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Updated] (KAFKA-15843) Review consumer onPartitionsAssigned called with empty partitions

[ https://issues.apache.org/jira/browse/KAFKA-15843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-15843: --- Priority: Minor (was: Major) > Review consumer onPartitionsAssigned called with empty

Re: [PR] KAFKA-15899 [1/2] Move kafka.security package from core to server module [kafka]

nizhikov commented on code in PR #15572: URL: https://github.com/apache/kafka/pull/15572#discussion_r1543177295 ## server/src/main/java/org/apache/kafka/security/authorizer/AclEntry.java: ## @@ -0,0 +1,209 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-7663: Reprocessing on user added global stores restore [kafka]

wcarlson5 merged PR #15414: URL: https://github.com/apache/kafka/pull/15414 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16310 ListOffsets doesn't report the offset with maxTimestamp a… [kafka]

junrao commented on code in PR #15618: URL: https://github.com/apache/kafka/pull/15618#discussion_r1543349555 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1320,10 +1320,8 @@ class UnifiedLog(@volatile var logStartOffset: Long, // constant time access while

Re: [PR] KAFKA-14585: Refactoring for moving the storage tool [kafka]

fvaleri closed pull request #15273: KAFKA-14585: Refactoring for moving the storage tool URL: https://github.com/apache/kafka/pull/15273 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] KAFKA-14585: Refactoring for moving the storage tool [kafka]

fvaleri commented on PR #15273: URL: https://github.com/apache/kafka/pull/15273#issuecomment-2025743216 Closing this one in favor of the work done for KAFKA-15853. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] KAFKA-16397 - Use ByteBufferOutputStream to avoid array copy [kafka]

chiacyu commented on code in PR #15589: URL: https://github.com/apache/kafka/pull/15589#discussion_r154312 ## clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryUtils.java: ## @@ -204,16 +202,14 @@ public static byte[] compress(byte[] raw,

Re: [PR] KAFKA-16397 - Use ByteBufferOutputStream to avoid array copy [kafka]

chiacyu commented on code in PR #15589: URL: https://github.com/apache/kafka/pull/15589#discussion_r1543121911 ## clients/src/test/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryUtilsTest.java: ## @@ -132,9 +133,9 @@ public void

Re: [PR] MINOR: Remove the client side assignor from the ConsumerGroupHeartbeat API [kafka]

jolshan commented on code in PR #14469: URL: https://github.com/apache/kafka/pull/14469#discussion_r1543165416 ## clients/src/main/resources/common/message/ConsumerGroupHeartbeatRequest.json: ## @@ -43,21 +43,6 @@ "about": "null if it didn't change since the last

Re: [PR] KAFKA-16156: beginningOrEndOffsets does not need to build an OffsetAndTimestamps object upon completion [kafka]

philipnee commented on PR #15525: URL: https://github.com/apache/kafka/pull/15525#issuecomment-2025522451 hi @lucasbru - Let me address Lianets comment in this PR and have a separated PR for the behavior inconsistency as it does require some changes to the unit test -- This is an

Re: [PR] MINOR: Rename PROP to CONFIG in ZkConfigs [kafka]

mimaison merged PR #15614: URL: https://github.com/apache/kafka/pull/15614 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] MINOR: Remove the client side assignor from the ConsumerGroupHeartbeat API [kafka]

aiven-anton commented on code in PR #14469: URL: https://github.com/apache/kafka/pull/14469#discussion_r1543168871 ## clients/src/main/resources/common/message/ConsumerGroupHeartbeatRequest.json: ## @@ -43,21 +43,6 @@ "about": "null if it didn't change since the last

Re: [PR] MINOR: AbstractConfig cleanup [kafka]

mimaison commented on code in PR #15597: URL: https://github.com/apache/kafka/pull/15597#discussion_r1543174303 ## core/src/main/scala/kafka/controller/PartitionStateMachine.scala: ## @@ -486,7 +486,7 @@ class ZkPartitionStateMachine(config: KafkaConfig, } else {

Re: [PR] MINOR: Remove the client side assignor from the ConsumerGroupHeartbeat API [kafka]

jolshan commented on code in PR #14469: URL: https://github.com/apache/kafka/pull/14469#discussion_r1543175309 ## clients/src/main/resources/common/message/ConsumerGroupHeartbeatRequest.json: ## @@ -43,21 +43,6 @@ "about": "null if it didn't change since the last

[PR] KAFKA-16310 ListOffsets doesn't report the offset with maxTimestamp a… [kafka]

chia7712 opened a new pull request, #15618: URL: https://github.com/apache/kafka/pull/15618 - add default implementation to Batch to return offset of max timestamp - copy ListOffsetsIntegrationTest from trunk branch ### Committer Checklist (excluded from commit message) - [ ]

[PR] 1024 impl [kafka]

wcarlson5 opened a new pull request, #15619: URL: https://github.com/apache/kafka/pull/15619 Implementation of Kip 1024. We change the `addGlobalStateStore` to be able to configure the way which restoring takes place or we let them use the default processor rather than a custom one.

Re: [PR] KAFKA-15853: Move KafkaConfig log properties and docs out of core [kafka]

mimaison commented on code in PR #15569: URL: https://github.com/apache/kafka/pull/15569#discussion_r1543199493 ## server/src/main/java/org/apache/kafka/server/config/KafkaConfig.java: ## @@ -0,0 +1,146 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-14133: Move StreamTaskTest to Mockito [kafka]

cadonna commented on PR #14716: URL: https://github.com/apache/kafka/pull/14716#issuecomment-2024894127 @clolov That is great! Looking forward to reviewing it! I am on vacation at the moment. Maybe I can look at it next week or the week after. -- This is an automated message from the

Re: [PR] KAFKA-15951: MissingSourceTopicException should include topic names [kafka]

chickenchickenlove commented on PR #15573: URL: https://github.com/apache/kafka/pull/15573#issuecomment-2025128974 > Thanks for the PR. Made a pass. Aye, i hope so.  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] KAFKA-15729: Add KRaft support in GetOffsetShellTest [kafka]

chia7712 commented on PR #15489: URL: https://github.com/apache/kafka/pull/15489#issuecomment-2025290627 @Owen-CH-Leung Could you add `toString` back? It seems the test is unstable and we need to dig in it :) -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] KAFKA-15951: MissingSourceTopicException should include topic names [kafka]

chickenchickenlove commented on code in PR #15573: URL: https://github.com/apache/kafka/pull/15573#discussion_r1543099933 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java: ## @@ -523,7 +523,17 @@ private RepartitionTopics

Re: [PR] KAFKA-15951: MissingSourceTopicException should include topic names [kafka]

mjsax commented on code in PR #15573: URL: https://github.com/apache/kafka/pull/15573#discussion_r1542738987 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java: ## @@ -523,7 +523,17 @@ private RepartitionTopics

[jira] [Commented] (KAFKA-16310) ListOffsets doesn't report the offset with maxTimestamp anymore

[ https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831747#comment-17831747 ] Chia-Ping Tsai commented on KAFKA-16310: > Yes, I agree with this method. But the question is,

Re: [PR] KAFKA-16406 [2] : Split consumer commit tests [kafka]

lucasbru merged PR #15612: URL: https://github.com/apache/kafka/pull/15612 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16103: commitSync should await pending async commits [kafka]

lucasbru commented on code in PR #15613: URL: https://github.com/apache/kafka/pull/15613#discussion_r1543068952 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1360,6 +1367,9 @@ public void commitSync(Map offsets, Duration

[jira] [Commented] (KAFKA-16310) ListOffsets doesn't report the offset with maxTimestamp anymore

[ https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831845#comment-17831845 ] Chia-Ping Tsai commented on KAFKA-16310: {quote} Team, there are serious issues that are fixed

[jira] [Commented] (KAFKA-16310) ListOffsets doesn't report the offset with maxTimestamp anymore

[ https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831848#comment-17831848 ] Ismael Juma commented on KAFKA-16310: - Perfect, thanks! > ListOffsets doesn't report the offset

[jira] [Updated] (KAFKA-16382) Kafka Streams drop NULL values after reset

[ https://issues.apache.org/jira/browse/KAFKA-16382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stanislav Spiridonov updated KAFKA-16382: - Description: Kafka Streams (KTable) drops null values after full reset. See

Re: [PR] KAFKA-15951: MissingSourceTopicException should include topic names [kafka]

mjsax commented on code in PR #15573: URL: https://github.com/apache/kafka/pull/15573#discussion_r1543047190 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java: ## @@ -523,7 +523,17 @@ private RepartitionTopics

Re: [PR] KAFKA-15951: MissingSourceTopicException should include topic names [kafka]

chickenchickenlove commented on code in PR #15573: URL: https://github.com/apache/kafka/pull/15573#discussion_r1542765807 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java: ## @@ -523,7 +523,17 @@ private RepartitionTopics

[jira] [Commented] (KAFKA-16310) ListOffsets doesn't report the offset with maxTimestamp anymore

[ https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831834#comment-17831834 ] Jun Rao commented on KAFKA-16310: - [~chia7712] : {quote}Did you mean that we should change the schema to

Re: [PR] KAFKA-15899 Move kafka.security package from core to server module [kafka]

OmniaGM commented on code in PR #15572: URL: https://github.com/apache/kafka/pull/15572#discussion_r1542478487 ## server-common/src/main/java/org/apache/kafka/server/util/Utils.java: ## @@ -0,0 +1,24 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] KAFKA-15729: Add KRaft support in GetOffsetShellTest [kafka]

Owen-CH-Leung commented on code in PR #15489: URL: https://github.com/apache/kafka/pull/15489#discussion_r1542557448 ## tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java: ## @@ -48,13 +52,14 @@ import static org.junit.jupiter.api.Assertions.assertTrue;

Re: [PR] KAFKA-15899 Move kafka.security package from core to server module [kafka]

chia7712 commented on code in PR #15572: URL: https://github.com/apache/kafka/pull/15572#discussion_r1542590608 ## server/src/main/java/org/apache/kafka/security/authorizer/AclEntry.java: ## @@ -0,0 +1,215 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-15899 Move kafka.security package from core to server module [kafka]

nizhikov commented on code in PR #15572: URL: https://github.com/apache/kafka/pull/15572#discussion_r1542631664 ## core/src/main/scala/kafka/zk/ZkData.scala: ## @@ -757,8 +757,8 @@ case object ExtendedAclChangeStore extends ZkAclChangeStore { object ResourceZNode { def

[jira] [Commented] (KAFKA-16382) Kafka Streams drop NULL values after reset

[ https://issues.apache.org/jira/browse/KAFKA-16382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831709#comment-17831709 ] Matthias J. Sax commented on KAFKA-16382: - Thanks for clarifying. Seems I did not understand the

Re: [PR] KAFKA-15951: MissingSourceTopicException should include topic names [kafka]

chickenchickenlove commented on code in PR #15573: URL: https://github.com/apache/kafka/pull/15573#discussion_r1542775368 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java: ## @@ -523,7 +523,17 @@ private RepartitionTopics

[jira] [Commented] (KAFKA-16310) ListOffsets doesn't report the offset with maxTimestamp anymore

[ https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831837#comment-17831837 ] Ismael Juma commented on KAFKA-16310: - Team, there are serious issues that are fixed by 3.6.2. We

[jira] [Resolved] (KAFKA-16271) Update consumer_rolling_upgrade_test.py to support KIP-848’s group protocol config

[ https://issues.apache.org/jira/browse/KAFKA-16271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True resolved KAFKA-16271. --- Reviewer: Lucas Brutschy Resolution: Fixed > Update consumer_rolling_upgrade_test.py to

[jira] [Updated] (KAFKA-16439) Update replication_replica_failure_test.py to support KIP-848’s group protocol config

[ https://issues.apache.org/jira/browse/KAFKA-16439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16439: -- Reviewer: (was: Lucas Brutschy) > Update replication_replica_failure_test.py to support KIP-848’s

[jira] [Updated] (KAFKA-16439) Update replication_replica_failure_test.py to support KIP-848’s group protocol config

[ https://issues.apache.org/jira/browse/KAFKA-16439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16439: -- Description: This task is to update the test method(s) in {{replication_replica_failure_test.py}} to

[jira] [Updated] (KAFKA-16443) Update streams_static_membership_test.py to support KIP-848’s group protocol config

[ https://issues.apache.org/jira/browse/KAFKA-16443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16443: -- Component/s: streams > Update streams_static_membership_test.py to support KIP-848’s group protocol

[jira] [Updated] (KAFKA-16442) Update streams_standby_replica_test.py to support KIP-848’s group protocol config

[ https://issues.apache.org/jira/browse/KAFKA-16442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16442: -- Component/s: streams > Update streams_standby_replica_test.py to support KIP-848’s group protocol >

Re: [PR] KAFKA-16310 ListOffsets doesn't report the offset with maxTimestamp a… [kafka]

junrao commented on PR #15618: URL: https://github.com/apache/kafka/pull/15618#issuecomment-2025853565 @chia7712: Since the follower only maintains offsetForMaxTimestamp at the batch level, the listMaxTimestamp API was never implemented correctly. So, technically, there was no regression

Re: [PR] KAFKA-15823: disconnect from controller on AuthenticationException [kafka]

soarez commented on PR #14760: URL: https://github.com/apache/kafka/pull/14760#issuecomment-2026260420 This still needs a review from a committer. @mimaison @mumrah @rondagostino @showuon -- This is an automated message from the Apache Git Service. To respond to the message,

  1   2   >