Re: [PR] MINOR: enhance kafka-reassign-partitions command output [kafka]

2024-04-02 Thread via GitHub
showuon merged PR #15610: URL: https://github.com/apache/kafka/pull/15610 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] MINOR: enhance kafka-reassign-partitions command output [kafka]

2024-04-02 Thread via GitHub
showuon commented on PR #15610: URL: https://github.com/apache/kafka/pull/15610#issuecomment-2031206526 Failed tests are unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (KAFKA-16456) Can't stop kafka debug logs

2024-04-02 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833062#comment-17833062 ] Chia-Ping Tsai commented on KAFKA-16456: the debug message "Received {} response from node {}

Re: [PR] KAFKA-16039: RecordHeaders supports the addAll method [kafka]

2024-04-02 Thread via GitHub
vamossagar12 commented on PR #15034: URL: https://github.com/apache/kafka/pull/15034#issuecomment-2031571928 @funky-eyes let me know if you got a chance to review my comment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Resolved] (KAFKA-16148) Implement GroupMetadataManager#onUnloaded

2024-04-02 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-16148. - Fix Version/s: 3.8.0 Resolution: Fixed > Implement GroupMetadataManager#onUnloaded >

[PR] KAFKA-15588 ConfigCommandIntegrationTest rewritten in java [kafka]

2024-04-02 Thread via GitHub
nizhikov opened a new pull request, #15645: URL: https://github.com/apache/kafka/pull/15645 This is first part of #15417 refactoring. PR intention - split big PR in parts to simplify review. PR contains `ConfigCommandIntegrationTest` rewritten in java ### Committer Checklist

[jira] [Updated] (KAFKA-16457) Useless import class

2024-04-02 Thread Svyatoslav (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Svyatoslav updated KAFKA-16457: --- Description: Useless import class in SslConfigs.java   {code:java} import

[jira] [Created] (KAFKA-16456) Can't stop kafka debug logs

2024-04-02 Thread Rajan Choudhary (Jira)
Rajan Choudhary created KAFKA-16456: --- Summary: Can't stop kafka debug logs Key: KAFKA-16456 URL: https://issues.apache.org/jira/browse/KAFKA-16456 Project: Kafka Issue Type: Bug

Re: [PR] [WIP] KAFKA-16383: fix flaky IdentityReplicationIntegrationTest .testReplicateFromLatest [kafka]

2024-04-02 Thread via GitHub
vamossagar12 commented on PR #15556: URL: https://github.com/apache/kafka/pull/15556#issuecomment-2031549949 @johnnychhsu ,for completeness sake, the issue with private constructor related noise in the logs is being fixed in this PR: https://github.com/apache/kafka/pull/15642 -- This is

Re: [PR] KAFKA-16068: Use TestPlugins in ConnectorValidationIntegrationTest to silence plugin scanning errors [kafka]

2024-04-02 Thread via GitHub
vamossagar12 commented on code in PR #15642: URL: https://github.com/apache/kafka/pull/15642#discussion_r1547506743 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/ConnectorValidationIntegrationTest.java: ## @@ -343,7 +346,7 @@ public void

[jira] [Created] (KAFKA-16457) Useless import class

2024-04-02 Thread Svyatoslav (Jira)
Svyatoslav created KAFKA-16457: -- Summary: Useless import class Key: KAFKA-16457 URL: https://issues.apache.org/jira/browse/KAFKA-16457 Project: Kafka Issue Type: Task Components:

[PR] MINOR: fix typo [kafka]

2024-04-02 Thread via GitHub
appchemist opened a new pull request, #15643: URL: https://github.com/apache/kafka/pull/15643 fix typo amd -> and ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify

Re: [PR] KAFKA-16068: Use TestPlugins in ConnectorValidationIntegrationTest to silence plugin scanning errors [kafka]

2024-04-02 Thread via GitHub
Joker-5 commented on code in PR #15642: URL: https://github.com/apache/kafka/pull/15642#discussion_r1547609546 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/ConnectorValidationIntegrationTest.java: ## @@ -331,7 +334,7 @@ public void

[PR] KAFKA-16457 Useless import class [kafka]

2024-04-02 Thread via GitHub
rykovsi opened a new pull request, #15646: URL: https://github.com/apache/kafka/pull/15646 [KAFKA-16457](https://issues.apache.org/jira/browse/KAFKA-16457) Useless import class in SslConfigs.java import org.apache.kafka.common.config.ConfigDef.Type; ...

Re: [PR] KAFKA-16068: Use TestPlugins in ConnectorValidationIntegrationTest to silence plugin scanning errors [kafka]

2024-04-02 Thread via GitHub
Joker-5 commented on code in PR #15642: URL: https://github.com/apache/kafka/pull/15642#discussion_r1547632847 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/ConnectorValidationIntegrationTest.java: ## @@ -343,7 +346,7 @@ public void

[PR] Add s390x support to CI [kafka]

2024-04-02 Thread via GitHub
Prashant-Jagtap opened a new pull request, #15644: URL: https://github.com/apache/kafka/pull/15644 We would like to add support for s390x to existing CI. Adding s390x build stage which uses Jdk21 and Scala 2.13. Verified the build and tests locally. ### Committer Checklist

Re: [PR] KAFKA-15588 ConfigCommandIntegrationTest rewritten in java [kafka]

2024-04-02 Thread via GitHub
nizhikov commented on PR #15645: URL: https://github.com/apache/kafka/pull/15645#issuecomment-2031645630 Hello @chia7712 This is first PR that moves parts of ConfigCommand to java. It contains rewritten `ConfigCommandIntegrationTest`. Please, take a look. -- This is an automated

Re: [PR] KAFKA-16068: Use TestPlugins in ConnectorValidationIntegrationTest to silence plugin scanning errors [kafka]

2024-04-02 Thread via GitHub
Joker-5 commented on code in PR #15642: URL: https://github.com/apache/kafka/pull/15642#discussion_r1547632847 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/ConnectorValidationIntegrationTest.java: ## @@ -343,7 +346,7 @@ public void

Re: [PR] KAFKA-16068: Use TestPlugins in ConnectorValidationIntegrationTest to silence plugin scanning errors [kafka]

2024-04-02 Thread via GitHub
Joker-5 commented on code in PR #15642: URL: https://github.com/apache/kafka/pull/15642#discussion_r1547690392 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/ConnectorValidationIntegrationTest.java: ## @@ -69,6 +69,9 @@ public static void setup() {

Re: [PR] KAFKA-16068: Use TestPlugins in ConnectorValidationIntegrationTest to silence plugin scanning errors [kafka]

2024-04-02 Thread via GitHub
Joker-5 commented on code in PR #15642: URL: https://github.com/apache/kafka/pull/15642#discussion_r1547690392 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/ConnectorValidationIntegrationTest.java: ## @@ -69,6 +69,9 @@ public static void setup() {

Re: [PR] KAFKA-15729: Add KRaft support in GetOffsetShellTest [kafka]

2024-04-02 Thread via GitHub
Owen-CH-Leung commented on code in PR #15489: URL: https://github.com/apache/kafka/pull/15489#discussion_r1547789497 ## tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java: ## @@ -391,4 +447,15 @@ private String[] addBootstrapServer(String... args) {

[jira] [Updated] (KAFKA-16082) Broker recreates reassigned partition after logdir failure

2024-04-02 Thread Igor Soarez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Soarez updated KAFKA-16082: Fix Version/s: 3.8.0 > Broker recreates reassigned partition after logdir failure >

Re: [PR] KAFKA-16316: Configure reprocessing with addGlobalStateStore [kafka]

2024-04-02 Thread via GitHub
mjsax commented on code in PR #15619: URL: https://github.com/apache/kafka/pull/15619#discussion_r1543277915 ## streams/src/main/java/org/apache/kafka/streams/StreamsBuilder.java: ## @@ -596,7 +597,9 @@ public synchronized StreamsBuilder addGlobalStore(final StoreBuilder s

[jira] [Updated] (KAFKA-16458) Add contains method in KeyValue store interface

2024-04-02 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-16458: Labels: needs-kip (was: ) > Add contains method in KeyValue store interface >

Re: [PR] KAFKA-15729: Add KRaft support in GetOffsetShellTest [kafka]

2024-04-02 Thread via GitHub
chia7712 commented on code in PR #15489: URL: https://github.com/apache/kafka/pull/15489#discussion_r1547934887 ## tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java: ## @@ -391,4 +447,15 @@ private String[] addBootstrapServer(String... args) { return

[jira] [Updated] (KAFKA-16234) Log directory failure re-creates partitions in another logdir automatically

2024-04-02 Thread Igor Soarez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Soarez updated KAFKA-16234: Fix Version/s: 3.8.0 > Log directory failure re-creates partitions in another logdir

[jira] [Updated] (KAFKA-16297) Race condition while promoting future replica can lead to partition unavailability.

2024-04-02 Thread Igor Soarez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Soarez updated KAFKA-16297: Fix Version/s: 3.8.0 > Race condition while promoting future replica can lead to partition >

Re: [PR] KAFKA-15729: Add KRaft support in GetOffsetShellTest [kafka]

2024-04-02 Thread via GitHub
Owen-CH-Leung commented on code in PR #15489: URL: https://github.com/apache/kafka/pull/15489#discussion_r1548061572 ## tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java: ## @@ -391,4 +420,15 @@ private String[] addBootstrapServer(String... args) {

Re: [PR] MINOR: AbstractConfig cleanup Part 2 [kafka]

2024-04-02 Thread via GitHub
gharris1727 commented on PR #15639: URL: https://github.com/apache/kafka/pull/15639#issuecomment-2032352619 Hi @chia7712 This [test is disabled in

Re: [PR] [WIP] KAFKA-16383: fix flaky IdentityReplicationIntegrationTest .testReplicateFromLatest [kafka]

2024-04-02 Thread via GitHub
johnnychhsu commented on PR #15556: URL: https://github.com/apache/kafka/pull/15556#issuecomment-2032431618 @vamossagar12 thanks for sharing! and from the build the IdentityReplicationIntegrationTest .testReplicateFromLatest passed with the fix, I think this could be the root cause,

[PR] KAFKA-15615: Improve handling of fetching during metadata updates [kafka]

2024-04-02 Thread via GitHub
appchemist opened a new pull request, #15647: URL: https://github.com/apache/kafka/pull/15647 - add 'AWAIT_UPDATE' state in FetchStates - This state makes the subscription unfetchable during metadata updates. - After a metadata update, the state becomes 'AWAIT_VALIDATION' or

[jira] [Updated] (KAFKA-16272) Update connect_distributed_test.py to support KIP-848’s group protocol config

2024-04-02 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16272: -- Fix Version/s: 4.0.0 (was: 3.8.0) > Update connect_distributed_test.py to

[jira] [Updated] (KAFKA-16459) consumer_test.py’s static membership tests fail with new consumer

2024-04-02 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16459: -- Description: (was: The following error is reported when running the {{test_valid_assignment}}

Re: [PR] KAFKA-15729: Add KRaft support in GetOffsetShellTest [kafka]

2024-04-02 Thread via GitHub
Owen-CH-Leung commented on code in PR #15489: URL: https://github.com/apache/kafka/pull/15489#discussion_r1548103258 ## tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java: ## @@ -391,4 +420,15 @@ private String[] addBootstrapServer(String... args) {

Re: [PR] MINOR: AbstractConfig cleanup Part 2 [kafka]

2024-04-02 Thread via GitHub
chia7712 commented on PR #15639: URL: https://github.com/apache/kafka/pull/15639#issuecomment-2032377734 > We should prioritize https://issues.apache.org/jira/browse/KAFKA-6527 to re-enable this test, as it would have caught this regression. sounds good to me. just test it on my

Re: [PR] KAFKA-16310 ListOffsets doesn't report the offset with maxTimestamp a… [kafka]

2024-04-02 Thread via GitHub
junrao commented on code in PR #15621: URL: https://github.com/apache/kafka/pull/15621#discussion_r1548211287 ## clients/src/main/java/org/apache/kafka/common/record/MemoryRecordsBuilder.java: ## @@ -240,25 +240,40 @@ public MemoryRecords build() { return builtRecords;

[jira] [Updated] (KAFKA-16418) Review/split long-running admin client integration tests

2024-04-02 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-16418: --- Summary: Review/split long-running admin client integration tests (was: Split long-running

Re: [PR] KAFKA-15729: Add KRaft support in GetOffsetShellTest [kafka]

2024-04-02 Thread via GitHub
chia7712 commented on code in PR #15489: URL: https://github.com/apache/kafka/pull/15489#discussion_r1548067397 ## tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java: ## @@ -391,4 +420,15 @@ private String[] addBootstrapServer(String... args) { return

[jira] [Created] (KAFKA-16459) consumer_test.py’s static membership tests fail with new consumer

2024-04-02 Thread Kirk True (Jira)
Kirk True created KAFKA-16459: - Summary: consumer_test.py’s static membership tests fail with new consumer Key: KAFKA-16459 URL: https://issues.apache.org/jira/browse/KAFKA-16459 Project: Kafka

[PR] KAFKA-16068: Use TestPlugins in ConnectorValidationIntegrationTest to silence plugin scanning errors [kafka]

2024-04-02 Thread via GitHub
Joker-5 opened a new pull request, #15642: URL: https://github.com/apache/kafka/pull/15642 Use TestPlugins in ConnectorValidationIntegrationTest to silence plugin scanning errors ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [

Re: [PR] MINOR: AbstractConfig cleanup Part 2 [kafka]

2024-04-02 Thread via GitHub
chia7712 commented on PR #15639: URL: https://github.com/apache/kafka/pull/15639#issuecomment-2031262693 @gharris1727 just curious. How do you notice that incorrect changes? Are there failed tests related to #15597? -- This is an automated message from the Apache Git Service. To respond

Re: [PR] KAFKA-15729: Add KRaft support in GetOffsetShellTest [kafka]

2024-04-02 Thread via GitHub
Owen-CH-Leung commented on code in PR #15489: URL: https://github.com/apache/kafka/pull/15489#discussion_r1547303323 ## tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java: ## @@ -94,15 +101,47 @@ private void setUp() { } } +private void

Re: [PR] KAFKA-15729: Add KRaft support in GetOffsetShellTest [kafka]

2024-04-02 Thread via GitHub
Owen-CH-Leung commented on code in PR #15489: URL: https://github.com/apache/kafka/pull/15489#discussion_r1547302390 ## tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java: ## @@ -391,4 +447,15 @@ private String[] addBootstrapServer(String... args) {

Re: [PR] KAFKA-15729: Add KRaft support in GetOffsetShellTest [kafka]

2024-04-02 Thread via GitHub
Owen-CH-Leung commented on code in PR #15489: URL: https://github.com/apache/kafka/pull/15489#discussion_r1547302390 ## tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java: ## @@ -391,4 +447,15 @@ private String[] addBootstrapServer(String... args) {

Re: [PR] KAFKA-16148: Implement GroupMetadataManager#onUnloaded [kafka]

2024-04-02 Thread via GitHub
dajac merged PR #15446: URL: https://github.com/apache/kafka/pull/15446 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (KAFKA-16458) Add contains method in KeyValue store interface

2024-04-02 Thread Ayoub Omari (Jira)
Ayoub Omari created KAFKA-16458: --- Summary: Add contains method in KeyValue store interface Key: KAFKA-16458 URL: https://issues.apache.org/jira/browse/KAFKA-16458 Project: Kafka Issue Type:

Re: [PR] KAFKA-15417 Sloppy bug: moved the outerJoinBreak-flags out of the loop [kafka]

2024-04-02 Thread via GitHub
mjsax merged PR #15510: URL: https://github.com/apache/kafka/pull/15510 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16123: KStreamKStreamJoinProcessor does not drop late records. [kafka]

2024-04-02 Thread via GitHub
mjsax commented on PR #15189: URL: https://github.com/apache/kafka/pull/15189#issuecomment-2032098989 Just merged https://github.com/apache/kafka/pull/15510 -- can we move forward with this PR (maybe by rebasing it to see if any tests break?)? -- This is an automated message from the

Re: [PR] KAFKA-15729: Add KRaft support in GetOffsetShellTest [kafka]

2024-04-02 Thread via GitHub
chia7712 commented on code in PR #15489: URL: https://github.com/apache/kafka/pull/15489#discussion_r1547986293 ## tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java: ## @@ -391,4 +420,15 @@ private String[] addBootstrapServer(String... args) { return

Re: [PR] KAFKA-15417 Sloppy bug: moved the outerJoinBreak-flags out of the loop [kafka]

2024-04-02 Thread via GitHub
mjsax commented on PR #15510: URL: https://github.com/apache/kafka/pull/15510#issuecomment-2032092184 Thanks for the fix @VictorvandenHoven! Merged to `trunk`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] KAFKA-16039: RecordHeaders supports the addAll method [kafka]

2024-04-02 Thread via GitHub
funky-eyes commented on PR #15034: URL: https://github.com/apache/kafka/pull/15034#issuecomment-2032110132 > @funky-eyes let me know if you got a chance to review my comment Hello, thank you for your reminder. I submitted this PR to make the functions of recordheader and list

Re: [PR] KAFKA-15538: Client support for java regex based subscription [kafka]

2024-04-02 Thread via GitHub
lianetm commented on PR #15585: URL: https://github.com/apache/kafka/pull/15585#issuecomment-2032154288 Hey @Phuc-Hong-Tran , any update on this one? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Updated] (KAFKA-16459) New consumer times out join group in consumer_test.py system test

2024-04-02 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16459: -- Description: The {{consumer_test.py}} system test fails with errors related to consumers joining the

[jira] [Updated] (KAFKA-16459) New consumer times out join group in consumer_test.py system test

2024-04-02 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16459: -- Description: The {{consumer_test.py}} system test fails with two different errors related to

[jira] [Assigned] (KAFKA-16459) New consumer times out join group in consumer_test.py system test

2024-04-02 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-16459: - Assignee: Kirk True (was: Philip Nee) > New consumer times out join group in consumer_test.py

[jira] [Updated] (KAFKA-16460) New consumer times out consuming records in consumer_test.py system test

2024-04-02 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16460: -- Description: The {{consumer_test.py}} system test fails with two different errors related to

[jira] [Updated] (KAFKA-16460) New consumer times out system test

2024-04-02 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16460: -- Description: The {{consumer_test.py}} system test fails with two different errors related to

[jira] [Created] (KAFKA-16462) New consumer fails with timeout in security_test.py system test

2024-04-02 Thread Kirk True (Jira)
Kirk True created KAFKA-16462: - Summary: New consumer fails with timeout in security_test.py system test Key: KAFKA-16462 URL: https://issues.apache.org/jira/browse/KAFKA-16462 Project: Kafka

[jira] [Updated] (KAFKA-16462) New consumer fails with timeout in security_test.py system test

2024-04-02 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16462: -- Description: The {{security_test.py}} system test fails with the following error: {noformat}

[jira] [Updated] (KAFKA-16463) Automatically delete metadata log directory on ZK brokers

2024-04-02 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-16463: - Description: Throughout the process of a ZK to KRaft migration, the operator has the choice to

[jira] [Created] (KAFKA-16463) Automatically delete metadata log directory on ZK brokers

2024-04-02 Thread David Arthur (Jira)
David Arthur created KAFKA-16463: Summary: Automatically delete metadata log directory on ZK brokers Key: KAFKA-16463 URL: https://issues.apache.org/jira/browse/KAFKA-16463 Project: Kafka

Re: [PR] KAFKA-16310 ListOffsets doesn't report the offset with maxTimestamp a… [kafka]

2024-04-02 Thread via GitHub
chia7712 commented on code in PR #15621: URL: https://github.com/apache/kafka/pull/15621#discussion_r1548390558 ## clients/src/main/java/org/apache/kafka/common/record/MemoryRecordsBuilder.java: ## @@ -240,25 +240,54 @@ public MemoryRecords build() { return

[jira] [Updated] (KAFKA-16405) Mismatch assignment error when running consumer rolling upgrade system tests

2024-04-02 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16405: -- Labels: kip-848-client-support system-tests (was: kip-848-client-support) > Mismatch assignment

[jira] [Created] (KAFKA-16465) New consumer does not invoke rebalance callbacks as expected in consumer_test.py system test

2024-04-02 Thread Kirk True (Jira)
Kirk True created KAFKA-16465: - Summary: New consumer does not invoke rebalance callbacks as expected in consumer_test.py system test Key: KAFKA-16465 URL: https://issues.apache.org/jira/browse/KAFKA-16465

[jira] [Updated] (KAFKA-16465) New consumer does not invoke rebalance callbacks as expected in consumer_test.py system test

2024-04-02 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16465: -- Description: The {{consumer_test.py}} system test fails with the following error: {noformat}

Re: [PR] KAFKA-16310 ListOffsets doesn't report the offset with maxTimestamp a… [kafka]

2024-04-02 Thread via GitHub
chia7712 commented on code in PR #15621: URL: https://github.com/apache/kafka/pull/15621#discussion_r1548530489 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1337,13 +1337,16 @@ class UnifiedLog(@volatile var logStartOffset: Long, } else if (targetTimestamp

Re: [PR] KAFKA-16310 ListOffsets doesn't report the offset with maxTimestamp a… [kafka]

2024-04-02 Thread via GitHub
chia7712 commented on code in PR #15621: URL: https://github.com/apache/kafka/pull/15621#discussion_r1548258165 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogValidator.java: ## @@ -434,7 +442,8 @@ public ValidationResult

[jira] [Updated] (KAFKA-16459) New consumer fails to join group in system tests

2024-04-02 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16459: -- Summary: New consumer fails to join group in system tests (was: consumer_test.py’s static membership

[jira] [Updated] (KAFKA-16459) consumer_test.py’s static membership tests fail with new consumer

2024-04-02 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16459: -- Description: System tests failures: {noformat} test_id:

[jira] [Updated] (KAFKA-16459) New consumer times out join group in consumer_test.py system test

2024-04-02 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16459: -- Summary: New consumer times out join group in consumer_test.py system test (was: New consumer fails

Re: [PR] KAFKA-16310 ListOffsets doesn't report the offset with maxTimestamp a… [kafka]

2024-04-02 Thread via GitHub
chia7712 commented on PR #15621: URL: https://github.com/apache/kafka/pull/15621#issuecomment-2032614122 @junrao thanks for additional reviews. I have addressed them except https://github.com/apache/kafka/pull/15621#discussion_r1548230600 -- This is an automated message from the Apache

[jira] [Created] (KAFKA-16460) New consumer times out system test

2024-04-02 Thread Kirk True (Jira)
Kirk True created KAFKA-16460: - Summary: New consumer times out system test Key: KAFKA-16460 URL: https://issues.apache.org/jira/browse/KAFKA-16460 Project: Kafka Issue Type: Bug

[jira] [Updated] (KAFKA-16460) New consumer times out consuming records in consumer_test.py system test

2024-04-02 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16460: -- Description: The {{consumer_test.py}} system test fails with the following errors: {quote} * Timed

[jira] [Created] (KAFKA-16461) New consumer fails to consume records in security_test.py system test

2024-04-02 Thread Kirk True (Jira)
Kirk True created KAFKA-16461: - Summary: New consumer fails to consume records in security_test.py system test Key: KAFKA-16461 URL: https://issues.apache.org/jira/browse/KAFKA-16461 Project: Kafka

[jira] [Updated] (KAFKA-16461) New consumer fails to consume records in security_test.py system test

2024-04-02 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16461: -- Description: The {{security_test.py}} system test fails with the following error: {quote} * Consumer

[jira] [Updated] (KAFKA-16463) Automatically delete metadata log directory on ZK brokers

2024-04-02 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-16463: - Description: Throughout the process of a ZK to KRaft migration, the operator has the choice to

[jira] [Updated] (KAFKA-16405) Mismatch assignment error when running consumer rolling upgrade system tests

2024-04-02 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16405: -- Issue Type: Bug (was: Task) > Mismatch assignment error when running consumer rolling upgrade system

[jira] [Updated] (KAFKA-16405) Mismatch assignment error when running consumer rolling upgrade system tests

2024-04-02 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16405: -- Priority: Blocker (was: Major) > Mismatch assignment error when running consumer rolling upgrade

[jira] [Updated] (KAFKA-16405) Mismatch assignment error when running consumer rolling upgrade system tests

2024-04-02 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16405: -- Component/s: clients > Mismatch assignment error when running consumer rolling upgrade system tests >

Re: [PR] KAFKA-16310 ListOffsets doesn't report the offset with maxTimestamp a… [kafka]

2024-04-02 Thread via GitHub
junrao commented on code in PR #15621: URL: https://github.com/apache/kafka/pull/15621#discussion_r1548427028 ## clients/src/main/java/org/apache/kafka/common/record/MemoryRecordsBuilder.java: ## @@ -240,25 +240,54 @@ public MemoryRecords build() { return builtRecords;

Re: [PR] KAFKA-16463 Delete metadata log on ZK broker startup [kafka]

2024-04-02 Thread via GitHub
jsancio commented on code in PR #15648: URL: https://github.com/apache/kafka/pull/15648#discussion_r1548472966 ## core/src/main/scala/kafka/raft/RaftManager.scala: ## @@ -69,6 +69,36 @@ object KafkaRaftManager { lock } + + /** + * Obtain the file lock and delete

[jira] [Updated] (KAFKA-16459) New consumer fails to join group in system tests

2024-04-02 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16459: -- Description: {{Consumers failed to join in a reasonable amount of time}} occurs in the following

[jira] [Updated] (KAFKA-16460) New consumer times out consuming records in consumer_test.py system test

2024-04-02 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16460: -- Summary: New consumer times out consuming records in consumer_test.py system test (was: New consumer

[jira] [Updated] (KAFKA-16459) New consumer times out joining group in consumer_test.py system test

2024-04-02 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16459: -- Summary: New consumer times out joining group in consumer_test.py system test (was: New consumer

[jira] [Created] (KAFKA-16464) New consumer fails with timeout in replication_replica_failure_test.py system test

2024-04-02 Thread Kirk True (Jira)
Kirk True created KAFKA-16464: - Summary: New consumer fails with timeout in replication_replica_failure_test.py system test Key: KAFKA-16464 URL: https://issues.apache.org/jira/browse/KAFKA-16464

[jira] [Updated] (KAFKA-16464) New consumer fails with timeout in replication_replica_failure_test.py system test

2024-04-02 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16464: -- Description: The {{replication_replica_failure_test.py}} system test fails with the following error:

[jira] [Updated] (KAFKA-16405) Mismatch assignment error when running consumer rolling upgrade system tests

2024-04-02 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16405: -- Fix Version/s: 3.8.0 > Mismatch assignment error when running consumer rolling upgrade system tests >

Re: [PR] KAFKA-16310 ListOffsets doesn't report the offset with maxTimestamp a… [kafka]

2024-04-02 Thread via GitHub
junrao commented on code in PR #15621: URL: https://github.com/apache/kafka/pull/15621#discussion_r1548487542 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1337,13 +1337,16 @@ class UnifiedLog(@volatile var logStartOffset: Long, } else if (targetTimestamp ==

Re: [PR] KAFKA-16463 Delete metadata log on ZK broker startup [kafka]

2024-04-02 Thread via GitHub
cmccabe commented on code in PR #15648: URL: https://github.com/apache/kafka/pull/15648#discussion_r1548528194 ## core/src/main/scala/kafka/raft/RaftManager.scala: ## @@ -69,6 +69,36 @@ object KafkaRaftManager { lock } + + /** + * Obtain the file lock and delete

[jira] [Updated] (KAFKA-16460) New consumer times out consuming records in consumer_test.py system test

2024-04-02 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16460: -- Description: The {{consumer_test.py}} system test fails with the following errors: {quote} * Timed

[jira] [Updated] (KAFKA-16460) New consumer times out consuming records in consumer_test.py system test

2024-04-02 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16460: -- Description: The {{consumer_test.py}} system test fails with the following errors: {quote} * Timed

Re: [PR] KAFKA-16310 ListOffsets doesn't report the offset with maxTimestamp a… [kafka]

2024-04-02 Thread via GitHub
junrao commented on code in PR #15621: URL: https://github.com/apache/kafka/pull/15621#discussion_r154830 ## clients/src/main/java/org/apache/kafka/common/record/MemoryRecordsBuilder.java: ## @@ -240,25 +240,40 @@ public MemoryRecords build() { return builtRecords;

[PR] KAFKA-16463 Delete metadata log on ZK broker startup [kafka]

2024-04-02 Thread via GitHub
mumrah opened a new pull request, #15648: URL: https://github.com/apache/kafka/pull/15648 This patch changes the behavior of the migrating ZK broker to always delete the local metadata log during startup. This deletion is done immediately before creating the RaftManager which will

Re: [PR] KAFKA-16310 ListOffsets doesn't report the offset with maxTimestamp a… [kafka]

2024-04-02 Thread via GitHub
chia7712 commented on code in PR #15621: URL: https://github.com/apache/kafka/pull/15621#discussion_r1548438900 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1337,13 +1337,16 @@ class UnifiedLog(@volatile var logStartOffset: Long, } else if (targetTimestamp

[jira] [Commented] (KAFKA-16389) consumer_test.py’s test_valid_assignment fails with new consumer

2024-04-02 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833298#comment-17833298 ] Kirk True commented on KAFKA-16389: --- Can you mark this as "In progress", [~pnee]? Thanks! >

Re: [PR] KAFKA-16463 Delete metadata log on ZK broker startup [kafka]

2024-04-02 Thread via GitHub
mumrah commented on code in PR #15648: URL: https://github.com/apache/kafka/pull/15648#discussion_r1548499611 ## core/src/main/scala/kafka/raft/RaftManager.scala: ## @@ -69,6 +69,36 @@ object KafkaRaftManager { lock } + + /** + * Obtain the file lock and delete the

[PR] Benchmark fibers [kafka]

2024-04-02 Thread via GitHub
bgprudhomme opened a new pull request, #15649: URL: https://github.com/apache/kafka/pull/15649 Refactor to fibers -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Benchmark fibers [kafka]

2024-04-02 Thread via GitHub
bgprudhomme closed pull request #15649: Benchmark fibers URL: https://github.com/apache/kafka/pull/15649 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[jira] [Assigned] (KAFKA-16459) New consumer times out joining group in consumer_test.py system test

2024-04-02 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-16459: - Assignee: Lianet Magrans (was: Kirk True) > New consumer times out joining group in

[jira] [Assigned] (KAFKA-16465) New consumer does not invoke rebalance callbacks as expected in consumer_test.py system test

2024-04-02 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-16465: - Assignee: Lianet Magrans (was: Kirk True) > New consumer does not invoke rebalance callbacks

  1   2   >