Re: [PR] MINOR: Improve logging in AssignmentsManager [kafka]

2024-04-12 Thread via GitHub
showuon commented on PR #15522: URL: https://github.com/apache/kafka/pull/15522#issuecomment-2051055209 Failed tests are unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Resolved] (KAFKA-16473) KafkaDockerWrapper uses wrong cluster ID when formatting log dir

2024-04-12 Thread Manikumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar resolved KAFKA-16473. --- Fix Version/s: 3.8.0 3.7.1 Resolution: Fixed > KafkaDockerWrapper uses

[jira] [Assigned] (KAFKA-16473) KafkaDockerWrapper uses wrong cluster ID when formatting log dir

2024-04-12 Thread Manikumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar reassigned KAFKA-16473: - Assignee: Sebastian Marsching > KafkaDockerWrapper uses wrong cluster ID when formatting log

Re: [PR] MINOR: Improve logging in AssignmentsManager [kafka]

2024-04-12 Thread via GitHub
showuon merged PR #15522: URL: https://github.com/apache/kafka/pull/15522 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16424: remove truncated logs after alter dir [kafka]

2024-04-12 Thread via GitHub
showuon commented on code in PR #15616: URL: https://github.com/apache/kafka/pull/15616#discussion_r1562184559 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogSegment.java: ## @@ -800,8 +802,23 @@ private Void deleteTypeIfExists(StorageAction delete, Stri

Re: [PR] KAFKA-16473: Use correct cluster ID when formatting log dir. [kafka]

2024-04-12 Thread via GitHub
omkreddy merged PR #15658: URL: https://github.com/apache/kafka/pull/15658 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (KAFKA-16542) The remote node is not a BROKER that supports the METADATA api. (org.apache.kafka.clients.admin.internals.AdminMetadataManager)

2024-04-12 Thread Hiro (Jira)
Hiro created KAFKA-16542: Summary: The remote node is not a BROKER that supports the METADATA api. (org.apache.kafka.clients.admin.internals.AdminMetadataManager) Key: KAFKA-16542 URL:

Re: [PR] KAFKA-16373: Adding Apache Kafka Docker Official Images Directory [kafka]

2024-04-12 Thread via GitHub
KrishVora01 closed pull request #15703: KAFKA-16373: Adding Apache Kafka Docker Official Images Directory URL: https://github.com/apache/kafka/pull/15703 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Assigned] (KAFKA-16522) Admin client changes for adding and removing voters

2024-04-12 Thread Quoc Phong Dang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Quoc Phong Dang reassigned KAFKA-16522: --- Assignee: Quoc Phong Dang > Admin client changes for adding and removing voters >

[jira] [Commented] (KAFKA-13636) Committed offsets could be deleted during a rebalance if a group did not commit for a while

2024-04-12 Thread zhangzhisheng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836455#comment-17836455 ] zhangzhisheng commented on KAFKA-13636: --- Kafka broker version is 2.7.2 Client version is 2.5.2.

Re: [PR] Add s390x support to CI [kafka]

2024-04-12 Thread via GitHub
Prashant-Jagtap commented on PR #15644: URL: https://github.com/apache/kafka/pull/15644#issuecomment-2051081344 @mimaison Could you please take a look. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (KAFKA-16510) java.lang.OutOfMemoryError in kafka-metadata-quorum.sh

2024-04-12 Thread Hiro (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836431#comment-17836431 ] Hiro commented on KAFKA-16510: -- [~leizhiyuan] Thank you your support ! this problem was resolved :) >

[jira] [Updated] (KAFKA-16542) The remote node is not a BROKER that supports the METADATA api. (org.apache.kafka.clients.admin.internals.AdminMetadataManager)

2024-04-12 Thread Hiro (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiro updated KAFKA-16542: - Description: I got this error by this cli. but when I executed this command to the broker, this was

[PR] KAFKA-16373: Adding code to support Apache Kafka Docker Official Images [kafka]

2024-04-12 Thread via GitHub
KrishVora01 opened a new pull request, #15704: URL: https://github.com/apache/kafka/pull/15704 This PR adds code to support Apache Kafka Docker Official Images. The files added include: 1. .github/workflows/prepare_docker_official_image_source.yml This adds github actions workflow to

Re: [PR] KAFKA-16211: Inconsistent config values in CreateTopicsResult and DescribeConfigsResult [kafka]

2024-04-12 Thread via GitHub
chia7712 commented on PR #15696: URL: https://github.com/apache/kafka/pull/15696#issuecomment-2051050590 > Considering describeTopics(), should we note that it should only be used with the resource of type BROKER at this momment? not sure whether the issue is related to

Re: [PR] MINOR: Document JBOD limitation during migration [kafka]

2024-04-12 Thread via GitHub
showuon merged PR #15692: URL: https://github.com/apache/kafka/pull/15692 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Resolved] (KAFKA-16510) java.lang.OutOfMemoryError in kafka-metadata-quorum.sh

2024-04-12 Thread Hiro (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiro resolved KAFKA-16510. -- Resolution: Fixed > java.lang.OutOfMemoryError in kafka-metadata-quorum.sh >

[jira] [Commented] (KAFKA-16511) Leaking tiered segments

2024-04-12 Thread Kamal Chandraprakash (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836444#comment-17836444 ] Kamal Chandraprakash commented on KAFKA-16511: -- The segment deletion might be stuck due to

[jira] [Commented] (KAFKA-2499) kafka-producer-perf-test should use something more realistic than empty byte arrays

2024-04-12 Thread Walter Hernandez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-2499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836506#comment-17836506 ] Walter Hernandez commented on KAFKA-2499: - This is indeed duplicated by the referenced earlier

[jira] [Comment Edited] (KAFKA-2499) kafka-producer-perf-test should use something more realistic than empty byte arrays

2024-04-12 Thread Walter Hernandez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-2499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836506#comment-17836506 ] Walter Hernandez edited comment on KAFKA-2499 at 4/12/24 8:45 AM: -- This

[jira] [Commented] (KAFKA-16510) java.lang.OutOfMemoryError in kafka-metadata-quorum.sh

2024-04-12 Thread Hiro (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836517#comment-17836517 ] Hiro commented on KAFKA-16510: -- [~showuon] No, the problem occurred with all scripts. When I tried it

[jira] [Comment Edited] (KAFKA-16511) Leaking tiered segments

2024-04-12 Thread Francois Visconte (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836472#comment-17836472 ] Francois Visconte edited comment on KAFKA-16511 at 4/12/24 8:24 AM:

[jira] (KAFKA-2499) kafka-producer-perf-test should use something more realistic than empty byte arrays

2024-04-12 Thread Walter Hernandez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-2499 ] Walter Hernandez deleted comment on KAFKA-2499: - was (Author: JIRAUSER305029): This indeed duplicates the referenced earlier ticket, where there is a patch available. However, this

Re: [PR] KAFKA-16373: Adding code to support Apache Kafka Docker Official Images [kafka]

2024-04-12 Thread via GitHub
VedarthConfluent commented on code in PR #15704: URL: https://github.com/apache/kafka/pull/15704#discussion_r1562289692 ## docker/generate_kafka_pr_template.sh: ## @@ -0,0 +1,61 @@ +#!/usr/bin/env bash Review Comment: Add license string at the beginning of all new files

[jira] [Commented] (KAFKA-16511) Leaking tiered segments

2024-04-12 Thread Francois Visconte (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836472#comment-17836472 ] Francois Visconte commented on KAFKA-16511: --- I ran kafka-delete-records.sh and it did the

[jira] [Updated] (KAFKA-2499) kafka-producer-perf-test should use something more realistic than empty byte arrays

2024-04-12 Thread Walter Hernandez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-2499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Walter Hernandez updated KAFKA-2499: Issue Type: Improvement (was: Bug) > kafka-producer-perf-test should use something more

[jira] [Assigned] (KAFKA-2499) kafka-producer-perf-test should use something more realistic than empty byte arrays

2024-04-12 Thread Walter Hernandez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-2499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Walter Hernandez reassigned KAFKA-2499: --- Assignee: Walter Hernandez > kafka-producer-perf-test should use something more

Re: [PR] KAFKA-16082: Avoid resuming future replica if current replica is in the same directory [kafka]

2024-04-12 Thread via GitHub
showuon commented on code in PR #15136: URL: https://github.com/apache/kafka/pull/15136#discussion_r1562284319 ## core/src/main/scala/kafka/log/LogManager.scala: ## @@ -1176,6 +1176,42 @@ class LogManager(logDirs: Seq[File], } } + def

[jira] [Commented] (KAFKA-16510) java.lang.OutOfMemoryError in kafka-metadata-quorum.sh

2024-04-12 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836529#comment-17836529 ] Luke Chen commented on KAFKA-16510: --- OK, I see. If it's the issue of incorrectly SASL_SSL setting,

[jira] [Commented] (KAFKA-16510) java.lang.OutOfMemoryError in kafka-metadata-quorum.sh

2024-04-12 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836501#comment-17836501 ] Luke Chen commented on KAFKA-16510: --- [~hiroa] , I'd like to confirm that only

[jira] [Updated] (KAFKA-16510) java.lang.OutOfMemoryError in kafka-metadata-quorum.sh

2024-04-12 Thread Hiro (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiro updated KAFKA-16510: - Affects Version/s: 3.7.0 (was: 3.4.1) > java.lang.OutOfMemoryError in

[jira] [Commented] (KAFKA-2499) kafka-producer-perf-test should use something more realistic than empty byte arrays

2024-04-12 Thread Walter Hernandez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-2499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836503#comment-17836503 ] Walter Hernandez commented on KAFKA-2499: - This indeed duplicates the referenced earlier ticket,

Re: [PR] KAFKA-16082: Avoid resuming future replica if current replica is in the same directory [kafka]

2024-04-12 Thread via GitHub
showuon commented on code in PR #15136: URL: https://github.com/apache/kafka/pull/15136#discussion_r1562307197 ## core/src/main/scala/kafka/log/LogManager.scala: ## @@ -1173,6 +1173,35 @@ class LogManager(logDirs: Seq[File], } } + def

Re: [PR] KAFKA-15776: Use the FETCH request timeout as the delay timeout for DelayedRemoteFetch [kafka]

2024-04-12 Thread via GitHub
showuon commented on PR #14778: URL: https://github.com/apache/kafka/pull/14778#issuecomment-2051465918 Correction: For this: > some users might feel surprised when their fetch doesn't respond in fetch.max.wait.ms time. This is wrong. Even if the remote reading is not completed,

[PR] MINOR: Various cleanups in clients [kafka]

2024-04-12 Thread via GitHub
mimaison opened a new pull request, #15705: URL: https://github.com/apache/kafka/pull/15705 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including

Re: [PR] MINOR : Replaced the while loop with TestUtils.waitForCondition [kafka]

2024-04-12 Thread via GitHub
chiacyu commented on code in PR #15678: URL: https://github.com/apache/kafka/pull/15678#discussion_r1562574967 ## server/src/test/java/org/apache/kafka/server/AssignmentsManagerTest.java: ## @@ -172,10 +172,11 @@ public void testAssignmentAggregation() throws

[PR] Various cleanups in trogdor [kafka]

2024-04-12 Thread via GitHub
mimaison opened a new pull request, #15708: URL: https://github.com/apache/kafka/pull/15708 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including

Re: [PR] KAFKA-16543:There may be ambiguous deletions in the `cleanupGroupMetadata` when the generation of the group is less than or equal to 0 [kafka]

2024-04-12 Thread via GitHub
dajac commented on PR #15706: URL: https://github.com/apache/kafka/pull/15706#issuecomment-2051869550 Hi @hudeqi. Thanks for the patch. I would like to better understand it. My first question is how would Flink commit Flink with a generationId equal to -1? The generation of the group is

[jira] [Assigned] (KAFKA-15359) Support log.dir.failure.timeout.ms configuration for JBOD

2024-04-12 Thread Igor Soarez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Soarez reassigned KAFKA-15359: --- Assignee: (was: Igor Soarez) > Support log.dir.failure.timeout.ms configuration for

[jira] [Created] (KAFKA-16543) There may be ambiguous deletions in the `cleanupGroupMetadata` when the generation of the group is less than or equal to 0

2024-04-12 Thread hudeqi (Jira)
hudeqi created KAFKA-16543: -- Summary: There may be ambiguous deletions in the `cleanupGroupMetadata` when the generation of the group is less than or equal to 0 Key: KAFKA-16543 URL:

Re: [PR] KAFKA-16371: fix lingering pending commit when handling OFFSET_METADATA_TOO_LARGE [kafka]

2024-04-12 Thread via GitHub
dajac commented on PR #15536: URL: https://github.com/apache/kafka/pull/15536#issuecomment-2051891235 Sorry for the delay on this one. I will review it next week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[PR] MINOR: Fix incorrect equals comparison of topicId by reference in PartitionMetadataFile [kafka]

2024-04-12 Thread via GitHub
alok123t opened a new pull request, #15707: URL: https://github.com/apache/kafka/pull/15707 Previously, we were comparing uuid by reference, which could be incorrect. This PR replaces to do the comparison by value instead ### Committer Checklist (excluded from commit message) - [

Re: [PR] KAFKA-16528: Client HB timing fix [kafka]

2024-04-12 Thread via GitHub
cadonna commented on code in PR #15698: URL: https://github.com/apache/kafka/pull/15698#discussion_r1562500382 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -269,6 +269,9 @@ private NetworkClientDelegate.UnsentRequest

[PR] KAFKA-16543:There may be ambiguous deletions in the `cleanupGroupMetadata` when the generation of the group is less than or equal to 0 [kafka]

2024-04-12 Thread via GitHub
hudeqi opened a new pull request, #15706: URL: https://github.com/apache/kafka/pull/15706 In the `cleanupGroupMetadata` method, tombstone messages is written to delete the group's MetadataKey only when the group is in the Dead state and the generation is greater than 0. The comment

[jira] [Commented] (KAFKA-16514) Kafka Streams: stream.close(CloseOptions) does not respect options.leaveGroup flag.

2024-04-12 Thread Sal Sorrentino (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836644#comment-17836644 ] Sal Sorrentino commented on KAFKA-16514: Digging further into this, it seems the leaveGroup

[jira] [Updated] (KAFKA-16543) There may be ambiguous deletions in the `cleanupGroupMetadata` when the generation of the group is less than or equal to 0

2024-04-12 Thread hudeqi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] hudeqi updated KAFKA-16543: --- Description: In the `cleanupGroupMetadata` method, tombstone messages is written to delete the group's

Re: [PR] KAFKA-15649: Handle directory failure timeout [kafka]

2024-04-12 Thread via GitHub
soarez commented on code in PR #15697: URL: https://github.com/apache/kafka/pull/15697#discussion_r1562612304 ## core/src/main/scala/kafka/server/BrokerLifecycleManager.scala: ## @@ -507,6 +522,7 @@ class BrokerLifecycleManager( if (errorCode == Errors.NONE) {

[jira] [Commented] (KAFKA-16511) Leaking tiered segments

2024-04-12 Thread Kamal Chandraprakash (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836762#comment-17836762 ] Kamal Chandraprakash commented on KAFKA-16511: -- [~fvisconte]  The issue might be due to the

Re: [PR] KAFKA-15729: Add KRaft support in GetOffsetShellTest [kafka]

2024-04-12 Thread via GitHub
chia7712 commented on code in PR #15489: URL: https://github.com/apache/kafka/pull/15489#discussion_r1562683822 ## tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java: ## @@ -391,4 +428,30 @@ private String[] addBootstrapServer(String... args) { return

Re: [PR] debug for #15489 [kafka]

2024-04-12 Thread via GitHub
chia7712 commented on PR #15654: URL: https://github.com/apache/kafka/pull/15654#issuecomment-2053016969 close as we do see the root cause -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] debug for #15489 [kafka]

2024-04-12 Thread via GitHub
chia7712 closed pull request #15654: debug for #15489 URL: https://github.com/apache/kafka/pull/15654 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (KAFKA-16511) Leaking tiered segments

2024-04-12 Thread Kamal Chandraprakash (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamal Chandraprakash updated KAFKA-16511: - Description: I have some topics there were not written since a few days (having

Re: [PR] Fix incorrect equals comparison of Uuid by reference [kafka]

2024-04-12 Thread via GitHub
chia7712 commented on code in PR #15707: URL: https://github.com/apache/kafka/pull/15707#discussion_r1563600417 ## core/src/main/scala/kafka/server/AlterPartitionManager.scala: ## @@ -270,7 +270,7 @@ class DefaultAlterPartitionManager(

Re: [PR] Fix incorrect Java equals comparison of Uuid by reference [kafka]

2024-04-12 Thread via GitHub
alok123t commented on code in PR #15707: URL: https://github.com/apache/kafka/pull/15707#discussion_r1563676834 ## core/src/main/scala/kafka/server/AlterPartitionManager.scala: ## @@ -270,7 +270,7 @@ class DefaultAlterPartitionManager(

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

2024-04-12 Thread via GitHub
CalvinConfluent commented on PR #15702: URL: https://github.com/apache/kafka/pull/15702#issuecomment-2052041676 @mumrah Can you help take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[PR] MINOR: Various cleanups in shell [kafka]

2024-04-12 Thread via GitHub
mimaison opened a new pull request, #15712: URL: https://github.com/apache/kafka/pull/15712 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including

Re: [PR] MINOR: Various cleanups in server and server-common [kafka]

2024-04-12 Thread via GitHub
chia7712 commented on code in PR #15710: URL: https://github.com/apache/kafka/pull/15710#discussion_r1562828732 ## server-common/src/test/java/org/apache/kafka/timeline/SnapshotRegistryTest.java: ## @@ -41,9 +42,7 @@ public void testEmptyRegistry() { private static void

Re: [PR] KAFKA-15046: Get rid of unnecessary fsyncs inside UnifiedLog.lock to stabilize performance [kafka]

2024-04-12 Thread via GitHub
junrao commented on code in PR #14242: URL: https://github.com/apache/kafka/pull/14242#discussion_r1562928115 ## server-common/src/main/java/org/apache/kafka/server/common/CheckpointFile.java: ## @@ -72,18 +72,20 @@ public CheckpointFile(File file, tempPath =

[PR] MINOR: Various cleanups in tools [kafka]

2024-04-12 Thread via GitHub
mimaison opened a new pull request, #15709: URL: https://github.com/apache/kafka/pull/15709 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including

[jira] [Commented] (KAFKA-16514) Kafka Streams: stream.close(CloseOptions) does not respect options.leaveGroup flag.

2024-04-12 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836671#comment-17836671 ] Matthias J. Sax commented on KAFKA-16514: - CloseOption was introduced via

Re: [PR] KAFKA-16463 Delete metadata log on ZK broker startup [kafka]

2024-04-12 Thread via GitHub
cmccabe merged PR #15648: URL: https://github.com/apache/kafka/pull/15648 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] MINOR: Various cleanups in storage [kafka]

2024-04-12 Thread via GitHub
mimaison opened a new pull request, #15711: URL: https://github.com/apache/kafka/pull/15711 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including

[PR] MINOR: fix duplicated return and other streams docs typos [kafka]

2024-04-12 Thread via GitHub
AyoubOm opened a new pull request, #15713: URL: https://github.com/apache/kafka/pull/15713 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] KAFKA-16287: Implement example tests for common rebalance callback [kafka]

2024-04-12 Thread via GitHub
kirktrue commented on PR #15408: URL: https://github.com/apache/kafka/pull/15408#issuecomment-2052100630 @lucasbru—I think it's worth adding the tests, even if we already know there are more to be added in the future. -- This is an automated message from the Apache Git Service. To

Re: [PR] MINOR: Fix incorrect equals comparison of topicId by reference in PartitionMetadataFile [kafka]

2024-04-12 Thread via GitHub
chia7712 commented on PR #15707: URL: https://github.com/apache/kafka/pull/15707#issuecomment-2052183089 the following links have similar issue. Should we fix them in this PR or I file a follow-up to fix them?

[PR] Various cleanups in server and server-common [kafka]

2024-04-12 Thread via GitHub
mimaison opened a new pull request, #15710: URL: https://github.com/apache/kafka/pull/15710 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including

Re: [PR] KAFKA-15853: Move transactions configs out of core [kafka]

2024-04-12 Thread via GitHub
chia7712 merged PR #15670: URL: https://github.com/apache/kafka/pull/15670 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (KAFKA-16541) Potential leader epoch checkpoint file corruption on OS crash

2024-04-12 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-16541: Affects Version/s: 3.7.0 > Potential leader epoch checkpoint file corruption on OS crash >

[jira] [Created] (KAFKA-16544) DescribeTopicsResult#allTopicIds and DescribeTopicsResult#allTopicNames should return null instead of throwing NPE

2024-04-12 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-16544: -- Summary: DescribeTopicsResult#allTopicIds and DescribeTopicsResult#allTopicNames should return null instead of throwing NPE Key: KAFKA-16544 URL:

[jira] [Created] (KAFKA-16545) Auto adjust the replica factor according to number of broker when using ClusterTestExtensions

2024-04-12 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-16545: -- Summary: Auto adjust the replica factor according to number of broker when using ClusterTestExtensions Key: KAFKA-16545 URL: https://issues.apache.org/jira/browse/KAFKA-16545

[jira] [Commented] (KAFKA-16514) Kafka Streams: stream.close(CloseOptions) does not respect options.leaveGroup flag.

2024-04-12 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836736#comment-17836736 ] A. Sophie Blee-Goldman commented on KAFKA-16514: I haven't gone back and re-read the

[jira] [Commented] (KAFKA-16541) Potential leader epoch checkpoint file corruption on OS crash

2024-04-12 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836717#comment-17836717 ] Jun Rao commented on KAFKA-16541: - Thanks for filing the jira, [~ocadaruma] !  Since this is a

[jira] [Comment Edited] (KAFKA-16541) Potential leader epoch checkpoint file corruption on OS crash

2024-04-12 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836717#comment-17836717 ] Jun Rao edited comment on KAFKA-16541 at 4/12/24 5:43 PM: -- Thanks for filing

Re: [PR] KAFKA-16073: Increment the local-log-start-offset before deleting segments in memory table [kafka]

2024-04-12 Thread via GitHub
junrao commented on PR #15631: URL: https://github.com/apache/kafka/pull/15631#issuecomment-2052208460 @kamalcph : Thanks for the update. JDK 11 and Scala 2.13 didn't complete in the last test run. Could you trigger another run of the tests? -- This is an automated message from the

Re: [PR] MINOR: Various cleanups in clients [kafka]

2024-04-12 Thread via GitHub
chia7712 commented on code in PR #15705: URL: https://github.com/apache/kafka/pull/15705#discussion_r1562938471 ## clients/src/main/java/org/apache/kafka/common/memory/GarbageCollectedMemoryPool.java: ## @@ -37,13 +37,13 @@ public class GarbageCollectedMemoryPool extends

[jira] [Assigned] (KAFKA-16544) DescribeTopicsResult#allTopicIds and DescribeTopicsResult#allTopicNames should return null instead of throwing NPE

2024-04-12 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-16544: -- Assignee: Chia-Ping Tsai > DescribeTopicsResult#allTopicIds and

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

2024-04-12 Thread via GitHub
splett2 commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1563195256 ## metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java: ## @@ -423,6 +441,17 @@ public void replay(ConfigRecord record) {

Re: [PR] MINOR: Fix incorrect equals comparison of topicId by reference in PartitionMetadataFile [kafka]

2024-04-12 Thread via GitHub
alok123t commented on PR #15707: URL: https://github.com/apache/kafka/pull/15707#issuecomment-2052600875 @jolshan @chia7712 randomly looking at the code base, i think this is prevalent in multiple places. Shall I update them all in this PR and also create a ticket? -- This is an

[jira] [Comment Edited] (KAFKA-16514) Kafka Streams: stream.close(CloseOptions) does not respect options.leaveGroup flag.

2024-04-12 Thread Sal Sorrentino (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836750#comment-17836750 ] Sal Sorrentino edited comment on KAFKA-16514 at 4/12/24 10:03 PM: -- The

Re: [PR] Fix incorrect equals comparison of Uuid by reference [kafka]

2024-04-12 Thread via GitHub
alok123t commented on PR #15707: URL: https://github.com/apache/kafka/pull/15707#issuecomment-2052621773 i did smth similar to https://stackoverflow.com/a/73535824 to find all usages in the codebase -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

2024-04-12 Thread via GitHub
splett2 commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1563193794 ## metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java: ## @@ -423,6 +441,17 @@ public void replay(ConfigRecord record) {

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

2024-04-12 Thread via GitHub
splett2 commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1563199330 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -2360,4 +2363,9 @@ void setNewNextWriteOffset(long newNextWriteOffset) { void

Re: [PR] KAFKA-16452: Bound high-watermark offset to range between LLSO and LEO [kafka]

2024-04-12 Thread via GitHub
junrao commented on code in PR #15634: URL: https://github.com/apache/kafka/pull/15634#discussion_r1562991673 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -282,15 +282,15 @@ class UnifiedLog(@volatile var logStartOffset: Long, /** * Update high watermark

[jira] [Commented] (KAFKA-16514) Kafka Streams: stream.close(CloseOptions) does not respect options.leaveGroup flag.

2024-04-12 Thread Sal Sorrentino (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836750#comment-17836750 ] Sal Sorrentino commented on KAFKA-16514: The KIP mentions nothing about static membership. I

[jira] [Comment Edited] (KAFKA-16514) Kafka Streams: stream.close(CloseOptions) does not respect options.leaveGroup flag.

2024-04-12 Thread Sal Sorrentino (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836750#comment-17836750 ] Sal Sorrentino edited comment on KAFKA-16514 at 4/12/24 10:06 PM: -- The