[jira] [Updated] (KAFKA-10437) KIP-478: Implement test-utils changes

2021-02-26 Thread dengziming (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dengziming updated KAFKA-10437: --- Attachment: image.png > KIP-478: Implement test-utils changes >

[jira] [Updated] (KAFKA-10437) KIP-478: Implement test-utils changes

2021-02-26 Thread dengziming (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dengziming updated KAFKA-10437: --- Attachment: (was: image.png) > KIP-478: Implement test-utils changes >

[GitHub] [kafka] dengziming commented on pull request #10229: MINOR: Account for extra whitespaces in WordCountDemo

2021-02-26 Thread GitBox
dengziming commented on pull request #10229: URL: https://github.com/apache/kafka/pull/10229#issuecomment-786993345 @mjsax ,Hello, this is inspired by #10044 which forget `WordCountProcessorDemo` and `WordCountTransformerDemo`, PTAL.

[GitHub] [kafka] dengziming opened a new pull request #10229: MINOR: Account for extra whitespaces in WordCountDemo

2021-02-26 Thread GitBox
dengziming opened a new pull request #10229: URL: https://github.com/apache/kafka/pull/10229 *More detailed description of your change* As the title. *Summary of testing strategy (including rationale)* QA ### Committer Checklist (excluded from commit message) - [ ]

[GitHub] [kafka] ijuma commented on pull request #8830: KAFKA-10116: GraalVM native-image prototype

2021-02-26 Thread GitBox
ijuma commented on pull request #8830: URL: https://github.com/apache/kafka/pull/8830#issuecomment-786989056 Rebased and regenerated the configs with graalvm ce 21.0.0.2. Need to investigate the error during start-up: > Exception in thread "main" java.lang.NoClassDefFoundError:

[GitHub] [kafka] junrao commented on a change in pull request #10184: MINOR: enable topic deletion in the KIP-500 controller

2021-02-26 Thread GitBox
junrao commented on a change in pull request #10184: URL: https://github.com/apache/kafka/pull/10184#discussion_r584019199 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -349,6 +357,16 @@ public void

[GitHub] [kafka] showuon commented on pull request #10228: KAFKA-10251: increase timeout for consumeing records

2021-02-26 Thread GitBox
showuon commented on pull request #10228: URL: https://github.com/apache/kafka/pull/10228#issuecomment-786981927 @abbccdda @ableegoldman @mjsax , could you help review this PR? Thanks. This is an automated message from the

[GitHub] [kafka] showuon opened a new pull request #10228: KAFKA-10251: increase timeout for consumeing records

2021-02-26 Thread GitBox
showuon opened a new pull request #10228: URL: https://github.com/apache/kafka/pull/10228 We need to wait for the translation state changed to `READY` to start consuming the records. But we didn't have any way to change the transationManager state in client, so we can just wait. I've

[jira] [Created] (KAFKA-12384) Flaky Test ListOffsetsRequestTest.testResponseIncludesLeaderEpoch

2021-02-26 Thread Matthias J. Sax (Jira)
Matthias J. Sax created KAFKA-12384: --- Summary: Flaky Test ListOffsetsRequestTest.testResponseIncludesLeaderEpoch Key: KAFKA-12384 URL: https://issues.apache.org/jira/browse/KAFKA-12384 Project:

[GitHub] [kafka] showuon commented on a change in pull request #10185: KAFKA-12284: wait for mm2 auto-created the topic

2021-02-26 Thread GitBox
showuon commented on a change in pull request #10185: URL: https://github.com/apache/kafka/pull/10185#discussion_r584015842 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationBaseTest.java ## @@ -455,27 +470,44 @@

[jira] [Commented] (KAFKA-10251) Flaky Test kafka.api.TransactionsBounceTest.testWithGroupMetadata

2021-02-26 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17292005#comment-17292005 ] Luke Chen commented on KAFKA-10251: --- This flaky test also points to the same root cause.

[jira] [Created] (KAFKA-12383) Get RaftClusterTest.java and other KIP-500 junit tests working

2021-02-26 Thread Colin McCabe (Jira)
Colin McCabe created KAFKA-12383: Summary: Get RaftClusterTest.java and other KIP-500 junit tests working Key: KAFKA-12383 URL: https://issues.apache.org/jira/browse/KAFKA-12383 Project: Kafka

[GitHub] [kafka] showuon commented on pull request #10185: KAFKA-12284: wait for mm2 auto-created the topic

2021-02-26 Thread GitBox
showuon commented on pull request #10185: URL: https://github.com/apache/kafka/pull/10185#issuecomment-786978491 @mimaison , thanks for your comments. I've addressed them and updated in this commit:

[jira] [Created] (KAFKA-12382) Create KIP-500 README for the 2.8 rleease

2021-02-26 Thread Colin McCabe (Jira)
Colin McCabe created KAFKA-12382: Summary: Create KIP-500 README for the 2.8 rleease Key: KAFKA-12382 URL: https://issues.apache.org/jira/browse/KAFKA-12382 Project: Kafka Issue Type: Bug

[jira] [Updated] (KAFKA-12382) Create KIP-500 README for the 2.8 release

2021-02-26 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-12382: - Summary: Create KIP-500 README for the 2.8 release (was: Create KIP-500 README for the 2.8

[GitHub] [kafka] showuon commented on a change in pull request #10185: KAFKA-12284: wait for mm2 auto-created the topic

2021-02-26 Thread GitBox
showuon commented on a change in pull request #10185: URL: https://github.com/apache/kafka/pull/10185#discussion_r584013857 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationBaseTest.java ## @@ -455,27 +470,44 @@

[GitHub] [kafka] showuon commented on a change in pull request #10185: KAFKA-12284: wait for mm2 auto-created the topic

2021-02-26 Thread GitBox
showuon commented on a change in pull request #10185: URL: https://github.com/apache/kafka/pull/10185#discussion_r584013620 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationBaseTest.java ## @@ -455,27 +470,44 @@

[GitHub] [kafka] cmccabe merged pull request #10226: MINOR: fix kafka-metadata-shell.sh

2021-02-26 Thread GitBox
cmccabe merged pull request #10226: URL: https://github.com/apache/kafka/pull/10226 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] cmccabe commented on a change in pull request #10184: MINOR: enable topic deletion in the KIP-500 controller

2021-02-26 Thread GitBox
cmccabe commented on a change in pull request #10184: URL: https://github.com/apache/kafka/pull/10184#discussion_r584009213 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -349,6 +357,16 @@ public void

[GitHub] [kafka] cmccabe commented on a change in pull request #10184: MINOR: enable topic deletion in the KIP-500 controller

2021-02-26 Thread GitBox
cmccabe commented on a change in pull request #10184: URL: https://github.com/apache/kafka/pull/10184#discussion_r584007497 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -349,6 +357,16 @@ public void

[GitHub] [kafka] cmccabe commented on pull request #10199: KAFKA-12374: Add missing config sasl.mechanism.controller.protocol

2021-02-26 Thread GitBox
cmccabe commented on pull request #10199: URL: https://github.com/apache/kafka/pull/10199#issuecomment-786970988 I filed https://issues.apache.org/jira/browse/KAFKA-12381 to follow up on the auto-topic-creation behavior change discussion.

[GitHub] [kafka] cmccabe merged pull request #10199: KAFKA-12374: Add missing config sasl.mechanism.controller.protocol

2021-02-26 Thread GitBox
cmccabe merged pull request #10199: URL: https://github.com/apache/kafka/pull/10199 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (KAFKA-12381) Incompatible change in verifiable_producer.log in 2.8

2021-02-26 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17291991#comment-17291991 ] Colin McCabe commented on KAFKA-12381: -- cc [~rndgstn], [~hachikuji], [~ijuma] > Incompatible

[jira] [Updated] (KAFKA-12381) Incompatible change in verifiable_producer.log in 2.8

2021-02-26 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-12381: - Affects Version/s: 2.8.0 > Incompatible change in verifiable_producer.log in 2.8 >

[jira] [Assigned] (KAFKA-12381) Incompatible change in verifiable_producer.log in 2.8

2021-02-26 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe reassigned KAFKA-12381: Assignee: Boyang Chen > Incompatible change in verifiable_producer.log in 2.8 >

[jira] [Created] (KAFKA-12381) Incompatible change in verifiable_producer.log in 2.8

2021-02-26 Thread Colin McCabe (Jira)
Colin McCabe created KAFKA-12381: Summary: Incompatible change in verifiable_producer.log in 2.8 Key: KAFKA-12381 URL: https://issues.apache.org/jira/browse/KAFKA-12381 Project: Kafka Issue

[GitHub] [kafka] cmccabe opened a new pull request #10227: MINOR: add a README for KIP-500

2021-02-26 Thread GitBox
cmccabe opened a new pull request #10227: URL: https://github.com/apache/kafka/pull/10227 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] cmccabe opened a new pull request #10226: MINOR: fix kafka-metadata-shell.sh

2021-02-26 Thread GitBox
cmccabe opened a new pull request #10226: URL: https://github.com/apache/kafka/pull/10226 * Fix CLASSPATH issues in the startup script * Fix overly verbose log messages during loading * Update to use the new MetadataRecordSerde (this is needed now that we have a frame

[GitHub] [kafka] hachikuji commented on pull request #10225: MINOR: fix security_test for ZK case due to error change

2021-02-26 Thread GitBox
hachikuji commented on pull request #10225: URL: https://github.com/apache/kafka/pull/10225#issuecomment-786959937 @rondagostino Thanks for identifying the issue. Returning `INVALID_REPLICATION_FACTOR` seems like a mistake to me if we were previously returning `LEADER_NOT_AVAILABLE`. I'd

[GitHub] [kafka] rondagostino commented on pull request #10225: MINOR: fix security_test for ZK case due to error change

2021-02-26 Thread GitBox
rondagostino commented on pull request #10225: URL: https://github.com/apache/kafka/pull/10225#issuecomment-786955706 @abbccdda, @cmccabe. Ported from #10199 to discuss separately. We used to see this error message in `verifiable_producer.log` when `security_protocol='PLAINTEXT',

[GitHub] [kafka] rondagostino opened a new pull request #10225: MINOR: fix security_test for ZK case due to error change

2021-02-26 Thread GitBox
rondagostino opened a new pull request #10225: URL: https://github.com/apache/kafka/pull/10225 The ZooKeeper version of this system test is failing because the producer is no longer seeing `LEADER_NOT_AVAILABLE`. When the broker sees a METADATA request for the test topic after it restarts

[GitHub] [kafka] junrao commented on a change in pull request #10184: MINOR: enable topic deletion in the KIP-500 controller

2021-02-26 Thread GitBox
junrao commented on a change in pull request #10184: URL: https://github.com/apache/kafka/pull/10184#discussion_r583984728 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -349,6 +357,16 @@ public void

[GitHub] [kafka] rondagostino opened a new pull request #10224: MINOR: Disable transactional streams system tests for Raft quorums

2021-02-26 Thread GitBox
rondagostino opened a new pull request #10224: URL: https://github.com/apache/kafka/pull/10224 Transactions are not supported in the KIP-500 early access release. This patch disables a system test for Raft metadata quorums that uses transactions and that was still enabled after #10194.

[GitHub] [kafka] rhauch commented on a change in pull request #10203: MINOR: Prepare for Gradle 7.0

2021-02-26 Thread GitBox
rhauch commented on a change in pull request #10203: URL: https://github.com/apache/kafka/pull/10203#discussion_r583981010 ## File path: build.gradle ## @@ -2026,52 +2043,53 @@ project(':connect:runtime') { archivesBaseName = "connect-runtime" dependencies { - -

[jira] [Commented] (KAFKA-9714) Flaky Test SslTransportLayerTest#testTLSDefaults

2021-02-26 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17291965#comment-17291965 ] Matthias J. Sax commented on KAFKA-9714: Different test method:

[jira] [Commented] (KAFKA-10251) Flaky Test kafka.api.TransactionsBounceTest.testWithGroupMetadata

2021-02-26 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17291964#comment-17291964 ] Matthias J. Sax commented on KAFKA-10251: - Different test method:

[jira] [Commented] (KAFKA-8711) Kafka 2.3.0 Transient Unit Test Failures SocketServerTest. testControlPlaneRequest

2021-02-26 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17291963#comment-17291963 ] Matthias J. Sax commented on KAFKA-8711: Different but related test

[jira] [Commented] (KAFKA-10582) Mirror Maker 2 not replicating new topics until restart

2021-02-26 Thread Leonid Ilyevsky (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17291956#comment-17291956 ] Leonid Ilyevsky commented on KAFKA-10582: - I have the same problem, but in my case just

[GitHub] [kafka] hachikuji opened a new pull request #10223: MINOR: Do not expose topic name in `DeleteTopic` response if no describe permission

2021-02-26 Thread GitBox
hachikuji opened a new pull request #10223: URL: https://github.com/apache/kafka/pull/10223 We now accept topicIds in the `DescribeTopic` request. If the client principal does not have `Describe` permission, then we return `UNKNOWN_TOPIC_ID` regardless whether the topic exists or not.

[GitHub] [kafka] cmccabe commented on a change in pull request #10184: MINOR: enable topic deletion in the KIP-500 controller

2021-02-26 Thread GitBox
cmccabe commented on a change in pull request #10184: URL: https://github.com/apache/kafka/pull/10184#discussion_r583965997 ## File path: core/src/main/scala/kafka/server/ControllerApis.scala ## @@ -154,6 +161,147 @@ class ControllerApis(val requestChannel: RequestChannel,

[GitHub] [kafka] ijuma commented on pull request #8812: KAFKA-10101: Fix edge cases in Log.recoverLog and LogManager.loadLogs

2021-02-26 Thread GitBox
ijuma commented on pull request #8812: URL: https://github.com/apache/kafka/pull/8812#issuecomment-786935020 Tests passed, merged to trunk and 2.8. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] rhauch commented on a change in pull request #10016: KAFKA-10340: Proactively close producer when cancelling source tasks

2021-02-26 Thread GitBox
rhauch commented on a change in pull request #10016: URL: https://github.com/apache/kafka/pull/10016#discussion_r583964769 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java ## @@ -259,6 +267,16 @@ public void execute() {

[GitHub] [kafka] rhauch commented on a change in pull request #10016: KAFKA-10340: Proactively close producer when cancelling source tasks

2021-02-26 Thread GitBox
rhauch commented on a change in pull request #10016: URL: https://github.com/apache/kafka/pull/10016#discussion_r583964769 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java ## @@ -259,6 +267,16 @@ public void execute() {

[jira] [Created] (KAFKA-12380) Executor in Connect's Worker is not shut down when the worker is

2021-02-26 Thread Randall Hauch (Jira)
Randall Hauch created KAFKA-12380: - Summary: Executor in Connect's Worker is not shut down when the worker is Key: KAFKA-12380 URL: https://issues.apache.org/jira/browse/KAFKA-12380 Project: Kafka

[GitHub] [kafka] ijuma merged pull request #8812: KAFKA-10101: Fix edge cases in Log.recoverLog and LogManager.loadLogs

2021-02-26 Thread GitBox
ijuma merged pull request #8812: URL: https://github.com/apache/kafka/pull/8812 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] cmccabe commented on a change in pull request #10184: MINOR: enable topic deletion in the KIP-500 controller

2021-02-26 Thread GitBox
cmccabe commented on a change in pull request #10184: URL: https://github.com/apache/kafka/pull/10184#discussion_r583962844 ## File path: core/src/main/scala/kafka/server/ControllerApis.scala ## @@ -154,6 +161,147 @@ class ControllerApis(val requestChannel: RequestChannel,

[GitHub] [kafka] cmccabe commented on a change in pull request #10184: MINOR: enable topic deletion in the KIP-500 controller

2021-02-26 Thread GitBox
cmccabe commented on a change in pull request #10184: URL: https://github.com/apache/kafka/pull/10184#discussion_r583940888 ## File path: core/src/test/java/kafka/test/MockController.java ## @@ -0,0 +1,224 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] cmccabe commented on a change in pull request #10184: MINOR: enable topic deletion in the KIP-500 controller

2021-02-26 Thread GitBox
cmccabe commented on a change in pull request #10184: URL: https://github.com/apache/kafka/pull/10184#discussion_r583940677 ## File path: core/src/main/scala/kafka/server/ControllerApis.scala ## @@ -154,6 +161,147 @@ class ControllerApis(val requestChannel: RequestChannel,

[GitHub] [kafka] cmccabe merged pull request #10222: MINOR: disable test_produce_bench_transactions for Raft metadata quorum

2021-02-26 Thread GitBox
cmccabe merged pull request #10222: URL: https://github.com/apache/kafka/pull/10222 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] rhauch edited a comment on pull request #9950: KAFKA-12170: Fix for Connect Cast SMT to correctly transform a Byte array into a string

2021-02-26 Thread GitBox
rhauch edited a comment on pull request #9950: URL: https://github.com/apache/kafka/pull/9950#issuecomment-786911483 The documentation is auto-generated from the transforms code, via

[GitHub] [kafka] rhauch edited a comment on pull request #9950: KAFKA-12170: Fix for Connect Cast SMT to correctly transform a Byte array into a string

2021-02-26 Thread GitBox
rhauch edited a comment on pull request #9950: URL: https://github.com/apache/kafka/pull/9950#issuecomment-786911483 The documentation is auto-generated from the transforms code, via

[GitHub] [kafka] rhauch edited a comment on pull request #9950: KAFKA-12170: Fix for Connect Cast SMT to correctly transform a Byte array into a string

2021-02-26 Thread GitBox
rhauch edited a comment on pull request #9950: URL: https://github.com/apache/kafka/pull/9950#issuecomment-786911483 The documentation is auto-generated from the transforms code, via

[GitHub] [kafka] rhauch edited a comment on pull request #9950: KAFKA-12170: Fix for Connect Cast SMT to correctly transform a Byte array into a string

2021-02-26 Thread GitBox
rhauch edited a comment on pull request #9950: URL: https://github.com/apache/kafka/pull/9950#issuecomment-786911483 The documentation is auto-generated from the transforms code, via

[GitHub] [kafka] rhauch commented on pull request #9950: KAFKA-12170: Fix for Connect Cast SMT to correctly transform a Byte array into a string

2021-02-26 Thread GitBox
rhauch commented on pull request #9950: URL: https://github.com/apache/kafka/pull/9950#issuecomment-786911483 The documentation is auto-generated from the code, via

[GitHub] [kafka] hachikuji commented on a change in pull request #10184: MINOR: enable topic deletion in the KIP-500 controller

2021-02-26 Thread GitBox
hachikuji commented on a change in pull request #10184: URL: https://github.com/apache/kafka/pull/10184#discussion_r583886777 ## File path: core/src/main/scala/kafka/server/ControllerApis.scala ## @@ -154,6 +161,147 @@ class ControllerApis(val requestChannel: RequestChannel,

[GitHub] [kafka] rondagostino opened a new pull request #10222: MINOR: disable test_produce_bench_transactions for Raft metadata quorum

2021-02-26 Thread GitBox
rondagostino opened a new pull request #10222: URL: https://github.com/apache/kafka/pull/10222 Transactions are not supported in the KIP-500 early access release. This patch disables a system test for Raft metadata quorums that uses transactions and that was still enabled after

[GitHub] [kafka] dhruvilshah3 commented on pull request #10217: KAFKA-12254: Ensure MM2 creates topics with source topic configs

2021-02-26 Thread GitBox
dhruvilshah3 commented on pull request #10217: URL: https://github.com/apache/kafka/pull/10217#issuecomment-786895408 Thanks for the review @rajinisivaram. I ran `MirrorConnectorsIntegrationSSLTest` a few times locally and it passed. It passed in the latest jenkins run as well. Couple of

[GitHub] [kafka] ijuma commented on a change in pull request #8812: KAFKA-10101: Fix edge cases in Log.recoverLog and LogManager.loadLogs

2021-02-26 Thread GitBox
ijuma commented on a change in pull request #8812: URL: https://github.com/apache/kafka/pull/8812#discussion_r583907925 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -826,8 +832,16 @@ class Log(@volatile private var _dir: File, preallocate =

[GitHub] [kafka] cmccabe commented on a change in pull request #10184: MINOR: enable topic deletion in the KIP-500 controller

2021-02-26 Thread GitBox
cmccabe commented on a change in pull request #10184: URL: https://github.com/apache/kafka/pull/10184#discussion_r583903614 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -349,6 +357,16 @@ public void

[GitHub] [kafka] cmccabe commented on a change in pull request #10184: MINOR: enable topic deletion in the KIP-500 controller

2021-02-26 Thread GitBox
cmccabe commented on a change in pull request #10184: URL: https://github.com/apache/kafka/pull/10184#discussion_r583900849 ## File path: core/src/main/scala/kafka/server/ControllerApis.scala ## @@ -154,6 +161,147 @@ class ControllerApis(val requestChannel: RequestChannel,

[GitHub] [kafka] ableegoldman commented on pull request #10213: KAFKA-12375: fix concurrency issue in application shutdown

2021-02-26 Thread GitBox
ableegoldman commented on pull request #10213: URL: https://github.com/apache/kafka/pull/10213#issuecomment-786873825 Merged to trunk and cherrypicked to 2.8 cc @vvcephei This is an automated message from the Apache Git

[GitHub] [kafka] ableegoldman merged pull request #10213: KAFKA-12375: fix concurrency issue in application shutdown

2021-02-26 Thread GitBox
ableegoldman merged pull request #10213: URL: https://github.com/apache/kafka/pull/10213 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] ableegoldman commented on pull request #10213: KAFKA-12375: fix concurrency issue in application shutdown

2021-02-26 Thread GitBox
ableegoldman commented on pull request #10213: URL: https://github.com/apache/kafka/pull/10213#issuecomment-786871581 One unrelated test failure: `kafka.server.ListOffsetsRequestTest.testResponseIncludesLeaderEpoch` Going to merge this now

[jira] [Updated] (KAFKA-12235) ZkAdminManager.describeConfigs returns no config when 2+ configuration keys are specified

2021-02-26 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-12235: - Fix Version/s: 2.7.1 > ZkAdminManager.describeConfigs returns no config when 2+ configuration

[GitHub] [kafka] cmccabe commented on a change in pull request #9990: KAFKA-12235: Fix ZkAdminManager.describeConfigs on 2+ config keys

2021-02-26 Thread GitBox
cmccabe commented on a change in pull request #9990: URL: https://github.com/apache/kafka/pull/9990#discussion_r583245201 ## File path: core/src/main/scala/kafka/server/ConfigHelper.scala ## @@ -47,11 +47,11 @@ class ConfigHelper(metadataCache: MetadataCache, config:

[jira] [Commented] (KAFKA-9880) Error while range compacting during bulk loading of FIFO compacted RocksDB Store

2021-02-26 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17291899#comment-17291899 ] A. Sophie Blee-Goldman commented on KAFKA-9880: --- Since we turned off bulk loading in 2.6.0

[jira] [Resolved] (KAFKA-9880) Error while range compacting during bulk loading of FIFO compacted RocksDB Store

2021-02-26 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman resolved KAFKA-9880. --- Fix Version/s: 2.6.0 Resolution: Fixed > Error while range compacting

[GitHub] [kafka] hachikuji commented on a change in pull request #8812: KAFKA-10101: Fix edge cases in Log.recoverLog and LogManager.loadLogs

2021-02-26 Thread GitBox
hachikuji commented on a change in pull request #8812: URL: https://github.com/apache/kafka/pull/8812#discussion_r583835401 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -826,8 +832,16 @@ class Log(@volatile private var _dir: File, preallocate =

[GitHub] [kafka] hachikuji commented on a change in pull request #10206: KAFKA-12369; Implement `ListTransactions` API

2021-02-26 Thread GitBox
hachikuji commented on a change in pull request #10206: URL: https://github.com/apache/kafka/pull/10206#discussion_r583877084 ## File path: core/src/main/scala/kafka/coordinator/transaction/TransactionStateManager.scala ## @@ -223,6 +224,46 @@ class

[GitHub] [kafka] cmccabe merged pull request #9990: KAFKA-12235: Fix ZkAdminManager.describeConfigs on 2+ config keys

2021-02-26 Thread GitBox
cmccabe merged pull request #9990: URL: https://github.com/apache/kafka/pull/9990 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] cmccabe merged pull request #10212: MINOR: Add cluster-metadata-decoder to DumpLogSegments

2021-02-26 Thread GitBox
cmccabe merged pull request #10212: URL: https://github.com/apache/kafka/pull/10212 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] hachikuji merged pull request #9958: MINOR: Clean up group instance id handling in `GroupCoordinator`

2021-02-26 Thread GitBox
hachikuji merged pull request #9958: URL: https://github.com/apache/kafka/pull/9958 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] ableegoldman closed pull request #10214: MINOR: fix message and reduce log level of PartitionGroup enforced processing

2021-02-26 Thread GitBox
ableegoldman closed pull request #10214: URL: https://github.com/apache/kafka/pull/10214 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] ableegoldman commented on pull request #10214: MINOR: fix message and reduce log level of PartitionGroup enforced processing

2021-02-26 Thread GitBox
ableegoldman commented on pull request #10214: URL: https://github.com/apache/kafka/pull/10214#issuecomment-786832334 Closing since this issue should be addressed on the side in https://github.com/apache/kafka/pull/10137

[GitHub] [kafka] cmccabe commented on a change in pull request #10212: MINOR: Add cluster-metadata-decoder to DumpLogSegments

2021-02-26 Thread GitBox
cmccabe commented on a change in pull request #10212: URL: https://github.com/apache/kafka/pull/10212#discussion_r583849492 ## File path: core/src/main/scala/kafka/tools/DumpLogSegments.scala ## @@ -242,7 +246,8 @@ object DumpLogSegments {

[GitHub] [kafka] ableegoldman commented on a change in pull request #10137: KAFKA-12268: Implement task idling semantics via currentLag API

2021-02-26 Thread GitBox
ableegoldman commented on a change in pull request #10137: URL: https://github.com/apache/kafka/pull/10137#discussion_r583848994 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/PartitionGroup.java ## @@ -211,7 +192,7 @@ public boolean

[GitHub] [kafka] hachikuji commented on a change in pull request #8812: KAFKA-10101: Fix edge cases in Log.recoverLog and LogManager.loadLogs

2021-02-26 Thread GitBox
hachikuji commented on a change in pull request #8812: URL: https://github.com/apache/kafka/pull/8812#discussion_r583835401 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -826,8 +832,16 @@ class Log(@volatile private var _dir: File, preallocate =

[GitHub] [kafka] ijuma commented on a change in pull request #10203: MINOR: Prepare for Gradle 7.0

2021-02-26 Thread GitBox
ijuma commented on a change in pull request #10203: URL: https://github.com/apache/kafka/pull/10203#discussion_r583834500 ## File path: build.gradle ## @@ -2026,52 +2043,53 @@ project(':connect:runtime') { archivesBaseName = "connect-runtime" dependencies { - -

[GitHub] [kafka] junrao commented on a change in pull request #8812: KAFKA-10101: Fix edge cases in Log.recoverLog and LogManager.loadLogs

2021-02-26 Thread GitBox
junrao commented on a change in pull request #8812: URL: https://github.com/apache/kafka/pull/8812#discussion_r583834117 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -826,8 +832,16 @@ class Log(@volatile private var _dir: File, preallocate =

[GitHub] [kafka] dhruvilshah3 commented on a change in pull request #10217: KAFKA-12254: Ensure MM2 creates topics with source topic configs

2021-02-26 Thread GitBox
dhruvilshah3 commented on a change in pull request #10217: URL: https://github.com/apache/kafka/pull/10217#discussion_r583832959 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceConnector.java ## @@ -306,40 +307,84 @@ private void

[GitHub] [kafka] mimaison opened a new pull request #10221: KAFKA-12379: Allow configuring the location of the offset-syncs topic…

2021-02-26 Thread GitBox
mimaison opened a new pull request #10221: URL: https://github.com/apache/kafka/pull/10221 … with MirrorMaker2 This commit implements KIP-716. It introduces a new setting `offset-syncs.topic.location` that allows specifying where the offset-syncs topic is created. ###

[jira] [Updated] (KAFKA-12379) KIP-716: Allow configuring the location of the offsetsync topic with MirrorMaker2

2021-02-26 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-12379: --- Description: Ticket for KIP-716

[jira] [Assigned] (KAFKA-12379) KIP-716: Allow configuring the location of the offsetsync topic with MirrorMaker2

2021-02-26 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison reassigned KAFKA-12379: -- Assignee: Mickael Maison > KIP-716: Allow configuring the location of the offsetsync

[jira] [Updated] (KAFKA-12362) Determine if a Task is idling

2021-02-26 Thread Walker Carlson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Walker Carlson updated KAFKA-12362: --- Description: determine if a task is idling given the task Id. (was: determine if a task is

[jira] [Created] (KAFKA-12379) KIP-716: Allow configuring the location of the offsetsync topic with MirrorMaker2

2021-02-26 Thread Mickael Maison (Jira)
Mickael Maison created KAFKA-12379: -- Summary: KIP-716: Allow configuring the location of the offsetsync topic with MirrorMaker2 Key: KAFKA-12379 URL: https://issues.apache.org/jira/browse/KAFKA-12379

[jira] [Closed] (KAFKA-12362) Determine if a Task is idling

2021-02-26 Thread Walker Carlson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Walker Carlson closed KAFKA-12362. -- > Determine if a Task is idling > - > > Key:

[jira] [Resolved] (KAFKA-12362) Determine if a Task is idling

2021-02-26 Thread Walker Carlson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Walker Carlson resolved KAFKA-12362. Resolution: Abandoned > Determine if a Task is idling > - > >

[jira] [Commented] (KAFKA-12376) Use scheduleAtomicAppend for records that need to be atomic

2021-02-26 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17291843#comment-17291843 ] Jose Armando Garcia Sancio commented on KAFKA-12376: Yes [~rounak] . I am working on

[GitHub] [kafka] wcarlson5 commented on a change in pull request #10215: KAFKA-12375: don't reuse thread.id until a thread has fully shut down

2021-02-26 Thread GitBox
wcarlson5 commented on a change in pull request #10215: URL: https://github.com/apache/kafka/pull/10215#discussion_r583808502 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -463,9 +464,8 @@ private void replaceStreamThread(final Throwable

[jira] [Commented] (KAFKA-12319) Flaky test ConnectionQuotasTest.testListenerConnectionRateLimitWhenActualRateAboveLimit()

2021-02-26 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17291826#comment-17291826 ] Matthias J. Sax commented on KAFKA-12319: - Failed again

[jira] [Created] (KAFKA-12378) If a broker is down for more then `delete.retention.ms` deleted records in a compacted topic can come back.

2021-02-26 Thread Shane (Jira)
Shane created KAFKA-12378: - Summary: If a broker is down for more then `delete.retention.ms` deleted records in a compacted topic can come back. Key: KAFKA-12378 URL: https://issues.apache.org/jira/browse/KAFKA-12378

[GitHub] [kafka] cadonna commented on a change in pull request #10215: KAFKA-12375: don't reuse thread.id until a thread has fully shut down

2021-02-26 Thread GitBox
cadonna commented on a change in pull request #10215: URL: https://github.com/apache/kafka/pull/10215#discussion_r583801473 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -463,9 +464,8 @@ private void replaceStreamThread(final Throwable

[jira] [Commented] (KAFKA-12284) Flaky Test MirrorConnectorsIntegrationSSLTest#testOneWayReplicationWithAutoOffsetSync

2021-02-26 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17291820#comment-17291820 ] Matthias J. Sax commented on KAFKA-12284: - Failde again:  {quote}java.lang.RuntimeException:

[jira] [Commented] (KAFKA-8003) Flaky Test TransactionsTest #testFencingOnTransactionExpiration

2021-02-26 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17291818#comment-17291818 ] Matthias J. Sax commented on KAFKA-8003: Different test method

[GitHub] [kafka] rhauch commented on a change in pull request #10016: KAFKA-10340: Proactively close producer when cancelling source tasks

2021-02-26 Thread GitBox
rhauch commented on a change in pull request #10016: URL: https://github.com/apache/kafka/pull/10016#discussion_r583796206 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java ## @@ -259,6 +267,16 @@ public void execute() {

[jira] [Created] (KAFKA-12377) Flaky Test SaslAuthenticatorTest#testSslClientAuthRequiredForSaslSslListener

2021-02-26 Thread Matthias J. Sax (Jira)
Matthias J. Sax created KAFKA-12377: --- Summary: Flaky Test SaslAuthenticatorTest#testSslClientAuthRequiredForSaslSslListener Key: KAFKA-12377 URL: https://issues.apache.org/jira/browse/KAFKA-12377

[jira] [Commented] (KAFKA-12376) Use scheduleAtomicAppend for records that need to be atomic

2021-02-26 Thread Rounak Datta (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17291784#comment-17291784 ] Rounak Datta commented on KAFKA-12376: -- {quote}records that need to be atomic {quote}   Can you

[GitHub] [kafka] wcarlson5 commented on a change in pull request #10215: KAFKA-12375: don't reuse thread.id until a thread has fully shut down

2021-02-26 Thread GitBox
wcarlson5 commented on a change in pull request #10215: URL: https://github.com/apache/kafka/pull/10215#discussion_r583787814 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -1047,9 +1047,15 @@ private int getNumStreamThreads(final boolean

[jira] [Commented] (KAFKA-12375) ReplaceStreamThread creates a new consumer with the same name as the one it's replacing

2021-02-26 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17291777#comment-17291777 ] Bruno Cadonna commented on KAFKA-12375: --- I agree with [~ableegoldman] that ensuring a unique

[GitHub] [kafka] rhauch commented on a change in pull request #10203: MINOR: Prepare for Gradle 7.0

2021-02-26 Thread GitBox
rhauch commented on a change in pull request #10203: URL: https://github.com/apache/kafka/pull/10203#discussion_r583780438 ## File path: build.gradle ## @@ -2026,52 +2043,53 @@ project(':connect:runtime') { archivesBaseName = "connect-runtime" dependencies { - -

  1   2   >