[GitHub] [kafka] showuon commented on a diff in pull request #13135: KAFKA-14633: Reduce data copy & buffer allocation during decompression

2023-05-07 Thread via GitHub
showuon commented on code in PR #13135: URL: https://github.com/apache/kafka/pull/13135#discussion_r1185891570 ## clients/src/main/java/org/apache/kafka/common/utils/ChunkedBytesStream.java: ## @@ -0,0 +1,357 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] ableegoldman opened a new pull request, #13682: MINOR: improve error messages for join window store settings

2023-05-07 Thread via GitHub
ableegoldman opened a new pull request, #13682: URL: https://github.com/apache/kafka/pull/13682 Trying to configure the underlying state stores in a join is pretty awkward, and getting all the parameters right can be particularly frustrating. At a minimum, we should break up the

[jira] [Commented] (KAFKA-14914) binarySearch in AbstactIndex may execute with infinite loop

2023-05-07 Thread li xiangyuan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17720372#comment-17720372 ] li xiangyuan commented on KAFKA-14914: -- After create this jira ticket we had encountered this

[GitHub] [kafka] showuon merged pull request #13515: KAFKA-14752: Kafka examples improvements - producer changes

2023-05-07 Thread via GitHub
showuon merged PR #13515: URL: https://github.com/apache/kafka/pull/13515 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] showuon commented on pull request #13515: KAFKA-14752: Kafka examples improvements - producer changes

2023-05-07 Thread via GitHub
showuon commented on PR #13515: URL: https://github.com/apache/kafka/pull/13515#issuecomment-1537643776 Failed tests are unrelated: ``` Build / JDK 8 and Scala 2.12 /

[GitHub] [kafka] showuon commented on pull request #13669: MINOR: Fix producer Callback comment

2023-05-07 Thread via GitHub
showuon commented on PR #13669: URL: https://github.com/apache/kafka/pull/13669#issuecomment-1537641986 CI build failed with infra issue. Rebuilding https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13669/3/ -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka] mehbey opened a new pull request, #13681: KAFKA-14133: Migrate ActiveTaskCreator mock in TaskManagerTest to Mockito

2023-05-07 Thread via GitHub
mehbey opened a new pull request, #13681: URL: https://github.com/apache/kafka/pull/13681 This pull requests migrates the ActiveTaskCreator mock in TaskManagerTest from EasyMock to Mockito The change is restricted to a single mock to minimize the scope and make it easier for review.

[GitHub] [kafka] satishd commented on a diff in pull request #13535: KAFKA-9579 Fetch implementation for records in the remote storage through a specific purgatory.

2023-05-07 Thread via GitHub
satishd commented on code in PR #13535: URL: https://github.com/apache/kafka/pull/13535#discussion_r1186813113 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -600,25 +622,208 @@ public String toString() { } } -long

[jira] [Created] (KAFKA-14972) Make KafkaConsumer usable in async runtimes

2023-05-07 Thread Erik van Oosten (Jira)
Erik van Oosten created KAFKA-14972: --- Summary: Make KafkaConsumer usable in async runtimes Key: KAFKA-14972 URL: https://issues.apache.org/jira/browse/KAFKA-14972 Project: Kafka Issue

[GitHub] [kafka] dajac commented on a diff in pull request #13638: KAFKA-14462; [11/N] Add CurrentAssignmentBuilder

2023-05-07 Thread via GitHub
dajac commented on code in PR #13638: URL: https://github.com/apache/kafka/pull/13638#discussion_r1186823970 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/CurrentAssignmentBuilder.java: ## @@ -0,0 +1,445 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] satishd commented on a diff in pull request #13535: KAFKA-9579 Fetch implementation for records in the remote storage through a specific purgatory.

2023-05-07 Thread via GitHub
satishd commented on code in PR #13535: URL: https://github.com/apache/kafka/pull/13535#discussion_r1186813113 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -600,25 +622,208 @@ public String toString() { } } -long

[GitHub] [kafka] satishd commented on a diff in pull request #13535: KAFKA-9579 Fetch implementation for records in the remote storage through a specific purgatory.

2023-05-07 Thread via GitHub
satishd commented on code in PR #13535: URL: https://github.com/apache/kafka/pull/13535#discussion_r1186812350 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -600,6 +622,176 @@ public String toString() { } } +public FetchDataInfo

[jira] [Updated] (KAFKA-14930) Public documentation for new Kafka Connect offset management REST APIs

2023-05-07 Thread Yash Mayya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yash Mayya updated KAFKA-14930: --- Description: Add public documentation for the new Kafka Connect offset management REST APIs from

[GitHub] [kafka] vamossagar12 commented on pull request #13594: KAFKA-14913: Using ThreadUtils.shutdownExecutorServiceQuietly to close executors in Connect Runtime

2023-05-07 Thread via GitHub
vamossagar12 commented on PR #13594: URL: https://github.com/apache/kafka/pull/13594#issuecomment-1537335506 The 2 connect related tests, `testSyncTopicConfigs() – org.apache.kafka.connect.mirror.integration.IdentityReplicationIntegrationTest` and

[jira] [Updated] (KAFKA-14971) Flaky Test org.apache.kafka.connect.mirror.integration.IdentityReplicationIntegrationTest#testSyncTopicConfigs

2023-05-07 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sagar Rao updated KAFKA-14971: -- Description: The test testSyncTopicConfigs in

[jira] [Created] (KAFKA-14971) Flaky Test org.apache.kafka.connect.mirror.integration.IdentityReplicationIntegrationTest#testSyncTopicConfigs

2023-05-07 Thread Sagar Rao (Jira)
Sagar Rao created KAFKA-14971: - Summary: Flaky Test org.apache.kafka.connect.mirror.integration.IdentityReplicationIntegrationTest#testSyncTopicConfigs Key: KAFKA-14971 URL: