[GitHub] [kafka] monish-byte commented on pull request #14156: KAFKA-15202: Fix MM2 offset translation when syncs are variably spaced

2023-08-05 Thread via GitHub
monish-byte commented on PR #14156: URL: https://github.com/apache/kafka/pull/14156#issuecomment-186364 hey @gharris1727 I have joined the mailing list. I am eager to know what should I do next. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] gharris1727 commented on pull request #14156: KAFKA-15202: Fix MM2 offset translation when syncs are variably spaced

2023-08-05 Thread via GitHub
gharris1727 commented on PR #14156: URL: https://github.com/apache/kafka/pull/14156#issuecomment-1666576481 Hi @monish-byte ! Thanks for considering contributing to Apache Kafka. You can find the contributing guide here: https://kafka.apache.org/contributing.html It is a good idea

[GitHub] [kafka] erikvanoosten commented on pull request #13914: KAFKA-14972: Support async runtimes in consumer

2023-08-05 Thread via GitHub
erikvanoosten commented on PR #13914: URL: https://github.com/apache/kafka/pull/13914#issuecomment-1666574852 Withdrawn because the committers do not seem to be convinced that you cannot control on what thread code runs with an async runtime. -- This is an automated message from the

[GitHub] [kafka] erikvanoosten closed pull request #13914: KAFKA-14972: Support async runtimes in consumer

2023-08-05 Thread via GitHub
erikvanoosten closed pull request #13914: KAFKA-14972: Support async runtimes in consumer URL: https://github.com/apache/kafka/pull/13914 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] erikvanoosten commented on pull request #14071: Make acquire and release protected

2023-08-05 Thread via GitHub
erikvanoosten commented on PR #14071: URL: https://github.com/apache/kafka/pull/14071#issuecomment-1666574726 Withdrawn because the committers do not seem to be convinced that you cannot control on what thread code runs with an async runtime. -- This is an automated message from the

[GitHub] [kafka] erikvanoosten closed pull request #14071: Make acquire and release protected

2023-08-05 Thread via GitHub
erikvanoosten closed pull request #14071: Make acquire and release protected URL: https://github.com/apache/kafka/pull/14071 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Resolved] (KAFKA-14972) Make KafkaConsumer usable in async runtimes

2023-08-05 Thread Erik van Oosten (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erik van Oosten resolved KAFKA-14972. - Resolution: Won't Fix > Make KafkaConsumer usable in async runtimes >

[jira] [Commented] (KAFKA-14972) Make KafkaConsumer usable in async runtimes

2023-08-05 Thread Erik van Oosten (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17751330#comment-17751330 ] Erik van Oosten commented on KAFKA-14972: - I am closing this task as won't fix as the committers

[jira] [Assigned] (KAFKA-14972) Make KafkaConsumer usable in async runtimes

2023-08-05 Thread Erik van Oosten (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erik van Oosten reassigned KAFKA-14972: --- Assignee: (was: Erik van Oosten) > Make KafkaConsumer usable in async runtimes

[jira] [Commented] (KAFKA-15302) Stale value returned when using store.all() in punctuation function.

2023-08-05 Thread Jinyong Choi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17751323#comment-17751323 ] Jinyong Choi commented on KAFKA-15302: -- Hi Matthias J. Sax, Reading your comment helped me to be

[GitHub] [kafka] omkreddy commented on a diff in pull request #14130: KAFKA-15273: Log common name of expired client certificates

2023-08-05 Thread via GitHub
omkreddy commented on code in PR #14130: URL: https://github.com/apache/kafka/pull/14130#discussion_r1285082984 ## clients/src/main/java/org/apache/kafka/common/security/ssl/DefaultSslEngineFactory.java: ## @@ -255,7 +271,7 @@ private SSLContext createSSLContext(SecurityStore

[GitHub] [kafka] ethaden commented on a diff in pull request #14130: KAFKA-15273: Log common name of expired client certificates

2023-08-05 Thread via GitHub
ethaden commented on code in PR #14130: URL: https://github.com/apache/kafka/pull/14130#discussion_r1285078073 ## clients/src/main/java/org/apache/kafka/common/security/ssl/DefaultSslEngineFactory.java: ## @@ -578,4 +594,335 @@ private List pemEntries(String pem) {

[jira] [Resolved] (KAFKA-10334) Transactions not working properly

2023-08-05 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-10334. --- Resolution: Duplicate > Transactions not working properly >

[jira] [Comment Edited] (KAFKA-15310) Add timezone configuration option in TimestampConverter from connectors

2023-08-05 Thread Romulo Souza (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17751309#comment-17751309 ] Romulo Souza edited comment on KAFKA-15310 at 8/5/23 1:56 PM: -- I intend to

[GitHub] [kafka] monish-byte commented on pull request #14156: KAFKA-15202: Fix MM2 offset translation when syncs are variably spaced

2023-08-05 Thread via GitHub
monish-byte commented on PR #14156: URL: https://github.com/apache/kafka/pull/14156#issuecomment-1666502303 hey @gharris1727 , can you please guide me how can I start contributing to this project as I am new to open source contribution but I have a strong knowledge of Java. Thank you.

[jira] [Commented] (KAFKA-15310) Add timezone configuration option in TimestampConverter from connectors

2023-08-05 Thread Romulo Souza (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17751309#comment-17751309 ] Romulo Souza commented on KAFKA-15310: -- I intend to work on this issue. > Add timezone

[jira] [Updated] (KAFKA-15310) Add timezone configuration option in TimestampConverter from connectors

2023-08-05 Thread Romulo Souza (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Romulo Souza updated KAFKA-15310: - Description: In some cenarios where the use of TimestampConverter happens, it's interesting to

[jira] [Created] (KAFKA-15310) Add timezone configuration option in TimestampConverter from connectors

2023-08-05 Thread Romulo Souza (Jira)
Romulo Souza created KAFKA-15310: Summary: Add timezone configuration option in TimestampConverter from connectors Key: KAFKA-15310 URL: https://issues.apache.org/jira/browse/KAFKA-15310 Project:

[GitHub] [kafka] ruslankrivoshein commented on a diff in pull request #13562: KAFKA-14581: Moving GetOffsetShell to tools

2023-08-05 Thread via GitHub
ruslankrivoshein commented on code in PR #13562: URL: https://github.com/apache/kafka/pull/13562#discussion_r1285035259 ## tools/src/main/java/org/apache/kafka/tools/ToolsUtils.java: ## @@ -99,4 +101,26 @@ public static void prettyPrintTable( printRow(columnLengths,

[jira] [Commented] (KAFKA-15050) Prompts in the quickstarts

2023-08-05 Thread Joobi S B (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17751303#comment-17751303 ] Joobi S B commented on KAFKA-15050: --- Hi [~tombentley]  could you please look at this PR, I've updated

[jira] [Commented] (KAFKA-15203) Remove dependency on Reflections

2023-08-05 Thread Joobi S B (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17751302#comment-17751302 ] Joobi S B commented on KAFKA-15203: --- Hi [~divijvaidya] , I would like to work on this, could you

[GitHub] [kafka] kamalcph commented on a diff in pull request #14151: KAFKA-15083: add config with "remote.log.metadata" prefix

2023-08-05 Thread via GitHub
kamalcph commented on code in PR #14151: URL: https://github.com/apache/kafka/pull/14151#discussion_r1285019147 ## storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java: ## @@ -134,6 +134,8 @@ public final class RemoteLogManagerConfig {

[GitHub] [kafka] joobisb commented on pull request #13931: KAFKA-8977: Remove MockStreamsMetrics since it is not a mock

2023-08-05 Thread via GitHub
joobisb commented on PR #13931: URL: https://github.com/apache/kafka/pull/13931#issuecomment-1666466685 Hi @cadonna , As per the comment, I've setup mocks and verified the calls on it, also addressed other comments as well, please have a look. -- This is an automated message from

[GitHub] [kafka] kamalcph commented on a diff in pull request #13984: KAFKA-15107: Support custom metadata for remote log segment

2023-08-05 Thread via GitHub
kamalcph commented on code in PR #13984: URL: https://github.com/apache/kafka/pull/13984#discussion_r1285011540 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -621,10 +626,30 @@ private void copyLogSegment(UnifiedLog log, LogSegment segment, long

[GitHub] [kafka] kamalcph commented on a diff in pull request #13984: KAFKA-15107: Support custom metadata for remote log segment

2023-08-05 Thread via GitHub
kamalcph commented on code in PR #13984: URL: https://github.com/apache/kafka/pull/13984#discussion_r1285011540 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -621,10 +626,30 @@ private void copyLogSegment(UnifiedLog log, LogSegment segment, long

[GitHub] [kafka] fvaleri commented on a diff in pull request #13562: KAFKA-14581: Moving GetOffsetShell to tools

2023-08-05 Thread via GitHub
fvaleri commented on code in PR #13562: URL: https://github.com/apache/kafka/pull/13562#discussion_r1285005842 ## tools/src/main/java/org/apache/kafka/tools/ToolsUtils.java: ## @@ -99,4 +101,26 @@ public static void prettyPrintTable( printRow(columnLengths, headers,

[GitHub] [kafka] fvaleri commented on a diff in pull request #13562: KAFKA-14581: Moving GetOffsetShell to tools

2023-08-05 Thread via GitHub
fvaleri commented on code in PR #13562: URL: https://github.com/apache/kafka/pull/13562#discussion_r1285005842 ## tools/src/main/java/org/apache/kafka/tools/ToolsUtils.java: ## @@ -99,4 +101,26 @@ public static void prettyPrintTable( printRow(columnLengths, headers,

[GitHub] [kafka] fvaleri commented on pull request #14092: KAFKA-15239: Fix system tests using producer performance service

2023-08-05 Thread via GitHub
fvaleri commented on PR #14092: URL: https://github.com/apache/kafka/pull/14092#issuecomment-1666442787 > That does appear to work, because [server-common is not being excluded from

[GitHub] [kafka] showuon commented on pull request #14116: KAFKA-15167: Tiered Storage Test Harness Framework

2023-08-05 Thread via GitHub
showuon commented on PR #14116: URL: https://github.com/apache/kafka/pull/14116#issuecomment-1666411942 Please let me know when ready for review. Thanks for the work! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] kamalcph commented on pull request #14151: KAFKA-15083: add config with "remote.log.metadata" prefix

2023-08-05 Thread via GitHub
kamalcph commented on PR #14151: URL: https://github.com/apache/kafka/pull/14151#issuecomment-1666405256 Not clear on this patch, will go another round of review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the