[valgrind] [Bug 359871] Incorrect mask handling in ppoll

https://bugs.kde.org/show_bug.cgi?id=359871 Ivo Raisr changed: What|Removed |Added Resolution|--- |FIXED

[valgrind] [Bug 359871] Incorrect mask handling in ppoll

https://bugs.kde.org/show_bug.cgi?id=359871 --- Comment #20 from Steven Smith --- Looks good to me, thank you. -- You are receiving this mail because: You are watching all bug changes.

[valgrind] [Bug 359871] Incorrect mask handling in ppoll

https://bugs.kde.org/show_bug.cgi?id=359871 Ivo Raisr changed: What|Removed |Added Attachment #97643|0 |1 is obsolete|

[valgrind] [Bug 359871] Incorrect mask handling in ppoll

https://bugs.kde.org/show_bug.cgi?id=359871 --- Comment #18 from Ivo Raisr --- Thank you for a quick turnaround. I think this should work. As regards the scalar test, if you are not able to get it working with high confidence then we should probably leave it alone. I will

[valgrind] [Bug 359871] Incorrect mask handling in ppoll

https://bugs.kde.org/show_bug.cgi?id=359871 Steven Smith changed: What|Removed |Added Attachment #97682|0 |1 is obsolete|

[valgrind] [Bug 359871] Incorrect mask handling in ppoll

https://bugs.kde.org/show_bug.cgi?id=359871 --- Comment #16 from Ivo Raisr --- Please could you also move the test for failed pselect into memcheck/tests/x86-linux/scalar.c where it truly belongs. See its header. Thanks a lot! -- You are receiving this mail because: You are

[valgrind] [Bug 359871] Incorrect mask handling in ppoll

https://bugs.kde.org/show_bug.cgi?id=359871 --- Comment #15 from Ivo Raisr --- Thank you for quick fix and analysis. Yes, indeed, changing args for failed syscall wrapper is not allowed. I wonder why you need to explicitly set failure status if kernel is going to do anyway.

[valgrind] [Bug 359871] Incorrect mask handling in ppoll

https://bugs.kde.org/show_bug.cgi?id=359871 Steven Smith changed: What|Removed |Added Attachment #97670|0 |1 is obsolete|

[valgrind] [Bug 359871] Incorrect mask handling in ppoll

https://bugs.kde.org/show_bug.cgi?id=359871 --- Comment #13 from Ivo Raisr --- Thank you for the fixes. Everything seems to be reasonable, except for the error paths. If an error path is taken (setting status failure), allocated memory is not assigned to ARG6/ARG4. This means

[valgrind] [Bug 359871] Incorrect mask handling in ppoll

https://bugs.kde.org/show_bug.cgi?id=359871 Steven Smith changed: What|Removed |Added Attachment #97645|0 |1 is obsolete|

[valgrind] [Bug 359871] Incorrect mask handling in ppoll

https://bugs.kde.org/show_bug.cgi?id=359871 --- Comment #11 from Ivo Raisr --- Thank you for the patch covering Linux. I have only three minor comments: - Why assert ARG7 == 0 in pselect6 wrapper? On some architectures arg7 would be on stack, containing some random values. On

[valgrind] [Bug 359871] Incorrect mask handling in ppoll

https://bugs.kde.org/show_bug.cgi?id=359871 --- Comment #10 from Steven Smith --- Created attachment 97645 --> https://bugs.kde.org/attachment.cgi?id=97645=edit Port the ppoll patch to Linux, and extend to cover pselect6 Sure, here's a patch which does something similar

[valgrind] [Bug 359871] Incorrect mask handling in ppoll

https://bugs.kde.org/show_bug.cgi?id=359871 --- Comment #9 from Ivo Raisr --- Steven, would you be able to prepare a patch for Linux using similar technique? I cannot currently devote to developing it for a while. Beware that Linux has ppoll and pselect6 syscalls. And pselect6

[valgrind] [Bug 359871] Incorrect mask handling in ppoll

https://bugs.kde.org/show_bug.cgi?id=359871 Ivo Raisr changed: What|Removed |Added Attachment #97632|0 |1 is obsolete|

[valgrind] [Bug 359871] Incorrect mask handling in ppoll

https://bugs.kde.org/show_bug.cgi?id=359871 --- Comment #7 from Ivo Raisr --- The attached patch has two problems: - it modifies a client memory which may be read-only (see for example bugs for modifying env) - it modifies a client memory and does not restore the changes after

[valgrind] [Bug 359871] Incorrect mask handling in ppoll

https://bugs.kde.org/show_bug.cgi?id=359871 --- Comment #6 from Ivo Raisr --- Steven, thank you for the test case provided and a suggested fix. Indeed, simple things are very often also effective. I will prepare patch for Linux as well and have that reviewed. -- You are

[valgrind] [Bug 359871] Incorrect mask handling in ppoll

https://bugs.kde.org/show_bug.cgi?id=359871 Ivo Raisr changed: What|Removed |Added Attachment #97584|0 |1 is obsolete|

[valgrind] [Bug 359871] Incorrect mask handling in ppoll

https://bugs.kde.org/show_bug.cgi?id=359871 Ivo Raisr changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED

[valgrind] [Bug 359871] Incorrect mask handling in ppoll

https://bugs.kde.org/show_bug.cgi?id=359871 Steven Smith changed: What|Removed |Added Attachment #97583|0 |1 is obsolete|

[valgrind] [Bug 359871] Incorrect mask handling in ppoll

https://bugs.kde.org/show_bug.cgi?id=359871 Ivo Raisr changed: What|Removed |Added CC||iv...@ivosh.net --- Comment #2

[valgrind] [Bug 359871] Incorrect mask handling in ppoll

https://bugs.kde.org/show_bug.cgi?id=359871 --- Comment #1 from Steven Smith --- Created attachment 97584 --> https://bugs.kde.org/attachment.cgi?id=97584=edit Kind of a fix, if you squint -- You are receiving this mail because: You are watching all bug changes.