https://bugs.kde.org/show_bug.cgi?id=385408
Ivo Raisr changed:
What|Removed |Added
CC||iv...@ivosh.net
https://bugs.kde.org/show_bug.cgi?id=385408
--- Comment #37 from Vadim Barkov ---
Thank you for apply. Could you mark this as resolved and close?
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=385408
--- Comment #36 from Julian Seward ---
Pushed as f1a49eeb427caf42e7af2da2b91198e55c6f33b2.
Thanks for working on this.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=385408
Vadim Barkov changed:
What|Removed |Added
Attachment #109653|0 |1
is obsolete|
https://bugs.kde.org/show_bug.cgi?id=385408
--- Comment #34 from Vadim Barkov ---
Please try use --ignore-whitespaces option while paching (I forgot to mention
it). It works for me (on latest commit from Jan, 3,
0f18cfc986f800b107c7eee063b8b7c04617e0b8).
Anyway I'll try to find
https://bugs.kde.org/show_bug.cgi?id=385408
--- Comment #33 from Julian Seward ---
(In reply to Vadim Barkov from comment #32)
> Created attachment 109653 [details]
> Initial vector support (chapter 21) (hope final)
Hi Vadim. Andreas and I tried to apply the patch to the
https://bugs.kde.org/show_bug.cgi?id=385408
Vadim Barkov changed:
What|Removed |Added
Attachment #109635|0 |1
is obsolete|
https://bugs.kde.org/show_bug.cgi?id=385408
--- Comment #31 from Vadim Barkov ---
Are here other task for me to do?
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=385408
Vadim Barkov changed:
What|Removed |Added
Attachment #108826|0 |1
is obsolete|
https://bugs.kde.org/show_bug.cgi?id=385408
--- Comment #29 from Julian Seward ---
(In reply to Julian Seward from comment #28)
> Looks good to me. My only comment is below.
Duh! Here is is:
guest_s390_helpers.c, __inline__ directives
eg
static __inline__ void
Please
https://bugs.kde.org/show_bug.cgi?id=385408
--- Comment #28 from Julian Seward ---
(In reply to Vadim Barkov from comment #20)
> Created attachment 108826 [details]
> Initial vector support (chapter 21) (after review)
Looks good to me. My only comment is below.
OK to land
https://bugs.kde.org/show_bug.cgi?id=385408
--- Comment #27 from Vadim Barkov ---
Julian, did you check this out? I just want to remind you if you forget about
this issue for some reason.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=385408
--- Comment #26 from Andreas Arnez ---
(In reply to Vadim Barkov from comment #23)
> Is the current patch okay? Could you merge it or tell me what's wrong with
> it please?
For the record, I didn't find any further problems
https://bugs.kde.org/show_bug.cgi?id=385408
--- Comment #24 from Julian Seward ---
Sorry for the delay. I will review it in Monday.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=385408
--- Comment #25 from Julian Seward ---
*on* Monday, that is.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=385408
--- Comment #23 from Vadim Barkov ---
(In reply to Andreas Arnez from comment #12)
> (In reply to Vadim Barkov from comment #10)
> > Created attachment 108579 [details]
> > Initial vector support (chapter 21) (remastered)
> >
> >
https://bugs.kde.org/show_bug.cgi?id=385408
--- Comment #22 from Vadim Barkov ---
(In reply to Julian Seward from comment #19)
If the new Iop_Perm8x16x2 handling in memcheck is incorrect I'll remove
Iop_Perm8x16x2 operation and will handle VPERM insn via dirtyhelper. I already
https://bugs.kde.org/show_bug.cgi?id=385408
--- Comment #21 from Vadim Barkov ---
(In reply to Julian Seward from comment #19)
> (In reply to Vadim Barkov from comment #18)
> > Created attachment 108754 [details]
> > Initial vector support (chapter 21) (fixed doc)
>
> This is
https://bugs.kde.org/show_bug.cgi?id=385408
Vadim Barkov changed:
What|Removed |Added
Attachment #108754|0 |1
is obsolete|
https://bugs.kde.org/show_bug.cgi?id=385408
--- Comment #19 from Julian Seward ---
(In reply to Vadim Barkov from comment #18)
> Created attachment 108754 [details]
> Initial vector support (chapter 21) (fixed doc)
This is pretty good on the whole, but there are a couple of
https://bugs.kde.org/show_bug.cgi?id=385408
Vadim Barkov changed:
What|Removed |Added
Attachment #108682|0 |1
is obsolete|
https://bugs.kde.org/show_bug.cgi?id=385408
--- Comment #17 from Julian Seward ---
(In reply to Vadim Barkov from comment #16)
I started to look at it. It looks a lot better. I will look at it in
more detail in the next day or so.
--
You are receiving this mail because:
You
https://bugs.kde.org/show_bug.cgi?id=385408
--- Comment #16 from Vadim Barkov ---
(In reply to Julian Seward from comment #8)
> (In reply to Vadim Barkov from comment #6)
> > Created attachment 108482 [details]
> > Initial vector support for z13 (chapter 21)
>
> This patch
https://bugs.kde.org/show_bug.cgi?id=385408
--- Comment #15 from Vadim Barkov ---
I've fixed all problems you pointed to. Waiting for your verdict
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=385408
Vadim Barkov changed:
What|Removed |Added
Attachment #108579|0 |1
is obsolete|
https://bugs.kde.org/show_bug.cgi?id=385408
--- Comment #13 from Vadim Barkov ---
(In reply to Andreas Arnez from comment #12)
> (In reply to Vadim Barkov from comment #10)
> * In /none/tests/s390x/vector.c, you use z13 instructions in __asm__
> directives. This is probably OK
https://bugs.kde.org/show_bug.cgi?id=385408
--- Comment #12 from Andreas Arnez ---
(In reply to Vadim Barkov from comment #10)
> Created attachment 108579 [details]
> Initial vector support (chapter 21) (remastered)
>
> Changes:
> - Removed ALL trailing whitespaces
https://bugs.kde.org/show_bug.cgi?id=385408
--- Comment #11 from Vadim Barkov ---
(In reply to Julian Seward from comment #8)
> (In reply to Vadim Barkov from comment #6)
> * Divide it up into much smaller pieces, each of which can be reviewed
> independently.
I divided code
https://bugs.kde.org/show_bug.cgi?id=385408
Vadim Barkov changed:
What|Removed |Added
Attachment #108482|0 |1
is obsolete|
https://bugs.kde.org/show_bug.cgi?id=385408
--- Comment #9 from Andreas Arnez ---
(In reply to Julian Seward from comment #8)
> This patch will need some further work before it is reviewable.
> Right now it is so huge and difficult to follow that I have no
> confidence
https://bugs.kde.org/show_bug.cgi?id=385408
--- Comment #8 from Julian Seward ---
(In reply to Vadim Barkov from comment #6)
> Created attachment 108482 [details]
> Initial vector support for z13 (chapter 21)
This patch will need some further work before it is reviewable.
Right
https://bugs.kde.org/show_bug.cgi?id=385408
--- Comment #7 from Vadim Barkov ---
(In reply to Andreas Arnez from comment #5)
> (In reply to Vadim Barkov from comment #3)
> > The adding of -march=z13 to CFLAGS isn't good aproach however it's the only
> > way to compile condition
https://bugs.kde.org/show_bug.cgi?id=385408
Vadim Barkov changed:
What|Removed |Added
Attachment #108457|0 |1
is obsolete|
https://bugs.kde.org/show_bug.cgi?id=385408
--- Comment #5 from Andreas Arnez ---
(In reply to Vadim Barkov from comment #3)
> The adding of -march=z13 to CFLAGS isn't good aproach however it's the only
> way to compile condition code helpers in
https://bugs.kde.org/show_bug.cgi?id=385408
Vadim Barkov changed:
What|Removed |Added
Attachment #108343|0 |1
is obsolete|
https://bugs.kde.org/show_bug.cgi?id=385408
--- Comment #3 from Vadim Barkov ---
The adding of -march=z13 to CFLAGS isn't good aproach however it's the only way
to compile condition code helpers in VEX/priv/guest_s390x_helpers.c (I've tried
".insn vrr, ..." aproach but it
https://bugs.kde.org/show_bug.cgi?id=385408
Andreas Arnez changed:
What|Removed |Added
Blocks|366413 |
Referenced Bugs:
https://bugs.kde.org/show_bug.cgi?id=385408
--- Comment #2 from Vadim Barkov ---
Alternatively to patch you can clone my mirror:
$ git clone https://github.com/barkovv/valgrind
$ git checkout vector_basic_z13
--
You are receiving this mail because:
You are watching all bug
https://bugs.kde.org/show_bug.cgi?id=385408
neverscai...@gmail.com changed:
What|Removed |Added
CC||neverscai...@gmail.com
--- Comment #1
https://bugs.kde.org/show_bug.cgi?id=385408
Andreas Arnez changed:
What|Removed |Added
Blocks||366413
Referenced
40 matches
Mail list logo