Re: Fwd: KF5 CMake usage question

On Samstag, 13. Mai 2017 23:48:33 CEST Shaheed Haque wrote: > Hi, > > On 13 May 2017 at 22:04, Sven Brauch wrote: > > Hi, > > > > On 05/13/2017 06:06 PM, Shaheed Haque wrote: > >> The printed output shows that the variable KF5KIO_INCLUDE_DIRS is > >> not > >> set. In poking

Re: The curious case of stuck systemd poweroff

On Donnerstag, 14. Juli 2016 16:19:15 CEST Harald Sitter wrote: > On Thu, Jul 14, 2016 at 3:43 PM, Andreas Hartmetz <ahartm...@gmail.com> wrote: > > Hello, > > > > Am Donnerstag, 14. Juli 2016, 11:11:26 CEST schrieb Harald Sitter: > >> Hola! > >>

Re: The curious case of stuck systemd poweroff

Hello, Am Donnerstag, 14. Juli 2016, 11:11:26 CEST schrieb Harald Sitter: > Hola! > > ever since systemd and or sddm started not killing all our session > processes we have had problems of poweroff/reboot getting hung up > waiting for processes to quit. > Recently systemd then started sending

Re: Review Request 126660: Avoid finding the same package multiple times from different paths.

uot; and tray config dialog, no duplicates anymore. Also no duplicates anymore in KWin effects KCM. Thanks, Andreas Hartmetz

Re: Review Request 126660: Avoid finding the same package multiple times from different paths.

marked as submitted. Review request for KDE Frameworks, kdelibs, Plasma, and Marco Martin. Changes --- Submitted with commit 85cc90b65ed8a9aa110018b01813fe1fd6772d48 by Andreas Hartmetz to branch master. Repository: kpackage Description --- That was a problem in a scenario

Review Request 126660: Avoid finding the same package multiple times from different paths.

iff: https://git.reviewboard.kde.org/r/126660/diff/ Testing --- Checked for duplicate entries in "add applets" and tray config dialog, no duplicates anymore. Also no duplicates anymore in KWin effects KCM. Thanks, Andreas Hartmetz

Re: Review Request 126660: Avoid finding the same package multiple times from different paths.

g by > > the id (the plugin name). > > Andreas Hartmetz wrote: > Depends on the scope in which an ID is guaranteed to be unique. If it's > guaranteed to be globally unique and independent of category, sure, I'm all > for not making it more complicated than necessary.

Re: Review Request 126660: Avoid finding the same package multiple times from different paths.

s. O(n^2) - Andreas --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126660/#review90755 --- On Jan. 7, 2016, 3:21 p.m., A

Re: Review Request 126660: Avoid finding the same package multiple times from different paths.

sure, I'm all for not making it more complicated than necessary. - Andreas --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126660/#review90755 ------

Re: Causes of session management problems in Plasma 5

On Donnerstag, 26. November 2015 08:55:19 CET Thomas Lübking wrote: > On Donnerstag, 26. November 2015 05:19:34 CEST, Nicolás Alvarez wrote: > > What do you mean with "konsole asks"? Things like "You have > > multiple tabs open, are you sure you want to quit?" and "You > > have unsaved changes"? >

Remove legacy session management support?

Hello, While looking at ksmserver, which is already a bit too big to be easy to understand, I noticed that it still has about 500 lines of code to deal with applications that don't yet speak the "modern" (from 1993) XSMP session management protocol. kwin seems to have some more code for legacy

Re: Causes of session management problems in Plasma 5

sts. > On November 23, 2015 7:02:46 PM CST, Andreas Hartmetz <ahartm...@gmail.com> wrote: > >Hello, > > > >As apparently one of the last users of session management, because I > >shut down my computers about once every day, I run into problems > >about

Re: Causes of session management problems in Plasma 5

On Mittwoch, 25. November 2015 18:05:26 CET Thomas Lübking wrote: > On Dienstag, 24. November 2015 02:02:46 CEST, Andreas Hartmetz wrote: > > - The session manager not "locking down" or better copying the list > > of> > > clients *while* logging out. T

Causes of session management problems in Plasma 5

Hello, As apparently one of the last users of session management, because I shut down my computers about once every day, I run into problems about as often as I log into a session that is supposed to be restored. The number one problem is Konsole just not restoring. So I took some time to

Re: Freeze on nested eventloops (QFileDialog::getOpen*)

On Sunday 14 June 2015 15:00:57 Milian Wolff wrote: Hey all, in massif-visualizer's framework branch, and now also kate, I sometimes notice GUI lockups when I try to open files via Ctrl + O. The backtraces look like the following: https://paste.kde.org/pbzhkgx8r Any idea what might be

Re: Freeze on nested eventloops (QFileDialog::getOpen*)

top to bottom. On 21 June 2015 at 20:29, Andreas Hartmetz ahartm...@gmail.com wrote: On Sunday 14 June 2015 15:00:57 Milian Wolff wrote: Hey all, in massif-visualizer's framework branch, and now also kate, I sometimes notice GUI lockups when I try to open files via Ctrl + O

Re: Freeze on nested eventloops (QFileDialog::getOpen*)

On Sunday 14 June 2015 15:00:57 Milian Wolff wrote: Hey all, in massif-visualizer's framework branch, and now also kate, I sometimes notice GUI lockups when I try to open files via Ctrl + O. The backtraces look like the following: https://paste.kde.org/pbzhkgx8r Any idea what might be

Re: KDiagram libs (KChart, KGantt) in KDE Review

On Wednesday 11 February 2015 14:59:50 Adriaan de Groot wrote: On Monday 09 February 2015 01:50:03 Friedrich W. H. Kossebau wrote: Yes, nearly copypaste: the copies of KDChart in Calligra KMyMoney are older (2.4.1, based on Qt4) versions, while the copy of KDChart in Massif-Visualizer

Re: Review Request 111335: Fix for one of the oldest KIO bugs: multiple dialogs when KIO encounters SSL errors

it a child of the public class. kio/kio/slaveinterface.cpp http://git.reviewboard.kde.org/r/111335/#comment26049 Early return for less nesting - Andreas Hartmetz On July 1, 2013, 5:10 a.m., Dawit Alemayehu wrote

Re: Review Request 111370: system_tray: initialize uninitialized members

://git.reviewboard.kde.org/r/111370/#comment26060 Two style issues: put the m_applet initialization on a new line (with the comma on the previous line), and use 0, not NULL. - Andreas Hartmetz On July 2, 2013, 6:15 p.m., Jiri Slaby wrote

Re: Review Request 111370: system_tray: initialize uninitialized members

://git.reviewboard.kde.org/r/111370/#comment26086 Please don't use tabs and align it with the previous item. - Andreas Hartmetz On July 3, 2013, 10:54 a.m., Jiri Slaby wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 111370: system_tray: initialize uninitialized members

), m_someVariable(0), m_someOtherVariable(bar) { } - Andreas Hartmetz On July 3, 2013, 11:58 a.m., Jiri Slaby wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111370

Re: Review Request 111370: system_tray: initialize uninitialized members

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111370/#review35523 --- Ship it! Congratulations :P - Andreas Hartmetz On July 3

Re: Finalized proposal for i18n in KF5, second iteration

On Tuesday 02 April 2013 15:46:52 Chusslove Illich wrote: After considering comments from the previous iteration: http://mail.kde.org/pipermail/kde-frameworks-devel/2012-December/001358.htm l here is the updated version: http://nedohodnik.net/misc/ki18n-kf5-02/html/prg_guide.html

Re: Review Request 109748: kioslave/sftp: Show correct port number when connecting to default port

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109748/#review3 --- Ship it! Ship It! - Andreas Hartmetz On March 26, 2013, 8

Review Request 109675: Make sure that the KDE prefix comes first in XDG_DATA_DIRS

. Diffs - startkde.cmake 8361fe0 Diff: http://git.reviewboard.kde.org/r/109675/diff/ Testing --- Thanks, Andreas Hartmetz

Re: Review Request 109675: Make sure that the KDE prefix comes first in XDG_DATA_DIRS

touched XDG_DATA_DIRS. But it should, and now it does. Diffs - startkde.cmake 8361fe0 Diff: http://git.reviewboard.kde.org/r/109675/diff/ Testing --- Thanks, Andreas Hartmetz

Re: RFC: Enabling -DKDE4_BUILD_TESTS=ON by default

On Monday 08 October 2012 22:40:55 Albert Astals Cid wrote: Hi fellow kde-core-develers, i was thinking that from time to time someone commits some code that breaks the building of the tests. This happens because people is not aware that those parts are unit tested. I think that by

Re: Review Request: Cleanup the use of HTTPProtocol::httpClose

On Oct. 12, 2011, 10:51 p.m., Andreas Hartmetz wrote: This changeset changes some important parts without obvious (to me) gain. Before I spend an hour or two thinking through all the cases, which may or may not catch potential regressions, I'd like to know what this does for us

Re: Review Request: Cleanup the use of HTTPProtocol::httpClose

(to me) gain. Before I spend an hour or two thinking through all the cases, which may or may not catch potential regressions, I'd like to know what this does for us. The current approach of acting a bit dumb seems more robust. - Andreas Hartmetz On Oct. 8, 2011, 5:16 a.m., Dawit Alemayehu wrote

Re: Review Request: kio_http: fix keepalive timeout parsing

cases the values are case sensitive (usernames, something Base64-encoded for example), so the parser better leaves them alone. So you need to normalize the case yourself. - Andreas Hartmetz On Oct. 10, 2011, 10:35 p.m., Andrea Iacovitti wrote

Re: Review Request: kio_http: fix keepalive timeout parsing

On Oct. 12, 2011, 10:58 p.m., Andreas Hartmetz wrote: kioslave/http/http.cpp, line 3107 http://git.reviewboard.kde.org/r/102822/diff/1/?file=38514#file38514line3107 I guess the parser just lowercases the key (keep-alive), not the values. Lowercasing the keys is okay because per

Re: Review Request: Proxy overhaul Part 4: More proxy changes and fixes for KProtocolManager

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102691/#review6927 --- Ship it! Ship It! - Andreas Hartmetz On Sept. 25, 2011, 4

Re: Review Request: Proxy overhaul Part 4: More proxy changes and fixes for KProtocolManager

On Sept. 25, 2011, 2:20 p.m., Andreas Hartmetz wrote: I'd actually be interested to hear which testing you did. The ResolveHostNamesBeforeProxyCheck option seems strange. In which situations is this supposed to be set / not set? Dawit Alemayehu wrote

Re: Review Request: Proxy overhaul Part 4: More proxy changes and fixes for KProtocolManager

the name, but it is good practice to state all the important facts in the apidox. kio/kio/kprotocolmanager.cpp http://git.reviewboard.kde.org/r/102691/#comment6012 This looks more like if no proxy scheme is given, assume SOCKS - Andreas Hartmetz On Sept. 25, 2011, 2:08 a.m., Dawit

Re: Review Request: Proxy overhaul Part 5: Add support for trying multiple proxies to KIO HTTP

the correct value where it is used. - Andreas Hartmetz On Sept. 25, 2011, 2:28 a.m., Dawit Alemayehu wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102696

Re: Qt5 - KDE5?

On Monday 09 May 2011 18:03:18 Olivier Goffart wrote: Hi, With Qt5 around the corner[1], I think it is time to start thinking about KDE5 Raw summary: - Qt5 is planed to be released in about one year from now if everything goes well. - It should be mostly source compatible with Qt4,

Re: Review Request: Fix for a couple of KIO put-slave-on-hold bugs

On Thursday 28 April 2011 16:05:51 Dawit Alemayehu wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101244/ --- (Updated

Re: 4.6 branches created in git again

On Sunday 20 March 2011 15:17:11 Ian Monroe wrote: On Sun, Mar 20, 2011 at 09:09, Andreas Hartmetz ahartm...@gmail.com wrote: On Sunday 20 March 2011 14:38:40 Albert Astals Cid wrote: Can you please be careful and do not create incorrectly 4.6 branches in places where the branch is called

Re: 4.6 branches created in git again

On Sunday 20 March 2011 15:59:55 Parker Coates wrote: On Sun, Mar 20, 2011 at 10:09, Andreas Hartmetz wrote: On Sunday 20 March 2011 14:38:40 Albert Astals Cid wrote: Can you please be careful and do not create incorrectly 4.6 branches in places where the branch is called KDE/4.6 (e.g

Re: Review Request: Fix handling of FTP urls whose path name ends with a type code

On Friday 18 March 2011 20:58:52 David Faure wrote: On Wednesday 16 March 2011, Thiago Macieira wrote: Suggestion: path.left(path.length() - sizeof ;type=); Unreadable. sizeof(;type=) == strlen(;type=X) A hidden off-by-one, how nice to have in our code ;) The best

Re: Review Request: Fix for connecting to FTP sites through HTTP proxy

On Thursday 10 March 2011 08:14:04 Dawit A wrote: On Wed, Mar 9, 2011 at 6:32 PM, Andreas Hartmetz ahartm...@gmail.com wrote: On Wednesday 09 March 2011 23:43:23 Dawit A wrote: [snipped] Yes, it is, but not for those reasons. That entry was not put there simply because we had an HTTP

Re: Future of KSysguard - removing remote monitoring

On Wednesday 09 March 2011 15:00:27 Aaron J. Seigo wrote: On Tuesday, March 8, 2011, John Tapsell wrote: So unless anyone can talk me out of it now, I am going to remove the ability to monitor remote hosts entirely imho: instead of eviscerating the application of the primary

Re: Review Request: Fix for connecting to FTP sites through HTTP proxy

On Wednesday 09 March 2011 20:06:40 Dawit A wrote: On Wed, Mar 9, 2011 at 12:46 PM, David Faure fa...@kde.org wrote: On Wednesday 09 March 2011, Dawit Alemayehu wrote: proxiedBy always returns true since ftp.protocol no longer contains a ProxiedBy= entry. Yes it does, of course. But

Re: Review Request: Fix for connecting to FTP sites through HTTP proxy

On Wednesday 09 March 2011 23:43:23 Dawit A wrote: On Wed, Mar 9, 2011 at 2:53 PM, Andreas Hartmetz ahartm...@gmail.com wrote: On Wednesday 09 March 2011 20:06:40 Dawit A wrote: On Wed, Mar 9, 2011 at 12:46 PM, David Faure fa...@kde.org wrote: On Wednesday 09 March 2011, Dawit Alemayehu

Re: Profiles for all KDE-applications

On Saturday 26 February 2011 10:58:23 Jonathan Schmidt-Dominé wrote: Hi! In Mozilla-applications so called “profiles”, sets of user-configuration, are a quite common feature, Konqueror implements them, too. But wouldn't it be possibe to provide this feature for all KDE-applications by

Re: git workflow draft

On Thursday 17 February 2011 09:01:05 Johannes Sixt wrote: Am 2/16/2011 22:10, schrieb Stephen Kelly: As one of the people asked to describe my idea of the workflow (which should focus on rebasing, not merging) I put write up here:

Re: Merge or Cherry-Pick?

On Thursday 03 February 2011 08:57:00 Johannes Sixt wrote: Am 2/3/2011 6:10, schrieb Dawit A: What happens if I tested a bug fix and wanted it to push it upstream so that it can receive even wider testing, but it just so happens the time to tag the next bug fix release is right around the

Re: Merge or Cherry-Pick?

On Wednesday 02 February 2011 21:15:31 Aaron J. Seigo wrote: On Wednesday, February 2, 2011, Thiago Macieira wrote: I still think the current procedure is wrong. You're not testing the stable release, there's no guarantee that you're solving the problem at all, or worse, that you're not

Re: KDE library compile error (on the ARM CORTEX-A8)

On Monday 17 January 2011 22:56:47 Thiago Macieira wrote: On Monday, 17 de January de 2011 22:04:46 АлексаМЎр КузеЌкП wrote: Hello! I have beagleboard-xm with Gentoo distributive on it. I compile and can run Qt 4.7.1 demo. Now I decide install kde from 4.6 branch svn. When