Re: openSUSE packagers' take on the 3 month release cycle

2013-07-09 Thread Parker Coates
On Tue, Jul 9, 2013 at 9:14 AM, Vishesh Handa wrote: On Tue, Jul 9, 2013 at 4:13 PM, Scott Kitterman wrote: These all have to be test compiled, checked for new or missing files, checked for files that have moved between packages, checked for license/copyright updates, etc. I guess you

Re: Review Request 110262: KRandomSequence::randomize: use the Fisher-Yates Algorithm to achieve O(N) complexity

2013-05-02 Thread Parker Coates
On May 1, 2013, 9:03 p.m., Parker Coates wrote: Since KRandomSequence is a class for generating a predictable random sequence, is it not possible that this change would break applications that relied on the code below producing a consistent result between kdelibs releases? QList

Re: Review Request 110262: KRandomSequence::randomize: use the Fisher-Yates Algorithm to achieve O(N) complexity

2013-05-01 Thread Parker Coates
; - Parker Coates On May 1, 2013, 8:34 p.m., Frank Reininghaus wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110262

Re: Review Request 110262: KRandomSequence::randomize: use the Fisher-Yates Algorithm to achieve O(N) complexity

2013-05-01 Thread Parker Coates
; - Parker Coates On May 1, 2013, 8:34 p.m., Frank Reininghaus wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110262

Re: Review Request 110262: KRandomSequence::randomize: use the Fisher-Yates Algorithm to achieve O(N) complexity

2013-05-01 Thread Parker Coates
; - Parker Coates On May 1, 2013, 8:34 p.m., Frank Reininghaus wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110262

Re: Review Request: Prevent Konqueror's address bar from being hidden by default

2012-07-27 Thread Parker Coates
On July 27, 2012, 8:50 a.m., David Faure wrote: I like the idea, but why the non-editable combo? What happens when navigating, in that window? Doesn't the combo then start to be messed up (the code assuming that it is editable, has history items, has completion, etc.) ... especially

Re: Review Request: Only show the Find File action for local URL in Dolphin's KPart

2012-07-18 Thread Parker Coates
. - Parker Coates On July 18, 2012, 2:53 a.m., Dawit Alemayehu wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105607

Re: Review Request: Fix Bug 152156 - KDE help center does not respect window placement policy

2012-04-18 Thread Parker Coates
://git.reviewboard.kde.org/r/104662/#comment9879 I've seen a few applications use a certain fraction of the screen size as the default. See http://websvn.kde.org/trunk/KDE/kdegames/kpat/mainwindow.cpp?view=markup#l118 . I'm not sure that's necessarily the best default, though. - Parker Coates On April 18

Re: Review Request: Fix Bug 152156 - KDE help center does not respect window placement policy

2012-04-18 Thread Parker Coates
On April 18, 2012, 6 p.m., Parker Coates wrote: khelpcenter/mainwindow.cpp, line 170 http://git.reviewboard.kde.org/r/104662/diff/1/?file=58010#file58010line170 I've seen a few applications use a certain fraction of the screen size as the default. See http://websvn.kde.org

Re: bugzilla situation

2012-02-25 Thread Parker Coates
On Sat, Feb 25, 2012 at 03:06, dE . wrote: I tend to think closing duplicate bugs and checking wish list issues can be done by a non-developer contributers. In which case there should be an option by which a particular user can be CCd to for a specific program(s). There should be an entry

Re: Please avoid noisy merge commits in frameworks

2012-02-19 Thread Parker Coates
On Sun, Feb 19, 2012 at 11:58, Anne-Marie Mahfouf wrote: I guess I should get used to using gitk. This is slightly off topic, but with all this talk of gitk, I thought it'd be a good time to recommend QGit [1]. It's an alternative git history viewer with a friendlier interface built on top of a

Re: Review Request: Support passing an argument to the Locale KCM tab to specify which tab to activate at load.

2011-10-26 Thread Parker Coates
On Oct. 23, 2011, 5:49 p.m., John Layt wrote: Hi Dave, as maintainer of the Locale KCM I'm happy for this to go in, but we do need to make the command line option consistent for all the KCM's. I suggest checking with Ben Cooksley who is overall maintainer of System Settings as to

Re: [PATCH] Automatically reload files modified on disk.

2011-10-21 Thread Parker Coates
On Fri, Oct 21, 2011 at 09:01, Reindl Harald wrote: Am 21.10.2011 13:46, schrieb Søren holm: Why is it bad to have files not changed from within the editor reload when they change? because if i work half an hour in a css-file and another one makes a simple change and press save it will

Re: KAction (and its shortcut configuration) on multiple widgets of same kind. Need help...

2011-10-16 Thread Parker Coates
On Sat, Oct 15, 2011 at 12:08, Yogesh Marwaha wrote: Hi, Scenario: I have three text editors separated by splitter in a single window. Each text editor has an action called cut. Now I want to set a shortcut for cut action and allow user to change it through KShortcutsDialog. But when its

Re: Module layout proposal: Split kdegames-data from kdegames

2011-10-15 Thread Parker Coates
On Fri, Oct 14, 2011 at 14:29, Stefan Majewsky wrote: DETAILED PROPOSAL kdegames is among the few modules that have not yet switched to Git. The main concern is that the kdegames source tree contains tons [1] of binary data files, which Git is known not to handle well. All

Re: Security Audit Request for Screenlocker Branch

2011-10-11 Thread Parker Coates
On Sun, Oct 9, 2011 at 14:02, Martin Gräßlin wrote: I want to request a security audit for the changes to ensure that the new implementation is as secure as the existing one and that I did not forget an important case which would compromise the security. The general concept of the new

Re: Clearing a QLineEdit

2011-06-19 Thread Parker Coates
On Mon, Jun 20, 2011 at 00:14, Steven Sroka wrote: Hi everyone, Does anyone know how to clear the contents of a QLineEdit when a user sets focus to it (ie. clicks it, presses the tab key repeatedly, etc.)? Subclass KLineEdit (which you`re using instead of QLineWidget, right?) and reimplement

Re: Disabling Oxygen's window dragging for specific QWidgets?

2011-05-13 Thread Parker Coates
On Fri, May 13, 2011 at 12:41, Hugo Pereira Da Costa wrote: Hello Nikos, I noticed that when running in KDE and using the Oxygen style, the windows of my Qt application can be dragged around with the mouse by clicking on any area in the window, not just the title bar.  But it behaves strange

Re: Review Request: Fix the layout of KNameAndUrlInputDialog (kfile)

2011-05-08 Thread Parker Coates
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101312/#review3200 --- Adding some before and after screenshots would probably get you

Re: Help on .desktop files for oxygen

2011-05-06 Thread Parker Coates
On Fri, May 6, 2011 at 05:50, Hugo Pereira Da Costa wrote: Some follow-up. I coded locally the necessary changes to have oxygen-settings included inside systemsettings, even when through changing the various pages into KCModules, and ... well ... it pretty much defeats the purpose (see

Re: Proposal of user input style global setting

2011-04-26 Thread Parker Coates
On Tue, Apr 26, 2011 at 03:09, Jeffery MacEachern wrote: On Sun, Apr 24, 2011 at 13:35, 4ernov wrote: 1. The feature that was introduced in Qt 4.7 - you can drag the window clicking on unused area. Quite cool on touch devices. But the sense I thought this was an Oxygen feature, not a general

Re: Review Request: Proper All files option when using mime types as filters for KFileDialog's functions

2011-04-10 Thread Parker Coates
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101075/#review2553 --- While I'm not really qualified to comment on the

Review Request: Improvements to KFileDialog filtering

2011-04-02 Thread Parker Coates
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101013/ --- Review request for kdelibs. Summary --- This patch attempts to

Re: Review Request: Improvements to KFileDialog filtering

2011-04-02 Thread Parker Coates
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101013/ --- (Updated April 2, 2011, 11:47 p.m.) Review request for kdelibs. Changes

Re: Review Request: Adding Ångström to KUnitConversion

2011-03-22 Thread Parker Coates
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100923/#review2109 --- kunitconversion/length.cpp

Re: Review Request: Adding Ångström to KUnitConversion

2011-03-22 Thread Parker Coates
On March 22, 2011, 10:14 p.m., Parker Coates wrote: kunitconversion/length.cpp, line 146 http://git.reviewboard.kde.org/r/100923/diff/1/?file=12695#file12695line146 You missed Angstrom. Accents are too hard for some of us. :) Plural forms might be good too. Christoph Feck

Re: 4.6 branches created in git again

2011-03-20 Thread Parker Coates
On Sun, Mar 20, 2011 at 10:57, Ian Monroe wrote: On Sun, Mar 20, 2011 at 09:45, John Tapsell wrote: Why do we let people create branches on the main git server anyway? Well for feature branches its fine and kind of the point of git. There's no reason to let non-admins create version branches

Re: Git Workflow - Outstanding Issues

2011-03-18 Thread Parker Coates
On Fri, Mar 18, 2011 at 23:25, Wolfgang Rohdewald wrote: On Freitag 18 März 2011, John Layt wrote: * Commit Template I've finally committed the Commit Template into kdelibs, any Git project that  wants to use a different version can commit that to their own repo provided they follow the basic

Re: Merge or Cherry-Pick?

2011-02-04 Thread Parker Coates
On Tue, Feb 1, 2011 at 06:29, Johannes Sixt wrote: Am 2/1/2011 10:31, schrieb David Jarvie: On Mon, January 31, 2011 11:27 pm, Thiago Macieira wrote: On Monday, 31 de January de 2011 23:34:39 Arno Rehn wrote: I guess that won't quite work when there are commits specific to 4.6 in the 4.6

Re: Merge or Cherry-Pick?

2011-02-02 Thread Parker Coates
On Wed, Feb 2, 2011 at 08:25, David Jarvie wrote: I'd recommend maintaining a local 'master' branch which always mirrors the remote repository. Never do development in your local 'master' branch - always do your work in other local branches, and only merge/cherry-pick changes from them into

Re: irc meeting for kdelibs git workflow

2011-02-02 Thread Parker Coates
On Wed, Feb 2, 2011 at 08:45, John Layt wrote: On Wednesday 02 February 2011 09:19:29 Oswald Buddenhagen wrote: i'd suggest a look at http://qt.gitorious.org/qt/pages/CommitPolicy, in particular point 8 of the rules. the point it makes is independent from using git (in fact, we have a similar

Re: Merge or Cherry-Pick?

2011-02-02 Thread Parker Coates
On Wed, Feb 2, 2011 at 09:05, John Layt wrote: On Wednesday 02 February 2011 13:43:04 Parker Coates wrote: My preferred workflow is to put all local commits intended for master in a single, local, long-lived workmaster branch instead of putting them in master directly. Since the changes

Re: Initial support for kde_projects.xml in kdesrc-build

2011-01-31 Thread Parker Coates
On Mon, Jan 31, 2011 at 19:08, Michael Pyne wrote: On Monday, January 31, 2011 18:19:12 Albert Astals Cid wrote: cons:  * There is black magic happening behind your back and once something breaks you won't know how to fix things by yourself. For instance even after using kdesrc-build on my

Re: Usefulness of Subject-header of git commit mails

2011-01-28 Thread Parker Coates
On Fri, Jan 28, 2011 at 11:42, Andreas Hartmetz wrote: On Monday 24 January 2011 00:13:26 Eike Hein wrote: Yep - for the benefit of those who aren't used to the git jargon (sorry for that), in git the convention is to for- mat the commit message like this: single line of about 50 chars,

Re: kdesrc-build polkit-agent-1

2011-01-21 Thread Parker Coates
On Fri, Jan 21, 2011 at 11:52, Steven Sroka wrote: If Michale Pyne is around, or if anyone has noticed this, the new version of kdesrc-build tries to compile polkit-qt-1, but polkit-qt-1 needs polkit-agent-1. Where can I get polkit-agent-1 so I can put the repo address into my kdesrc-buildrc

Re: KDE git docs for dummies ? WAS: Re: splitting up kdebase in git

2011-01-20 Thread Parker Coates
2011/1/20 Alexander Neundorf: As long as there is no policy defined, I simply try to push/merge to the respective master ? I also think that really most/all new KDE git repositories should use a common workflow. I think this is a reasonable expectation for all repositories that are part of

Re: KRichTextWidget

2011-01-15 Thread Parker Coates
On Sat, Jan 15, 2011 at 23:20, Steven Sroka wrote: Is there some way to know if a user has clicked a KRichTextWidget widget? I would like to create a KRichTextWidget that is small in size at first because it is optional if the user wants to type some data into it. If indeed the user does want

Re: Action icons in menus

2010-12-13 Thread Parker Coates
On Mon, Dec 13, 2010 at 16:26, Miha Čančula wrote: 2010/12/13 Albert Astals Cid aa...@kde.org A Dilluns, 13 de desembre de 2010, Miha Čančula va escriure: Dne ponedeljek 13 decembra 2010 ob 21:32:30 je Albert Astals Cid napisal(a): Does this break keyboard navigation in the menu? Yes,

Re: -DQT_NO_CAST_FROM_ASCII -DQT_NO_CAST_TO_ASCII as policy in kde

2010-11-15 Thread Parker Coates
On Mon, Nov 15, 2010 at 13:25, David Faure wrote: On Wednesday 06 October 2010, Parker Coates wrote:  But I just don't think wrapping every single literal with a constructor or conversion function is improving code quality. [2] Right. In the code you linked to, it's apparent that 1) KIcon