Prarit Bhargava writes:
>> So this papers over the real problem. I looked at the Makefile and wonder why
>> CFLAGS wasn't being passed over even with "override" being used to append the
>> flags. Seems the real problem is that the updated CFLAGS aren't being passed
>> to the submake used to build
From: Herton R. Krzesinski on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1721#note_900324237
So the problem of CFLAGS is that tools_make calls ```make CFLAGS=(...)```
instead of ```CFLAGS=(...) make```, the first form overrides the Makefile
CFLAGS and then you need to
From: Justin M. Forbes on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1721#note_900288988
Thanks, just used that to build kernel-tools for Fedora. We do have a
different make call there though, and I had to append the include, so my lines
are:
%{tools_make}
From: Herton R. Krzesinski on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1721#note_900260336
Justin, just opened this MR: https://gitlab.com/cki-project/kernel-
ark/-/merge_requests/1736
___
kernel mailing list --
From: Justin M. Forbes on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1721#note_899643862
Friday I just fixed things up by hand in dist-git, and I had planed to do the
same for rc1, but would like to just get things include-in-releases at least
until we get proper acks.
From: Herton R. Krzesinski on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1721#note_899632055
By not using full flags I mean you can drop the %make invocation and call it
directly as a quick workaround, until we get it fixed.
From: Herton R. Krzesinski on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1721#note_899628813
Yes I'll try to do it here. Also, if you need to just get the build working,
feel free to keep the change on spec only not using full flags, until we get
the Makefile change
From: Justin M. Forbes on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1721#note_898479057
I have not found a successful way to get this to build in koji without your
Makefile changes Herton. Want to send a patch upstream and create an MR to get
it in ark?
From: David Arcari on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1721#note_897880574
That's correct - we are updating the Intel Speed Select driver and user
command in 9.1.
___
kernel mailing list --
From: Herton R. Krzesinski on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1721#note_897542898
I think David is backporting patches that need it now. However, @darcari if
you're using this approach, make sure the build is using the full LDFLAGS, and
what I mean by that it
From: Justin M. Forbes on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1721#note_897518778
Does centos9 even need this? It wasn't required before the 5.18 merge window,
and the issues are a combination of the added features there and gcc 12
issues.
From: David Arcari on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1721#note_897468353
I tried Justin's patch on centos9 and it worked:
https://gitlab.com/redhat/centos-stream/src/kernel/centos-
stream-9/-/commit/3a5d7820e110ab5ac5e2ba95f7123389630e7274
From: Justin M. Forbes on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1721#note_896710175
Yes, it seems my fix is not actually a fix when building in koji.
___
kernel mailing list -- kernel@lists.fedoraproject.org
To
From: Herton R. Krzesinski on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1721#note_896317016
So the problem with LDFLAGS is the linking order when using -Wl,--as-needed
We need this fix into the Makefile:
```
$ git diff
diff --git
From: Herton R. Krzesinski on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1721#note_896228176
So the LDFLAGS issue manifests itself because %{?build_hostldflags} (which
comes from our redhat rpm config) contains the flag -Wl,--as-needed, and once
we fix the passing of
From: Herton R. Krzesinski on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1721#note_896233057
Yes it's possible to do it in spec, and right now I'm in favour of it as well.
However for the intel-speed-select issue, if we fix LDFLAGS right now we will
have the linker
From: Justin M. Forbes on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1721#note_896201128
It does work with the version I have locally, but until I can get a build
through to verify, I was not planning to send the update. The other issue is
in iio_event_monitor, which
From: Herton R. Krzesinski on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1721#note_896180024
I see the LDFLAGS now, let me check it...
___
kernel mailing list -- kernel@lists.fedoraproject.org
To unsubscribe send an email to
From: Herton R. Krzesinski on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1721#note_896155421
I mean, once I change the Makefile to use ```+ $(Q)$(MAKE)
CFLAGS="$(CFLAGS)" $(build)=intel-speed-select```, the LDFLAGS issue didn't
reproduce/break linking.
From: Herton R. Krzesinski on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1721#note_896150217
well, we already are using the perf_make idea by defining a make macro in the
spec. But that's not working in this case due how make is behaving
From: Herton R. Krzesinski on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1721#note_896147244
what about if you change it just to:
```
CFLAGS="%{?build_hostcflags}" LDFLAGS="%{?build_hostldflags}" {__make}
```
btw, I was not able to reproduce locally the problem with
From: Justin M. Forbes on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1721#note_896035285
That's pretty much what I did, but not a whole lot of point in pushing it
until things actually build.
___
kernel mailing list --
From: Don Zickus on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1721#note_896031021
I know jolsa had similar issues a couple of years ago with perf. He put some
interesting workarounds in the spec file to deal with them, "perf_make". Is
that something we can
From: Justin M. Forbes on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1721#note_896016507
Right, so I did
`%{make} CFLAGS="${RPM_OPT_FLAGS} -D_GNU_SOURCE -I/usr/include/libnl3"
LDFLAGS="%{__global_ldflags} -lnl-genl-3 -lnl-3`
In the kernel spec and that got around both
Hi Herton,
On 3/30/22 5:16 PM, Prarit Bhargava wrote:
On 3/30/22 15:10, Herton R. Krzesinski (via Email Bridge) wrote:
From: Herton R. Krzesinski on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1721#note_895049612
So this papers over the real problem. I looked at
From: Herton R. Krzesinski on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1721#note_895271798
>
>
>
> CKI Gitlab commented:
>
>
> DJ Delorie commented via email:
> ```
> Prarit Bhargava writes:
> >> So this papers over the real problem. I looked at the Makefile and
On 3/30/22 15:10, Herton R. Krzesinski (via Email Bridge) wrote:
From: Herton R. Krzesinski on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1721#note_895049612
So this papers over the real problem. I looked at the Makefile and wonder why
CFLAGS wasn't being passed over
From: Herton R. Krzesinski on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1721#note_895049612
So this papers over the real problem. I looked at the Makefile and wonder why
CFLAGS wasn't being passed over even with "override" being used to append the
flags. Seems the real
From: Justin M. Forbes on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1721#note_894758127
This does not work, testing another fix and will update the MR if that works.
___
kernel mailing list -- kernel@lists.fedoraproject.org
From: Prarit Bhargava
redhat/kernel.spec.template: Fix intel-speed-select compile
The intel-speed-select utility needs the libnl3 library to compile.
Signed-off-by: Prarit Bhargava
diff --git a/redhat/kernel.spec.template b/redhat/kernel.spec.template
index blahblah..blahblah 100755
---
30 matches
Mail list logo
