Re: Problem with netconsole and eth0 timing

2018-09-26 Thread don fisher
On 9/26/18 2:33 PM, valdis.kletni...@vt.edu wrote: On Wed, 26 Sep 2018 13:25:35 -0700, don fisher said: Would you tell me how to tell the driver that it is to be eth0, ip address etc. Maybe on linux command line, but I do not know the format. To quote some guy named Don Fisher: my kernel

Re: Problem with netconsole and eth0 timing

2018-09-26 Thread valdis . kletnieks
On Wed, 26 Sep 2018 13:25:35 -0700, don fisher said: > Would you tell me how to tell the driver that it is to be eth0, ip > address etc. Maybe on linux command line, but I do not know the format. To quote some guy named Don Fisher: > my kernel and including the proper command (as shown below) in

Re: Problem with netconsole and eth0 timing

2018-09-26 Thread don fisher
On 9/25/18 7:26 PM, valdis.kletni...@vt.edu wrote: On Tue, 25 Sep 2018 18:26:06 -0700, don fisher said: The wicked message eth0: up comes at Sep 24 22:02:01.173616. The difference is maybe 36 seconds? There is an eth0: avail message at Sep 24 22:01:34.112744, don't know if that would suffice

Re: staging:rtl8192u: Possible memory leak?

2018-09-26 Thread valdis . kletnieks
On Wed, 26 Sep 2018 16:52:03 +0100, John Whitmore said: > This might all be a mute point as I seem to remember someone saying > that memory allocation never fails in Linux and this can only happen > if the first two allocations work and the third fails. If memory allocation never fails, it would

[PATCH] fix error handling in drivers/staging/rtl8192u/ieee80211/ieee80211_module.c

2018-09-26 Thread valdis . kletnieks
John notes that if the kzalloc of ieee->pHTInfo fails, we fail to call ieee80211_networks_free(). In addition, that function has an un-needed check before kfree(). Reported-by: John Whitmore Signed-off-by: Valdis Kletnieks --- diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c

staging:rtl8192u: Possible memory leak?

2018-09-26 Thread John Whitmore
I've been going through the rtl8192u driver in drivers/staging trying to get a better understanding of the code. It's possibly not the text book network driver but it seemed as good a place to start as any. So I'm looking at the allocation function in ieee80211_module.c: struct net_device