Re: Please give advise about my first patch attempt

2020-08-27 Thread Pawan Gupta
On Thu, Aug 27, 2020 at 10:49:51AM +0200, Thomas Schmitt wrote: > Hi, > > i am preparing my first patch. > May i ask for review and advise how to make it acceptable ? If you are not running it already you can catch common mistakes by running checkpatch script from the kernel source top directory

Re: Please give advise about my first patch attempt

2020-08-27 Thread Lukas Bulwahn
nux-next > ... > * [new branch]akpm -> linux-next/akpm > * [new branch]akpm-base -> linux-next/akpm-base > * [new branch]master-> linux-next/master > * [new branch] pending-fixes -&

cpu-freq: running the perf increases the data rate?

2020-08-27 Thread Subhashini Rao Beerisetty
[ Please keep me in CC as I'm not subscribed to the list] Hi all, I have an application which finds the data rate over the PCIe interface. I’m getting the lesser data rate in one of my Linux X86 systems. When I change the scaling_governor from "powersave" to "performance" mode for each CPU,

Re: Please give advise about my first patch attempt

2020-08-27 Thread Thomas Schmitt
aster-> linux-next/master * [new branch]pending-fixes -> linux-next/pending-fixes * [new branch]stable-> linux-next/stable * [new tag] next-20200827 -> next-20200827 $ git checkout master ... $ git remote u

Re: Please give advise about my first patch attempt

2020-08-27 Thread Greg KH
On Thu, Aug 27, 2020 at 10:02:21AM -0400, Leam Hall wrote: > On Thu, Aug 27, 2020 at 9:20 AM Greg KH wrote: > > > That is also documented in the ever-growing submitting patches document > > somewhere... > > This? > > https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html That's

Re: Please give advise about my first patch attempt

2020-08-27 Thread Leam Hall
On Thu, Aug 27, 2020 at 9:20 AM Greg KH wrote: > That is also documented in the ever-growing submitting patches document > somewhere... This? https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html ___ Kernelnewbies mailing list

Re: Please give advise about my first patch attempt

2020-08-27 Thread Greg KH
On Thu, Aug 27, 2020 at 11:52:56AM +0200, Garrit Franke wrote: > Hi Thomas, > > Noob here. > > On Thu, Aug 27, 2020 at 10:49 AM Thomas Schmitt wrote: > > > > Commit 210ba1d1724f5c4ed87a2ab1a21ca861a915f734 of january 2008 switched > > sr_drive_status() away from indirectly using sr_do_ioctl()

Cannot boot kernel 2.6.35 or 2.6.24 with qemu 5.1

2020-08-27 Thread Cao Nitro
Hi all, As the title mentions, I cannot boot Linux kernel 2.6.35 or 2.6.24 with QEMU 5.1 on Arch Linux. QEMU hasn’t any output when running. Environment: OS: Arch Linux 5.8.1-arch1-1 GCC: 5.5.0, installed from AUR. QEMU: qemu-headless 5.1.0-1 Architecture: x86_64

Re: Please give advise about my first patch attempt

2020-08-27 Thread Garrit Franke
Hi Thomas, Noob here. On Thu, Aug 27, 2020 at 10:49 AM Thomas Schmitt wrote: > > Commit 210ba1d1724f5c4ed87a2ab1a21ca861a915f734 of january 2008 switched > sr_drive_status() away from indirectly using sr_do_ioctl() for sending > TEST UNIT READY commands. sr_do_ioctl() has a wait-and-retry loop

Re: Please give advise about my first patch attempt

2020-08-27 Thread Lukas Bulwahn
Hi Thomas, On Thu, 27 Aug 2020, Thomas Schmitt wrote: > Hi, > > i am preparing my first patch. > May i ask for review and advise how to make it acceptable ? > > The patch shall fix an old regression of cdrom and sr drivers. > Although drivers/cdrom has no mailing list entry in MAINTAINERS, i

Please give advise about my first patch attempt

2020-08-27 Thread Thomas Schmitt
Hi, i am preparing my first patch. May i ask for review and advise how to make it acceptable ? The patch shall fix an old regression of cdrom and sr drivers. Although drivers/cdrom has no mailing list entry in MAINTAINERS, i assume that such patches should go to linux-s...@vger.kernel.org which