Re: picking the first patch

On Sun, 21 Mar 2021 12:03:36 -0400, Harsha Vardhan said: > So far I have spent a lot of time dreaming to be a kernel hacker without > doing much , 1) What Greg said.. :) 2) Go read this: https://lists.kernelnewbies.org/pipermail/kernelnewbies/2017-April/017765.html And yes, *why* you want to

Re: picking the first patch

On Sun, Mar 21, 2021 at 5:25 PM Harsha Vardhan wrote: > > perfect ! I will do it that way then. > > besides that, generally if you are making changes to drivers , then the > responsibility of testing is on the author of the patch right ? if you don't > have the device how would you test such

Re: picking the first patch

sha Vardhan wrote: > > Any thoughts on whether I should just do a checkpatch.pl change as my > first > > patch ? > > You should do a checkpatch.pl change as your first patch :) > > That way you can focus on the process more than the technical aspects of > the patch (

Re: picking the first patch

On Sun, Mar 21, 2021 at 12:03:36PM -0400, Harsha Vardhan wrote: > Any thoughts on whether I should just do a checkpatch.pl change as my first > patch ? You should do a checkpatch.pl change as your first patch :) That way you can focus on the process more than the technical aspects of the

picking the first patch

Hello team , Sorry for a vague question. So far I have spent a lot of time dreaming to be a kernel hacker without doing much , but I realised its geting too late and now I want to pick my first patch to work, I have decided to address the TODO at drivers/staging/grebus/TODO : " * Make pwm.

Re: Please give advise about my first patch attempt

Hi, i'm back at work with my patch for automatic CD loading, but the target moves faster than i can follow. Meanwhile the sr part of my change plays on a fresh construction site of linux-scsi: https://lore.kernel.org/linux-scsi/730eced4-c804-a78f-3d52-2a448dbd1...@interlog.com/T/#t "rework

Re: Please give advise about my first patch attempt

Hi, i might get a community problem with the goal of my patch. While googling for hints of acceptance for cdrom on linux-s...@vger.kernel.org i came to a thread where a much more expensive fix of the problem was obviously rejected by Jens Axboe in november 2019:

Re: Please give advise about my first patch attempt

On Thu, Aug 27, 2020 at 10:49:51AM +0200, Thomas Schmitt wrote: > Hi, > > i am preparing my first patch. > May i ask for review and advise how to make it acceptable ? If you are not running it already you can catch common mistakes by running checkpatch script from the kernel source t

Re: Please give advise about my first patch attempt

On Thu, 27 Aug 2020, Thomas Schmitt wrote: > Hi, > > Lukas Bulwahn wrote: > > Just take all maintainers as recipients. > > ax...@kernel.dk linux-ker...@vger.kernel.org j...@linux.ibm.com > > martin.peter...@oracle.com linux-s...@vger.kernel.org > > Really that loudly ? > Ain't

Re: Please give advise about my first patch attempt

Hi, Lukas Bulwahn wrote: > Just take all maintainers as recipients. > ax...@kernel.dk linux-ker...@vger.kernel.org j...@linux.ibm.com > martin.peter...@oracle.com linux-s...@vger.kernel.org Really that loudly ? Ain't linux-ker...@vger.kernel.org too general ? > It is probably best to base it

Re: Please give advise about my first patch attempt

On Thu, Aug 27, 2020 at 10:02:21AM -0400, Leam Hall wrote: > On Thu, Aug 27, 2020 at 9:20 AM Greg KH wrote: > > > That is also documented in the ever-growing submitting patches document > > somewhere... > > This? > > https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html That's

Re: Please give advise about my first patch attempt

On Thu, Aug 27, 2020 at 9:20 AM Greg KH wrote: > That is also documented in the ever-growing submitting patches document > somewhere... This? https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html ___ Kernelnewbies mailing list

Re: Please give advise about my first patch attempt

On Thu, Aug 27, 2020 at 11:52:56AM +0200, Garrit Franke wrote: > Hi Thomas, > > Noob here. > > On Thu, Aug 27, 2020 at 10:49 AM Thomas Schmitt wrote: > > > > Commit 210ba1d1724f5c4ed87a2ab1a21ca861a915f734 of january 2008 switched > > sr_drive_status() away from indirectly using sr_do_ioctl()

Re: Please give advise about my first patch attempt

Hi Thomas, Noob here. On Thu, Aug 27, 2020 at 10:49 AM Thomas Schmitt wrote: > > Commit 210ba1d1724f5c4ed87a2ab1a21ca861a915f734 of january 2008 switched > sr_drive_status() away from indirectly using sr_do_ioctl() for sending > TEST UNIT READY commands. sr_do_ioctl() has a wait-and-retry loop

Re: Please give advise about my first patch attempt

Hi Thomas, On Thu, 27 Aug 2020, Thomas Schmitt wrote: > Hi, > > i am preparing my first patch. > May i ask for review and advise how to make it acceptable ? > > The patch shall fix an old regression of cdrom and sr drivers. > Although drivers/cdrom has no mailing list en

Please give advise about my first patch attempt

Hi, i am preparing my first patch. May i ask for review and advise how to make it acceptable ? The patch shall fix an old regression of cdrom and sr drivers. Although drivers/cdrom has no mailing list entry in MAINTAINERS, i assume that such patches should go to linux-s...@vger.kernel.org which

Re: First patch questions (target mailing list, target tree)

On 10/05/2020 23:55, Valdis Klētnieks wrote: On Sun, 10 May 2020 18:26:27 +0100, Wojciech Kudla said: I'd like to send a patch to arch/x86/kernel/smp.c but I'm not sure about 1) which branch of whose tree do I crate the patch against? According to MAINTAINERS: T: git

Re: First patch questions (target mailing list, target tree)

On Sun, 10 May 2020 18:26:27 +0100, Wojciech Kudla said: > I'd like to send a patch to arch/x86/kernel/smp.c but I'm not sure about > 1) which branch of whose tree do I crate the patch against? > According to MAINTAINERS: T: git git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git

Re: First patch questions (target mailing list, target tree)

On 10/05/2020 19:12, Konstantin Ryabitsev wrote: On Sun, May 10, 2020 at 06:26:27PM +0100, Wojciech Kudla wrote: (I'll let others answer your first question.) 2) how do I access archives of x...@kernel.org? You cannot, because this is an alias, not a mailing list. You can use query filters

Re: First patch questions (target mailing list, target tree)

On Sun, May 10, 2020 at 06:26:27PM +0100, Wojciech Kudla wrote: (I'll let others answer your first question.) > 2) how do I access archives of x...@kernel.org? You cannot, because this is an alias, not a mailing list. You can use query filters on LKML to see what public messages were sent to

First patch questions (target mailing list, target tree)

Hi, I'd like to send a patch to arch/x86/kernel/smp.c but I'm not sure about 2 details: 1) which branch of whose tree do I crate the patch against? According to MAINTAINERS: M: Thomas Gleixner M: Ingo Molnar R: "H. Peter Anvin" M: x...@kernel.org L:

Re: First Patch: Memory Limit Exceeded

On Sun, 2018-08-26 at 20:14 +0530, Anika Murarka wrote: > Hi, > I am Anika , and I have been trying to submit my first patch for > Linux Kernel. > I had completed till the make command and rebooted my vm after that. > While rebooting the following message popped :- &qu

First Patch: Memory Limit Exceeded

Hi, I am Anika , and I have been trying to submit my first patch for Linux Kernel. I had completed till the make command and rebooted my vm after that. While rebooting the following message popped :- " End kernel panic not syncing out of memory and no killable processes" . I tried

Re: first patch question

On 2018-08-10 01:04 AM, Nicholas Mc Guire wrote: On Thu, Aug 09, 2018 at 01:19:53PM -0400, greg gallagher wrote: On 2018-08-07 12:47 AM, Nicholas Mc Guire wrote: On Tue, Aug 07, 2018 at 12:15:04AM -0400, Greg Gallagher wrote: Hi, I creating my first patch to the kernel. I followed

Re: first patch question

On Thu, Aug 09, 2018 at 01:19:53PM -0400, greg gallagher wrote: > > > On 2018-08-07 12:47 AM, Nicholas Mc Guire wrote: > >On Tue, Aug 07, 2018 at 12:15:04AM -0400, Greg Gallagher wrote: > >>Hi, > >>I creating my first patch to the kernel. I followed the &g

Re: first patch question

On 2018-08-07 12:47 AM, Nicholas Mc Guire wrote: On Tue, Aug 07, 2018 at 12:15:04AM -0400, Greg Gallagher wrote: Hi, I creating my first patch to the kernel. I followed the instruction on the newbies wiki and everything went smoothly. I got feedback from the maintainer to fix all

Re: first patch question

On Tue, Aug 07, 2018 at 12:15:04AM -0400, Greg Gallagher wrote: > Hi, >I creating my first patch to the kernel. I followed the > instruction on the newbies wiki and everything went smoothly. I got > feedback from the maintainer to fix all the alignment issues in the > file

first patch question

Hi, I creating my first patch to the kernel. I followed the instruction on the newbies wiki and everything went smoothly. I got feedback from the maintainer to fix all the alignment issues in the file instead of just the one i picked. My question is if I fix 10 alignment issues identified

Re: First patch

On Thu, 02 Aug 2018 23:49:03 +0200, Arkadiusz Lis said: > From 231fa77d595536cdaacf364b02dd64fd45a6adc4 Mon Sep 17 00:00:00 2001 > From: Arkadiusz Lis > Date: Thu, 2 Aug 2018 23:38:17 +0200 > Subject: [PATCH] Staging: One Laptop Per Child: fix coding style and license > issues One thing per

First patch

Hi guys, I created my first patch. Could you please take a look and check for mistakes? It's a small clean up removing checkpatch.pl warnings. It was generated using 'git format-patch master..'. See below: >From 231fa77d595536cdaacf364b02dd64fd45a6adc4 Mon Sep 17 00:00:00 2001 From: Arkadi

Re: My first patch - patch for adl_pci9118.c

On Sat, Nov 18, 2017 at 01:07:30PM +0100, Fabian Baumanis wrote: > Hi there, > > this morning i created my first patch for the Linux kernel. > It fixes a style issue which was reported by using checkpatch.pl on > drivers/staging/comedi/drivers/adl_pci9118.c > > Although it

My first patch - patch for adl_pci9118.c

Hi there, this morning i created my first patch for the Linux kernel. It fixes a style issue which was reported by using checkpatch.pl on drivers/staging/comedi/drivers/adl_pci9118.c Although it's a very small patch, i hope this is useful. My question now is: how can i submit the patch

Re: Problem in First-Patch-Tutorial

On Sun, Mar 19, 2017 at 6:53 PM, Alexander Kapshuk wrote: > On Sun, Mar 19, 2017 at 10:53 AM, SIMRAN SINGHAL > wrote: >> # modinfo iio_dummy_evgen.ko >> filename: >> /home/simran/git/kernels/staging/drivers/iio/dummy/iio_dummy_evgen.ko >>

Re: Problem in First-Patch-Tutorial

On Sun, Mar 19, 2017 at 10:53 AM, SIMRAN SINGHAL wrote: > # modinfo iio_dummy_evgen.ko > filename: > /home/simran/git/kernels/staging/drivers/iio/dummy/iio_dummy_evgen.ko > license:GPL v2 > description:IIO dummy driver > author: Jonathan Cameron

Re: Problem in First-Patch-Tutorial

# modinfo iio_dummy_evgen.ko filename: /home/simran/git/kernels/staging/drivers/iio/dummy/iio_dummy_evgen.ko license:GPL v2 description:IIO dummy driver author: Jonathan Cameron srcversion: A8AC238EC07833E018CAF7B depends:industrialio intree:

Re: Problem in First-Patch-Tutorial

On Mon, 13 Mar 2017 15:38:07 +0530, SIMRAN SINGHAL said: > >> # modinfo iio_dummy_evgen.ko > >> filename: > >> vermagic: 4.11.0-rc1+ SMP mod_unload modversions > >> > >> > >> $ uname -r > >> 4.10.0-rc3+ > Greg, I got that I have to build the module against the kernel I am using. > But,

Re: Problem in First-Patch-Tutorial

Seems like these tasks are all part of outreachy program and you are supposed to be submitting it to the outreachy mailing list.: https://kernelnewbies.org/IIO_tasks one of the task is learning how to compile your own module, which is better explained in

Re: Problem in First-Patch-Tutorial

On Mon, Mar 13, 2017 at 12:08 PM, SIMRAN SINGHAL wrote: > On Mon, Mar 13, 2017 at 1:05 PM, Greg KH wrote: >> On Mon, Mar 13, 2017 at 11:39:36AM +0530, SIMRAN SINGHAL wrote: >>> On Mon, Mar 13, 2017 at 10:42 AM, Alexander Kapshuk >>>

Re: Problem in First-Patch-Tutorial

On Mon, Mar 13, 2017 at 1:05 PM, Greg KH wrote: > On Mon, Mar 13, 2017 at 11:39:36AM +0530, SIMRAN SINGHAL wrote: >> On Mon, Mar 13, 2017 at 10:42 AM, Alexander Kapshuk >> wrote: >> > On Mon, Mar 13, 2017 at 6:18 AM, SIMRAN SINGHAL >> >

Re: Problem in First-Patch-Tutorial

On Mon, Mar 13, 2017 at 11:39:36AM +0530, SIMRAN SINGHAL wrote: > On Mon, Mar 13, 2017 at 10:42 AM, Alexander Kapshuk > wrote: > > On Mon, Mar 13, 2017 at 6:18 AM, SIMRAN SINGHAL > > wrote: > >> On Mon, Mar 13, 2017 at 12:05 AM, Alexander

Re: Problem in First-Patch-Tutorial

On Mon, Mar 13, 2017 at 8:09 AM, SIMRAN SINGHAL wrote: > On Mon, Mar 13, 2017 at 10:42 AM, Alexander Kapshuk > wrote: >> On Mon, Mar 13, 2017 at 6:18 AM, SIMRAN SINGHAL >> wrote: >>> On Mon, Mar 13, 2017 at 12:05

Re: Problem in First-Patch-Tutorial

On Mon, Mar 13, 2017 at 10:42 AM, Alexander Kapshuk wrote: > On Mon, Mar 13, 2017 at 6:18 AM, SIMRAN SINGHAL > wrote: >> On Mon, Mar 13, 2017 at 12:05 AM, Alexander Kapshuk >> wrote: >>> On Sun, Mar 12, 2017 at

Re: Problem in First-Patch-Tutorial

On Mon, Mar 13, 2017 at 6:18 AM, SIMRAN SINGHAL wrote: > On Mon, Mar 13, 2017 at 12:05 AM, Alexander Kapshuk > wrote: >> On Sun, Mar 12, 2017 at 8:20 PM, SIMRAN SINGHAL >> wrote: >>> On Sun, Mar 12, 2017 at 10:15

Re: Problem in First-Patch-Tutorial

On Mon, Mar 13, 2017 at 12:05 AM, Alexander Kapshuk wrote: > On Sun, Mar 12, 2017 at 8:20 PM, SIMRAN SINGHAL > wrote: >> On Sun, Mar 12, 2017 at 10:15 PM, Alexander Kapshuk >> wrote: >>> On Sun, Mar 12, 2017 at

Re: Problem in First-Patch-Tutorial

On Sun, Mar 12, 2017 at 8:20 PM, SIMRAN SINGHAL wrote: > On Sun, Mar 12, 2017 at 10:15 PM, Alexander Kapshuk > wrote: >> On Sun, Mar 12, 2017 at 5:34 PM, wrote: >>> On Sun, 12 Mar 2017 15:49:31 +0200, Alexander

Re: Problem in First-Patch-Tutorial

On Sun, Mar 12, 2017 at 10:15 PM, Alexander Kapshuk wrote: > On Sun, Mar 12, 2017 at 5:34 PM, wrote: >> On Sun, 12 Mar 2017 15:49:31 +0200, Alexander Kapshuk said: >> >>> Are these drivers, drivers/iio/dummy/{iio_dummy_evgen,iio_dummy}.ko,

Re: Problem in First-Patch-Tutorial

On Sun, Mar 12, 2017 at 5:34 PM, wrote: > On Sun, 12 Mar 2017 15:49:31 +0200, Alexander Kapshuk said: > >> Are these drivers, drivers/iio/dummy/{iio_dummy_evgen,iio_dummy}.ko, >> something of your own making, as I'm not seeing them in the kernel >> source tree? >> >> The

Re: Problem in First-Patch-Tutorial

On Sun, 12 Mar 2017 15:49:31 +0200, Alexander Kapshuk said: > Are these drivers, drivers/iio/dummy/{iio_dummy_evgen,iio_dummy}.ko, > something of your own making, as I'm not seeing them in the kernel > source tree? > > The 'modules_install' make target installs drivers that have been > compiled

Re: Problem in First-Patch-Tutorial

On Sun, Mar 12, 2017 at 12:00 PM, SIMRAN SINGHAL wrote: > Reloading Modules > > make -j2 && sudo make modules_install > sudo modprobe -r > sudo modprobe > > In Reloading Modules I tried the first command it works fine for me. > > git/kernels/staging$ ls

Re: Problem in First-Patch-Tutorial

Hi, On Sun, 12. Mar 17:58, SIMRAN SINGHAL wrote: > On Sun, Mar 12, 2017 at 5:57 PM, SIMRAN SINGHAL > wrote: > > On Sun, Mar 12, 2017 at 5:55 PM, Lino Sanfilippo > > wrote: > >> Hi, > >> > >> On 12.03.2017 13:15, SIMRAN SINGHAL wrote: > >>> On

Re: Problem in First-Patch-Tutorial

On Sun, Mar 12, 2017 at 5:57 PM, SIMRAN SINGHAL wrote: > On Sun, Mar 12, 2017 at 5:55 PM, Lino Sanfilippo > wrote: >> Hi, >> >> On 12.03.2017 13:15, SIMRAN SINGHAL wrote: >>> On Sun, Mar 12, 2017 at 4:04 PM, Varsha Rao

Re: Problem in First-Patch-Tutorial

On Sun, Mar 12, 2017 at 5:55 PM, Lino Sanfilippo wrote: > Hi, > > On 12.03.2017 13:15, SIMRAN SINGHAL wrote: >> On Sun, Mar 12, 2017 at 4:04 PM, Varsha Rao wrote: >>> Hello Simran, >>> In Reloading Modules I tried the first command it works fine

Re: Problem in First-Patch-Tutorial

Hi, On 12.03.2017 13:15, SIMRAN SINGHAL wrote: > On Sun, Mar 12, 2017 at 4:04 PM, Varsha Rao wrote: >> Hello Simran, >> >>> In Reloading Modules I tried the first command it works fine for me. >>> >>> git/kernels/staging$ ls drivers/iio/dummy/*.ko >>>

Re: Problem in First-Patch-Tutorial

On Sun, Mar 12, 2017 at 4:04 PM, Varsha Rao wrote: > Hello Simran, > >> In Reloading Modules I tried the first command it works fine for me. >> >> git/kernels/staging$ ls drivers/iio/dummy/*.ko >> drivers/iio/dummy/iio_dummy_evgen.ko drivers/iio/dummy/iio_dummy.ko >> >>

Re: Problem in First-Patch-Tutorial

Hello Simran, > In Reloading Modules I tried the first command it works fine for me. > > git/kernels/staging$ ls drivers/iio/dummy/*.ko > drivers/iio/dummy/iio_dummy_evgen.ko drivers/iio/dummy/iio_dummy.ko > > Then I tried to run second-command > > git/kernels/staging$ sudo modprobe -r

Problem in First-Patch-Tutorial

Reloading Modules make -j2 && sudo make modules_install sudo modprobe -r sudo modprobe In Reloading Modules I tried the first command it works fine for me. git/kernels/staging$ ls drivers/iio/dummy/*.ko drivers/iio/dummy/iio_dummy_evgen.ko drivers/iio/dummy/iio_dummy.ko Then I tried to run

Sending your first patch[FYI]

Hi all, This is not really a question but I am sharing this article written by Julia about how to send your first patch. This question is asked quite a bit lot here on this list and I have not seen this article before. This has a lot of useful and practical info, please feel free to share

No response to first patch, is my patch correct?

Hi, I followed the "Write and Submit your first Linux kernel Patch" tutorial by Greg Kroah-Hartman [1] and tried to submit my first (clean up) patch [2]. However, I did not get any response, so I sent it again [3]. Once again, I haven't gotten any response. Am I doing anything wrong, or should I

Re: No response to first patch, is my patch correct?

On Tue, Jan 26, 2016 at 12:01 PM, Sushuruth Sadagopan wrote: > Hi, > > I followed the "Write and Submit your first Linux kernel Patch" tutorial > by Greg > Kroah-Hartman [1] and tried to submit my first (clean up) patch [2]. > However, > I did not get any response, so I sent

Re: first patch

On Wed Dec 23 15, maoma king wrote: > Dear > I have sent my first patch (https://lkml.org/lkml/2015/11/18/239) to > linux-next tree.But I never received anything about it.So I sent it > again. You say "Doesn't apply to my tree :(".but it can be apply to > least linux-nex

first patch

Dear I have sent my first patch (https://lkml.org/lkml/2015/11/18/239) to linux-next tree.But I never received anything about it.So I sent it again. You say "Doesn't apply to my tree :(".but it can be apply to least linux-next branch . I make n new patch and send it.I receive re

Re: first patch

On Wed, Dec 23, 2015 at 11:37:14AM +0800, maoma king wrote: > Dear > I have sent my first patch (https://lkml.org/lkml/2015/11/18/239) to > linux-next tree.But I never received anything about it.So I sent it > again. You say "Doesn't apply to my tree :(".but it can be apply

Re: Question about "Creating first patch" guide

On Wed, Sep 23, 2015 at 07:22:08PM +, Rob Groner wrote: > The OutreachyfirstpatchSetup has been very helpful in setting up my computer > to > develop a patch to submit to the kernel overlords. > > > > I’m at the point where I’ve changed the kernel code, ran and test it, and see > just my

Re: Is this a good first patch for enabling screen rotation?

Hello Valdis Sorry for such a late reply and thank you for such a quick reply. On Thu, 2015-01-29 at 12:12 -0500, valdis.kletni...@vt.edu wrote: On Fri, 30 Jan 2015 00:45:30 +0800, Brock York said: (Note, I don't have an Acer, nor am I an HID expert... so take this all with a grain of

Is this a good first patch for enabling screen rotation?

Hello This is my first patch and after speaking to a few kernel devs at LCA2015 I thought I would ask here for some advice on if I have followed the newbie guide correctly. The patch is to get automatic screen rotation working on a acer iconia w500 tablet. The patch was made against linux-next

Re: Is this a good first patch for enabling screen rotation?

On Fri, 30 Jan 2015 00:45:30 +0800, Brock York said: (Note, I don't have an Acer, nor am I an HID expert... so take this all with a grain of salt...) Swap the x and y values and negate the x value converting the accelerometers coordinate system into the coordinate system userspace udev

Re: Submitted a first patch and no reply

Hi, Actually on the website it's return that Pick a warning, and try to fix it. For your first patch, only pick one warning. In the future you can group multiple changes into one patch, but only if you follow the PatchPhilosophy http://kernelnewbies.org/PatchPhilosophy of breaking each patch

Re: Submitted a first patch and no reply

On Thu, 2015-01-08 at 15:49 -0500, valdis.kletni...@vt.edu wrote: On Thu, 08 Jan 2015 12:37:15 -0800, shirish gajera said: That's hwy I just fix one warning. That means don't fix a warning about indentation *and* a warning about trailing blanks in the same patch. Also, if you're

Re: Submitted a first patch and no reply

On Thu, 08 Jan 2015 12:37:15 -0800, shirish gajera said: That's hwy I just fix one warning. That means don't fix a warning about indentation *and* a warning about trailing blanks in the same patch. Also, if you're fixing a style issue, you should actually *review* the code, and make sure you

Re: Submitted a first patch and no reply

I will make necessary and try to re- submit the patch. On Thu, Jan 8, 2015 at 1:14 PM, Joe Perches j...@perches.com wrote: On Thu, 2015-01-08 at 15:49 -0500, valdis.kletni...@vt.edu wrote: On Thu, 08 Jan 2015 12:37:15 -0800, shirish gajera said: That's hwy I just fix one warning.

Submitted a first patch and no reply

Hi, I have submitted my first patch on 12/30/2014 and I have not received any reply for next step like error or merge ect. I send the email to person that get_maintainer.pl script tells me to send. Please guide whom should I reached for this. Below is the email - This patch fixes

Re: Submitted a first patch and no reply

On Thu, 08 Jan 2015 12:00:07 -0800, shirish gajera said: WARNING: Single statement macros should not use a do {} while (0) loop I have added single statement in curly braces, because it was giving me WARNING: macros should not use a trailing semicolon. Signed-off-by: Shirish Gajera

Re: Advice on first patch

...but davem wanted to keep it as documentation. Who could have imagined that? That's how things work. Just find something else to fix. Sooner or later you will get a patch accepted :-) But you might consider taking his (hidden) advise and look for something more challenging than checkpatch

Re: Advice on first patch

: I'm hopefully going to be submitting the attached patch to the mainline kernel tree, and as it's my first patch, I figured it would be wise to run it past KN first in case I'd done something monumentally stupid! I found it through a checkpatch run, from the excellent talk by GregKH at FOSDEM

Advice on first patch

I'm hopefully going to be submitting the attached patch to the mainline kernel tree, and as it's my first patch, I figured it would be wise to run it past KN first in case I'd done something monumentally stupid! I found it through a checkpatch run, from the excellent talk by GregKH at FOSDEM

Re: Advice on first patch

matt...@walster.org writes: I'm hopefully going to be submitting the attached patch to the mainline kernel tree, and as it's my first patch, I figured it would be wise to run it past KN first in case I'd done something monumentally stupid! I found it through a checkpatch run, from

Re: Advice on first patch

On 2 October 2012 12:29, Bjørn Mork bj...@mork.no wrote: matt...@walster.org writes: I'm hopefully going to be submitting the attached patch to the mainline kernel tree, and as it's my first patch, I figured it would be wise to run it past KN first in case I'd done something