Re: Using binary attributes for configuration sysfs entries

2019-03-14 Thread Jay Aurabind
On Thu, 14 Mar 2019 at 20:27, Greg KH wrote: > > On Thu, Mar 14, 2019 at 04:17:13PM +0530, Jay Aurabind wrote: > > On Wed, 13 Mar 2019 at 19:55, Greg KH wrote: > > > > > > On Wed, Mar 13, 2019 at 12:02:02PM +0530, Jay Aurabind wrote: > > > > Hi, > > > > > > > > Before I send this patch to actual

Re: Using binary attributes for configuration sysfs entries

2019-03-14 Thread Greg KH
On Thu, Mar 14, 2019 at 04:17:13PM +0530, Jay Aurabind wrote: > On Wed, 13 Mar 2019 at 19:55, Greg KH wrote: > > > > On Wed, Mar 13, 2019 at 12:02:02PM +0530, Jay Aurabind wrote: > > > Hi, > > > > > > Before I send this patch to actual mailing list, I'd appreciate if > > > someone could tell me

Re: Using binary attributes for configuration sysfs entries

2019-03-14 Thread Jay Aurabind
On Wed, 13 Mar 2019 at 19:55, Greg KH wrote: > > On Wed, Mar 13, 2019 at 12:02:02PM +0530, Jay Aurabind wrote: > > Hi, > > > > Before I send this patch to actual mailing list, I'd appreciate if > > someone could tell me if this is a bad idea! > > > > The driver in staging for pi433 (a wireless

Re: Using binary attributes for configuration sysfs entries

2019-03-13 Thread Greg KH
On Wed, Mar 13, 2019 at 12:02:02PM +0530, Jay Aurabind wrote: > Hi, > > Before I send this patch to actual mailing list, I'd appreciate if > someone could tell me if this is a bad idea! > > The driver in staging for pi433 (a wireless transceiver) uses IOCTLs > at the moment. I wish to add a

Re: Using binary attributes for configuration sysfs entries

2019-03-13 Thread Jay Aurabind
Dear Valdis, Thank you for the response. Please see my inline queries: On Wed, 13 Mar 2019 at 12:26, wrote: > > On Wed, 13 Mar 2019 12:02:02 +0530, Jay Aurabind said: > > > For the corresponding sysfs interface, since there are a lot of > > parameters, would it be justified to use the same

Re: Using binary attributes for configuration sysfs entries

2019-03-13 Thread valdis . kletnieks
On Wed, 13 Mar 2019 12:02:02 +0530, Jay Aurabind said: > For the corresponding sysfs interface, since there are a lot of > parameters, would it be justified to use the same binary format though > sysfs_create_binary_file() ? The rationale is that it would be easier > to simply pack all the config

Using binary attributes for configuration sysfs entries

2019-03-13 Thread Jay Aurabind
Hi, Before I send this patch to actual mailing list, I'd appreciate if someone could tell me if this is a bad idea! The driver in staging for pi433 (a wireless transceiver) uses IOCTLs at the moment. I wish to add a sysfs interface to it that control the various transmission and reception