Re: [Kicad-developers] New version of net selector up

2018-09-25 Thread Andrzej Wolski
It is better now, but I still have some artifacts (Win 10), see here: https://www.dropbox.com/s/l671nfmdtikbmlq/kicad%202018-09-25%2023-05-52.mov?dl=0 Andrzej W dniu 2018-09-25 o 18:57, Jeff Young pisze: Thanks, JP. I’ve pushed another “fix”. It works on OSX, but then so did the first one,

Re: [Kicad-developers] New version of net selector up

2018-09-25 Thread Andrzej Wolski
ent fixes to the Net Selector on GTK, so let’s make sure you’ve got that code first. Neither Seth nor I have MSW, so all bets are off there…. Cheers, Jeff. On 25 Sep 2018, at 11:09, Andrzej Wolski wrote: Hi Jeff, net selector seems to no longer work on Windows and Linux. When I try to drop it d

Re: [Kicad-developers] New version of net selector up

2018-09-25 Thread Andrzej Wolski
to the Net Selector on GTK, so let’s make sure you’ve got that code first. Neither Seth nor I have MSW, so all bets are off there…. Cheers, Jeff. On 25 Sep 2018, at 11:09, Andrzej Wolski wrote: Hi Jeff, net selector seems to no longer work on Windows and Linux. When I try to drop it down it jus

Re: [Kicad-developers] New version of net selector up

2018-09-25 Thread Andrzej Wolski
there…. Cheers, Jeff. On 25 Sep 2018, at 11:09, Andrzej Wolski wrote: Hi Jeff, net selector seems to no longer work on Windows and Linux. When I try to drop it down it just flickers and folds back up. Andrzej W dniu 2018-09-21 o 21:43, Jeff Young pisze: I just pushed a new version of the net selector

Re: [Kicad-developers] New version of net selector up

2018-09-25 Thread Andrzej Wolski
Hi Jeff, net selector seems to no longer work on Windows and Linux. When I try to drop it down it just flickers and folds back up. Andrzej W dniu 2018-09-21 o 21:43, Jeff Young pisze: I just pushed a new version of the net selector combobox. It’s a complete re-write using less wxStuff, and

Re: [Kicad-developers] [PATCH] GAL: Draw hole even if pad has no layer

2018-06-25 Thread Andrzej Wolski
Hi, if by submitter you mean me, then this is a board I found on Github, I don't know if it was manually edited. But I have done a little investigation, and I think I've found the source of this problem. The problematic footprint is identical to the one that can be downloaded from SnapEDA:

Re: [Kicad-developers] [PATCH] GAL: Draw hole even if pad has no layer

2018-06-23 Thread Andrzej Wolski
-06-23 o 08:54, jp charras pisze: Le 22/06/2018 à 21:54, Andrzej Wolski a écrit : No, this IS an error in the board :) If you open pad properties and click OK, it won't let you save it as is, you will have to enable copper layers. NPTH pads also HAVE TO exists on copper layers (I don't understand

Re: [Kicad-developers] [PATCH] Fix overbar drawing for non-italic text

2018-06-23 Thread Andrzej Wolski
should be continuous (no breaks between characters). Did you test this as well. If this needs fixed, I would like to get it merged for rc3. Anyone else have any thoughts on this. Cheers, Wayne On 06/22/2018 10:35 AM, Andrzej Wolski wrote: No, the patch didn't go the wrong way. If you try

Re: [Kicad-developers] [PATCH] GAL: Draw hole even if pad has no layer

2018-06-22 Thread Andrzej Wolski
of drawing one with no layers. -S Am Fr., 22. Juni 2018 um 12:33 Uhr schrieb Andrzej Wolski mailto:awolski.ki...@gmail.com>>: IIRC you have to leave (layers) to reproduce this. This is a board where I found the issue: https://github.com/mntmn/reform/blob/master/electronics/

Re: [Kicad-developers] [PATCH] GAL: Draw hole even if pad has no layer

2018-06-22 Thread Andrzej Wolski
it was only the test board I used? -S Am Fr., 22. Juni 2018 um 10:51 Uhr schrieb Andrzej Wolski mailto:awolski.ki...@gmail.com>>: Hi Seth, current behavior is that malformed pad holes are always hidden, so you can't see on the screen something that exists on yo

Re: [Kicad-developers] [PATCH] GAL: Draw hole even if pad has no layer

2018-06-22 Thread Andrzej Wolski
Those pads are shown in 4.0 GAL and in 5.0 legacy, only 5.0 GAL has this problem, so to me this is a regression fix rather than workaround. Fixing those pads may be a good idea, but that is another matter. Andrzej W dniu 2018-06-22 o 20:03, jp charras pisze: Le 22/06/2018 à 19:51, Andrzej

Re: [Kicad-developers] [PATCH] GAL: Draw hole even if pad has no layer

2018-06-22 Thread Andrzej Wolski
explain the issue that this patch addresses?  I read the commit message but it looks like malformed pads (GetLayerSet().any() == 0) are no longer hidden.  This seems counter-intuitive but maybe I'm just not seeing the problem. Thanks! Seth​ Am Fr., 22. Juni 2018 um 03:57 Uhr schrieb Andrzej

Re: [Kicad-developers] [PATCH] Fix overbar drawing for non-italic text

2018-06-22 Thread Andrzej Wolski
On 2018-06-22 07:01 AM, Andrzej Wolski wrote: This is an illustration of what this patch do: https://imgur.com/a/GxIeLkA Hm... did the patch go the wrong way with the change to the position and length of the bar over non-italicized text? Before the bar started at the left side of the letter a

[Kicad-developers] [PATCH] GAL: Draw hole even if pad has no layer

2018-06-22 Thread Andrzej Wolski
From d82e05f3328c95cb4443af7a2c0040ff1766fc96 Mon Sep 17 00:00:00 2001 From: Andrzej Wolski Date: Fri, 22 Jun 2018 12:07:56 +0200 Subject: [PATCH] GAL: Draw hole even if pad has no layer While pcbnew does not allow to create THT pad without a copper layer, there are boards that somehow have

Re: [Kicad-developers] [PATCH] Fix overbar drawing for non-italic text

2018-06-22 Thread Andrzej Wolski
This is an illustration of what this patch do: https://imgur.com/a/GxIeLkA Andrzej ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More

[Kicad-developers] [PATCH] Save through hole pads color to config file

2018-06-22 Thread Andrzej Wolski
From ebfb1d5cc9ebdeddaa518f14e7c86b7e5c1bbdaa Mon Sep 17 00:00:00 2001 From: Andrzej Wolski Date: Fri, 22 Jun 2018 01:35:05 +0200 Subject: [PATCH] Save through hole pads color to config file TH Pads color is now user settable, so should be saved in config file. --- common

[Kicad-developers] [PATCH] Fix overbar drawing for non-italic text

2018-06-22 Thread Andrzej Wolski
From db2243f6fff9f1666049b501f45f582c2837caf2 Mon Sep 17 00:00:00 2001 From: Andrzej Wolski Date: Fri, 22 Jun 2018 12:51:53 +0200 Subject: [PATCH] Fix overbar drawing for non-italic text Overbar was always indented inward, regardless if text was italic or not. --- common/gal/stroke_font.cpp

[Kicad-developers] [PATCH] Do not plot zero width oval holes in Gerber X2 drill, files

2018-06-17 Thread Andrzej Wolski
From 2be418ff0ef219960d53d5252d331b6def443bd0 Mon Sep 17 00:00:00 2001 From: Andrzej Wolski Date: Sun, 17 Jun 2018 14:37:49 +0200 Subject: [PATCH 2/2] Do not plot zero width oval holes in Gerber X2 drill files In case there are zero width oval holes on the PCB, it is safer to not plot them

[Kicad-developers] [PATCH] Do not allow setting zero Y size for oval holes

2018-06-17 Thread Andrzej Wolski
From 348f5456d427e22c16577fbfe3712052249e9aa2 Mon Sep 17 00:00:00 2001 From: Andrzej Wolski Date: Sun, 17 Jun 2018 14:29:26 +0200 Subject: [PATCH 1/2] Do not allow setting zero Y size for oval holes --- pcbnew/dialogs/dialog_pad_properties.cpp | 3 ++- 1 file changed, 2 insertions(+), 1

Re: [Kicad-developers] Selection filtering, and other missing GAL functionality

2018-03-08 Thread Andrzej Wolski
Legacy-like selection filter is already present in GAL: after selecting - right click and choose Select -> Filter Selection. Andrzej W dniu 2018-03-07 o 23:20, Jon Evans pisze: Hi all, As part of preparing a new 6.0 roadmap, I want to make sure we have all functionality that only exists in

Re: [Kicad-developers] [PATCH] Rework footprint selection filtering to improve behavior

2018-03-05 Thread Andrzej Wolski
, 2018 at 3:29 PM, Andy Peters <de...@latke.net <mailto:de...@latke.net>> wrote: On Mar 2, 2018, at 10:28 AM, Andrzej Wolski <awolski.ki...@gmail.com <mailto:awolski.ki...@gmail.com>> wrote: Jon, I probably didn't express myself clearly. What I

Re: [Kicad-developers] [PATCH] Rework footprint selection filtering to improve behavior

2018-03-02 Thread Andrzej Wolski
to select footprints even if the "front pads" is hidden from layers like the paste layer, *unless* you are in high contrast mode. -Jon On Fri, Mar 2, 2018 at 3:53 AM, Andrzej Wolski <awolski.ki...@gmail.com <mailto:awolski.ki...@gmail.com>> wrote: I've tried this patch, an

Re: [Kicad-developers] [PATCH] Rework footprint selection filtering to improve behavior

2018-03-02 Thread Andrzej Wolski
I've tried this patch, and there is a small issue: if you have only eg front paste layer enabled and front pads are hidden, footprint is still selectable. Andrzej W dniu 2018-02-27 o 04:11, Jon Evans pisze: This patch changes the selection logic for footprints to fix a reported issue[1] and

[Kicad-developers] [PATCH] Restore some missing visibility items from board file

2018-03-01 Thread Andrzej Wolski
rom 9ccc36e2d0de45175e928bb70f14340392bd35be Mon Sep 17 00:00:00 2001 From: Andrzej Wolski <awolski.ki...@gmail.com> Date: Sat, 24 Feb 2018 21:51:33 +0100 Subject: [PATCH] Restore some missing visibility items from board file MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="2.7.4" This is a

Re: [Kicad-developers] Decimal separator characters

2018-02-25 Thread Andrzej Wolski
I wouldn't say it's rare. I have Kicad set to English language, so it displays ".", but numeric keyboard on my system puts ",". Andrzej W dniu 2018-02-26 o 00:10, Jeff Young pisze: I think we can close it for now. The patch only addresses one side of the issue (accepting a ‘.’ in a ‘,’

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

2018-02-25 Thread Andrzej Wolski
There is a similar issue with "New" and "Append Board" operations, but it existed way before Jon's improvements. I've created a bug report, so it not gets lost: https://bugs.launchpad.net/kicad/+bug/1751589 Andrzej W dniu 2018-02-23 o 13:18, jp charras pisze: Le 23/02/2018 à 01:04, Jon Evans

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

2018-02-24 Thread Andrzej Wolski
4. State of some checkboxes is not saved. Fix for that one in attachment. Andrzej >From 9ccc36e2d0de45175e928bb70f14340392bd35be Mon Sep 17 00:00:00 2001 From: Andrzej Wolski <awolski.ki...@gmail.com> Date: Sat, 24 Feb 2018 21:51:33 +0100 Subject: [PATCH] Restore some missing v

Re: [Kicad-developers] Fabrication Outputs and Plot

2018-02-24 Thread Andrzej Wolski
Cairo have PDF, SVG and Postscript support. I was once wondering if GAL/Cairo could be used for printing. Andrzej W dniu 2018-02-24 o 19:24, Jon Evans pisze: Yeah, there (at least) three different dialogs that all present similar things (i.e. a list of layers to include, settings, etc):

Re: [Kicad-developers] Non copper zones

2018-02-23 Thread Andrzej Wolski
 There are a number of missing features in the polygon tool that exist in the zone editor.  Adding corners is a large one. Cutouts would be a big regression. I think gr_poly is a single polygon and cannot have cutouts? Andrzej ___ Mailing

Re: [Kicad-developers] Non copper zones

2018-02-23 Thread Andrzej Wolski
can't draw a brand new one. -S 2018-02-23 17:07 GMT-08:00 Andrzej Wolski <awolski.ki...@gmail.com <mailto:awolski.ki...@gmail.com>>: Was it ever possible to run the fill algorithm (meaning, only fill in parts of a polygon outline, based on some clearance to

Re: [Kicad-developers] Non copper zones

2018-02-23 Thread Andrzej Wolski
 Does the polygon tool allow you to edit zones on non-copper layers or were zones on non-copper layers saved as polygons?  If the latter is the case then I'm guessing this change is not significant but if that is not the case then there could be some editing issues. Zones on non copper

Re: [Kicad-developers] Non copper zones

2018-02-23 Thread Andrzej Wolski
Was it ever possible to run the fill algorithm (meaning, only fill in parts of a polygon outline, based on some clearance to other items on the same layer) on a non-copper zone? No, I didn't mean it was already possible. Seth, yes I see that dialog too in old builds, but the outline

Re: [Kicad-developers] Non copper zones

2018-02-23 Thread Andrzej Wolski
a copper zone.  Even when using the zone tool, they behave like graphic polygons. Were you able to do this up until Orson's recent change?  If so, how do you do it? On Fri, Feb 23, 2018 at 7:23 PM, Andrzej Wolski <awolski.ki...@gmail.com <mailto:awolski.ki...@gmail.com>> wrote:    

Re: [Kicad-developers] Non copper zones

2018-02-23 Thread Andrzej Wolski
But setting the width of a graphical polygon to 0 removes the size issue Andrzej mentioned. But the you don't have them with rounded corners :) For filling vs. non-filling, I don't personally see the usefulness in having the fill algorithm run over a polygon that will always be filled. 

Re: [Kicad-developers] Non copper zones

2018-02-23 Thread Andrzej Wolski
copper zone.  Even when using the zone tool, they behave like graphic polygons. Were you able to do this up until Orson's recent change? If so, how do you do it? On Fri, Feb 23, 2018 at 7:23 PM, Andrzej Wolski <awolski.ki...@gmail.com <mailto:awolski.ki...@gmail.com>> wrote: Pol

Re: [Kicad-developers] Non copper zones

2018-02-23 Thread Andrzej Wolski
Is there any reason not to allow zones to be drawn on non-copper layers?  The changes you made in this commit would seem to indicate there was a reason not to allow this.  I'm going to hold off on rc1 until we get this resolved. Thanks, Wayne On 02/23/2018 06:10 PM

[Kicad-developers] Non copper zones

2018-02-23 Thread Andrzej Wolski
Hello, after this change: https://git.launchpad.net/kicad/commit/?id=fea71c9f8f02c59a05de19293a8ce5a55432527b I can no logner draw zones on non copper layers. Was that intentional? Andrzej ___ Mailing list: https://launchpad.net/~kicad-developers

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

2018-02-23 Thread Andrzej Wolski
Actually that logic was already there, I just fixed hiding non footprint items together with pads. Andrzej W dniu 2018-02-23 o 21:46, Jon Evans pisze: I'm fine with renaming to SMD pads. Right now the logic (implemented by Andrzej, not me by the way) assumes that all pads are associated with

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

2018-02-22 Thread Andrzej Wolski
with it, since Jeff isn't worried about conflicts? -Jon On Thu, Feb 22, 2018 at 9:53 AM, Wayne Stambaugh <stambau...@gmail.com <mailto:stambau...@gmail.com>> wrote: On 2/22/2018 9:10 AM, Andrzej Wolski wrote: > If some work on Render panel is still bei

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

2018-02-22 Thread Andrzej Wolski
t;mailto:stambau...@gmail.com>> wrote: On 2/22/2018 9:10 AM, Andrzej Wolski wrote: > If some work on Render panel is still being done, I would have some > suggestions: > 1. "Text Front" and "Text Back" should be renamed to something like > &q

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

2018-02-22 Thread Andrzej Wolski
3. It would be nice to have right click menu with something like:     "Show all footprint related"     "Hide all footprint related"     "Show all free primitives"     "Hide all free primitives"     "Show all other???"     "Hide all other???"     "Show all"     "Hide all" Don't we

Re: [Kicad-developers] [RFC] Change to object visibility system for usability/clarity

2018-02-22 Thread Andrzej Wolski
. On 22 Feb 2018, at 13:43, Andrzej Wolski <awolski.ki...@gmail.com> wrote: Wayne, thanks for merging. I have a complementary patch that fixes problem with selecting hidden tracks. Cheers, Andrzej On 02/21/2018 08:40 PM, Wayne Stambaugh wrote: Andrzej, I merged your patches. Hopefull

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

2018-02-22 Thread Andrzej Wolski
If some work on Render panel is still being done, I would have some suggestions: 1. "Text Front" and "Text Back" should be renamed to something like "Footpr. Text Front" It is misleading now. 2. "Bl/Bburied Via" and "Micro Via" could be hidden if they are disabled in design settings. 3. It

Re: [Kicad-developers] [RFC] Change to object visibility system for usability/clarity

2018-02-22 Thread Andrzej Wolski
for your contribution to KiCad. Cheers, Wayne On 2/21/2018 12:44 PM, Andrzej Wolski wrote: Wayne, in attachment all 3 patches I have, rebased. Cheers, Andrzej On 02/21/2018 05:45 PM, Wayne Stambaugh wrote: Andrzej, This patch does not apply cleanly.  Please rebase and resubmit it when you get

Re: [Kicad-developers] [PATCH] Use polygonal hit testing for module selection

2018-02-22 Thread Andrzej Wolski
nt of time, please let me know so I can >     back out your polygon hit test patch.  We need to be able to select >     footprints. > >     Thanks, > >     Wayne > >     On 2/21/2018 11:41 AM, Andrzej Wolski wrote: >     &g

Re: [Kicad-developers] [PATCH] Use polygonal hit testing for module selection

2018-02-21 Thread Andrzej Wolski
Seems to happen when there is no closed outline drawn in the footprint. Another test cases in an attachment. Andrzej W dniu 2018-02-21 o 17:41, Andrzej Wolski pisze: After this patch, I can no longer select some footprints by clicking inside their area. Please see the board in an attachment

Re: [Kicad-developers] [RFC] Change to object visibility system for usability/clarity

2018-02-21 Thread Andrzej Wolski
Wayne, in attachment all 3 patches I have, rebased. Cheers, Andrzej On 02/21/2018 05:45 PM, Wayne Stambaugh wrote: Andrzej, This patch does not apply cleanly. Please rebase and resubmit it when you get a chance. Thanks, Wayne On 2/21/2018 11:27 AM, Andrzej Wolski wrote: Wayne, I have

Re: [Kicad-developers] [PATCH] Use polygonal hit testing for module selection

2018-02-21 Thread Andrzej Wolski
After this patch, I can no longer select some footprints by clicking inside their area. Please see the board in an attachment. Andrzej W dniu 2018-02-20 o 16:44, Wayne Stambaugh pisze: Jon, I merged your patch. Thanks, Wayne On 2/18/2018 7:01 PM, Jon Evans wrote: Hi Wayne, In my testing

Re: [Kicad-developers] [RFC] Change to object visibility system for usability/clarity

2018-02-19 Thread Andrzej Wolski
It would also be great to see all the holes like in a drill file Something like this? :) http://bit.ly/2ojZEq7 Cheers, ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe :

Re: [Kicad-developers] [RFC] Change to object visibility system for usability/clarity

2018-02-19 Thread Andrzej Wolski
Patch (in attachment) for "Tracks" turned out to be very simple. If it gets accepted, I could make more of these. Andrzej On 02/19/2018 02:12 PM, Andrzej Wolski wrote: It would be also nice to have separate controls for: 1. Tracks 2. Drawing primitives (graphic lines, arcs, and

Re: [Kicad-developers] [RFC] Change to object visibility system for usability/clarity

2018-02-19 Thread Andrzej Wolski
It would be also nice to have separate controls for: 1. Tracks 2. Drawing primitives (graphic lines, arcs, and circles) 3. Zones 4. Polygons 5. Text (now there is control only for footprint text) 6. Dimensions 7. Plated holes That would make Render tab (almost) complete. Andrzej W dniu

Re: [Kicad-developers] Pads front and F.Cu visibility, possible bugs?

2018-02-17 Thread Andrzej Wolski
know 3. pads and layer share color setting, not necessarily opacity setting. Comments on these? >From 2c624e9ce413a6066c589c77cb0aedfeb2e0dea7 Mon Sep 17 00:00:00 2001 From: Andrzej Wolski <awolski.ki...@gmail.com> Date: Sat, 17 Feb 2018 23:53:44 +0100 Subject: [PATCH 2/2] Do not

[Kicad-developers] Zone vs polygon outline

2018-02-16 Thread Andrzej Wolski
Hello, there is an inconsistency between the way zones and polygons handle their outline. In zones outline is drawn on the inside, so the size of the zone is exactly the same as drawn by the user. In polygons, half of the width of the outline is added to the size of the polygon. Illustration

[Kicad-developers] [PATCH] Initialize color of vias netnames text

2018-01-15 Thread Andrzej Wolski
LAYER_VIAS_NETNAMES color was not initialized which resulted in black text, not visible in outline mode. This patch sets color to gray, similar to that on tracks when they have bright color. >From 811184477d0113f48fd18e6cbf4d4b72936c8617 Mon Sep 17 00:00:00 2001 From: Andrzej Wol