On 2018-06-22 10:35 AM, Andrzej Wolski wrote:
If you try to shorten the right side of the bar, for some characters it will
look really bad, and in case of "I" it will turn into dot.
This is before patch:
Thanks for the detailed before and after images. They more clearly show the
issues with
This patch looks good to me. I tried it and it looks better than without
on my machines.
-S
Am Sa., 23. Juni 2018 um 11:44 Uhr schrieb Maciej Suminski <
maciej.sumin...@cern.ch>:
> +1 for the patch. The change seems sensible just by looking at the raw
> diff and the presented images justify
+1 for the patch. The change seems sensible just by looking at the raw
diff and the presented images justify correctness.
Cheers,
Orson
On 06/23/2018 05:32 PM, Andrzej Wolski wrote:
> Wayne,
>
> this is after patch:
> https://imgur.com/a/54ESCMD
>
> Andrzej
>
> W dniu 2018-06-23 o 16:54,
Looks very good to me. I could nitpick aesthetics (I think it might be a
_little_ bit too long now) but that's just useless bikeshedding - it's
very clear and visible and balanced.
On Sat, Jun 23, 2018 at 12:00:04PM -0400, Wayne Stambaugh wrote:
> This looks correct to me. Is there something I'm
This looks correct to me. Is there something I'm missing here? I don't
pretend to be an expert on character rendering.
On 06/23/2018 11:32 AM, Andrzej Wolski wrote:
Wayne,
this is after patch:
https://imgur.com/a/54ESCMD
Andrzej
W dniu 2018-06-23 o 16:54, Wayne Stambaugh pisze:
Andrzej,
Wayne,
this is after patch:
https://imgur.com/a/54ESCMD
Andrzej
W dniu 2018-06-23 o 16:54, Wayne Stambaugh pisze:
Andrzej,
Do you have an image of the same characters after you patch? The other
question I have is what happens when consecutive characters have and
overbar? AFAIK, the overbar
Andrzej,
Do you have an image of the same characters after you patch? The other
question I have is what happens when consecutive characters have and
overbar? AFAIK, the overbar should be continuous (no breaks between
characters). Did you test this as well. If this needs fixed, I would
like to
No, the patch didn't go the wrong way.
If you try to shorten the right side of the bar, for some characters it
will look really bad, and in case of "I" it will turn into dot.
This is before patch:
https://imgur.com/a/TjibR0Q
Andrzej
W dniu 2018-06-22 o 15:40, Kevin Cozens pisze:
On
On 2018-06-22 07:01 AM, Andrzej Wolski wrote:
This is an illustration of what this patch do:
https://imgur.com/a/GxIeLkA
Hm... did the patch go the wrong way with the change to the position and
length of the bar over non-italicized text? Before the bar started at the
left side of the letter
This is an illustration of what this patch do:
https://imgur.com/a/GxIeLkA
Andrzej
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More
From db2243f6fff9f1666049b501f45f582c2837caf2 Mon Sep 17 00:00:00 2001
From: Andrzej Wolski
Date: Fri, 22 Jun 2018 12:51:53 +0200
Subject: [PATCH] Fix overbar drawing for non-italic text
Overbar was always indented inward, regardless if text was italic or not.
---
common/gal/stroke_font.cpp |
11 matches
Mail list logo
