Re: [Kicad-developers] Fix CMakeLists.txt

2018-07-27 Thread Aimylios
Hi Orson, perfect, thank you very much! Best regards, Marcus Am 27.07.2018 um 09:13 schrieb Maciej Sumiński: Hi Marcus, Actually my memory has let my down this time. I have just checked the patch on msys2 and it worked as expected, so I recommitted the original version. Sorry for the noise.

Re: [Kicad-developers] Fix CMakeLists.txt

2018-07-27 Thread Maciej Sumiński
Hi Marcus, Actually my memory has let my down this time. I have just checked the patch on msys2 and it worked as expected, so I recommitted the original version. Sorry for the noise. Cheers, Orson On 07/26/2018 11:36 PM, Aimylios wrote: > Hi Orson, > > thank you for taking the time to review

Re: [Kicad-developers] Fix CMakeLists.txt

2018-07-26 Thread Aimylios
Hi Orson, thank you for taking the time to review and merge my patches! Thank you for the patches, I have just merged them. I have slightly modified the last patch - I realize that you used the correct convention for calling execute_process(), but IIRC it did not work with msys2. Therefore I

Re: [Kicad-developers] Fix CMakeLists.txt

2018-07-26 Thread Maciej Suminski
Hi Marcus, Thank you for the patches, I have just merged them. I have slightly modified the last patch - I realize that you used the correct convention for calling execute_process(), but IIRC it did not work with msys2. Therefore I simply added the suggested ${wxWidgets_CONFIG_OPTIONS} to the

Re: [Kicad-developers] Fix CMakeLists.txt

2018-07-22 Thread Nick Østergaard
The patches look fin for me. I suggest you add the [PATCH] tag to your email title next time. Den lør. 21. jul. 2018 kl. 16.21 skrev Aimylios : > > Hi! > > While trying to build KiCad for Fedora 28 I discovered some minor > problems in the main CMakeLists.txt file. Patches attached. > > Best

[Kicad-developers] Fix CMakeLists.txt

2018-07-21 Thread Aimylios
Hi! While trying to build KiCad for Fedora 28 I discovered some minor problems in the main CMakeLists.txt file. Patches attached. Best regards, Marcus >From cbb85acdd95a6b4f91a8369f405a5ff841a424cf Mon Sep 17 00:00:00 2001 From: Marcus A Date: Sat, 21 Jul 2018 08:10:24 +0200 Subject: [PATCH