John,
On 5/6/2019 8:11 AM, John Beard wrote:
> On 03/05/2019 19:28, Wayne Stambaugh wrote:
>>
>> I'm guessing John used a later version of clang-format when he wrote the
>> commit hooks. John, any ideas how to fix this or do we force devs to
>> use clang-format > 3.8?
>
> I'm on Arch, so I have
On 06/05/2019 22:12, Wayne Stambaugh wrote:
On 5/6/2019 5:11 PM, John Beard wrote:
I still suggest to change it to false be default and allow developers to
manually align when they want (and then override the formatter). Then at
least the default behaviour is a valid formatting choice.
That
Looks good John, feel free to push the change.
Thanks,
Wayne
On 5/6/2019 5:35 PM, John Beard wrote:
> On 06/05/2019 22:12, Wayne Stambaugh wrote:
>> On 5/6/2019 5:11 PM, John Beard wrote:
>>> I still suggest to change it to false be default and allow developers to
>>> manually align when they
John,
On 5/6/2019 5:11 PM, John Beard wrote:
>
>
> On 06/05/2019 21:46, Wayne Stambaugh wrote:
>> John,
>>
>> On 5/6/19 4:09 PM, John Beard wrote:
>>> On 06/05/2019 17:51, Reece R. Pollack wrote:
John,
I've already jumped to clang-format 6.0, which is one of the optional
On 06/05/2019 21:46, Wayne Stambaugh wrote:
John,
On 5/6/19 4:09 PM, John Beard wrote:
On 06/05/2019 17:51, Reece R. Pollack wrote:
John,
I've already jumped to clang-format 6.0, which is one of the optional
installs for Mint 18. That works, once you get all the symlinks fixed,
Good to
We do use (and encourage) single-line cases when it’s more readable that way.
This particularly comes up when mapping or converting something, such as:
switch( aFaceId )
{
case FACE_SCH: name = KIFACE_PREFIX "eeschema";break;
case FACE_PCB: name =
John,
On 5/6/19 4:09 PM, John Beard wrote:
> On 06/05/2019 17:51, Reece R. Pollack wrote:
>> John,
>>
>> I've already jumped to clang-format 6.0, which is one of the optional
>> installs for Mint 18. That works, once you get all the symlinks fixed,
>
> Good to know, thanks for the update.
>
>>
On 06/05/2019 17:51, Reece R. Pollack wrote:
John,
I've already jumped to clang-format 6.0, which is one of the optional
installs for Mint 18. That works, once you get all the symlinks fixed,
Good to know, thanks for the update.
except it keeps wanting to reformat my switch statements like
John,
I've already jumped to clang-format 6.0, which is one of the optional installs
for Mint 18. That works, once you get all the symlinks fixed, except it keeps
wanting to reformat my switch statements like this, which is contrary to the
KiCad coding standards:
@@ -148,15 +130,9 @@ int
On 2019-05-06 8:11 a.m., John Beard wrote:
* Tell people to use 3.9 or later (actually I don't know what options we
have need what versions).
I recently found an online clang configuration tool as I'm thinking of
adding in git hooks to force a developer to follow a coding style we've
talked
On 03/05/2019 19:28, Wayne Stambaugh wrote:
I'm guessing John used a later version of clang-format when he wrote the
commit hooks. John, any ideas how to fix this or do we force devs to
use clang-format > 3.8?
I'm on Arch, so I have quite recent clang-format (8.0.0). This
particular option
Reece,
On 5/3/2019 2:09 PM, Reece R. Pollack wrote:
> Hi Wayne,
>
> No worries on formatting. As a senior professional software engineer I'm
> used to dealing with formal coding conventions and I'm keeping the web
> page open while I'm writing. I prefer the K style myself, but I'm not
> going to
Hi Wayne,
No worries on formatting. As a senior professional software engineer I'm
used to dealing with formal coding conventions and I'm keeping the web
page open while I'm writing. I prefer the K style myself, but I'm not
going to lose sleep over the differences.
I had a bit of trouble
Hi Reece,
Just a few comments on top of Jeff's reply since this will be your first
patch submission:
Please follow the coding style policy[1]. It saves a lot of back and
forth. There is also a git commit hook[2] which you can use to verify
your coding style is correct. You will have to have
Hi Reece,
You should code internal stuff in VECTOR2I rather than wxPoint. wxPoint should
only be used when going to the UI. (We’re trying to reduce our wxWidgets
dependencies, although this is very much a work in progress.)
If you do use UNIT_BINDER keep in mind that it’s not yet used in
15 matches
Mail list logo
