Re: [Kicad-developers] Patch: Legacy symbol read/write extraction; SCH_PLUGIN registry mechanism

2019-03-11 Thread Andrew Lutsenko
Hi Brian, I don't have any comments on specifics of the patch but I just wanted to let you know that I'm looking forward to this work being merged. Some time ago I suggested that KiCad moved to protobuf based file formats and even done

Re: [Kicad-developers] V6 merge priority

2019-03-11 Thread jp charras
Le 10/03/2019 à 01:59, Tomasz Wlostowski a écrit : > On 09/03/2019 19:03, Wayne Stambaugh wrote: >> Rather than try to figure out every possible merge combination, I'm >> going to prioritize things serially per editor. The highest priority >> are changes those that will or potentially impact

[Kicad-developers] Bus upgrades merge (was: V6 merge priority)

2019-03-11 Thread Jon Evans
Hi Wayne, I will rebase and post an updated branch soon. I will also generally be available to fix any bugs although will be offline for a few days at a time here and there for travel. If you would prefer, I could put the bus aliases feature behind a flag so that it is effectively disabled, and

Re: [Kicad-developers] On EESCHEMA symbol library plugins

2019-03-11 Thread Jon Evans
Hi Brian, I don't have any immediate comments on your technical suggestions, but I do want to say that having a database-backed library is a very nice feature to have and it's been on my idea list for a while (I miss this feature from commercial software). So I did want to say that your idea is

Re: [Kicad-developers] V6 merge priority

2019-03-11 Thread Wayne Stambaugh
Hey Jon, On 3/9/2019 5:58 PM, Jon Evans wrote: > Hi Wayne and the rest of the team, > > My code is located here: > https://github.com/craftyjon/kicad/tree/bus_upgrades > (I can rebase/format this as a patchset to make review easier if needed) Please rebase it when you get a chance. It

Re: [Kicad-developers] V6 merge priority

2019-03-11 Thread Wayne Stambaugh
Hi JP, On 3/11/2019 7:42 AM, jp charras wrote: > Le 10/03/2019 à 01:59, Tomasz Wlostowski a écrit : >> On 09/03/2019 19:03, Wayne Stambaugh wrote: >>> Rather than try to figure out every possible merge combination, I'm >>> going to prioritize things serially per editor. The highest priority >>>

Re: [Kicad-developers] V6 merge priority

2019-03-11 Thread jp charras
Le 11/03/2019 à 14:10, Wayne Stambaugh a écrit : > Hi JP, > > On 3/11/2019 7:42 AM, jp charras wrote: >> Le 10/03/2019 à 01:59, Tomasz Wlostowski a écrit : >>> On 09/03/2019 19:03, Wayne Stambaugh wrote: Rather than try to figure out every possible merge combination, I'm going to

Re: [Kicad-developers] V6 merge priority

2019-03-11 Thread Wayne Stambaugh
Hi Tom, On 3/9/2019 7:59 PM, Tomasz Wlostowski wrote: > On 09/03/2019 19:03, Wayne Stambaugh wrote: >> Rather than try to figure out every possible merge combination, I'm >> going to prioritize things serially per editor. The highest priority >> are changes those that will or potentially impact

Re: [Kicad-developers] V6 merge priority

2019-03-11 Thread Jeff Young
> On 11 Mar 2019, at 13:17, Tomasz Wlostowski wrote: > > Should we remove the legacy code from pcbnew > sometime early during V6 cycle? > I would certainly be in favour of this. I keep tripping over the duplicate EDA_DRAW_FRAMEs when trying to debug (or use CLion’s “go to definition” or

Re: [Kicad-developers] V6 merge priority

2019-03-11 Thread Tomasz Wlostowski
On 11/03/2019 14:41, Wayne Stambaugh wrote: > On 3/11/2019 9:17 AM, Tomasz Wlostowski wrote: >> On 11/03/2019 13:57, Wayne Stambaugh wrote: >>> Hi Tom, >>> >>> On 3/9/2019 7:59 PM, Tomasz Wlostowski wrote: On 09/03/2019 19:03, Wayne Stambaugh wrote: > Rather than try to figure out every

Re: [Kicad-developers] V6 merge priority

2019-03-11 Thread Tomasz Wlostowski
On 11/03/2019 13:57, Wayne Stambaugh wrote: > Hi Tom, > > On 3/9/2019 7:59 PM, Tomasz Wlostowski wrote: >> On 09/03/2019 19:03, Wayne Stambaugh wrote: >>> Rather than try to figure out every possible merge combination, I'm >>> going to prioritize things serially per editor. The highest priority

Re: [Kicad-developers] V6 merge priority

2019-03-11 Thread Wayne Stambaugh
On 3/11/2019 9:17 AM, Tomasz Wlostowski wrote: > On 11/03/2019 13:57, Wayne Stambaugh wrote: >> Hi Tom, >> >> On 3/9/2019 7:59 PM, Tomasz Wlostowski wrote: >>> On 09/03/2019 19:03, Wayne Stambaugh wrote: Rather than try to figure out every possible merge combination, I'm going to

[Kicad-developers] On EESCHEMA symbol library plugins

2019-03-11 Thread Brian
Hello everyone, tl;dr - hi, I'm new here and I'd like to suggest a couple small changes to make maintaining my private fork a little easier. Presuming I can present a concise patch that adheres to the coding standard, what's the right way to propose it? ===Background=== I've been

Re: [Kicad-developers] Bus upgrades merge (was: V6 merge priority)

2019-03-11 Thread Nick Østergaard
If you do decide to merge but disable by default, please consider to use the kicad_advanced config. man. 11. mar. 2019 15.06 skrev Jon Evans : > Hi Wayne, > > I will rebase and post an updated branch soon. > I will also generally be available to fix any bugs although will be > offline for a few

[Kicad-developers] Idea: Merging libraries along the search path

2019-03-11 Thread Simon Richter
Hi, since the topic of library management came up: Would it make sense to collect library contents along the library search path? The search path would always be - project libraries (stored in the project folder) - user libraries (stored in the user home) - organization libraries -

Re: [Kicad-developers] On EESCHEMA symbol library plugins

2019-03-11 Thread Wayne Stambaugh
Hi Brian, On 3/11/2019 9:58 AM, Brian wrote: > Hello everyone, > > tl;dr - hi, I'm new here and I'd like to suggest a couple small changes > to make maintaining my private fork a little easier. Presuming I can > present a concise patch that adheres to the coding standard, what's the > right way

Re: [Kicad-developers] Idea: Merging libraries along the search path

2019-03-11 Thread José Ignacio
I like this, though if the UI is not made carefully it has the potential to be confusing. On Mon, Mar 11, 2019 at 10:13 AM Simon Richter wrote: > Hi, > > since the topic of library management came up: Would it make sense to > collect library contents along the library search path? > > The

Re: [Kicad-developers] Bus upgrades merge (was: V6 merge priority)

2019-03-11 Thread Wayne Stambaugh
Jon, On 3/11/2019 9:55 AM, Jon Evans wrote: > Hi Wayne, > > I will rebase and post an updated branch soon. Thanks! I should have time to review and test this weekend. > I will also generally be available to fix any bugs although will be > offline for a few days at a time here and there for

Re: [Kicad-developers] On EESCHEMA symbol library plugins

2019-03-11 Thread Seth Hillbrand
On Mon, Mar 11, 2019 at 9:59 AM Brian wrote: Hello everyone, tl;dr - hi, I'm new here and I'd like to suggest a couple small changes to make maintaining my private fork a little easier. Presuming I can present a concise patch that adheres to the coding standard, what's the right way to

Re: [Kicad-developers] Idea: Merging libraries along the search path

2019-03-11 Thread Rene Pöschl
On 11/03/19 16:13, Simon Richter wrote: This would solve the problem where users modify parts from shipped libraries and cannot save back because they are read-only I am not sure about that one to be honest. But i can see reason behind it and would also ensure that projects contain all parts

[Kicad-developers] Patch: Legacy symbol read/write extraction; SCH_PLUGIN registry mechanism

2019-03-11 Thread Brian
Hello everyone, Thank you for the kind, informative, and speedy responses to my previous message about schematic library code. Attached please find a gzipped patch generated by `git format-patch` for initial review and comment at your ("y'all's") leisure.  This patch both extracts legacy

Re: [Kicad-developers] Patch: Legacy symbol read/write extraction; SCH_PLUGIN registry mechanism

2019-03-11 Thread Brian
My apologies; I realize I didn't do a very good job of describing my changes.  So: -- Legacy read/write extraction: This one's rather straight-forward.  I pretty much just yanked all the code from SCH_LEGACY_PLUGIN_CACHE specific to parsing / writing legacy symbol format and stuffed it into

Re: [Kicad-developers] Patch: Legacy symbol read/write extraction; SCH_PLUGIN registry mechanism

2019-03-11 Thread Seth Hillbrand
Am 2019-03-11 17:46, schrieb Brian: -- Registry mechanism This one's a bit more involved and I welcome comment and discussion. Refer to eeschema/sch_io_plugin_registry.h/cpp. A new class called SCH_IO_PLUGIN_REGISTRY is a singleton which maintains a few indices of plugins.  In order to