Re: [Kicad-developers] Some first impressions on our tool framework

2019-05-06 Thread Seth Hillbrand
Am 2019-05-06 21:02, schrieb Tomasz Wlostowski: On 06/05/2019 09:48, Jeff Young wrote: 1) I hate the coroutines. They truncate backtraces in the debugger. Hi, How about using ucontext.h on Unices (Linux/OSX) and WinFiber API on Windows? I have working implementation of the latter already in

Re: [Kicad-developers] Some first impressions on our tool framework

2019-05-06 Thread Simon Richter
Hi, On 07.05.19 03:02, Tomasz Wlostowski wrote: > How about using ucontext.h on Unices (Linux/OSX) and WinFiber API on > Windows? I have working implementation of the latter already in the MSVC > branch. Are there any reasons to not use ucontext under Linux/OSX? Technically, these APIs are

Re: [Kicad-developers] Bug #1773638: The origins of 6.0 (pun intended)

2019-05-06 Thread Jon Evans
Hi Reece, I only have opinions on a few of your questions so far: 1. This seems logical to me 2. I agree this panel is getting full. Maybe we should start a "coordinates and grids" setting page, if we are eventually going to support custom grids, move the current grid settings there, and add

Re: [Kicad-developers] Some first impressions on our tool framework

2019-05-06 Thread Tomasz Wlostowski
On 06/05/2019 09:48, Jeff Young wrote: > 1) I hate the coroutines. They truncate backtraces in the debugger. Hi, How about using ucontext.h on Unices (Linux/OSX) and WinFiber API on Windows? I have working implementation of the latter already in the MSVC branch. Are there any reasons to not use

Re: [Kicad-developers] Pcbnew display origin transforms for v6

2019-05-06 Thread Wayne Stambaugh
John, On 5/6/2019 5:11 PM, John Beard wrote: > > > On 06/05/2019 21:46, Wayne Stambaugh wrote: >> John, >> >> On 5/6/19 4:09 PM, John Beard wrote: >>> On 06/05/2019 17:51, Reece R. Pollack wrote: John, I've already jumped to clang-format 6.0, which is one of the optional

Re: [Kicad-developers] Pcbnew display origin transforms for v6

2019-05-06 Thread John Beard
On 06/05/2019 21:46, Wayne Stambaugh wrote: John, On 5/6/19 4:09 PM, John Beard wrote: On 06/05/2019 17:51, Reece R. Pollack wrote: John, I've already jumped to clang-format 6.0, which is one of the optional installs for Mint 18. That works, once you get all the symlinks fixed, Good to

Re: [Kicad-developers] Pcbnew display origin transforms for v6

2019-05-06 Thread Wayne Stambaugh
Looks good John, feel free to push the change. Thanks, Wayne On 5/6/2019 5:35 PM, John Beard wrote: > On 06/05/2019 22:12, Wayne Stambaugh wrote: >> On 5/6/2019 5:11 PM, John Beard wrote: >>> I still suggest to change it to false be default and allow developers to >>> manually align when they

Re: [Kicad-developers] Some first impressions on our tool framework

2019-05-06 Thread Jeff Young
That would be very cool, because a lot of the rest of the framework is really nice. > On 6 May 2019, at 18:22, Tomasz Wlostowski wrote: > > On 06/05/2019 09:48, Jeff Young wrote: >> 1) I hate the coroutines. They truncate backtraces in the debugger. > > Hi Jeff, > > I'm thinking how to

Re: [Kicad-developers] Pcbnew display origin transforms for v6

2019-05-06 Thread John Beard
On 06/05/2019 17:51, Reece R. Pollack wrote: John, I've already jumped to clang-format 6.0, which is one of the optional installs for Mint 18. That works, once you get all the symlinks fixed, Good to know, thanks for the update. except it keeps wanting to reformat my switch statements like

Re: [Kicad-developers] Pcbnew display origin transforms for v6

2019-05-06 Thread Jeff Young
We do use (and encourage) single-line cases when it’s more readable that way. This particularly comes up when mapping or converting something, such as: switch( aFaceId ) { case FACE_SCH: name = KIFACE_PREFIX "eeschema";break; case FACE_PCB: name =

Re: [Kicad-developers] Pcbnew display origin transforms for v6

2019-05-06 Thread John Beard
On 06/05/2019 22:12, Wayne Stambaugh wrote: On 5/6/2019 5:11 PM, John Beard wrote: I still suggest to change it to false be default and allow developers to manually align when they want (and then override the formatter). Then at least the default behaviour is a valid formatting choice. That

Re: [Kicad-developers] Pcbnew display origin transforms for v6

2019-05-06 Thread Wayne Stambaugh
John, On 5/6/19 4:09 PM, John Beard wrote: > On 06/05/2019 17:51, Reece R. Pollack wrote: >> John, >> >> I've already jumped to clang-format 6.0, which is one of the optional >> installs for Mint 18. That works, once you get all the symlinks fixed, > > Good to know, thanks for the update. > >>

[Kicad-developers] Cross-probe: select or highlight?

2019-05-06 Thread Jeff Young
Eelik reported that our cross-probing is inconsistent. Symbols are highlighted while footprints are selected. Is there a reason for them being different? If not, I presume uniformly highlighting would be better than uniformly selecting? ___ Mailing

Re: [Kicad-developers] [PATCH] Replace remaining Boost Mutexes with std::mutex

2019-05-06 Thread John Beard
Hi Ian, On 05/05/2019 15:58, Ian McInerney wrote: I saw that on the todo list along with the auto_ptr replacement and decided to take a stab at it. Thank you for taking the initiative here, and thanks also for updating the TODO list! doing the auto_ptr replacement part since when I looked

[Kicad-developers] Symbol editing with the latest nightly build, new eeschema toolset - does it work?

2019-05-06 Thread Eeli Kaikkonen
A quick question. I can't edit symbols (the editor's tools don't work at all, at least graphic lines and pins) with the latest nightly build on Windows. Going back to 5.1.2 helps. Has anyone tried symbol editing with a version with modern toolset in eeschema? Or maybe it's not related to the

Re: [Kicad-developers] Symbol editing with the latest nightly build, new eeschema toolset - does it work?

2019-05-06 Thread Jeff Young
It doesn’t work for anyone in last night’s build. The mouse handling got lost in a recent merge. (It’s now fixed if you do your own build, or you can wait for tonight’s nightly.) Cheers, Jeff. > On 6 May 2019, at 12:06, Eeli Kaikkonen wrote: > > A quick question. I can't edit symbols (the

Re: [Kicad-developers] Cross-probe: select or highlight?

2019-05-06 Thread Nick Østergaard
I guess this is sort of related to the observation and response I got here: https://www.mail-archive.com/kicad-developers@lists.launchpad.net/msg27587.html Or maybe I misunderstand what exactly you mean. On Mon, 6 May 2019 at 12:38, Jeff Young wrote: > > Eelik reported that our cross-probing

Re: [Kicad-developers] eemodern branch

2019-05-06 Thread Wayne Stambaugh
The sheet tool is broken. The first click starts drawing the sheet as expected. The second click does not complete the sheet and show the sheet properties dialog and the sheet being drawn disappears. I can file a bug report if your prefer. Wayne On 5/5/19 4:32 PM, Michael Kavanagh wrote: >

Re: [Kicad-developers] eemodern branch

2019-05-06 Thread Jeff Young
No need. Reproduces for me. I’m on it. > On 6 May 2019, at 13:47, Wayne Stambaugh wrote: > > The sheet tool is broken. The first click starts drawing the sheet as > expected. The second click does not complete the sheet and show the > sheet properties dialog and the sheet being drawn

Re: [Kicad-developers] Pcbnew display origin transforms for v6

2019-05-06 Thread John Beard
On 03/05/2019 19:28, Wayne Stambaugh wrote: I'm guessing John used a later version of clang-format when he wrote the commit hooks. John, any ideas how to fix this or do we force devs to use clang-format > 3.8? I'm on Arch, so I have quite recent clang-format (8.0.0). This particular option

Re: [Kicad-developers] eemodern branch

2019-05-06 Thread Jeff Young
Fixed. (d12eee9c9876062e0463148a57f3b33ab016205f) > On 6 May 2019, at 13:48, Jeff Young wrote: > > No need. Reproduces for me. I’m on it. > >> On 6 May 2019, at 13:47, Wayne Stambaugh wrote: >> >> The sheet tool is broken. The first click starts drawing the sheet as >> expected. The

Re: [Kicad-developers] eemodern branch

2019-05-06 Thread Wayne Stambaugh
That was quick! Thanks Jeff. On 5/6/19 10:32 AM, Jeff Young wrote: > Fixed. (d12eee9c9876062e0463148a57f3b33ab016205f) > >> On 6 May 2019, at 13:48, Jeff Young wrote: >> >> No need. Reproduces for me. I’m on it. >> >>> On 6 May 2019, at 13:47, Wayne Stambaugh wrote: >>> >>> The sheet tool

[Kicad-developers] eemodern branch, "return" hotkey

2019-05-06 Thread Dino Ghilardi
Hello everybody, I've seen a "fast fix" an eemodern, so... The "return" hotkey for "left-click" is not working for me on 2d2b5f3e1915a270f2a51eb342f761df8b8a0122 doing a "paste" function. Reproducing it: -Select a block -ctrl-c for copy -ctrl-v for paste

[Kicad-developers] Some first impressions on our tool framework

2019-05-06 Thread Jeff Young
1) I hate the coroutines. They truncate backtraces in the debugger. 2) Having individual event loops for drawing, moving, etc. hugely improves encapsulation. 3) The improved encapsulation does make debugging easier overall. It’s still a pity about (1) though. 4) It can be a bit hard to

Re: [Kicad-developers] Pcbnew display origin transforms for v6

2019-05-06 Thread Kevin Cozens
On 2019-05-06 8:11 a.m., John Beard wrote: * Tell people to use 3.9 or later (actually I don't know what options we have need what versions). I recently found an online clang configuration tool as I'm thinking of adding in git hooks to force a developer to follow a coding style we've talked

Re: [Kicad-developers] eemodern branch, "return" hotkey

2019-05-06 Thread Jeff Young
Hi Dino, No need for a bug report for this one. Interestingly it was never implemented in the modern toolset for PCBNew either. I’m going to enable it for both and we’ll see what falls out. ;) Cheers, Jeff. > On 6 May 2019, at 16:10, Dino Ghilardi wrote: > > Hello everybody, I've seen a

Re: [Kicad-developers] Pcbnew display origin transforms for v6

2019-05-06 Thread Reece R. Pollack
John, I've already jumped to clang-format 6.0, which is one of the optional installs for Mint 18. That works, once you get all the symlinks fixed, except it keeps wanting to reformat my switch statements like this, which is contrary to the KiCad coding standards: @@ -148,15 +130,9 @@ int

Re: [Kicad-developers] Some first impressions on our tool framework

2019-05-06 Thread Wayne Stambaugh
Jeff, On 5/6/19 10:48 AM, Jeff Young wrote: > 1) I hate the coroutines. They truncate backtraces in the debugger. I'm not a big fan either but apparently they were the best solution for the P router design. I don't know if that is still the case or if we even tried a different solution at the

Re: [Kicad-developers] macOS build errors, swig?

2019-05-06 Thread Adam Wolf
Hi folks! I'm still not able to get anything to build on macOS, either 10.14 or 10.11. I keep getting: Error: the swig import helper was not fixed, check /vagrant/build/kicad/src/kicad-build/pcbnew/pcbnew.py and fix this script: fix_swig_imports.py Does anyone know anything more about this?

Re: [Kicad-developers] Some first impressions on our tool framework

2019-05-06 Thread Tomasz Wlostowski
On 06/05/2019 09:48, Jeff Young wrote: > 1) I hate the coroutines. They truncate backtraces in the debugger. Hi Jeff, I'm thinking how to improve this. Perhaps we can 'fix' a fake stack frame that will allow the debugger to unwind the stack past the coroutine entry point... Tom

Re: [Kicad-developers] Improving library editor checks

2019-05-06 Thread Wayne Stambaugh
If you are just doing the footprint checks then using the pcbnew python support should be fine. Whether or not it gets accepted into kicad depends on you commitment to maintaining it but you can always load and run it as a third party script. You will have to live with some api breakage from

Re: [Kicad-developers] macOS build errors, swig?

2019-05-06 Thread Adam Wolf
Sorry for the noise. It appears that we need to adjust that script for when new versions of swig come out. Homebrew recently updated to swig 4.0.0. I will see if I can version pin swig for the moment and come up with the patch to get swig 4.0.0 working. Adam On Mon, May 6, 2019 at 12:25 PM