Re: [Kicad-developers] [PATCH] Code style fix: three spaces to four spaces

2015-07-20 Thread Wayne Stambaugh
Your patch was committed in the product branch r5962. Thank you for your contribution to KiCad. Cheers, Wayne On 6/27/2015 4:23 PM, Ruben De Smet wrote: Hi, While trying to fix https://bugs.launchpad.net/kicad/+bug/1423515, I tripped over this simple code style error. You can look at

Re: [Kicad-developers] Modal dialogs

2015-07-20 Thread yann jautard
Le 19/07/2015 10:54, LordBlick a écrit : Why modal dialog from pcbnew(netlist) also blocks any operation in eeschema? This as to do with the new modular architecture. We had some discussion maybe one year ago with Dick on this subject and he did a change to correct this annoying behaviour

Re: [Kicad-developers] [PATCH] [Bug 1416745] Re: Add grid 100 mil grid to the dropdown menu

2015-07-20 Thread Wayne Stambaugh
Patch committed in product branch r5961. Thanks. On 7/2/2015 4:40 PM, Nick Østergaard wrote: I hereby attach a patch for the bug mentioned in the subject. Please consider this patch and commit at will. Suggested commit message: Add 100 mil grid for eeschema to help confirming to KLC

[Kicad-developers] [PATCH] rewrite error message in pcbnew BOM export

2015-07-20 Thread Chris Pavlina
When running the BOM export in pcbnew on an empty board, a very obtuse No Modules! error message is displayed. This patch rewrites it to Cannot export BOM: there are no footprints in the PCB. -- Chris commit c8363cbe351d6a22921da725748e1d599084eb45 Author: Chris Pavlina cpavl...@binghamton.edu

Re: [Kicad-developers] selecting footprints in schematic - idea

2015-07-20 Thread Wayne Stambaugh
It looks promising but the dialog box may need some layout changes. I'm not sure what, but it looks a bit odd and may be problematic on smaller displays. I certainly will entertain the idea during the next development cycle. At this point, I'm going to put the brakes on any new features so we

Re: [Kicad-developers] [PATCH] [Bug 1416745] Re: Add grid 100 mil grid to the dropdown menu

2015-07-20 Thread Wayne Stambaugh
The hot key. On 7/20/2015 1:44 PM, Nick Østergaard wrote: Which thing? The 100 mil grid select or the hotkey? 2015-07-20 19:31 GMT+02:00 Wayne Stambaugh stambau...@gmail.com: Oh yeah! We shouldn't forget the component library editor as well. I didn't even look to see if this was

Re: [Kicad-developers] [PATCH] [Bug 1416745] Re: Add grid 100 mil grid to the dropdown menu

2015-07-20 Thread LordBlick
In response to a message written on 20.07.2015, 19:16, from Wayne Stambaugh: N is already used in Eeschema so we will have to change the N hot key action in Eeschema if you want to keep it the same as Pcbnew.In my opinion the use Shift with a fairly away from him, another key in commonly used

Re: [Kicad-developers] [PATCH] [Bug 1416745] Re: Add grid 100 mil grid to the dropdown menu

2015-07-20 Thread Nick Østergaard
Which thing? The 100 mil grid select or the hotkey? 2015-07-20 19:31 GMT+02:00 Wayne Stambaugh stambau...@gmail.com: Oh yeah! We shouldn't forget the component library editor as well. I didn't even look to see if this was implemented in the footprint editor. On 7/20/2015 1:19 PM, Chris

[Kicad-developers] eeschema - copy block rotate bug

2015-07-20 Thread LordBlick
I've found bug in eeschema - unfinished functionality: - select some elements and chose „copy block” - after drag to new place press „R” to rotate the block copy to the desired position Unexpectedly application drops block copy to /dev/null and rotates source block. -- Best Regards, LordBlick

Re: [Kicad-developers] [PATCH] [Bug 1416745] Re: Add grid 100 mil grid to the dropdown menu

2015-07-20 Thread Chris Pavlina
N and Shift-N, should be - since that is what pcbnew is using On Mon, Jul 20, 2015 at 07:10:46PM +0200, LordBlick wrote: In response to a message written on 20.07.2015, 16:14, from Wayne Stambaugh: Patch committed in product branch r5961. Thanks. On 7/2/2015 4:40 PM, Nick Østergaard wrote:

Re: [Kicad-developers] [PATCH] [Bug 1416745] Re: Add grid 100 mil grid to the dropdown menu

2015-07-20 Thread Wayne Stambaugh
Oh yeah! We shouldn't forget the component library editor as well. I didn't even look to see if this was implemented in the footprint editor. On 7/20/2015 1:19 PM, Chris Pavlina wrote: Good point, and a tricky decision. Not having the hotkeys unified across the whole package steepens the

Re: [Kicad-developers] [PATCH] [Bug 1416745] Re: Add grid 100 mil grid to the dropdown menu

2015-07-20 Thread LordBlick
In response to a message written on 20.07.2015, 16:14, from Wayne Stambaugh: Patch committed in product branch r5961. Thanks. On 7/2/2015 4:40 PM, Nick Østergaard wrote: I hereby attach a patch for the bug mentioned in the subject. Please consider this patch and commit at will. Suggested

Re: [Kicad-developers] [PATCH] [Bug 1416745] Re: Add grid 100 mil grid to the dropdown menu

2015-07-20 Thread Chris Pavlina
Good point, and a tricky decision. Not having the hotkeys unified across the whole package steepens the learning curve, but changing hotkeys can piss off long-time users. Myself, I'd vote to unify the hotkeys - but not arbitrarily, it's something that should probably be done all at once so

Re: [Kicad-developers] [PATCH] [Bug 1416745] Re: Add grid 100 mil grid to the dropdown menu

2015-07-20 Thread Wayne Stambaugh
On 7/20/2015 1:19 PM, Chris Pavlina wrote: Good point, and a tricky decision. Not having the hotkeys unified across the whole package steepens the learning curve, but changing hotkeys can piss off long-time users. I'm not sure how much the change component to normal orientation (N) hot key

Re: [Kicad-developers] [PATCH] [Bug 1416745] Re: Add grid 100 mil grid to the dropdown menu

2015-07-20 Thread Wayne Stambaugh
N is already used in Eeschema so we will have to change the N hot key action in Eeschema if you want to keep it the same as Pcbnew. On 7/20/2015 1:12 PM, Chris Pavlina wrote: N and Shift-N, should be - since that is what pcbnew is using On Mon, Jul 20, 2015 at 07:10:46PM +0200, LordBlick

Re: [Kicad-developers] [PATCH] rewrite error message in pcbnew BOM export

2015-07-20 Thread Wayne Stambaugh
Patch committed in product branch r5965. Thanks. On 7/20/2015 2:47 PM, Chris Pavlina wrote: When running the BOM export in pcbnew on an empty board, a very obtuse No Modules! error message is displayed. This patch rewrites it to Cannot export BOM: there are no footprints in the PCB. --

[Kicad-developers] [PATCH] Crash and assertion failure in dialog_print_using_printer.cpp

2015-07-20 Thread Chris Pavlina
On some systems, a mismatched format string in dialog_print_using_printer.cpp causes an assertion failure and subsequent segfault. (Some wx builds seem not to mind - I couldn't reproduce the failure on my own system - but the bug is definitely there and someone shared a backtrace with me.)

Re: [Kicad-developers] Middle mouse button panning.

2015-07-20 Thread Garth Corral
Since nobody has replied, I'll say that I'd be happy to do this but don't currently have a mouse with a middle button. I'll try to dig one up but in the mean time if some who has such a device can try this out, please do. As for the panning past the scroll bar limits, it always seemed odd to

[Kicad-developers] [PATCH] Fix enter button in dialog_edit_module_text

2015-07-20 Thread Chris Pavlina
The Enter button cannot be used as OK in DialogEditModuleText while in a text field. This patch fixes that. -- Chris commit f459b217a8cc55d8d80463933ecceca02aa213c6 Author: Chris Pavlina cpavl...@binghamton.edu Date: Mon Jul 20 19:45:53 2015 -0400 Fix enter button in

[Kicad-developers] Suggestion: Bring B.Cu to front when editing back mech layers

2015-07-20 Thread Chris Pavlina
This isn't a concern in legacy, which displays all layers 'flat' anyway, but GAL brings the active layer to the front. Does anyone think that when editing a back mechanical layer like B.SilkS, B.Cu should be brought to front so you can see the things in the neighborhood of B.SilkS? Or even

Re: [Kicad-developers] [PATCH] Crash and assertion failure in dialog_print_using_printer.cpp

2015-07-20 Thread Wayne Stambaugh
Patch committed in product branch r5966. Thanks. On 7/20/2015 4:26 PM, Chris Pavlina wrote: On some systems, a mismatched format string in dialog_print_using_printer.cpp causes an assertion failure and subsequent segfault. (Some wx builds seem not to mind - I couldn't reproduce the