Re: [Kicad-developers] Bus upgrades merge

Thanks Wayne! Everything looks good to me. Glad to finally have this merged so that I can start building other improvements on top of it. On Sun, Mar 31, 2019 at 9:42 PM Wayne Stambaugh wrote: > Jon, > > I forgot to mention. Please take a look and make sure I didn't muck > anything up when

Re: [Kicad-developers] Bus upgrades merge

Jon, I forgot to mention. Please take a look and make sure I didn't muck anything up when you get a chance. Wayne On 3/31/19 9:38 PM, Wayne Stambaugh wrote: Jon, I merged your patch set into the master branch.  Thank you for all of your efforts. Cheers, Wayne On 3/31/19 7:50 PM, Jon

Re: [Kicad-developers] Bus upgrades merge

Jon, I merged your patch set into the master branch. Thank you for all of your efforts. Cheers, Wayne On 3/31/19 7:50 PM, Jon Evans wrote: Yes I just squashed the parts that dont compile on their own. On Sun, Mar 31, 2019, 19:48 Wayne Stambaugh > wrote:

Re: [Kicad-developers] Bus upgrades merge

Yes I just squashed the parts that dont compile on their own. On Sun, Mar 31, 2019, 19:48 Wayne Stambaugh wrote: > Jon, > > I thought we decided to squash your patch set or did you just squash > part of the patch set? I see 17 separate patches the archive you sent. > > Wayne > > On 3/31/19

Re: [Kicad-developers] Bus upgrades merge

Jon, I thought we decided to squash your patch set or did you just squash part of the patch set? I see 17 separate patches the archive you sent. Wayne On 3/31/19 7:39 PM, Jon Evans wrote: Attached! On Sun, Mar 31, 2019 at 7:28 PM Wayne Stambaugh > wrote:

Re: [Kicad-developers] 5.1 release

On 3/30/19 11:17 PM, Kevin Cozens wrote: On 2019-03-10 5:39 p.m., Adam Wolf wrote: Nick, is the docs tarball ready? That is an interesting question. Who maintains the file format doc? The only version I can find is over 2 years old. I'm writing a script to convert the files from a schematic

Re: [Kicad-developers] Bus upgrades merge

Jon, Would you please post the squashed patch to the mailing list so I can get it merged? Thanks, Wayne On 3/31/19 3:07 PM, Jon Evans wrote: I went through and squashed the offending commits and updated the PRs. -Jon On Sun, Mar 31, 2019 at 2:22 PM Wayne Stambaugh

[Kicad-developers] Eeschema test segfault

Hi, I'm trying to get the eeschema tests building and working, but I have an issue with a segfault on init (the existing test itself will not work either as it has hardcoded data paths, but it doesn't get that far, so baby steps!). It looks like the init of wxCursor in simulate.cpp line #144 is

Re: [Kicad-developers] Bus upgrades merge

Thanks Jon!-SOn Mar 31, 2019 12:07 PM, Jon Evans wrote:I went through and squashed the offending commits and updated the PRs.-JonOn Sun, Mar 31, 2019 at 2:22 PM Wayne Stambaugh wrote:If that's the case then it may make the most sense to squash everything into a single

Re: [Kicad-developers] Bus upgrades merge

I went through and squashed the offending commits and updated the PRs. -Jon On Sun, Mar 31, 2019 at 2:22 PM Wayne Stambaugh wrote: > If that's the case then it may make the most sense to squash everything > into a single commit. > > On 3/31/19 2:17 PM, Jon Evans wrote: > > That one was very

Re: [Kicad-developers] License CC-BY-SA-4.0 used in KiCad

I reverted this commit so this should resolve the Fedora build issue. On 3/31/19 12:59 PM, Carsten Schoenert wrote: > Hello Aimylios, > > Am 30.03.19 um 20:42 schrieb Aimylios: >> Hi Carsten, > > (no need to address me directly, I'm subscribed to the list) > >> your third patch breaks the

Re: [Kicad-developers] Bus upgrades merge

If that's the case then it may make the most sense to squash everything into a single commit. On 3/31/19 2:17 PM, Jon Evans wrote: > That one was very late and would be easy to squash. However, some of the > very early commits in the branch were split up for review purposes and > not intended to

Re: [Kicad-developers] Bus upgrades merge

That one was very late and would be easy to squash. However, some of the very early commits in the branch were split up for review purposes and not intended to be built on their own. On Sun, Mar 31, 2019, 14:16 Wayne Stambaugh wrote: > When was the code that did not build on msvc introduced?

Re: [Kicad-developers] Bus upgrades merge

When was the code that did not build on msvc introduced? If was early then it might make sense to squash everything. Otherwise, it may be worthwhile squashing from the commit where the build error was introduced to and including the commit where the build error was fixed. I don't have a

Re: [Kicad-developers] License CC-BY-SA-4.0 used in KiCad

Hello Aimylios, Am 30.03.19 um 20:42 schrieb Aimylios: > Hi Carsten, (no need to address me directly, I'm subscribed to the list) > your third patch breaks the Fedora nightly builds. This is the error we > get (see [1] for a full build log): > > FAILED: > ? tag-missing : is not

Re: [Kicad-developers] Crash report in Fedora Bugzilla

I'll add a comment to the bug, and see if the user can reproduce the problem. I'll suggest hitting "down arrow". Steve On 3/31/19 11:12 AM, Jon Evans wrote: > Looks like this happened inside the component selector when the users pressed > the down arrow key. > > I think the stack

Re: [Kicad-developers] Bus upgrades merge

Seth, I split up the initial rebased branch to make review a bit easier. I could squash everything into one huge commit if you'd prefer. On Sun, Mar 31, 2019 at 9:56 AM Seth Hillbrand wrote: > Am 2019-03-30 17:33, schrieb Simon Richter: > > Hi Wayne, > > > > On 30.03.19 21:30, Wayne Stambaugh

Re: [Kicad-developers] Crash report in Fedora Bugzilla

Looks like this happened inside the component selector when the users pressed the down arrow key. I think the stack trace is assuming one of the wx GetNextItem calls instead of the one in wxdataviewctrl_helpers.cpp which is what was actually called (I think?) Without an accurate backtrace inside

Re: [Kicad-developers] Bus upgrades merge

Hi, On 31.03.19 15:55, Seth Hillbrand wrote: > I use git bisect frequently.  Please do not push commits that do not > compile.  This has been done previously and it added hours to fixing a > single bug in 5.0.1. It's probably trivial: commit f67d243c368659798828dde87d9cf562c9176694 Author: Jon

Re: [Kicad-developers] Bus upgrades merge

Am 2019-03-30 17:33, schrieb Simon Richter: Hi Wayne, On 30.03.19 21:30, Wayne Stambaugh wrote: Is this the last of it? If so, I will attempt to get this merged tomorrow. Compiles fine on msys2 and msvc. Not all intermediate commits compile, but I'm not sure anyone does git-bisect anyway.

[Kicad-developers] Crash report in Fedora Bugzilla

I was alerted to the following bug report: https://bugzilla.redhat.com/show_bug.cgi?id=1694288 The user hit a key - doesn't know which key - and somehow triggered a crash in GetNextItem. I don't know if this bug report is helpful, but it does have a backtrace, and we know which version of

Re: [Kicad-developers] Zone hatch filling patch

Le 30/03/2019 à 21:27, Wayne Stambaugh a écrit : > Hey JP, > > Go ahead and push the changes so we can get some wider testing. > > Thanks, > > Wayne Done. -- Jean-Pierre CHARRAS ___ Mailing list: https://launchpad.net/~kicad-developers Post to