Re: [Kicad-developers] [PATCH] IPC-7351 Footprint wizard

2014-04-28 Thread John Beard
On 27/04/14 20:18, Francesco Del Degan wrote: Yes, I will try to reuse the helper classes that was committed few days ago, and fix some issues with it. (I just discovered that actual BGA footprint uses all 26 letters, but only ABCDEFGHJKLMNPRTUVWY should be allowed) . My bad, thanks for

[Kicad-developers] Forward-compatibility in s-expression formats

2014-05-06 Thread John Beard
I think it would be a good idea to allow unknown fields in the s-expression formats so that an older KiCad doesn't choke on things it doesn't understand, and doesn't need to. For example, I was thinking that it might be helpful to add a field to the footprint format: part_reference, which would

Re: [Kicad-developers] Forward-compatibility in s-expression formats

2014-05-06 Thread John Beard
On 06/05/14 21:47, Jean-Paul Louis wrote: Why not collect all the field of any part being loaded, and consider all the fields that are not known as “user defined fields”? In future you may want you use a word for a new field, and you don't really want to stomp on some poor sap who thought he

Re: [Kicad-developers] Forward-compatibility in s-expression formats

2014-05-06 Thread John Beard
On 06/05/14 23:18, Tomasz Wlostowski wrote: How about about adding a generic attribute set for each part, stored as a list of type-name-value entries: (part xxx (attribute simulation_model (string .cir) ) (attribute part_reference_farnell (int 123456 ) ) ) Such scheme would not

Re: [Kicad-developers] Forward-compatibility in s-expression formats

2014-05-06 Thread John Beard
On 06/05/14 21:47, Lorenzo Marcantonio wrote: That said, I think that *if* the sexp reader can traverse automatically a generic sexp (without having a grammar, only tokenising) we could decide that it could 'skip' each subexpression starting with an unknown token. Maybe with warnings:D I

Re: [Kicad-developers] Forward-compatibility in s-expression formats

2014-05-08 Thread John Beard
On 08/05/14 15:53, Dick Hollenbeck wrote: That's exactly what I mean - older versions of KiCad should be able to ignore, but retain, unknown data. This sentence has two concepts in it. One is fools gold, the other is poorly expressed. 1) An older kicad should load a data file that is

Re: [Kicad-developers] Forward-compatibility in s-expression formats

2014-05-08 Thread John Beard
On 07/05/14 07:19, Lorenzo Marcantonio wrote: On Wed, May 07, 2014 at 12:48:22AM +0100, John Beard wrote: I would have thought this would exactly be done at the end of tokenisation More or less, that's the idea :D There are various ways to do this but all depends on the flexibility

Re: [Kicad-developers] Forward-compatibility in s-expression formats

2014-05-08 Thread John Beard
On 08/05/14 20:12, Lorenzo Marcantonio wrote: On Thu, May 08, 2014 at 07:31:47PM +0100, John Beard wrote: it will show you what it can. You'd be annoyed if it didn't, it would be like Flash needing the latest version to watch your video, without the excuse that is necessary to implement

Re: [Kicad-developers] Forward-compatibility in s-expression formats

2014-05-09 Thread John Beard
On 08/05/14 20:44, Dick Hollenbeck wrote: On 05/08/2014 02:18 PM, Dick Hollenbeck wrote: On 05/08/2014 01:31 PM, John Beard wrote: On 08/05/14 15:53, Dick Hollenbeck wrote: Submit a patch. Hope it gets accepted. Since your interest is limited to the *.kicad_mod file. You can use

Re: [Kicad-developers] [Kicad-lib-committers] Silk screens over pads and naming

2014-06-13 Thread John Beard
On 13/06/14 19:36, Lorenzo Marcantonio wrote: On Fri, Jun 13, 2014 at 06:46:37PM +0100, John Beard wrote: The silk screen is put so it can be seen after soldering. The ASCII art arrow is an assembly layer feature, modelled after the IPC standard. Sorry my fault. I was thinking was a fancy

Re: [Kicad-developers] [Kicad-lib-committers] Silk screens over pads and naming

2014-06-13 Thread John Beard
On 13/06/14 20:44, Lorenzo Marcantonio wrote: On Fri, Jun 13, 2014 at 08:33:02PM +0100, John Beard wrote: OK, I won't worry too much about it and get one with making more footprints! Are there any more things you'd like to see changed? No matter how tiny! These are already *way* nicer than

Re: [Kicad-developers] [Kicad-lib-committers] Silk screens over pads and naming

2014-06-13 Thread John Beard
On 13/06/14 21:23, Nick Østergaard wrote: I like the 3D view very much, even the old simple one is great for verifying tracks. I often find things I want to change when looking at the 3D view of just the traces and silk. I agree, I think it's having an alaternative perspective. A bit like

[Kicad-developers] Footprint wizard changes

2014-07-05 Thread John Beard
Hi, I have made some changes to the helpers for the footprint wizards. There is now a matrix-based transform stack that helps simplify calculations that footprint wizards need to do. The patch attached is based on BZR rev 4975. There are also some tests in the pcbnew/scripting/tests directory

[Kicad-developers] Use of std::vectorwxPoint in Python

2014-07-12 Thread John Beard
Hi, I am trying to get fp_poly working in the footprint wizards. It seems that I should be using pcbnew.DRAWSEGMENT.SetPolyPoints(), which takes a std::vectorwxPoint as an argument. I tried to feed it a Python list of wxPoints, but it couldn't handle that: File

[Kicad-developers] PATCH: Footprint wizard helpers

2014-09-11 Thread John Beard
Hi, I have a patch (fpw-overhaul.diff) for the Python footprint wizard helpers. This adds a few more drawing functions, such as for circles, and also uses a matrix-based transform stack with greatly simplifies constructing footprints consisting of regularly spaced elements (e.g. in lines, grids,

[Kicad-developers] [PATCH] Use the main workspace background in component chooser/browser dialogues

2014-09-23 Thread John Beard
Hi, Here is a small patch to make the component chooser dialogue and the library browser dialogue use the main workspace background colour (white or black, as configured) instead of white, which otherwise looks inconsistent when the main workspace is black. Because DIALOG_CHOOSE_COMPONENT and

[Kicad-developers] [PATCH] Minor tweaks for the eeschema component chooser, especially for aliases.

2014-10-06 Thread John Beard
Hello, Attached is a small patch that does a few things in the eeschema component chooser: * Shows aliases' names, rather than the root device names in the preview window * Doesn't paint the background if nothing is selected * Add the component name as a heading in the

[Kicad-developers] [PATCH] Info panel for DRAWSEGMENTs in the module editor

2014-11-07 Thread John Beard
about the angle display - I used an anti-clockwise from 3-o'clock convention, rather than a compass-like clockwise from 12-o'clock. Also, I don't know what each of the colours signifies, so I went with DARKGREEN. Thanks, John commit 8cd6097275c41afa237f92fc81c6f8c7dbb1a456 Author: John Beard

Re: [Kicad-developers] [PATCH/RFC] Move exactly and duplicate in modedit

2014-11-15 Thread John Beard
On 15/11/14 15:32, Wayne Stambaugh wrote: I just commented on Cirilo's request and the same hold true for your change as well. Please push the branch with these changes to launchpad and submit a merge request. Since this is a new feature and we are trying to work towards a stable release, I

[Kicad-developers] [PATCH] Hotkey for editing module with module editor (Ctrl-E)

2014-11-15 Thread John Beard
Hi all, Here is a little patch for adding a hotkey to edit a module with the module editor. It defaults to Ctrl-E. At least this makes it a little easier to develop for modedit, as you now don't need to click into the menu to get there! Thanks, John diff --git a/pcbnew/hotkeys.cpp

[Kicad-developers] [PATCH] Handle empty string in cvpcb GetModuleInfo()

2014-11-20 Thread John Beard
Hi, Here is a tiny patch to defend against asserts in debug mode when the footprint list in cvpcb is empty. The aFootprintName was coming in as in that case. You could also check for an empty string at the call sites, but since this function already can return null (and thus callers should be

Re: [Kicad-developers] Haskell Library (SVG drawing)

2014-12-02 Thread John Beard
/plugins/bezier_converter.py @@ -0,0 +1,339 @@ + +Copyright 2014 (C) John Beard, john.j.be...@gmail.com +based on gcode_tools.py (C) 2009 Nick Drobchenko, n...@cnc-club.ru +based on gcode.py (C) 2007 hugomatic... +based on addnodes.py (C) 2005,2007 Aaron Spike, aa...@ekips.org +based on dots.py (C) 2005

Re: [Kicad-developers] [PATCH] Hotkey for editing module with module editor (Ctrl-E)

2014-12-02 Thread John Beard
On Mon, 2014-12-01 at 13:22 -0500, Wayne Stambaugh wrote: Hi John, Sorry it took so long to try out this patch but I've been busy. I found a segfault on the first attempt to use Ctrl-E when no previous item has been selected. D'oh, what a clanger! Once you fix this issue, I'll commit

Re: [Kicad-developers] [PATCH/RFC] Move exactly and duplicate in modedit

2014-12-05 Thread John Beard
On Sun, 2014-11-16 at 10:33 -0500, Wayne Stambaugh wrote: Thanks. I'll test this as soon as I get a chance. It would also be worthwhile to port any new features added to the legacy rendering to the new OpenGL/Cairo rendering using the new tool framework. I think its a good idea at this

[Kicad-developers] [PATCH/RFC] Transfer user settings to child frames

2014-12-06 Thread John Beard
Attached is a patch to import settings from a parent frame to child frames. This is in response to a bug reported in IRC that the warp-on-zoom behaviour in pcbnew was not being transferred to modedit. This patch provides a generic way of importing settings from a wxWindow parent in impure virtual

Re: [Kicad-developers] [PATCH] Hotkey for editing module with module editor (Ctrl-E)

2014-12-07 Thread John Beard
On Sat, 2014-12-06 at 15:37 -0500, Wayne Stambaugh wrote: This still doesn't work correctly unless the footprint is already the current item selected. It behaves the same in both the GAL and legacy rendering modes. You should not have to select an item first to make a hot keys work. Try

Re: [Kicad-developers] Modifier keys for hotkeys

2014-12-28 Thread John Beard
On Thu, Dec 18, 2014 at 6:58 PM, jp charras jp.char...@wanadoo.fr wrote: Le 15/12/2014 20:26, John Beard a écrit : On Sun, 2014-12-14 at 20:04 +0100, jp charras wrote: Le 14/12/2014 03:02, John Beard a écrit : I'm trying to get a hotkey defined as Ctrl-Shift-D. Currently, I can make it work

Re: [Kicad-developers] documentation format

2015-02-03 Thread John Beard
On Wed, 2015-02-04 at 01:31 +, John Beard wrote: On Tue, 2015-02-03 at 19:14 -0500, Wayne Stambaugh wrote: I think the availability of tools on those platforms is actually not of huge significance. The worst case is that the docs are built for every commit by something like Jenkins

Re: [Kicad-developers] documentation format

2015-02-03 Thread John Beard
On Tue, 2015-02-03 at 19:14 -0500, Wayne Stambaugh wrote: On 2/3/2015 6:55 PM, Cirilo Bernardo wrote: It has been some time since Marco has done an evaluation of document format alternatives. Has any decision been made yet about what format we shall use, or are there still some other

Re: [Kicad-developers] [PATCH] Hotkey for editing module with module editor (Ctrl-E)

2015-01-22 Thread John Beard
On Sun, 2014-12-07 at 21:54 +, John Beard wrote: Here is an amended patch, where Ctrl-E over an item in either legacy or GAL will launch the footprint editor. A single selection works as before. That patch no longer applies, please find attached a new patch for the current product tip

Re: [Kicad-developers] [PATCH/RFC] Move exactly and duplicate in modedit (now with arrays)

2015-01-09 Thread John Beard
On Fri, 2014-12-05 at 22:02 +, John Beard wrote: The move exact and duplicate tools are now supplemented by an array tool which allows creation of grid, staggered grid and circular arrays of pads, lines or text within modedit. It is available in both legacy and GAL modes, but blocks can only

Re: [Kicad-developers] cmake errors wxWidgets

2015-02-10 Thread John Beard
On Tue, 2015-02-10 at 01:11 -0600, inkblotter wrote: I'll try again to find someone who understands the ins and out of cmake enough to steer me to some solution that make sense. Below you will see what happens on Fedora always with kicad cmake and wxWidgets. CMake Error at

[Kicad-developers] Uncrustify case indentation rules

2015-01-07 Thread John Beard
Hi, Is the policy for braced case indentation as follows? case SOMETHING: { int i = 0; break; } This seems to be the case for tidying-up commits like r5288, but the uncrustify.cfg rules call for: case SOMETHING: { int i = 0; break; } If this is in fact

Re: [Kicad-developers] The library tables wizard

2015-01-07 Thread John Beard
On Wed, 2015-01-07 at 23:38 +0100, Miguel Ángel Ajo wrote: Hi Jean Pierre, just an idea for your wizard work: https://api.github.com/orgs/KiCad/repos You could save the need to work with the HTML viewer and pagination problems using the above API endpoint, all the KiCad project

[Kicad-developers] [PATCH] Fix for cancellation of duplicate in GAL mode

2015-03-14 Thread John Beard
I have noticed a quirk when cancelling a duplicate in modedit under GAL. The duplicated item would be left in the same place as the original rather than being deleted. This was caused by not handling the creation of the undo point correctly in modedit (the analogous case was already handled in

[Kicad-developers] [PATCH] Re: Icons needed

2015-03-15 Thread John Beard
Hi all, I have made a few modifications to the icons (mostly pixel alignment at 26px) and added them to the relevant CMake file and header. They are now used in the pcbnew menus. Balint should still get credit for the icons - I just tweaked them! Are there other places these icons can/should be

[Kicad-developers] [PATCH] Fix for broken callback in diff pair dimensions dialog

2015-03-15 Thread John Beard
The callback for the checkbox in the Differential Pair Dimensions dialog is broken due to function name mismatch (on... vs On...). Because the function is impure virtual and we can't mark the overrider with override due to the compiler type, the different spelling didn't cause a compile time

Re: [Kicad-developers] [PATCH] Hotkey for editing module with module editor (Ctrl-E)

2015-03-13 Thread John Beard
. I noticed that the MD_CTRL + 'E' is not MD_CTRL + int( 'E' ) like the other shortcuts, but changing this didn't seem to work either. Cheers, John On Fri, 2015-01-23 at 10:43 +0100, Tomasz Wlostowski wrote: On 02.12.2014 22:16, John Beard wrote: On Mon, 2014-12-01 at 13:22 -0500, Wayne

Re: [Kicad-developers] Feature Request: ViaStiching

2015-03-27 Thread John Beard
Hi, The array tool should make rudimentary stitching possible - just create a grid of the via you want to duplicate and remove any that aren't in the area you want. It's a fully manual process, but it seems to interact sensibly with zones at least - see the attached screenshot for the behaviour

[Kicad-developers] Array tool patches

2015-07-15 Thread John Beard
. The third patch refactors some of the array code to make reuse easier for any future array tools and adds a few general tidy-ups. Thank you, John From 61e09b33ec7d1edcd14a49eed45655c264b98952 Mon Sep 17 00:00:00 2001 From: John Beard john.j.be...@gmail.com Date: Thu, 9 Jul 2015 23:36:12 +0100 Subject

[Kicad-developers] Array tool patches

2016-03-22 Thread John Beard
canvasses (decouples the array tool from the actual canvas implementation) * Improved error reporting when bad parameters are detected. Thanks, John >From 15d935aa90757b69ab332919358fde1049b06992 Mon Sep 17 00:00:00 2001 From: John Beard <john.j.be...@gmail.com> Date: Mon, 21 Mar 2016 07:25

Re: [Kicad-developers] Git transition

2016-08-08 Thread John Beard
I understand that many people will be using the Bzr UI tools, but Git is very good at enabling digging in the history using the command line. I have a handy Git alias which shows me a condensed version of the history (it's actually coloured in my terminal, so it's really clear what's going on):

[Kicad-developers] [PATCH] .gitconfig syntax, missing '='

2016-08-08 Thread John Beard
git config --local include.path ../.gitconfig Cheers, John From 53b2afd692ecaab9757b5b0698dad09e624502bc Mon Sep 17 00:00:00 2001 From: John Beard <john.j.be...@gmail.com> Date: Mon, 8 Aug 2016 11:03:04 +0800 Subject: [PATCH] Fix .gitconfig syntax --- .gitconfig | 2 +- 1 file changed, 1

[Kicad-developers] [PATCH] Add exchange footprints to GAL

2017-01-31 Thread John Beard
as needed. The third patch is optional, but tidies up a copy-pasted selection routine into a named function and adds a little commentary to a couple of related existing functions. Cheers, John From fd30b0465e0b627a4f69fa574f077396ea3f7861 Mon Sep 17 00:00:00 2001 From: John Beard <john.j.be

[Kicad-developers] [PATCH] Fix warp-to-nearest pad bug with T hotkey

2017-02-06 Thread John Beard
Hi, This patch fixes a GAL usability quirk with the T hotkey (find and move). Fixes: https://bugs.launchpad.net/kicad/+bug/1571214 Cheers, John From 191412b93ba263f69d69e75cabb7758b175607bd Mon Sep 17 00:00:00 2001 From: John Beard <john.j.be...@gmail.com> Date: Mon, 6 Feb 2017 18:16:36

Re: [Kicad-developers] Add a cmake option for legacy canvas

2017-02-06 Thread John Beard
surface, but because this tool doesn't have a lot of backend of it's own, it's not a significant factor. Note: I am not submitting this patch in the expectation that it be merged, it's an example (I wouldn't stop anyone though!). Cheers, John On Sun, Feb 5, 2017 at 1:25 PM, John Beard <john.j.be...

Re: [Kicad-developers] [PATCH] Delete whole tracks in GAL

2017-02-07 Thread John Beard
The first of these patches has a mistake in the selection code, which used to clear the selection and replace it, and should now augment, not replace. Please use the attached patches instead. Thanks, John On Mon, Feb 6, 2017 at 12:37 AM, John Beard <john.j.be...@gmail.com> wrote: > A

[Kicad-developers] [PATCH] Show zero thickness lines in GAL

2017-02-07 Thread John Beard
Hi, Here is a patch to show zero-thickness lines in GAL using the "outline width". This addressess https://bugs.launchpad.net/kicad/+bug/1501749 Cheers, John From 60dfc34c70493bf05f77ecd4dca7594b46798c8e Mon Sep 17 00:00:00 2001 From: John Beard <john.j.be...@gmail.com> Date:

Re: [Kicad-developers] Issues in right click context menu in GAL mode on Windows.

2017-02-08 Thread John Beard
On Thu, Feb 9, 2017 at 2:01 AM, Kristoffer Ödmark wrote: > I am seeing the "Pads" menu entry when right-clicking empty in linux, "push > pads settings" is enabled in the submenus and if I press that one and get a > small dialog, the button "Pad Editor" gives me a

Re: [Kicad-developers] Issues in right click context menu in GAL mode on Windows.

2017-02-08 Thread John Beard
Here is a Launchpad bug for tracking the broken Windows submenus: https://bugs.launchpad.net/kicad/+bug/1663101 On Wed, Feb 8, 2017 at 10:37 PM, jp charras wrote: > Recently, some enhancements were added to the right click popup context menus. > > On windows, most are

Re: [Kicad-developers] [PATCH] Delete whole tracks in GAL

2017-02-08 Thread John Beard
On Wed, Feb 8, 2017 at 6:48 AM, Nick Østergaard wrote: > Mm, it seems this also reverses it such that you have to use backspace > to delete a footprint whereas in that case the delete key should be > used. Hi Nick, The latest patch (Feb 7) should not do that - for me, both

Re: [Kicad-developers] Pad import/export/push and modedit mirror

2017-02-05 Thread John Beard
On Sat, Feb 4, 2017 at 8:10 PM, Nick Østergaard wrote: > I have attached a patch that renames this. It contains three commits > for easier review. Sounds good to me. At the (considerable) risk of bikeshedding, I might also suggest something like "stash" or "store" instead of

[Kicad-developers] [PATCH] CCW Rotation in GAL

2017-02-05 Thread John Beard
rotation to everywhere there is unidirectional rotation in GAL now). Cheers, John From 77bc4b3b42d64137d915aecdfef0139150c0844b Mon Sep 17 00:00:00 2001 From: John Beard <john.j.be...@gmail.com> Date: Sat, 4 Feb 2017 13:09:50 +0800 Subject: [PATCH] Add CCW rotation to GAL canvas This makes &

[Kicad-developers] [PATCH] Delete whole tracks in GAL

2017-02-05 Thread John Beard
, which wasn't used until now. Cheers, John From 9fc80d8c5fc971cab9f756bc87a7383b732dfeba Mon Sep 17 00:00:00 2001 From: John Beard <john.j.be...@gmail.com> Date: Sat, 4 Feb 2017 14:45:52 +0800 Subject: [PATCH 2/2] Allow delete whole track in GAL This commit wires up the as-yet-unused "remove alternate"

Re: [Kicad-developers] Add a cmake option for legacy canvas

2017-02-04 Thread John Beard
Hi, I support the general idea of being able to turn off bits of the legacy canvas at will, in principle. However, I'm not sure how many people will actually bother to check if stuff behind an #ifdef is getting broken, and legacy stuff is quite vulnerable because of tight binding to large classes

[Kicad-developers] [PATCH] Add duplicate zone onto layer tool

2017-02-06 Thread John Beard
Hi, This patch adds a missing tool to GAL: duplicate zone onto layer. It's accessed through the zones context menu and does the same as the legacy mode version. Cheers, John From 031b15406695e60b17af6bb9e8b984e662c728d8 Mon Sep 17 00:00:00 2001 From: John Beard <john.j.be...@gmail.com>

[Kicad-developers] [PATCH] Dragging with tracks in GAL

2017-02-07 Thread John Beard
not sure where to start to do that. Cheers, John From 7e493417cf1f04912a0f47681a40f30f2a9e96e3 Mon Sep 17 00:00:00 2001 From: John Beard <john.j.be...@gmail.com> Date: Thu, 2 Feb 2017 00:14:18 +0800 Subject: [PATCH] Add drag tool to GAL edit tool This adds segment endpoint dragging when

Re: [Kicad-developers] [PATCH] Dragging with tracks in GAL

2017-02-07 Thread John Beard
/~john-j-beard/kicad/+git/kicad/+ref/drag_tracks On Wed, Feb 8, 2017 at 9:47 AM, John Beard <john.j.be...@gmail.com> wrote: > Hi, > > Here is a really basic concept patch for component dragging with > tracks ('G') in pcbnew GAL. > > It uses the same dragging mechanism as legacy

Re: [Kicad-developers] [PATCH] Delete whole tracks in GAL

2017-02-05 Thread John Beard
Apparently those patches don't apply because the diff context lines have a line of a different non-mainline patch in them (from the rotate CCW patch). Hopefully, these will apply to the current master. On Sun, Feb 5, 2017 at 9:23 PM, John Beard <john.j.be...@gmail.com> wrote

[Kicad-developers] Fwd: [PATCH] C++14-style std::make_unique for C++11

2017-01-22 Thread John Beard
FWD to list -- Forwarded message -- From: John Beard <john.j.be...@gmail.com> Date: Mon, Jan 23, 2017 at 8:36 AM Subject: Re: [Kicad-developers] [PATCH] C++14-style std::make_unique for C++11 To: Wayne Stambaugh <stambau...@gmail.com> The idea with std:

[Kicad-developers] [PATCH] Allow editing locked modules in modedit

2017-01-22 Thread John Beard
). Fixes: LP 1591625 https://bugs.launchpad.net/kicad/+bug/1591625 From 317510c194c8e8c3829abb4cdabbeab773b087bc Mon Sep 17 00:00:00 2001 From: John Beard <john.j.be...@gmail.com> Date: Sun, 22 Jan 2017 01:32:45 +0800 Subject: [PATCH] Allow editing locked modules in modedit Since you have to expl

[Kicad-developers] [PATCH] Init OPENGL_GAL currentTarget

2017-01-22 Thread John Beard
Hi, This patch initialises a class member in OPENGL_GAL. It uses the SetTarget function to make sure the target and manager initialise in a consistent way. Cheers, John From f9a0fc626f78337165595f18f4dca73afa11a9af Mon Sep 17 00:00:00 2001 From: John Beard <john.j.be...@gmail.com> Dat

[Kicad-developers] [PATCH] Move PostCommandMenuEvent to EDA_BASE_FRAME

2017-01-22 Thread John Beard
-recompile for anyone pulling both at once! Cheers, John From f8c76db985a90fbf5e209317e04011028b95e4de Mon Sep 17 00:00:00 2001 From: John Beard <john.j.be...@gmail.com> Date: Tue, 17 Jan 2017 13:57:53 +0800 Subject: [PATCH] Move PostCommandMenuEvent to EDA_BASE_FRAME There is nothing PCB

[Kicad-developers] [PATCH] C++14-style std::make_unique for C++11

2017-01-21 Thread John Beard
ay moves on to C++14, this file can be removed entirely and forgetten! Cheers, John From 5762fed4ae255612d244f5ab51c88c6b3c31fde4 Mon Sep 17 00:00:00 2001 From: John Beard <john.j.be...@gmail.com> Date: Sun, 22 Jan 2017 00:03:01 +0800 Subject: [PATCH] Add C++14-style std::make_unique 'polyfill' f

[Kicad-developers] Pad import/export/push and modedit mirror

2017-01-24 Thread John Beard
dit_tool.h @@ -81,6 +81,13 @@ public: int Flip( const TOOL_EVENT& aEvent ); /** + * Function Mirror + * + * Mirrors the current selection. The mirror axis passes though the current point. + */ +int Mirror( const TOOL_EVENT& aEvent ); + +/** * Function R

Re: [Kicad-developers] Pad import/export/push and modedit mirror

2017-01-24 Thread John Beard
Sorry, attached the wrong version of the "import export" patch - this is the correct sequence. On Wed, Jan 25, 2017 at 12:41 AM, John Beard <john.j.be...@gmail.com> wrote: > Hi, > > Here are two patches for outstanding GAL functionality: pad > import/export/push an

[Kicad-developers] [PATCH] Pre-select highlighted net in zone create dialog

2017-01-28 Thread John Beard
-existing and a different issue. Due to the use of a const-reference BOARD&, this patch relies on yesterday's "Consts in BOARD" patch. Cheers, John From 97cdca03faefe694bc49297db40ba000ca0025f8 Mon Sep 17 00:00:00 2001 From: John Beard <john.j.be...@gmail.com> Date: Fri,

[Kicad-developers] [PATCH] Tidy consts in D_PAD

2017-01-21 Thread John Beard
t are part of a larger inheriance hierarchy. Cheers, John From 4f726e83fb44f5057a28b05777bfef5613b3fbf9 Mon Sep 17 00:00:00 2001 From: John Beard <john.j.be...@gmail.com> Date: Sun, 22 Jan 2017 04:19:46 +0800 Subject: [PATCH 1/2] Tidy consts for class D_PAD Some accessors should be con

[Kicad-developers] [PATCH] Consts in BOARD

2017-01-27 Thread John Beard
) a member, "pcb", that gets conditionally initialised in that function, so it's impossible without a mutable, which I'm not sure would be correct or not. Cheers, John From 5d745e925631107ec0bd462907955345cacae2fd Mon Sep 17 00:00:00 2001 From: John Beard <john.j.be...@gmail.com> Date:

[Kicad-developers] [PATCH] Setting grid line sizes and density

2017-02-15 Thread John Beard
Hi, Here is a branch with a set of patches to add the ability to set the grid line/dot size and the minimum grid spacing (to avoid very dense grids when using thicker lines). https://code.launchpad.net/~john-j-beard/kicad/+git/kicad/+ref/grid_dot_size This also includes moving the grid display

[Kicad-developers] [PATCH] Fix layer color swatches in Linux

2017-02-21 Thread John Beard
onsistency in that file. Cheers, John From 92185ffb58305a7975d96c8a80c641ccb6cf80a4 Mon Sep 17 00:00:00 2001 From: John Beard <john.j.be...@gmail.com> Date: Tue, 21 Feb 2017 20:43:02 +0800 Subject: [PATCH 3/3] Use Bind rather than Connect in LAYER_WIDGET Bind is safer than Connect. Bind is more

Re: [Kicad-developers] [PATCH] Fix layer color swatches in Linux

2017-02-21 Thread John Beard
> >> > > > > If the single left click opens the dialog, be sure many times, >> > when clicking inside the layer >> > > > > manager, you will open the dialog, instead of changing the >> > active layer, especially if you are too >> > > > > busy clicking on the window to verify the e

[Kicad-developers] [PATCH] Move bitmaps.h out of base_struct.h

2017-02-20 Thread John Beard
. An additional benefit is that the icon list is now in its own header, which makes it easier to automate in future. Cheers, John From b72cbf3523c31e6e8af42d514beaa54b6ef5dd2e Mon Sep 17 00:00:00 2001 From: John Beard <john.j.be...@gmail.com> Date: Mon, 20 Feb 2017 20:20:39 +0800 Subject:

Re: [Kicad-developers] RICHIO performance - 3 to 30 times slower than std::ifstream

2017-02-19 Thread John Beard
On Sat, Feb 18, 2017 at 1:08 AM, Nox wrote: > What about wxFFileInputStream instead of wxFileInputStream? > wxFFileInputStream appears to be about 5-6 times faster than wxFileInputStream, but that's still much much slower than RICHIO or std::ifstream. $

Re: [Kicad-developers] Pushed new component selector

2017-02-19 Thread John Beard
On Sun, Feb 19, 2017 at 10:46 AM, Chris Pavlina wrote: > I just pushed the revamped component selector. > > Please, test thoroughly. Hi Chris, I get a bunch of asserts and then a crash on trying to place a part on an empty sheet. This on Linux on a few pull from LP. I

Re: [Kicad-developers] RICHIO performance - 3 to 30 times slower than std::ifstream

2017-02-16 Thread John Beard
e LINE_READER types. It > might be a bit more flexible if you just provided an ISTREAM_LINE_READER > that take any istream derived object rather than write a separate > LINE_READER for each istream derivative. > > Cheers, > > Wayne > > On 2/16/2017 8:43 AM, John Beard

[Kicad-developers] [PATCH] Add cancel interactive tool to GAL

2017-02-23 Thread John Beard
2001 From: John Beard <john.j.be...@gmail.com> Date: Tue, 7 Feb 2017 00:00:51 +0800 Subject: [PATCH] Add cancel interactive tool action to GAL This is used to provide menu entries that allows cancellation of interactive drawing and routing tools without needing the keyboard. It is pr

[Kicad-developers] [PATCH] Undo/redo points for zone fill actions (GAL)

2017-02-24 Thread John Beard
, legacy can use them as normal. Cheers, John From d9d18cd02e54ac3098e5b3ca7af667aeed3ef46b Mon Sep 17 00:00:00 2001 From: John Beard <john.j.be...@gmail.com> Date: Fri, 24 Feb 2017 20:26:43 +0800 Subject: [PATCH 1/4] When filling/unfilling zones, create undo points in GAL This is a feature

[Kicad-developers] [PATCH] Fix grid sizes in GAL modedit

2017-02-23 Thread John Beard
your words when reporting bugs - in this case mentioning that it was GAL only would have been a good pointer for a start! Cheers, John From 8911c539669832d5b4e261acbbe48ca9ffa25b98 Mon Sep 17 00:00:00 2001 From: John Beard <john.j.be...@gmail.com> Date: Thu, 23 Feb 2017 22:02:18 +0800 S

Re: [Kicad-developers] [PATCH] Select filter dialog in GAL

2017-02-22 Thread John Beard
could be moved somewhere else. > > Regards, > Orson > > 1. http://www.ohwr.org/attachments/4646/selection_filter.pdf > > On 02/22/2017 03:41 PM, John Beard wrote: >> Hi, >> >> I have rebased this branch over the new PCB_ACTION changes. >> >> Cheers,

Re: [Kicad-developers] [PATCH] Fix layer color swatches in Linux

2017-02-22 Thread John Beard
tidying up, and at least makes it usable and consistent across platforms for v5. Cheers, John On Tue, Feb 21, 2017 at 11:05 PM, John Beard <john.j.be...@gmail.com> wrote: > On Tue, Feb 21, 2017 at 10:41 PM, Wayne Stambaugh <stambau...@gmail.com> > wrote: >> I forgot to m

Re: [Kicad-developers] [PATCH] Fix layer color swatches in Linux

2017-02-22 Thread John Beard
Hi, Please use this branch instead: https://code.launchpad.net/~john-j-beard/kicad/+git/kicad/+ref/swatches The patches previously omitted the new colour picker in the rebase (which is kind of important!). Cheers, John On Thu, Feb 23, 2017 at 2:18 AM, John Beard <john.j.be...@gmail.

Re: [Kicad-developers] [PATCH] Select filter dialog in GAL

2017-02-22 Thread John Beard
Hi, I have rebased this branch over the new PCB_ACTION changes. Cheers, John On Sat, Feb 11, 2017 at 5:14 PM, John Beard <john.j.be...@gmail.com> wrote: > Hi, > > Here is a branch with a GAL action to invoke the block select dialog > and filter the current selection ba

[Kicad-developers] [PATCH] Update tool framework documention

2017-02-22 Thread John Beard
From: John Beard <john.j.be...@gmail.com> Date: Thu, 23 Feb 2017 10:47:19 +0800 Subject: [PATCH] Update GAL tool documentation Update to reference new PCB_ACTIONs (used to be COMMON_ACTION) Also expand on use of BOARD_COMMIT. Add doxygen TOC markup --- Documentation/development/tool-framew

[Kicad-developers] Fwd: {PATCH] Icon tweaks

2017-02-12 Thread John Beard
On Sat, Feb 11, 2017 at 5:54 AM, Nick Østergaard wrote: > While we are at it, what about making the line graphic icon such that > it matches the style of the arc and circle? That is making it not > dashed, and add anchor point indicators? I think that the "Graphic Line" tool

Re: [Kicad-developers] {PATCH] Icon tweaks

2017-02-12 Thread John Beard
we cannot start redesigning tons of new > icons because the documentation will then be heavily out of sync. > > thanks a lot > Fabrizio > > > On Fri, Feb 10, 2017 at 10:55 PM, John Beard <john.j.be...@gmail.com> wrote: >> >> And here are the same images with the ch

[Kicad-developers] [PATCH] GAL: Add similar and cutout zone tools

2017-02-10 Thread John Beard
Hi, This branch has patches for the Add Similar Zone and Add Zone Cutout tools in GAL: https://code.launchpad.net/~john-j-beard/kicad/+git/kicad/+ref/zone_tools They are preceded by a refactor which makes the tools themselves into relatively straightforward modifications of the existing

[Kicad-developers] [PATCH] Select filter dialog in GAL

2017-02-11 Thread John Beard
Hi, Here is a branch with a GAL action to invoke the block select dialog and filter the current selection based on the results: https://code.launchpad.net/~john-j-beard/kicad/+git/kicad/+ref/select_filter The first commit refactors the dialog so it can be reached by the GAL too, the second

Re: [Kicad-developers] {PATCH] Icon tweaks

2017-02-11 Thread John Beard
;> >> >> 2017-02-11 1:10 GMT+02:00 Ben Hest <bombledm...@gmail.com>: >>> >>> Not entirely sure which OS you are using, but LightShot [1] is fantastic >>> at being able take pictures of menus on Windows. (It works on Mac also) >>> >>> [1

Re: [Kicad-developers] {PATCH] Icon tweaks

2017-02-14 Thread John Beard
ank you > Fabrizio > > > > On Tue, Feb 14, 2017 at 3:39 PM, Wayne Stambaugh <stambau...@gmail.com> > wrote: >> >> Where do we stand on this? I think these changes should be committed. >> If there are no objections, please send a patch to the dev list

Re: [Kicad-developers] RFC: Change UX for item selection clarification

2017-02-12 Thread John Beard
On Mon, Feb 13, 2017 at 6:39 AM, Jon Evans wrote: > > The core of the issue is how KiCad thinks about selection of objects > compared to most other software that deals with graphical objects that the > user interacts with. > > Most applications have the concept of a "selection

Re: [Kicad-developers] Issues in right click context menu in GAL mode on Windows.

2017-02-10 Thread John Beard
On Fri, Feb 10, 2017 at 3:44 PM, Maciej Suminski wrote: > > On 02/08/2017 03:37 PM, jp charras wrote: >> >> For instance, Board editor: >> context menu for zones: submenus are not working. >> context menu with no tool: the pad export import menu is always shown. >>

[Kicad-developers] [PATCH] common.h tidyups

2017-02-09 Thread John Beard
Hi, I have a big set of patches on a branch that are mostly to do with stripping seldom-used functions out of common.h into more targeted headers: https://code.launchpad.net/~john-j-beard/kicad/+git/kicad/+ref/tidy_ups The idea here is to reduce the visibility of these functions from almost

Re: [Kicad-developers] [PATCH] Signal handlers for SINGLE_TOP and KICAD

2017-02-09 Thread John Beard
On Fri, Jan 27, 2017 at 12:44 AM, Wayne Stambaugh wrote: > Simon, > > Thanks for testing this. It was on my list but it looks like it has to > be fixed before we can commit it. > > Cheers, > > Wayne Thanks for testing on OSX, Simon. On Linux, I never see this, which must

Re: [Kicad-developers] [PATCH] common.h tidyups

2017-02-09 Thread John Beard
needs to be > merged. I'll try to take a look at it over the weekend. Keep up the > great work. > > Thanks, > > Wayne > > On 2/9/2017 8:44 AM, John Beard wrote: >> Hi, >> >> I have a big set of patches on a branch that are mostly to do with >>

[Kicad-developers] RICHIO performance - 3 to 30 times slower than std::ifstream

2017-02-16 Thread John Beard
this finding! Please find attached the benchmark program, such as it is. Cheers, John From 9030890b9ad86ff2601a0488ef6e0003dfbb2e66 Mon Sep 17 00:00:00 2001 From: John Beard <john.j.be...@gmail.com> Date: Wed, 15 Feb 2017 16:47:41 +0800 Subject: [PATCH] IO benchmark program: RICHIO vs std::fstream

Re: [Kicad-developers] [PATCH] Setting grid line sizes and density

2017-02-16 Thread John Beard
and hit Enter, pcbnew segfaults. I suspect > that kill focus event handler is executed after the window is gone, but > I am not fully sure. > > There are also a few minor patches, see the attachments. > > Cheers, > Orson > > On 02/16/2017 07:01 AM, John Beard wrote: >

Re: [Kicad-developers] [PATCH] Setting grid line sizes and density

2017-02-16 Thread John Beard
returning, otherwise things like Enter in a dialog can do an end run and not sanitise/update the value before returning. I have integrated your mods into the patch sequence in the appropriate places and rebased the branch onto master. Cheers, John On Fri, Feb 17, 2017 at 12:27 AM, John Beard

Re: [Kicad-developers] [PATCH] Fix crash when switching from dragging to routine (PNS router)

2017-02-27 Thread John Beard
Hi Julius, The TOOL_EVENT_UTILS functions are for generic event decision logic. That PCB_ACTIONS::routerInlineDrag acts as to cancel an in progress routing is specific to the ROUTER_TOOL event loop, so it should probably be OR'ed in in ROUTER_TOOL::performRouting(), like this: else if(

[Kicad-developers] [PATCH] Draw zone hatching in GAL

2017-02-26 Thread John Beard
00:00:00 2001 From: John Beard <john.j.be...@gmail.com> Date: Fri, 24 Feb 2017 20:26:25 +0800 Subject: [PATCH] Draw zone hatching in GAL This just uses the same hatch lines that are built into the zone as legacy. They are always drawn, even when there is a fill, as if the fill doesn't

  1   2   3   4   5   >