Re: [Kicad-developers] Bus upgrades merge

Thanks, JP. I've created https://bugs.launchpad.net/kicad/+bug/1838140. Cheers, Diego On Sat, 27 Jul 2019 at 15:03, jp charras wrote: > Le 27/07/2019 à 14:35, Diego Herranz a écrit : > > Hi, all. > > > > I'm using nightlies and facing a weird bug with buses. I was wondering > > whether it can

Re: [Kicad-developers] Bus upgrades merge

Hi, all. I'm using nightlies and facing a weird bug with buses. I was wondering whether it can be related to these bus upgrades. I've got a bus: ROW0, ROW1, ROW2, ROW3, ROW4, ROW5, ROW6, ROW7, which on the PCB layout becomes ROW0, ROW0, ROW0, ROW0, ROW0, ROW0, ROW0, ROW7 ??? It seems to be

Re: [Kicad-developers] Bus upgrades merge

I can move to stdlib regex; I'll look in to that later this week. On Wed, Apr 3, 2019 at 1:44 PM Wayne Stambaugh wrote: > Tom, > > On 4/3/2019 1:34 PM, Tomasz Wlostowski wrote: > > On 02/04/2019 17:27, Wayne Stambaugh wrote: > >> We should always be using wxLogTrace. Using printf and cout are

Re: [Kicad-developers] Bus upgrades merge

Tom, On 4/3/2019 1:34 PM, Tomasz Wlostowski wrote: > On 02/04/2019 17:27, Wayne Stambaugh wrote: >> We should always be using wxLogTrace. Using printf and cout are >> meaningless on windows and wxLogDebug means that your debugging output >> is always spewed on debug builds even when it's not

Re: [Kicad-developers] Bus upgrades merge

On 02/04/2019 17:27, Wayne Stambaugh wrote: > We should always be using wxLogTrace. Using printf and cout are > meaningless on windows and wxLogDebug means that your debugging output > is always spewed on debug builds even when it's not needed. I haven't > made the draconian move of making this

Re: [Kicad-developers] Bus upgrades merge

Tom and I were both doing penance for having added one of those arrays, so it was time to get us out of Purgatory. ;) > On 3 Apr 2019, at 13:37, Jon Evans wrote: > > Thanks Jeff! Changes look good to me. > > On Wed, Apr 3, 2019 at 6:28 AM Jeff Young > wrote: > Changes

Re: [Kicad-developers] Bus upgrades merge

Thanks Jeff! Changes look good to me. On Wed, Apr 3, 2019 at 6:28 AM Jeff Young wrote: > Changes are in. Jon (in particular) will want to pick them up soon. > > An array of SCH_PIN (mapped by LIB_PIN*) was created which replaces: > - the array of highlight flags > - the array of pin positions

Re: [Kicad-developers] Bus upgrades merge

Changes are in. Jon (in particular) will want to pick them up soon. An array of SCH_PIN (mapped by LIB_PIN*) was created which replaces: - the array of highlight flags - the array of pin positions - the array of brightened flags - the sparse array of dangling indices - the array (mapped by

Re: [Kicad-developers] Bus upgrades merge

Jeff, This makes sense to me so go ahead an push this to the main repo when it's ready. Wayne On 4/2/19 11:47 AM, Jeff Young wrote: >> ... I'm assuming SCH_PIN objects will only live inside the SCH_COMPONENT >> object. > > Correct. > > Cheers, > Jeff. >

Re: [Kicad-developers] Bus upgrades merge

Jeff, This makes sense to me. I'm assuming SCH_PIN objects will only live inside the SCH_COMPONENT object. I cannot see where a SCH_PIN object would be needed anywhere else. It might be useful to hide the SCH_PIN ctor to prevent unwanted construction by unauthorized code. Cheers, Wayne On

Re: [Kicad-developers] Bus upgrades merge

> ... I'm assuming SCH_PIN objects will only live inside the SCH_COMPONENT > object. Correct. Cheers, Jeff. ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe :

Re: [Kicad-developers] Bus upgrades merge

We should always be using wxLogTrace. Using printf and cout are meaningless on windows and wxLogDebug means that your debugging output is always spewed on debug builds even when it's not needed. I haven't made the draconian move of making this policy but maybe I should since we seem to be

Re: [Kicad-developers] Bus upgrades merge

Hi, Just a quick plug for two fairly useful ways to "modularise" debug to prevent insane amounts of logging overhead: * trace masking, so you can turn on only what is needed to log. If you want to conditionally trace more complex data, you can use wxLog::IsAllowedTraceMask to prevent doing

Re: [Kicad-developers] Bus upgrades merge

Running in a separate thread is one avenue I'm exploring. Right now in my testing, release builds are very fast (usually well below 100ms) JP raised some concerns because in his testing (using debug builds) it was unacceptably slow. I have tested on his designs with my computer, and rebuilds

Re: [Kicad-developers] Bus upgrades merge

Jon, I would think 100-150mS in release builds would be sufficient. Obviously faster would be better because any perceptible delay is going to annoy users. The problem with debug builds is they can vary significantly depending on the platform and the amount of debugging print output. I'm

Re: [Kicad-developers] Bus upgrades merge

Jeff, Before you push this to the main repo, please push the changes to your personal launchpad repo so I see what you are changing. I'm not sure merging these "shadow data structures" into SCH_PIN is necessarily the correct thing to do. The connectivity information really depends on the full

Re: [Kicad-developers] Bus upgrades merge

That sounds good, thanks! -Jon On Tue, Apr 2, 2019 at 8:44 AM Jeff Young wrote: > Hi Jon, > > Just a heads-up, you might want to delay any changes to this stuff till I > get a chance to merge. > > Over the years we’ve collected 5 shadow data structures for pins: > locations, dangling states,

Re: [Kicad-developers] Bus upgrades merge

Hi Jon, Just a heads-up, you might want to delay any changes to this stuff till I get a chance to merge. Over the years we’ve collected 5 shadow data structures for pins: locations, dangling states, highlight flags, brightened flags and now connections. I’m promoting your SCH_PIN_CONNECTION

Re: [Kicad-developers] Bus upgrades merge

Hmm… I don’t see any link between a SCH_PIN_CONNECTION and a SCH_CONNECTION. > On 1 Apr 2019, at 22:20, Jon Evans wrote: > > The pin should have a SCH_PIN_CONNECTION (via SCH_COMPONENT:: > m_pin_connections) which has a SCH_CONNECTION which is where the connectivity > info is stored. > You

Re: [Kicad-developers] Bus upgrades merge

Hi Jeff, You can call Name() on the connection object for the current sheet -- see SCH_EDIT_FRAME::HighlightConnectionAtPosition() for some reference code. GetDefaultNetName does not include the sheet path as it only returns candidate net names for pins, not the final net names used for

Re: [Kicad-developers] Bus upgrades merge

The pin should have a SCH_PIN_CONNECTION (via SCH_COMPONENT:: m_pin_connections) which has a SCH_CONNECTION which is where the connectivity info is stored. You want SCH_CONNECTION::Name() to get you the final netname. On Mon, Apr 1, 2019 at 5:15 PM Jeff Young wrote: > Name() appears to only be

Re: [Kicad-developers] Bus upgrades merge

Name() appears to only be on SHEET_PINs though. Or did I misread that? > On 1 Apr 2019, at 22:08, Jon Evans wrote: > > Hi Jeff, > > You can call Name() on the connection object for the current sheet -- see > SCH_EDIT_FRAME::HighlightConnectionAtPosition() for some reference code. >

Re: [Kicad-developers] Bus upgrades merge

Hi Jon, I’m trying to integrate the pin highlighting stuff with your merge. I’ve added some code to SCH_EDIT_FRAME::SetCurrentSheetHighlightFlags() which attempts to use the pin’s connection to see if it should be highlighted. However, I’m having two issues. 1) Is there a way to get the

Re: [Kicad-developers] Bus upgrades merge

Speaking of that, if anyone wants to be adventurous, you can test real-time by defining CONNECTIVITY_REAL_TIME and CONNECTIVITY_PROFILE. In my testing, it is so fast as to be seamless on most machines with most designs. There are a few edge cases where the regeneration can take longer, especially

Re: [Kicad-developers] Bus upgrades merge

No problem. I wanted to get this merged so we can get some additional testing. Hopefully you will be able to resolve the performance issues so we can have real time netlist generation and some of the nifty features that this will allow. On 3/31/2019 11:19 PM, Jon Evans wrote: > Thanks Wayne!

Re: [Kicad-developers] Bus upgrades merge

Thanks Wayne! Everything looks good to me. Glad to finally have this merged so that I can start building other improvements on top of it. On Sun, Mar 31, 2019 at 9:42 PM Wayne Stambaugh wrote: > Jon, > > I forgot to mention. Please take a look and make sure I didn't muck > anything up when

Re: [Kicad-developers] Bus upgrades merge

Jon, I forgot to mention. Please take a look and make sure I didn't muck anything up when you get a chance. Wayne On 3/31/19 9:38 PM, Wayne Stambaugh wrote: Jon, I merged your patch set into the master branch.  Thank you for all of your efforts. Cheers, Wayne On 3/31/19 7:50 PM, Jon

Re: [Kicad-developers] Bus upgrades merge

Jon, I merged your patch set into the master branch. Thank you for all of your efforts. Cheers, Wayne On 3/31/19 7:50 PM, Jon Evans wrote: Yes I just squashed the parts that dont compile on their own. On Sun, Mar 31, 2019, 19:48 Wayne Stambaugh > wrote:

Re: [Kicad-developers] Bus upgrades merge

Yes I just squashed the parts that dont compile on their own. On Sun, Mar 31, 2019, 19:48 Wayne Stambaugh wrote: > Jon, > > I thought we decided to squash your patch set or did you just squash > part of the patch set? I see 17 separate patches the archive you sent. > > Wayne > > On 3/31/19

Re: [Kicad-developers] Bus upgrades merge

Jon, I thought we decided to squash your patch set or did you just squash part of the patch set? I see 17 separate patches the archive you sent. Wayne On 3/31/19 7:39 PM, Jon Evans wrote: Attached! On Sun, Mar 31, 2019 at 7:28 PM Wayne Stambaugh > wrote:

Re: [Kicad-developers] Bus upgrades merge

Jon, Would you please post the squashed patch to the mailing list so I can get it merged? Thanks, Wayne On 3/31/19 3:07 PM, Jon Evans wrote: I went through and squashed the offending commits and updated the PRs. -Jon On Sun, Mar 31, 2019 at 2:22 PM Wayne Stambaugh

Re: [Kicad-developers] Bus upgrades merge

Thanks Jon!-SOn Mar 31, 2019 12:07 PM, Jon Evans wrote:I went through and squashed the offending commits and updated the PRs.-JonOn Sun, Mar 31, 2019 at 2:22 PM Wayne Stambaugh wrote:If that's the case then it may make the most sense to squash everything into a single

Re: [Kicad-developers] Bus upgrades merge

I went through and squashed the offending commits and updated the PRs. -Jon On Sun, Mar 31, 2019 at 2:22 PM Wayne Stambaugh wrote: > If that's the case then it may make the most sense to squash everything > into a single commit. > > On 3/31/19 2:17 PM, Jon Evans wrote: > > That one was very

Re: [Kicad-developers] Bus upgrades merge

If that's the case then it may make the most sense to squash everything into a single commit. On 3/31/19 2:17 PM, Jon Evans wrote: > That one was very late and would be easy to squash. However, some of the > very early commits in the branch were split up for review purposes and > not intended to

Re: [Kicad-developers] Bus upgrades merge

That one was very late and would be easy to squash. However, some of the very early commits in the branch were split up for review purposes and not intended to be built on their own. On Sun, Mar 31, 2019, 14:16 Wayne Stambaugh wrote: > When was the code that did not build on msvc introduced?

Re: [Kicad-developers] Bus upgrades merge

When was the code that did not build on msvc introduced? If was early then it might make sense to squash everything. Otherwise, it may be worthwhile squashing from the commit where the build error was introduced to and including the commit where the build error was fixed. I don't have a

Re: [Kicad-developers] Bus upgrades merge

Seth, I split up the initial rebased branch to make review a bit easier. I could squash everything into one huge commit if you'd prefer. On Sun, Mar 31, 2019 at 9:56 AM Seth Hillbrand wrote: > Am 2019-03-30 17:33, schrieb Simon Richter: > > Hi Wayne, > > > > On 30.03.19 21:30, Wayne Stambaugh

Re: [Kicad-developers] Bus upgrades merge

Hi, On 31.03.19 15:55, Seth Hillbrand wrote: > I use git bisect frequently.  Please do not push commits that do not > compile.  This has been done previously and it added hours to fixing a > single bug in 5.0.1. It's probably trivial: commit f67d243c368659798828dde87d9cf562c9176694 Author: Jon

Re: [Kicad-developers] Bus upgrades merge

Am 2019-03-30 17:33, schrieb Simon Richter: Hi Wayne, On 30.03.19 21:30, Wayne Stambaugh wrote: Is this the last of it? If so, I will attempt to get this merged tomorrow. Compiles fine on msys2 and msvc. Not all intermediate commits compile, but I'm not sure anyone does git-bisect anyway.

Re: [Kicad-developers] Bus upgrades merge

Hi Wayne, On 30.03.19 21:30, Wayne Stambaugh wrote: > Is this the last of it? If so, I will attempt to get this merged tomorrow. Compiles fine on msys2 and msvc. Not all intermediate commits compile, but I'm not sure anyone does git-bisect anyway. Simon signature.asc Description:

Re: [Kicad-developers] Bus upgrades merge

Is this the last of it? If so, I will attempt to get this merged tomorrow. Cheers, Wayne On 3/30/19 3:35 PM, Jon Evans wrote: > Oops! fixed. > > On Sat, Mar 30, 2019 at 3:03 PM Simon Richter > wrote: > > Hi Jon, > > On 30.03.19 19:23, Jon Evans

Re: [Kicad-developers] Bus upgrades merge

Oops! fixed. On Sat, Mar 30, 2019 at 3:03 PM Simon Richter wrote: > Hi Jon, > > On 30.03.19 19:23, Jon Evans wrote: > > > Rebased my branch (like I mentioned before, JP's usability concerns have > > been addressed for the moment by disabling immediate update until I can > > come up with a

Re: [Kicad-developers] Bus upgrades merge

Hi Jon, On 30.03.19 19:23, Jon Evans wrote: > Rebased my branch (like I mentioned before, JP's usability concerns have > been addressed for the moment by disabling immediate update until I can > come up with a better long-term fix) Fails to build on MSVC, because there is an

Re: [Kicad-developers] Bus upgrades merge

Rebased my branch (like I mentioned before, JP's usability concerns have been addressed for the moment by disabling immediate update until I can come up with a better long-term fix) On Sat, Mar 30, 2019 at 1:07 PM jp charras wrote: > Le 30/03/2019 à 13:33, Wayne Stambaugh a écrit : > > Jon, > >

Re: [Kicad-developers] Bus upgrades merge

Hi, On 30.03.19 17:27, Jon Evans wrote: > I have fixed a few issues, but since I can't be sure there are not still > performance issues in some situations, I have disabled real-time > connectivity updates for now so that this issue won't hold up the merge. > I will revisit this after any other

Re: [Kicad-developers] Bus upgrades merge

I have fixed a few issues, but since I can't be sure there are not still performance issues in some situations, I have disabled real-time connectivity updates for now so that this issue won't hold up the merge. I will revisit this after any other outstanding issues are fixed. On Sat, Mar 30, 2019

Re: [Kicad-developers] Bus upgrades merge

JP also just mentioned some performance issues that I'm going to look in to. I'll probably just hide the real-time connectivity updates behind a flag for now, and re-enable them with performance improvements after the branch is merged. -Jon On Sat, Mar 30, 2019, 08:34 Wayne Stambaugh wrote: >

Re: [Kicad-developers] Bus upgrades merge

Le 30/03/2019 à 13:33, Wayne Stambaugh a écrit : > Jon, > > I wanted to test complex hierarchy bus net connections which I just > haven't had time to look at. JP, did you check this during your > testing? If so and you didn't find any issues, then I will merge this > as soon as I get a chance.

Re: [Kicad-developers] Bus upgrades merge

Jon, I wanted to test complex hierarchy bus net connections which I just haven't had time to look at. JP, did you check this during your testing? If so and you didn't find any issues, then I will merge this as soon as I get a chance. If not, then I would like to test this and make sure there

Re: [Kicad-developers] Bus upgrades merge

Has anyone else been doing any testing? I have resolved some issues that JP found, but haven't heard from anyone else. -Jon On Fri, Mar 22, 2019 at 5:08 PM Wayne Stambaugh wrote: > I did some testing and the changes appear to have resolved the original > issues I found. One thing I did not

Re: [Kicad-developers] Bus upgrades merge

I did some testing and the changes appear to have resolved the original issues I found. One thing I did not test was complex hierarchical bus expansion. Has anyone else tested this yet? I hope to get to it over the weekend. It's definitely something that should be tested before we give it our

Re: [Kicad-developers] Bus upgrades merge

Am 2019-03-22 16:51, schrieb Seth Hillbrand: adjust but I'm seeing show stoppers. ** not ** seeing show stoppers. -S ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe :

Re: [Kicad-developers] Bus upgrades merge

Am 2019-03-12 17:11, schrieb Jon Evans: https://code.launchpad.net/~craftyjon/kicad/+git/kicad/+merge/364346 On Tue, Mar 12, 2019 at 4:32 PM Seth Hillbrand wrote: Am 2019-03-11 18:03, schrieb Jon Evans: Rebased branch is located here:

Re: [Kicad-developers] Bus upgrades merge

https://code.launchpad.net/~craftyjon/kicad/+git/kicad/+merge/364346 On Tue, Mar 12, 2019 at 4:32 PM Seth Hillbrand wrote: > Am 2019-03-11 18:03, schrieb Jon Evans: > > Rebased branch is located here: > > https://github.com/craftyjon/kicad/tree/bus_upgrades_merge > > I've also attached a

Re: [Kicad-developers] Bus upgrades merge

Am 2019-03-11 18:03, schrieb Jon Evans: Rebased branch is located here: https://github.com/craftyjon/kicad/tree/bus_upgrades_merge I've also attached a patchset for convenience. -Jon Hi Jon- Any chance you could you make a launchpad branch with a merge request for this? I'd like to ask

Re: [Kicad-developers] Bus upgrades merge (was: V6 merge priority)

Jon, On 3/11/2019 9:55 AM, Jon Evans wrote: > Hi Wayne, > > I will rebase and post an updated branch soon. Thanks! I should have time to review and test this weekend. > I will also generally be available to fix any bugs although will be > offline for a few days at a time here and there for

Re: [Kicad-developers] Bus upgrades merge (was: V6 merge priority)

If you do decide to merge but disable by default, please consider to use the kicad_advanced config. man. 11. mar. 2019 15.06 skrev Jon Evans : > Hi Wayne, > > I will rebase and post an updated branch soon. > I will also generally be available to fix any bugs although will be > offline for a few

[Kicad-developers] Bus upgrades merge (was: V6 merge priority)

Hi Wayne, I will rebase and post an updated branch soon. I will also generally be available to fix any bugs although will be offline for a few days at a time here and there for travel. If you would prefer, I could put the bus aliases feature behind a flag so that it is effectively disabled, and