Re: [Kicad-developers] OS X: pinch-to-zoom support for wxWidgets 3.1

Patch committed in product branch r6510. Thanks, Wayne On 1/17/2016 4:00 PM, Bernhard Stegmaier wrote: > Hi, > > current mainline pinch-to-zoom support on OS X only works with a patched > wxWidgets 3.0. > Pinch-to-zoom support now officially has arrived in wxWidgets master/3.1. > The attached

Re: [Kicad-developers] OS X: pinch-to-zoom support for wxWidgets 3.1

On 1/23/2016 2:05 AM, Bernhard Stegmaier wrote: > It is just the other way round!? > > wxWidgets 3.1 and above defines wxEVT_MAGNIFY for *all* patforms. > wxWidgets <3.1 doesn’t have this functionality *at all*. > The wxCHECK_VERSION is IMHO the official way to check for wxWidgets >= > 3.1, so

Re: [Kicad-developers] OS X: pinch-to-zoom support for wxWidgets 3.1

On 1/22/2016 1:49 AM, Bernhard Stegmaier wrote: > Hi, > > any objections or problems with this patch so it didn’t get applied yet? > Or, did it just get lost in some inboxes… Is there any reason not to build this when using wxWidgets 3.1 or greater? I'm guessing the wxMagnifyEvents will only

Re: [Kicad-developers] OS X: pinch-to-zoom support for wxWidgets 3.1

Le 22/01/2016 07:49, Bernhard Stegmaier a écrit : > Hi, > > any objections or problems with this patch so it didn’t get applied yet? > Or, did it just get lost in some inboxes… > > > Regards, > Bernhard > >> On 17 Jan 2016, at 22:00, Bernhard Stegmaier wrote: >> >>

Re: [Kicad-developers] OS X: pinch-to-zoom support for wxWidgets 3.1

It is just the other way round!? wxWidgets 3.1 and above defines wxEVT_MAGNIFY for *all* patforms. wxWidgets <3.1 doesn’t have this functionality *at all*. The wxCHECK_VERSION is IMHO the official way to check for wxWidgets >= 3.1, so this pieces of code will always compile when using wxWidgets

Re: [Kicad-developers] OS X: pinch-to-zoom support for wxWidgets 3.1

Hi, any objections or problems with this patch so it didn’t get applied yet? Or, did it just get lost in some inboxes… Regards, Bernhard > On 17 Jan 2016, at 22:00, Bernhard Stegmaier wrote: > > Hi, > > current mainline pinch-to-zoom support on OS X only works with

Re: [Kicad-developers] OS X: pinch-to-zoom support for wxWidgets 3.1

Aha ok, I see, I guess I should have tried to look up the doc for that then. 2016-01-19 0:04 GMT+01:00 Garth Corral : > wxCHECK_VERSION > > bool wxCHECK_VERSION(major, minor, release) > > This is a macro which evaluates to true if the current wxWidgets version is > at least

Re: [Kicad-developers] OS X: pinch-to-zoom support for wxWidgets 3.1

It is an oddly named macro who’s intent is not clear from the name. > On Jan 18, 2016, at 3:14 PM, Nick Østergaard wrote: > > Aha ok, I see, I guess I should have tried to look up the doc for that then. > > 2016-01-19 0:04 GMT+01:00 Garth Corral : >>

Re: [Kicad-developers] OS X: pinch-to-zoom support for wxWidgets 3.1

Mmm, I think this patch looks a bit wierd. It is quite possible that I just don't know what exactly the issues are with this stuff on OS X, but why do just add a check specifically for wx 3.1.0? What about never wx versions? 2016-01-17 22:00 GMT+01:00 Bernhard Stegmaier :

Re: [Kicad-developers] OS X: pinch-to-zoom support for wxWidgets 3.1

wxCHECK_VERSION bool wxCHECK_VERSION(major, minor, release) This is a macro which evaluates to true if the current wxWidgets version is at least major.minor.release. > On Jan 18, 2016, at 12:42 PM, Nick Østergaard wrote: > > Mmm, I think this patch looks a bit wierd. It

[Kicad-developers] OS X: pinch-to-zoom support for wxWidgets 3.1

Hi, current mainline pinch-to-zoom support on OS X only works with a patched wxWidgets 3.0. Pinch-to-zoom support now officially has arrived in wxWidgets master/3.1. The attached patch also adds support for pinch-to-zoom with official (unpatched) wxWidgets master/3.1. It should be safe for all