https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
Katrin Fischer changed:
What|Removed |Added
Keywords|release-notes-needed|
Text to go in the|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
Fridolin Somers changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
Tomás Cohen Arazi changed:
What|Removed |Added
Blocks||36790
Referenced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
--- Comment #61 from Tomás Cohen Arazi ---
Created attachment 166219
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166219=edit
Bug 25159: (QA follow-up) Make dbrev idempotent
Signed-off-by: Tomas Cohen Arazi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
--- Comment #60 from Kyle M Hall ---
I chose Struct::Diff because if generated the best format for the use case. I
doubt a library like Struct::Diff requires much, if anything, in the way of
maintenance. That said I see no problem
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
--- Comment #59 from Martin Renvoize ---
Looks like I maintained my own JSON::Patch library back then. 8 years ago,
wow.. I should really have upstreamed it to cpan.
Anywho, I think Struct::Diff, whilst not the nicest output for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
Angela Berrett changed:
What|Removed |Added
CC|angela.berrett@familysearch |
|.org
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
--- Comment #58 from Martin Renvoize ---
I asked the question to myself whilst QAing and couldn't find any comparable
module..
Data::Compare isn't one I came across but a quick look now suggests it has very
different output and
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
Katrin Fischer changed:
What|Removed |Added
Summary|Action logs should be |Action logs should be
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
--- Comment #57 from Marcel de Rooy ---
Why did we choose here for a perl module that has no Debian package?
Just glancing over cpan I am seeing for instance Data::Compare with a Debian
package libdata-compare-perl.
And note that
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
--- Comment #56 from Katrin Fischer ---
Pushed for 24.05!
Well done everyone, thank you!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
Katrin Fischer changed:
What|Removed |Added
Version(s)||24.05.00
released
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
Martin Renvoize changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
Chip Halvorsen changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
--- Comment #55 from Mason James ---
(In reply to Mason James from comment #53)
> (In reply to Katrin Fischer from comment #52)
> > Ok, this introduces a new dependency. We will need the packaging team to
> > have a look at this.
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
--- Comment #54 from Kyle M Hall ---
(In reply to Mason James from comment #53)
> (In reply to Katrin Fischer from comment #52)
> > Ok, this introduces a new dependency. We will need the packaging team to
> > have a look at this.
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
--- Comment #53 from Mason James ---
(In reply to Katrin Fischer from comment #52)
> Ok, this introduces a new dependency. We will need the packaging team to
> have a look at this.
>
> +use Struct::Diff qw( diff );
i'll have a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
Katrin Fischer changed:
What|Removed |Added
CC||m...@kohaaloha.com
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
Katrin Fischer changed:
What|Removed |Added
Keywords||rel_24_05_candidate
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
Katrin Fischer changed:
What|Removed |Added
Status|Passed QA |Signed Off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
--- Comment #51 from Katrin Fischer ---
This is quite an odd one, I can't seem to run QA tools on the patch set.
FAILC4/Log.pm
FAIL pod coverage
POD coverage was greater before, try perl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
Martin Renvoize changed:
What|Removed |Added
Blocks||36699
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
Martin Renvoize changed:
What|Removed |Added
Blocks||36698
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
Martin Renvoize changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
--- Comment #49 from Martin Renvoize ---
Created attachment 165532
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165532=edit
Bug 25159: (QA follow-up) Tidy changes
Signed-off-by: Martin Renvoize
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
Martin Renvoize changed:
What|Removed |Added
Attachment #164601|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
Martin Renvoize changed:
What|Removed |Added
Attachment #164600|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
Martin Renvoize changed:
What|Removed |Added
Attachment #164599|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
Martin Renvoize changed:
What|Removed |Added
Attachment #164598|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
Martin Renvoize changed:
What|Removed |Added
Attachment #164597|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
--- Comment #43 from Emmi Takkinen ---
(In reply to Kyle M Hall from comment #42)
> (In reply to Emmi Takkinen from comment #41)
> > Tests for this bug are OK but prove t/db_dependent/Log.t fails on following
> > error:
> >
> > #
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
--- Comment #42 from Kyle M Hall ---
(In reply to Emmi Takkinen from comment #41)
> Tests for this bug are OK but prove t/db_dependent/Log.t fails on following
> error:
>
> # Failed test 'Reduce log size by unblessing Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
David Cook changed:
What|Removed |Added
CC||dc...@prosentient.com.au
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
--- Comment #41 from Emmi Takkinen ---
Tests for this bug are OK but prove t/db_dependent/Log.t fails on following
error:
# Failed test 'Reduce log size by unblessing Koha objects'
# at t/db_dependent/Log.t line 195.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
Emmi Takkinen changed:
What|Removed |Added
Attachment #159758|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
Emmi Takkinen changed:
What|Removed |Added
Attachment #153646|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
Emmi Takkinen changed:
What|Removed |Added
Attachment #153645|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
Emmi Takkinen changed:
What|Removed |Added
Attachment #153644|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
Emmi Takkinen changed:
What|Removed |Added
Attachment #153643|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
Laura O'Neil changed:
What|Removed |Added
CC||la...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
Angela Berrett changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
--- Comment #35 from Kyle M Hall ---
Created attachment 159758
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159758=edit
Bug 25159: (QA follow-up) Allow passing of 'original' as hashref or
Koha::Object
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
Kyle M Hall changed:
What|Removed |Added
Status|Failed QA |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
--- Comment #34 from Kyle M Hall ---
> Replace:
> +my $original = C4::Context->preference('HoldsLog') ? $self->unblessed :
> undef;
> +logaction( 'HOLDS', 'SUSPEND', $self->reserve_id, $self, undef,
> $original )
>
> With
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
--- Comment #33 from Jonathan Druart ---
(In reply to Kyle M Hall from comment #32)
> (In reply to Jonathan Druart from comment #29)
> > 1. I am not sure, but maybe we could pass $self and log
> > $self->get_from_store as the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
--- Comment #32 from Kyle M Hall ---
(In reply to Jonathan Druart from comment #29)
> 1. I am not sure, but maybe we could pass $self and log
> $self->get_from_store as the original (?)
> Maybe we will lose flexibility however.
I
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
Lisette Scheer changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |Failed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
Jonathan Druart changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
--- Comment #28 from Kyle M Hall ---
Created attachment 153646
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153646=edit
Bug 25159: Implement diffs in action logs for holds
Test Plan:
1) Apply this patch
2) Run
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
--- Comment #27 from Kyle M Hall ---
Created attachment 153645
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153645=edit
Bug 25159: Add ability to specify a pre-modified version of action log data and
store as
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
--- Comment #26 from Kyle M Hall ---
Created attachment 153644
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153644=edit
Bug 25159: Update Schema File [DO NOT PUSH]
Signed-off-by: Kyle Hall
Signed-off-by:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
Kyle M Hall changed:
What|Removed |Added
Attachment #153637|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
Kyle M Hall changed:
What|Removed |Added
Attachment #153611|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
--- Comment #23 from Kyle M Hall ---
(In reply to Andrew Fuerste-Henry from comment #22)
> Those signoffs are actually mine, produced on a sandbox. Thanks!
I'll get those fixed!
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
Katie Bliss changed:
What|Removed |Added
CC||kebl...@dmpl.org
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
Andrew Fuerste-Henry changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
ByWater Sandboxes changed:
What|Removed |Added
Attachment #153609|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
ByWater Sandboxes changed:
What|Removed |Added
Attachment #153608|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
ByWater Sandboxes changed:
What|Removed |Added
Attachment #153607|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
ByWater Sandboxes changed:
What|Removed |Added
Attachment #153606|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
--- Comment #17 from Kyle M Hall ---
Created attachment 153609
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153609=edit
Bug 25159: Implement diffs in action logs for holds
Test Plan:
1) Apply this patch
2) Run
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
--- Comment #16 from Kyle M Hall ---
Created attachment 153608
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153608=edit
Bug 25159: Add ability to specify a pre-modified version of action log data and
store as
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
--- Comment #15 from Kyle M Hall ---
Created attachment 153607
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153607=edit
Bug 25159: Update Schema File [DO NOT PUSH]
--
You are receiving this mail because:
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
Kyle M Hall changed:
What|Removed |Added
Attachment #153601|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
--- Comment #13 from Kyle M Hall ---
Created attachment 153604
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153604=edit
Bug 15159: Implement diffs in action logs for holds
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
--- Comment #12 from Kyle M Hall ---
Created attachment 153603
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153603=edit
Bug 15159: Add ability to specify a pre-modified version of action log data and
store as
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
--- Comment #11 from Kyle M Hall ---
Created attachment 153602
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153602=edit
Bug 25159: Update Schema File [DO NOT PUSH]
--
You are receiving this mail because:
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
Kyle M Hall changed:
What|Removed |Added
Attachment #153600|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
--- Comment #9 from Kyle M Hall ---
Created attachment 153600
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153600=edit
Bug 25159: DB Update
--
You are receiving this mail because:
You are watching all bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
Kyle M Hall changed:
What|Removed |Added
Status|NEW |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
--- Comment #8 from Katrin Fischer ---
I think it's a good idea, our current logs all log a little differently. A
'fresh start' in a new column makes sense to get out of the situation
incrementally.
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
Michaela Sieber changed:
What|Removed |Added
CC||michaela.sie...@kit.edu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
Sally changed:
What|Removed |Added
CC||sally.healey@cheshireshared
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
--- Comment #7 from Andrew Fuerste-Henry ---
(In reply to Kyle M Hall from comment #6)
> I'm going to propose we begin by adding a new column named "diff" to the
> action_logs table to store this json formatted diff. Once that's in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
--- Comment #6 from Kyle M Hall ---
I'm going to propose we begin by adding a new column named "diff" to the
action_logs table to store this json formatted diff. Once that's in we can work
on the viewer as a followup.
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
Barbara Johnson changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
Andreas Roussos changed:
What|Removed |Added
CC||a.rous...@dataly.gr
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
Emmi Takkinen changed:
What|Removed |Added
CC||emmi.takki...@koha-suomi.fi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
Emily Lamancusa changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
Andrew Fuerste-Henry changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
Tomás Cohen Arazi changed:
What|Removed |Added
CC||tomasco...@gmail.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
--- Comment #2 from Kyle M Hall ---
Yet another benefit would be the ability to run queries against the action
log's data if/when the DBMS is JSON aware ( mysql 5.7 / maraia 10.2.3 ).
--
You are receiving this mail because:
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
--- Comment #1 from Kyle M Hall ---
If we used Scruct::Diff, we should keep the old values, but omit unchanged
values
$diff = diff($x, $y, noU => 1 ); # omit unchanged items
This would give:
{
"D": {
"cardnumber": {
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159
Kyle M Hall changed:
What|Removed |Added
Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
85 matches
Mail list logo