https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
--- Comment #72 from Victor Grousset/tuxayo ---
> Instead of disabling overlay rules to change the record - I updated the MARC
> modificatoin template for the 300 to set value 'FAILFAILFAILFAIL'
> After applying, updating,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
--- Comment #71 from Victor Grousset/tuxayo ---
UI: The MARCOverlayRules preference is not set, don't forget to enable it for
rules to take effect.
No, wait, I just missed that. Retesting. (good, bisecting that would have been
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
--- Comment #70 from Victor Grousset/tuxayo ---
> 6. 300$a should have been catified (expected, that's the bug)
> 7. 245$a is preserved
There has been something up in main since last time I tested this. So, without
patches, both
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
Nick Clemens (kidclamp) changed:
What|Removed |Added
Status|Signed Off |Failed QA
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
Katrin Fischer changed:
What|Removed |Added
Keywords||RM_priority
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
Katrin Fischer changed:
What|Removed |Added
Severity|enhancement |normal
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
--- Comment #67 from David Gustafsson ---
Thanks, no problem!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
Victor Grousset/tuxayo changed:
What|Removed |Added
Text to go in the|This enhancement changes|This enhancement
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
--- Comment #65 from David Gustafsson ---
Hi! No problem. I think Victor Grousset/tuxayo removed the release note,
perhaps by mistake, but now re-added it again.
--
You are receiving this mail because:
You are watching all bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
David Gustafsson changed:
What|Removed |Added
Text to go in the||This enhancement changes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
--- Comment #64 from Katrin Fischer ---
(In reply to David Gustafsson from comment #63)
> @Victor Grousset/tuxayo
>
> Ok, thanks for the feedback and test plan. I now submitted a release note.
> It's not that easy to explain the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
Victor Grousset/tuxayo changed:
What|Removed |Added
Text to go in the|This enhancement changes|
release
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
Miranda Nero changed:
What|Removed |Added
CC||mn...@oslri.net
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
David Gustafsson changed:
What|Removed |Added
Text to go in the|This enhancement changes|This enhancement changes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
David Gustafsson changed:
What|Removed |Added
Text to go in the|This enhancement changes|This enhancement changes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
--- Comment #63 from David Gustafsson ---
@Victor Grousset/tuxayo
Ok, thanks for the feedback and test plan. I now submitted a release note. It's
not that easy to explain the change in clear terms, so suggestions are welcome
if
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
David Gustafsson changed:
What|Removed |Added
Patch complexity|--- |Medium patch
Change
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
Victor Grousset/tuxayo changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #162805|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #162804|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #162803|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #162802|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #162801|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
--- Comment #56 from Victor Grousset/tuxayo ---
(In reply to David Gustafsson from comment #55)
> Yes, exactly.
I retried and it works!!! :D
I might have messed something because I should have been blocked at step:
> 8. Change the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
--- Comment #55 from David Gustafsson ---
Yes, exactly. You could try this script (run with koha-shell -c
"perl ":
use Koha::MarcOverlayRules;
use Data::Dumper;
my $rules = Koha::MarcOverlayRules->context_rules({ source =>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
--- Comment #54 from Victor Grousset/tuxayo ---
> I'm not able to reproduce your test case, for me it seems to work.
> [...]
> Works for me also with the latest version of the patch
So you followed the steps and at the 11th you got
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
David Gustafsson changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
--- Comment #52 from David Gustafsson ---
About the tests there is no difference testing manually vs the test cases with
the exception if there is an incorrect overlay_context parameter for ModBiblio
somewhere, and that has already
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
Victor Grousset/tuxayo changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #162800|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #162799|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #162798|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #162797|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #162796|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
--- Comment #45 from Victor Grousset/tuxayo ---
Thanks for the follow-up David.
I moved the tests to their own commit (with a generic commit message that would
benefit some completion) and reordered so we have all the test changes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
--- Comment #44 from Victor Grousset/tuxayo ---
Created attachment 162800
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162800=edit
Bug 33268: (QA follow-up): tidy up code
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #162786|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #160017|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #160018|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
--- Comment #40 from Victor Grousset/tuxayo ---
Created attachment 162796
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162796=edit
Bug 33268: Add tests
Sponsored-by: Gothenburg University Library
Signed-off-by:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
David Gustafsson changed:
What|Removed |Added
Attachment #162785|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
David Gustafsson changed:
What|Removed |Added
Attachment #162767|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
--- Comment #37 from David Gustafsson ---
Discovered an issue with the previous version of the update script which should
now be fixed.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
--- Comment #36 from David Gustafsson ---
2) Should now be fixed
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
David Gustafsson changed:
What|Removed |Added
Attachment #162766|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
David Gustafsson changed:
What|Removed |Added
Attachment #162764|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
--- Comment #33 from David Gustafsson ---
Created attachment 162764
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162764=edit
Bug 33268: If rules exists add rules sure to preserve current behaviour
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
David Gustafsson changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
--- Comment #31 from Ray Delahunty ---
I've just set up my first overlay rule in our test server and my clumsy
workaround to protect 506, 541, 561 and 562 (set up 4 sets of rules, for each
filter of Staff interface MARC editor,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
Ray Delahunty changed:
What|Removed |Added
CC||r.delahu...@arts.ac.uk
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
--- Comment #30 from Katrin Fischer ---
I am sad to see this has dropped off the radar.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
--- Comment #29 from Katrin Fischer ---
*ping*
This is waiting now waiting for feedback for more than 2 weeks.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
Katrin Fischer changed:
What|Removed |Added
Status|Passed QA |Failed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
Martin Renvoize changed:
What|Removed |Added
Status|Signed Off |Passed QA
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
Martin Renvoize changed:
What|Removed |Added
Attachment #159519|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
Martin Renvoize changed:
What|Removed |Added
Attachment #159518|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
--- Comment #24 from Tomás Cohen Arazi ---
(In reply to Marcel de Rooy from comment #18)
>
> Please tidy inline.
Done!
I think the fact '*' rules don't stack up is a bit confusing, but it makes
sense. We should (maybe) name it
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
--- Comment #23 from Tomás Cohen Arazi ---
Created attachment 159519
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159519=edit
Bug 33268: Add tests for context module priority
Signed-off-by: David Nind
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #159160|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Failed QA |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
Victor Grousset/tuxayo changed:
What|Removed |Added
CC||vic...@tuxayo.net
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
--- Comment #20 from Katrin Fischer ---
We are keen on the feature, but not on the right version yet. I know of at
least one big library that will be using it in production very soon.
I found the current behaviour with * confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
--- Comment #19 from Marcel de Rooy ---
It would be nice to know how many libraries have enabled OverlayRules btw.
Unfortunately this pref is not sent to HEA ;)
I need to study the manual what is actually meant by Delete and Remove
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
Marcel de Rooy changed:
What|Removed |Added
CC||m.de.r...@rijksmuseum.nl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
David Nind changed:
What|Removed |Added
Attachment #159058|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
David Nind changed:
What|Removed |Added
Attachment #159004|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
David Nind changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
David Gustafsson changed:
What|Removed |Added
Assignee|koha-b...@lists.koha-commun |glask...@gmail.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
David Gustafsson changed:
What|Removed |Added
Status|In Discussion |Needs Signoff
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
--- Comment #14 from David Gustafsson ---
Created attachment 159058
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159058=edit
Bug 33268: Add tests for context module priority
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
--- Comment #13 from David Gustafsson ---
Would be nice with some feedback whether this is preferable to the current way
rules are evaluated, will also need to update documentation in the manual.
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
--- Comment #12 from David Gustafsson ---
Now added some tests, it would probably be a good idea to add a test for
multiple contexts with regards to module precedence. Besides from that it
should be ready for review. Also have not
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
David Gustafsson changed:
What|Removed |Added
Attachment #158956|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
David Gustafsson changed:
What|Removed |Added
Status|NEW |In Discussion
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
--- Comment #9 from David Gustafsson ---
Created attachment 158956
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158956=edit
Bug 33268: Overlay rules don't work correctly when source is set to *
Fallback to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
--- Comment #8 from David Gustafsson ---
To summarize how the rules would be applied in a less convoluted way, for a
specific tag and context:
First all the rules for the matching module filter combination (context) are
evaluated,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
--- Comment #7 from David Gustafsson ---
I have to correct my previous comment, if context + filter (context) has higher
priority, but default rules are still merged in (but only if a rule with an
exact match on context already does
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
--- Comment #6 from David Gustafsson ---
Context is module and filter, so if rules are applied with either z3950 or
batchmod, '*' rules are ignored. '*' rules are only applied if there are no
rules defined for the current context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
--- Comment #5 from Katrin Fischer ---
Hm, If they were intended as a fallback, why does my second rule in the example
above not work?
What is context here?
--
You are receiving this mail because:
You are watching all bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
David Gustafsson changed:
What|Removed |Added
CC||glask...@gmail.com
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
Michaela Sieber changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
Nick Clemens changed:
What|Removed |Added
CC||jonathan.druart+koha@gmail.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
Katrin Fischer changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
--- Comment #1 from Katrin Fischer ---
It would be great if this could get some attention as it can create data loss.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
Katrin Fischer changed:
What|Removed |Added
Depends on||14957
Referenced Bugs:
85 matches
Mail list logo