Re: [Autotest] [PATCH 18/18] KVM test: Add subtest of testing offload by ethtool

2010-09-23 Thread Lucas Meneghel Rodrigues
On Thu, 2010-09-23 at 19:11 +0530, pradeep wrote: On Tue, 14 Sep 2010 19:25:43 -0300 Lucas Meneghel Rodrigues l...@redhat.com wrote: The latest case contains TX/RX/SG/TSO/GSO/GRO/LRO test. RTL8139 NIC doesn't support TSO, LRO, it's too old, so drop offload test from rtl8139. LRO, GRO

[PATCH] KVM-test: Update pci_hotplug to suit for new qemu

2010-09-23 Thread Lucas Meneghel Rodrigues
From: Yiqiao Pu y...@redhat.com In the new version of qemu device_add is instead of pci_add. So modify the scripts to suit for the new version of qemu. Now both nic and block devices are support in qemu, so keep using monitor command line for this test. Changs from v1: Can support block device

Re: [Autotest] [PATCH] KVM-test: Update pci_hotplug to suit for new qemu

2010-09-23 Thread Lucas Meneghel Rodrigues
On Thu, 2010-09-23 at 21:11 -0300, Lucas Meneghel Rodrigues wrote: From: Yiqiao Pu y...@redhat.com In the new version of qemu device_add is instead of pci_add. So modify the scripts to suit for the new version of qemu. Now both nic and block devices are support in qemu, so keep using monitor

[PATCH 0/2] Make all linux guests to use cdrom instead of floppy to hold answer file

2010-09-20 Thread Lucas Meneghel Rodrigues
This patchset contains a lot of much needed cleanups for the unattended install setup code. As the final user visible result, it is now possible to use both floppy as cdrom to hold the kickstart/autoyast file (cdrom default). Lucas Meneghel Rodrigues (2): KVM test: Cleaning up scripts

[PATCH 1/2] KVM test: Cleaning up scripts/unattended.py

2010-09-20 Thread Lucas Meneghel Rodrigues
functions that were not essential to the code's functionality Also, fixed the configuration files to use all windows virtio paths unescaped. Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com --- client/tests/kvm/scripts/unattended.py | 314 +--- client/tests

[PATCH 00/18] KVM autotest network patchset v3

2010-09-14 Thread Lucas Meneghel Rodrigues
Lucas Meneghel Rodrigues (6): KVM test: Make physical_resources_check to work with MAC management KVM test: Remove address_pools.cfg dependency KVM test: Add a get_ifname function KVM Test: Add a common ping module for network related tests KVM test: Add a subtest jumbo KVM test: Add

[PATCH 01/18] KVM test: Add a new macaddress pool algorithm

2010-09-14 Thread Lucas Meneghel Rodrigues
From: Amos Kong ak...@redhat.com Old method uses the addresses in the config files which could lead serious problem when multiple tests running in different hosts. This patch adds a new macaddress pool algorithm, it generates the mac prefix based on mac address of the host, and fix it to

[PATCH 02/18] KVM test: Make physical_resources_check to work with MAC management

2010-09-14 Thread Lucas Meneghel Rodrigues
The previous MAC address management breaks up the physical_resources_check test (the test picks up NIC MAC parameters from test parameters). Let's fix it by making it retrieve params from the method VM.get_mac_address() Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com --- client/tests/kvm

[PATCH 03/18] KVM test: Remove address_pools.cfg dependency

2010-09-14 Thread Lucas Meneghel Rodrigues
Since the previous patch introduces an automated management mechanism for MAC addresses, let's simplify things a bit by removing address_pools.cfg parsing from the control files, as well as just removing address_pools.cfg.sample. Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com --- client

[PATCH 10/18] KVM test: Add a subtest of nic promisc

2010-09-14 Thread Lucas Meneghel Rodrigues
From: Amos Kong ak...@redhat.com This test mainly covers TCP sent from host to guest and from guest to host with repeatedly turn on/off NIC promiscuous mode. Changes from v1: - Don't abruptly fail the whole test if we get a failure for a single size Signed-off-by: Amos Kong ak...@redhat.com ---

[PATCH 08/18] KVM test: Add basic file transfer test

2010-09-14 Thread Lucas Meneghel Rodrigues
From: Amos Kong ak...@redhat.com This test is the basic test of transfering file between host and guest. Try to transfer a large file from host to guest, and transfer it back to host, then compare the files by calculate their md5 hash. The default file size is 4000M, scp timeout is 1000s. It

[PATCH 13/18] KVM test: Add a subtest of changing MAC address

2010-09-14 Thread Lucas Meneghel Rodrigues
From: Amos Kong ak...@redhat.com Test steps: 1. Get a new mac from pool, and the old mac addr of guest. 2. Execute the mac_change.sh in guest. 3. Relogin to guest and query the interfaces info by `ifconfig` Signed-off-by: Cao, Chen k...@redhat.com Signed-off-by: Amos Kong ak...@redhat.com ---

[PATCH 09/18] KVM test: Add a subtest of load/unload nic driver

2010-09-14 Thread Lucas Meneghel Rodrigues
From: Amos Kong ak...@redhat.com Repeatedly load/unload nic driver, try to transfer file between guest and host by threads at the same time, and check the md5sum. Changes from v1: - Use a new method to get nic driver name - Use utils.hash_file() to get md5sum Signed-off-by: Amos Kong

[PATCH 14/18] KVM test: Add a netperf subtest

2010-09-14 Thread Lucas Meneghel Rodrigues
From: Amos Kong ak...@redhat.com Add network load by netperf, server is launched on guest, execute netperf client with different protocols on host. if all clients execute successfully, case will be pass. Test result will be record into result.txt. Now this case only tests with TCP_RR TCP_CRR

[PATCH 15/18] KVM test: kvm_utils - Add support of check if remote port free

2010-09-14 Thread Lucas Meneghel Rodrigues
From: Amos Kong ak...@redhat.com Signed-off-by: Amos Kong ak...@redhat.com --- client/tests/kvm/kvm_utils.py | 23 +++ 1 files changed, 15 insertions(+), 8 deletions(-) diff --git a/client/tests/kvm/kvm_utils.py b/client/tests/kvm/kvm_utils.py index bb5c868..71ab7d1 100644

[PATCH 16/18] KVM test: Improve vlan subtest

2010-09-14 Thread Lucas Meneghel Rodrigues
From: Amos Kong ak...@redhat.com This is an enhancement of existed vlan test. Rename the vlan_tag.py to vlan.py, it is more reasonable. . Setup arp from /proc/sys/net/ipv4/conf/all/arp_ignore . Multiple vlans exist simultaneously . Test ping between same and different vlans . Test by TCP data

[PATCH 17/18] KVM test: vlan subtest - Replace extra_params '-snapshot' with image_snapshot

2010-09-14 Thread Lucas Meneghel Rodrigues
From: Amos Kong ak...@redhat.com Framework could not totalise default extra_params and extra_params_vm1 in the following condition, it's difficult to realise when parsing config file or calling get_sub_dict*(). extra_params += ' str1' - case: extra_params_vm1 += str2 Signed-off-by: Amos Kong

[PATCH 18/18] KVM test: Add subtest of testing offload by ethtool

2010-09-14 Thread Lucas Meneghel Rodrigues
The latest case contains TX/RX/SG/TSO/GSO/GRO/LRO test. RTL8139 NIC doesn't support TSO, LRO, it's too old, so drop offload test from rtl8139. LRO, GRO are only supported by latest kernel, virtio nic doesn't support receive offloading function. Initialize the callbacks first and execute all the

[PATCH 12/18] KVM test: Add a subtest of pxe

2010-09-14 Thread Lucas Meneghel Rodrigues
From: Amos Kong ak...@redhat.com This case just snoop tftp packet through tcpdump, it depends on public dhcp server, better to test it through dnsmasq. FIXME: Use dnsmasq for pxe test Signed-off-by: Jason Wang jasow...@redhat.com Signed-off-by: Amos Kong ak...@redhat.com ---

[PATCH 11/18] KVM test: Add a subtest of multicast

2010-09-14 Thread Lucas Meneghel Rodrigues
From: Amos Kong ak...@redhat.com Use 'ping' to test send/recive multicat packets. Flood ping test is also added. Limit guest network as 'bridge' mode, because multicast packets could not be transmitted to guest when using 'user' network. Add join_mcast.py for joining machine into multicast

[PATCH 05/18] KVM Test: Add a common ping module for network related tests

2010-09-14 Thread Lucas Meneghel Rodrigues
The kvm_net_utils.py is a just a place that wraps common network related commands which is used to do the network-related tests. Use -1 as the packet ratio for loss analysis. Use quiet mode when doing the flood ping. Changes from v1: - Use None to indicate that the session should be local in

[PATCH] KVM test: Fix command to install virtio driver msi install package

2010-09-14 Thread Lucas Meneghel Rodrigues
won't loose time trying to figure out why the msi is not being installed. Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com --- client/tests/kvm/tests_base.cfg.sample |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/client/tests/kvm/tests_base.cfg.sample b/client

Re: [Autotest] [KVM-AUTOTEST] Patch to install cygwin and run autotest in windows

2010-09-13 Thread Lucas Meneghel Rodrigues
On Mon, 2010-09-13 at 15:01 +0530, yogi wrote: Hello Lucas, I like to submit patch to do unattended install of cygwin and run autotest test case on Windows guests using cygwin. Cygwin enable running some of test like stress, lmbench, bonnie, compilebench and netperf directly under windows,

Re: [KVM-AUTOTEST PATCH] tests/kvm: fix -net syntax for new qemu

2010-09-13 Thread Lucas Meneghel Rodrigues
On Mon, 2010-09-13 at 19:43 +0200, Michael S. Tsirkin wrote: netdev option in new qemu is mutually exclusive with vlan. Only pass vlan if netdev option is missing. Looks good to me, applied, thanks! http://autotest.kernel.org/changeset/4783 Signed-off-by: Michael S. Tsirkin m...@redhat.com

[PATCH] KVM-test: Add a new macaddress pool algorithm v3

2010-09-12 Thread Lucas Meneghel Rodrigues
From: Amos Kong ak...@redhat.com Old method uses the addresses in the config files which could lead serious problem when multiple tests running in different hosts. This patch adds a new macaddress pool algorithm, it generates the mac prefix based on mac address of the host, and fix it to

[PATCH] KVM test: tests.cfg.sample: add params to qemu command line properly

2010-09-10 Thread Lucas Meneghel Rodrigues
found this problem. Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com --- client/tests/fsfuzzer/control |2 +- client/tests/kvm/tests.cfg.sample |2 +- scheduler/scheduler_models.py | 14 +- 3 files changed, 11 insertions(+), 7 deletions(-) diff --git a/client

Re: [PATCH] KVM test: tests.cfg.sample: add params to qemu command line properly

2010-09-10 Thread Lucas Meneghel Rodrigues
On Fri, 2010-09-10 at 12:57 -0300, Lucas Meneghel Rodrigues wrote: There's a small bug on the qemu sample testset for KVM autotest: We need to append -enable-kvm as extra params to the qemu command line, not replace all extra params. Small bug, renders the unattended install unusable for folks

[PATCH] KVM test: tests.cfg.sample: add params to qemu command line properly

2010-09-10 Thread Lucas Meneghel Rodrigues
found this problem. Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com --- client/tests/kvm/tests.cfg.sample |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/client/tests/kvm/tests.cfg.sample b/client/tests/kvm/tests.cfg.sample index 12e1d7a..ce3e307 100644 --- a/client

Re: [PATCH 1/2] KVM test: unittest: Fix the broken smp params

2010-09-07 Thread Lucas Meneghel Rodrigues
On Mon, 2010-09-06 at 17:33 +0800, Jason Wang wrote: Make smp param in unittests.cfg works again. The entire patchset was applied. Thank you very much for the fixes and the support for the new unittests repo, Jason! Lucas Signed-off-by: Jason Wang jasow...@redhat.com ---

Re: [PATCH] KVM test: virtio_console test v2

2010-09-07 Thread Lucas Meneghel Rodrigues
On Thu, 2010-09-02 at 10:16 +0200, Lukáš Doktor wrote: Dne 2.9.2010 04:58, Lucas Meneghel Rodrigues napsal(a): From: Lukáš Doktorldok...@redhat.com 1) Starts VMs with the specified number of virtio console devices 2) Start smoke test 3) Start loopback test 4) Start performance test

[PATCH] KVM test: virtio_console test v2

2010-09-01 Thread Lucas Meneghel Rodrigues
. Signed-off-by: Lukas Doktor ldok...@redhat.com Signed-off-by: Jiri Zupka jzu...@redhat.com Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com --- client/tests/kvm/scripts/console_switch.py | 218 client/tests/kvm/tests/virtio_console.py | 774 client/tests

Re: [Autotest] [PATCH] KVM test: Update pci_hotplug to suit for new qemu

2010-08-27 Thread Lucas Meneghel Rodrigues
On Fri, 2010-08-06 at 10:23 +0800, Yiqiao Pu wrote: In the new version of qemu in RHEL 6.0 device_add is instead of pci_add. So modify the scripts to suit for the new version of qemu. There is still one problem here. Block device htoplug only supported in qmp command line, but qmp don't

[PATCH] KVM test: Change variant name from virtio to virtio_net

2010-08-26 Thread Lucas Meneghel Rodrigues
qemu_kvm_f13_quick. Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com --- client/tests/kvm/tests.cfg.sample |4 ++-- client/tests/kvm/tests_base.cfg.sample |4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/client/tests/kvm/tests.cfg.sample b/client/tests/kvm

Re: [PATCH] BUG: Turnoff khugepaged before start tests

2010-08-20 Thread Lucas Meneghel Rodrigues
On Tue, 2010-08-17 at 18:40 -0400, jzupka wrote: --- client/tests/kvm/tests/ksm_overcommit.py |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) Applied, thanks! diff --git a/client/tests/kvm/tests/ksm_overcommit.py b/client/tests/kvm/tests/ksm_overcommit.py index

[PATCH] server/autotest.py: Make an error message become an info message

2010-08-09 Thread Lucas Meneghel Rodrigues
If we can't install the client using the autotest internal package management system, give the user a less intimidating message, after all we'll fall back to use other methods to install the client. Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com --- server/autotest.py |7 +++ 1

[PATCH] KVM test: Unittest subtest: Avoid leak of extra_params

2010-08-03 Thread Lucas Meneghel Rodrigues
This is the sequel of the previous fix on the unittest subtest: As we're running on a loop through the unittest list, the original extra_params need to be restored at the end of each test, so previously set extra_params don't leak to other unittests. Signed-off-by: Lucas Meneghel Rodrigues l

[PATCH] KVM test: Subtest unittest: append extra_params to qemu cmdline

2010-08-02 Thread Lucas Meneghel Rodrigues
The extra_param config option on qemu-kvm's unittest config file wasn't being honored due to a silly mistake on the latest version of the unittest patchset (forgot to add the extra_params to the params dictionary). This patch fixes the problem. Signed-off-by: Lucas Meneghel Rodrigues l

Re: [PATCH] test: add svm tests

2010-08-02 Thread Lucas Meneghel Rodrigues
On Mon, 2010-08-02 at 19:57 +0300, Avi Kivity wrote: On 08/02/2010 05:56 PM, Avi Kivity wrote: Test behaviour both with svm enabled and with svm disabled. Signed-off-by: Avi Kivitya...@redhat.com --- kvm/test/x86/unittests.cfg | 10 ++ 1 files changed, 10 insertions(+), 0

Re: [RFC PATCH 14/14] KVM-test: Add subtest of testing offload by ethtool

2010-08-02 Thread Lucas Meneghel Rodrigues
On Tue, 2010-07-20 at 09:36 +0800, Amos Kong wrote: The latest case contains TX/RX/SG/TSO/GSO/GRO/LRO test. RTL8139 NIC doesn't support TSO, LRO, it's too old, so drop offload test from rtl8139. LRO, GRO are only supported by latest kernel, virtio nic doesn't support receive offloading

Re: [Autotest][RFC PATCH 00/14] Patchset of network related subtests

2010-08-02 Thread Lucas Meneghel Rodrigues
On Tue, 2010-07-20 at 09:34 +0800, Amos Kong wrote: The following series contain 11 network related subtests, welcome to give me some suggestions about correctness, design, enhancement. Thank you so much! Ok Amos, now that I made the first review of this patchset, I'll wait for a v2 and

Re: [Qemu-devel] [RFC PATCH 12/14] KVM-test: Add a subtest of netperf

2010-07-30 Thread Lucas Meneghel Rodrigues
On Tue, 2010-07-20 at 09:36 +0800, Amos Kong wrote: Add network load by netperf, server is launched on guest, execute netperf client with different protocols on host. if all clients execute successfully, case will be pass. Test result will be record into result.txt. Now this case only tests

[PATCH 1/2] KVM test: Make hugepage setup script print useful information

2010-07-29 Thread Lucas Meneghel Rodrigues
It's interesting to know what's the current large memory page settings for the host, and how many large pages autotest calculated for a given test that requires them. So make the setup script to print this information. Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com --- client/tests/kvm

[PATCH 2/2] KVM test: Fix hugepages variant post command

2010-07-29 Thread Lucas Meneghel Rodrigues
First try to umount the large pages directory, then, if that succeeds, free the used large pages by writing 0 to proc/sys/vm/nr_hugepages. Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com --- client/tests/kvm/tests_base.cfg.sample |2 +- 1 files changed, 1 insertions(+), 1 deletions

Re: [Qemu-devel] [RFC PATCH 07/14] KVM-test: Add a subtest of load/unload nic driver

2010-07-28 Thread Lucas Meneghel Rodrigues
On Tue, 2010-07-20 at 09:35 +0800, Amos Kong wrote: Repeatedly load/unload nic driver, try to transfer file between guest and host by threads at the same time, and check the md5sum. Signed-off-by: Amos Kong ak...@redhat.com --- 0 files changed, 0 insertions(+), 0 deletions(-) diff --git

Re: [RFC PATCH 08/14] KVM-test: Add a subtest of nic promisc

2010-07-28 Thread Lucas Meneghel Rodrigues
On Tue, 2010-07-20 at 09:35 +0800, Amos Kong wrote: This test mainly covers TCP sent from host to guest and from guest to host with repeatedly turn on/off NIC promiscuous mode. Signed-off-by: Amos Kong ak...@redhat.com --- 0 files changed, 0 insertions(+), 0 deletions(-) diff --git

Re: [Qemu-devel] [RFC PATCH 09/14] KVM-test: Add a subtest of multicast

2010-07-28 Thread Lucas Meneghel Rodrigues
On Tue, 2010-07-20 at 09:36 +0800, Amos Kong wrote: Use 'ping' to test send/recive multicat packets. Flood ping test is also added. Limit guest network as 'bridge' mode, because multicast packets could not be transmitted to guest when using 'user' network. Add join_mcast.py for joining

Re: [Qemu-devel] [RFC PATCH 10/14] KVM-test: Add a subtest of pxe

2010-07-28 Thread Lucas Meneghel Rodrigues
On Tue, 2010-07-20 at 09:36 +0800, Amos Kong wrote: This case just snoop tftp packet through tcpdump, it depends on public dhcp server, better to test it through dnsmasq. It would be a good idea to have an alternate implementation using dnsmasq, but not urgent. Signed-off-by: Jason Wang

Re: [Qemu-devel] [RFC PATCH 11/14] KVM-test: Add a subtest of changing mac address

2010-07-28 Thread Lucas Meneghel Rodrigues
On Tue, 2010-07-20 at 09:36 +0800, Amos Kong wrote: Mainly test steps: 1. get a new mac from pool, and the old mac addr of guest. 2. execute the mac_change.sh in guest. 3. relogin to guest and query the interfaces info by `ifconfig` Signed-off-by: Cao, Chen k...@redhat.com Signed-off-by:

Re: [Qemu-devel] [RFC PATCH 03/14] KVM Test: Add a common ping module for network related tests

2010-07-27 Thread Lucas Meneghel Rodrigues
On Tue, 2010-07-20 at 09:35 +0800, Amos Kong wrote: The kvm_net_utils.py is a just a place that wraps common network related commands which is used to do the network-related tests. Use -1 as the packet ratio for loss analysis. Use quiet mode when doing the flood ping. Signed-off-by: Jason

Re: [RFC PATCH 04/14] KVM-test: Add a new subtest ping

2010-07-27 Thread Lucas Meneghel Rodrigues
On Tue, 2010-07-20 at 09:35 +0800, Amos Kong wrote: This test use ping to check the virtual nics, it contains two kinds of test: 1. Packet loss ratio test, ping the guest with different size of packets. 2. Stress test, flood ping guest then use ordinary ping to test the network. The interval

Re: [RFC PATCH 05/14] KVM-test: Add a subtest jumbo

2010-07-27 Thread Lucas Meneghel Rodrigues
On Tue, 2010-07-20 at 09:35 +0800, Amos Kong wrote: According to different nic model set different MTU for it. And ping from guest to host, to see whether tested size can be received by host. Signed-off-by: Jason Wang jasow...@redhat.com Signed-off-by: Amos Kong ak...@redhat.com --- 0

Re: [Qemu-devel] [RFC PATCH 06/14] KVM-test: Add basic file transfer test

2010-07-27 Thread Lucas Meneghel Rodrigues
On Tue, 2010-07-20 at 09:35 +0800, Amos Kong wrote: This test is the basic test of transfering file between host and guest. Try to transfer a large file from host to guest, and transfer it back to host, then compare the files by diff command. The default file size is 4000M, scp timeout is

[PATCH] KVM test: Updating tests_base.cfg with cdrom_cd1

2010-07-26 Thread Lucas Meneghel Rodrigues
install script to retrieve the cdrom from the environment variable cdrom_cd1 instead of cdrom. Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com --- client/tests/kvm/scripts/unattended.py |2 +- client/tests/kvm/tests_base.cfg.sample | 174 2 files changed

Re: [RFC PATCH 01/14] KVM-test: Add a new macaddress pool algorithm

2010-07-26 Thread Lucas Meneghel Rodrigues
On Tue, 2010-07-20 at 09:34 +0800, Amos Kong wrote: Old method uses the mac address in the configuration files which could lead serious problem when multiple tests running in different hosts. This patch adds a new macaddress pool algorithm, it generates the mac prefix based on mac address of

Re: [Qemu-devel] [RFC PATCH 02/14] KVM Test: Add a function get_interface_name() to kvm_net_utils.py

2010-07-26 Thread Lucas Meneghel Rodrigues
On Tue, 2010-07-20 at 09:35 +0800, Amos Kong wrote: The function get_interface_name is used to get the interface name of linux guest through the macaddress of specified macaddress. I wonder if it wouldn't be overkill to have separate utility libraries on the kvm test instead of a single

[PATCH 1/3] KVM test: Introducing virtio windows drivers install - config file

2010-07-21 Thread Lucas Meneghel Rodrigues
to the virtio network driver. Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com --- client/tests/kvm/tests_base.cfg.sample | 47 +--- 1 files changed, 43 insertions(+), 4 deletions(-) diff --git a/client/tests/kvm/tests_base.cfg.sample b/client/tests/kvm

[PATCH 2/3] KVM test: Adapt scripts/unattended.py to handle win virtio drivers

2010-07-21 Thread Lucas Meneghel Rodrigues
Make the preparation script unattended.py to copy windows virtio drivers to the boot floppy and modify the unattended install files with the necessary data. Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com --- client/tests/kvm/scripts/unattended.py | 207

[PATCH 3/3] KVM test: Unattended files changes to support virtio drivers install

2010-07-21 Thread Lucas Meneghel Rodrigues
1) Make sure extra_driver_path is set on the xml files 2) Make sure the nw driver installer runs at the end of the install for both the xml and .ini files Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com --- client/tests/kvm/unattended/win2003-32.sif | 14 + client/tests

Re: [Autotest][RFC PATCH 00/14] Patchset of network related subtests

2010-07-20 Thread Lucas Meneghel Rodrigues
On Tue, 2010-07-20 at 09:34 +0800, Amos Kong wrote: The following series contain 11 network related subtests, welcome to give me some suggestions about correctness, design, enhancement. Awesome work, will start to review them today. Thanks! Thank you so much! --- Amos Kong (14):

Re: [Autotest] [PATCH 1/2] KVM Test: Update cmd() help function in kvm_monitor.py to support parameters.

2010-07-12 Thread Lucas Meneghel Rodrigues
On Mon, 2010-06-28 at 05:43 -0400, Feng Yang wrote: - Michael Goldish mgold...@redhat.com wrote: Why not add a wrapper for the command you're interested in? If we do it your way, a test that uses cmd() with parameters will have to handle the human case and the QMP case separately.

[PATCH] KVM test: deps/Makefile - Compile rss with -static-libgcc

2010-07-07 Thread Lucas Meneghel Rodrigues
In order to make rss.exe self contained, -static-libgcc has to be added to mingw command line. Update the Makefile to reflect that. Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com --- client/tests/kvm/deps/Makefile |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

Re: [KVM-AUTOTEST PATCH v4] [RFC] KVM test: add python client for rss file transfer services

2010-07-07 Thread Lucas Meneghel Rodrigues
On Sun, 2010-07-04 at 16:42 +0300, Michael Goldish wrote: See details in docstrings in rss_file_transfer.py. See protocol details in deps/rss.cpp. I've gone through both rss.cpp code and rss_file_transfer.py code, and must say it's very good. The only comment I'd make about this module is that

[PATCH] qemu-kvm unittests: Small makefile fix

2010-07-01 Thread Lucas Meneghel Rodrigues
Turns out $(tests-common) does not encompass all flat files built for the unittests. So let's fix the makefile install rule to include all flat files generated by the make procedure. Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com --- kvm/test/config-x86-common.mak |2 +- 1 files

Re: [PATCH] KVM test: Disable HPET on windows timedrift tests

2010-07-01 Thread Lucas Meneghel Rodrigues
On Thu, 2010-07-01 at 17:42 +0300, Avi Kivity wrote: On 06/30/2010 06:39 PM, Lucas Meneghel Rodrigues wrote: By default, HPET is enabled on qemu and no time drift mitigation is being made for it. So, add -no-hpet if qemu supports it, during windows timedrift tests. Hm, you're

[PATCH] KVM test: Disable HPET on windows timedrift tests

2010-06-30 Thread Lucas Meneghel Rodrigues
By default, HPET is enabled on qemu and no time drift mitigation is being made for it. So, add -no-hpet if qemu supports it, during windows timedrift tests. Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com --- client/tests/kvm/kvm_vm.py |9 + client/tests/kvm

[PATCH] KVM test: Add Makefile on deps/ subdir

2010-06-29 Thread Lucas Meneghel Rodrigues
With this makefile, it's possible to comfortably compile both rss.exe and finish.exe on a recent Fedora box with the mingw packages installed. This is a nice convenience and saves people of memorizing the compiler command lines. Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com --- client

Re: [KVM-AUTOTEST PATCH] [RFC] KVM test: rss.cpp: add file transfer support

2010-06-24 Thread Lucas Meneghel Rodrigues
On Thu, 2010-06-24 at 14:25 +0300, Yaniv Kaul wrote: On 6/24/2010 2:03 PM, Michael Goldish wrote: Enable RSS to send/receive files and directory trees (recursively). Are you slowly developing a competitor to STAF (http://staf.sourceforge.net/) ? And re. the file transfer protocol, why not

[PATCH] qemu-kvm tests: Create make target for install tests

2010-06-24 Thread Lucas Meneghel Rodrigues
# Name of the flat file to be used smp = 2 # Number of processors the VM will use during this test extra_params = -cpu qemu64,+x2apic # Additional parameters used For rpms, other patches defining qemu-kvm-tests.rpm will follow. Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com --- kvm/test

[PATCH 1/5] KVM test: support kernel -append command line options

2010-06-24 Thread Lucas Meneghel Rodrigues
Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_vm.py |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/client/tests/kvm/kvm_vm.py b/client/tests/kvm/kvm_vm.py index 966fb3c..87b037f 100755 --- a/client/tests/kvm/kvm_vm.py +++

[PATCH 2/5] KVM test: add boolean 'testdev' VM parameter for RHEL-6 style unit tests

2010-06-24 Thread Lucas Meneghel Rodrigues
Should be set to yes to enable testdev. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_vm.py |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/client/tests/kvm/kvm_vm.py b/client/tests/kvm/kvm_vm.py index 87b037f..7b1fc05 100755 ---

[PATCH 3/5] KVM test: add wrapper for RHEL-6 style unittests

2010-06-24 Thread Lucas Meneghel Rodrigues
success/failure by exit status instead of output - Restructure loop so that vm.is_dead() is called less often - Copy test log to debugdir/unittest.log - Change parameters passed to wait_for() Signed-off-by: Michael Goldish mgold...@redhat.com Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com

[PATCH 4/5] KVM test: add sample RHEL-6 style unittest config file

2010-06-24 Thread Lucas Meneghel Rodrigues
From: Michael Goldish mgold...@redhat.com Based on Naphtali Sprei's patches. Changes from v1: - Remove reference_output parameter Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/unittests.cfg.sample | 56 + 1 files changed, 56

[PATCH 5/5] KVM test: Make it possible to run VMs without NICs

2010-06-24 Thread Lucas Meneghel Rodrigues
For unittesting, for example, is interesting that we run the VM with the bare mininum number of parameters. This fix allows that. Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com --- client/tests/kvm/kvm_vm.py |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git

[PATCH] KVM test: Modify the build.git method to build and link unittests

2010-06-24 Thread Lucas Meneghel Rodrigues
If we have a certain file that has information about running unit tests, let's build the unittests on the build.git mode. This feature depends on a qemu-kvm patch that is still not upstream, but I am sending anyways so people can comment. Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com

[PATCH] KVM test: migrate - remove gzipped images when test finishes

2010-06-23 Thread Lucas Meneghel Rodrigues
The code to remove the migration files was one indentation block deeper than it should - my mistake. Now, we ensure the files are being cleaned up at the end of the test. Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com --- client/tests/kvm/kvm_test_utils.py |6 -- 1 files changed

Re: [PATCH KVM-AUTOTEST] KVM test: generate netdev ids that newer qemu can consume

2010-06-22 Thread Lucas Meneghel Rodrigues
On Tue, 2010-06-22 at 12:29 +0300, Avi Kivity wrote: Newer qemu restricts identifiers to starting with a letter. Applied, thanks Avi! Signed-off-by: Avi Kivity a...@redhat.com --- client/tests/kvm/kvm_utils.py |6 ++ client/tests/kvm/kvm_vm.py|2 +- 2 files changed, 7

[PATCH 01/13] KVM test: kvm_utils.py: add a primitive logging mechanism for kvm_subprocess

2010-06-21 Thread Lucas Meneghel Rodrigues
From: Michael Goldish mgold...@redhat.com Add log_line() which logs a single line to a given file. The file's path is given relative to a certain base dir. Add set_log_dir() which sets the base dir. This is useful for logging the output of kvm_subprocess. kvm_subprocess can take a callback

[PATCH 02/13] KVM test: add the auto_close option to all kvm_subprocess classes

2010-06-21 Thread Lucas Meneghel Rodrigues
From: Michael Goldish mgold...@redhat.com Allow all kvm_subprocess classes (kvm_spawn, kvm_tail, kvm_expect, kvm_shell_session) to close automatically if auto_close is given and True. By default auto_close if False for all classes except kvm_shell_session, for which it is True by default.

[PATCH 03/13] KVM test: restructure remote_login() and remote_scp()

2010-06-21 Thread Lucas Meneghel Rodrigues
- Add _remote_login() and _remote_scp() which, instead of taking a command line, take an existing session and operate on it. This is useful for logging into existing always-open sessions, such as serial console sessions. - Merge ssh/telnet/netcat into remote_login(). Signed-off-by:

[PATCH 04/13] KVM test: send username in remote_login()

2010-06-21 Thread Lucas Meneghel Rodrigues
In order to let the serial console work, we must let the remote_login() send the username when met the username prompt. This patch fails the progress if if it met the username prompt twice. Signed-off-by: Jason Wang jasow...@redhat.com Signed-off-by: Michael Goldish mgold...@redhat.com ---

[PATCH 05/13] KVM test: remote_login(): make the login re suitable for serial console

2010-06-21 Thread Lucas Meneghel Rodrigues
From: Michael Goldish mgold...@redhat.com Current matching re ^\s*[Ll]ogin:\s*$ is not suitable for the serial console, so change it to [Ll]ogin:\s*$. Signed-off-by: Jason Wang jasow...@redhat.com Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_utils.py |2 +- 1

[PATCH 06/13] KVM test: kvm_vm.py: redirect the serial console to a unix socket

2010-06-21 Thread Lucas Meneghel Rodrigues
From: Michael Goldish mgold...@redhat.com Based on Jason Wang's patch. Signed-off-by: Jason Wang jasow...@redhat.com Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_vm.py | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git

[PATCH 07/13] KVM test: kvm_vm.py: log serial console output and allow serial login

2010-06-21 Thread Lucas Meneghel Rodrigues
From: Michael Goldish mgold...@redhat.com Log serial console output to files in the debug dir. Also, add VM.serial_login() which attempts to log in via the serial console. Note: - Tests must NOT close() a serial console session, because it needs to remain open for the following tests to use.

[PATCH 08/13] KVM test: kvm.py: set log file dir for kvm_subprocess logging

2010-06-21 Thread Lucas Meneghel Rodrigues
From: Michael Goldish mgold...@redhat.com Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm.py |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/client/tests/kvm/kvm.py b/client/tests/kvm/kvm.py index bab1e6f..0799cff 100644 ---

[PATCH 09/13] KVM test: kvm_subprocess.py: don't sanitize text before passing it to callbacks

2010-06-21 Thread Lucas Meneghel Rodrigues
From: Michael Goldish mgold...@redhat.com Converting the text to utf-8 seems to cause trouble when converting back (e.g. when writing to files). The logging system seems to be fine with unsanitized text, so let's not sanitize it. Signed-off-by: Michael Goldish mgold...@redhat.com ---

[PATCH 10/13] KVM test: log output of all shell sessions and SCP transfers

2010-06-21 Thread Lucas Meneghel Rodrigues
From: Michael Goldish mgold...@redhat.com Use kvm_utils.log_line() to log the output of all shell sessions and SCP transfers. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_utils.py | 33 ++--- client/tests/kvm/kvm_vm.py| 15

[PATCH 11/13] KVM test: Enable the serial console during unattended installation

2010-06-21 Thread Lucas Meneghel Rodrigues
This patch enable the serial console during unattended installation for all linux guests. Signed-off-by: Jason Wang jasow...@redhat.com --- client/tests/kvm/tests_base.cfg.sample |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH 12/13] KVM test: Enable the serial console for all linux guests

2010-06-21 Thread Lucas Meneghel Rodrigues
From: Jason Wang jasow...@redhat.com As we have the ability to dump the content from serial console or use a session through it, we need to redirect the console to serial through unattended files to make use of it. The patch also keep the tty0 accroding to the suggestion of Michael Goldish.

[PATCH 13/13] KVM test: Fix a small bug on timedrift test

2010-06-21 Thread Lucas Meneghel Rodrigues
causing an exception while formatting the message. Let's fix that. Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/tests/timedrift.py |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/client

Re: [KVM-AUTOTEST PATCH 0/2] Make autoit wrapper support more guest scripts than just AutoIt

2010-06-18 Thread Lucas Meneghel Rodrigues
On Fri, 2010-06-18 at 17:27 +0800, Chen Cao wrote: Just rename variables and the file, the wrapper itself can support other scripts already. Ok Chen, looks good to me, patchset applied! --- Chen Cao (2): KVM-test: autoit: Generalize the variables in autoit.py KVM-test: rename

Re: [Autotest] [KVM-AUTOTEST PATCH v2 1/3] KVM test: add kvm_monitor.py, an interface to QEMU monitors

2010-06-17 Thread Lucas Meneghel Rodrigues
On Mon, 2010-06-14 at 19:54 +0300, Michael Goldish wrote: This module should replace vm.send_monitor_cmd(). Instead of connecting to the monitor each time a command is issued, this module maintains a continuous connection to the monitor. It disconnects when a test terminates and reconnects

Re: [PATCH] KVM-test: kvm.py: Code style fix

2010-06-08 Thread Lucas Meneghel Rodrigues
On Tue, 2010-06-08 at 20:50 +0300, Michael Goldish wrote: On 06/08/2010 11:02 AM, Marc Enthus wrote: From: Marc Enthus cxz...@gmail.com According to autotest coding style and http://www.python.org/dev/peps/pep-0008/ use if pa_type is not None: instead of if pa_type:

Re: [KVM-AUTOTEST PATCH] KVM test: kvm_vm.py: don't require pci_assignable to be defined

2010-06-07 Thread Lucas Meneghel Rodrigues
On Sun, 2010-06-06 at 09:41 +0300, Michael Goldish wrote: Currently to disable PCI device assignment pci_assignable must be explicitly set to no. This patch allows it to remain undefined (and adds a warning message and a comment). I have noticed this on Friday, while I was testing the patches

Re: [Autotest] [KVM-AUTOTEST PATCH] KVM test: kvm_vm.py: don't require pci_assignable to be defined

2010-06-07 Thread Lucas Meneghel Rodrigues
On Mon, 2010-06-07 at 10:24 -0300, Lucas Meneghel Rodrigues wrote: On Sun, 2010-06-06 at 09:41 +0300, Michael Goldish wrote: Currently to disable PCI device assignment pci_assignable must be explicitly set to no. This patch allows it to remain undefined (and adds a warning message

[PATCH] KVM test: Fixing size of NTFS partitions on windows unattended installs

2010-06-02 Thread Lucas Meneghel Rodrigues
While running tests on WinVista SP2 64 bits, I noticed that, even though we reserved 20GB of disk space on images, the unattended files are allocating 15GB of the effective space, causing SP2 64 bit install to fail. Fix that, make sure all primary disks do use 20GB. Signed-off-by: Lucas Meneghel

Re: [PATCH] KVM Test: Make login timeout configurable.

2010-06-01 Thread Lucas Meneghel Rodrigues
On Fri, 2010-05-28 at 13:36 +0800, Feng Yang wrote: Add login_timeout parameter to make login timeout configurable. Currently default timeout value is 240s. It is always not enough, many case fail foer could not boot up in 240s in our testing. I like the idea of unifying all login timeouts. I

Re: [PATCH 3/3] KVM test: Add implementation of network based unattended installation

2010-05-27 Thread Lucas Meneghel Rodrigues
On Wed, 2010-05-19 at 17:20 +0800, Jason Wang wrote: This patch could let the unattended installation to be done through the following method: - cdrom: the original method which does the installation from cdrom - url: installing the linux guest from http or ftp, tree url was specified

Re: [Autotest] [KVM-AUTOTEST PATCH] KVM test: use command line option wrapper functions

2010-05-26 Thread Lucas Meneghel Rodrigues
On Mon, 2010-05-17 at 16:29 +0300, Michael Goldish wrote: In order to support multiple versions of qemu which use different command line options or syntaxes, wrap all command line options in small helper functions, which append text to the command line according to the output of 'qemu -help'.

Re: [PATCH 2/3] KVM test: Do not use the hard-coded address during unattended installation

2010-05-26 Thread Lucas Meneghel Rodrigues
On Wed, 2010-05-19 at 17:20 +0800, Jason Wang wrote: When we do the unattended installation in tap mode, we should use vm.get_address() instead of the 'localhost' in order the connect to the finish program running in the guest. Signed-off-by: Jason Wang jasow...@redhat.com ---

Re: [PATCH v2 00/10] Redirct and make use of the guest serial console

2010-05-25 Thread Lucas Meneghel Rodrigues
On Tue, 2010-05-11 at 17:03 +0800, Jason Wang wrote: The guest console is useful for failure troubleshooting especially for the one who has calltrace. And as we plan to push the network related test in the next few weeks, we found the serial session in more reliable during the network testing.

<    2   3   4   5   6   7   8   9   10   11   >