Re: [Autotest] [KVM-AUTOTEST PATCH] Improve kvm subtest AutoIt - add option to download script from remote server

2009-12-04 Thread Lucas Meneghel Rodrigues
Ok, fair enough, applied! Thanks Chen On Thu, Dec 3, 2009 at 4:39 AM, Cao, Chen k...@redhat.com wrote: Hi, Lucas, On Thu, Dec 03, 2009 at 01:16:27AM -0200, Lucas Meneghel Rodrigues wrote: Chen, I have verified your patch, code looks good, but I am indeed a bit concerned about putting extra

Re: [Autotest] [PATCH] KVM test: Not execute build test by default

2009-12-02 Thread Lucas Meneghel Rodrigues
On Wed, 2009-12-02 at 09:45 +0530, sudhir kumar wrote: Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com Yeah, I like noinstall as a default. Definitely good, but I will prefer a name like no_kvm_install. We might leave this for the control file refactoring! Thanks

Re: [Autotest] [PATCH] Increase waiting time before first session check in kvm_test_utils.reboot

2009-12-02 Thread Lucas Meneghel Rodrigues
Ok, as discussed on this thread, following Michael's suggestion, I increased the time needed to rule a session as unresponsive from the default 5 seconds to 30 seconds. http://autotest.kernel.org/changeset/3987 This ought to be enough, if it isn't, let me know Chen! On Thu, Nov 26, 2009 at 5:57

Re: [Autotest] [KVM-AUTOTEST PATCH] Improve kvm subtest AutoIt - add option to download script from remote server

2009-12-02 Thread Lucas Meneghel Rodrigues
Chen, I have verified your patch, code looks good, but I am indeed a bit concerned about putting extra requirements on winutils.iso. How hard it is to get git working under windows? I did some quick research and seems that we have a portable version of git that could be kept on winutils.iso for

KVM autotest patch queue report 03-12-2009

2009-12-02 Thread Lucas Meneghel Rodrigues
Patch: Major control file cleanup URL: http://patchwork.test.kernel.org/patch/1464/ Comments: Will split this work in 2 stages: • Cleanups and splitting kvm_tests.cfg in a base config + test definitions • Move test definitions to control file then having an utility to parse all config and generate

[PATCH] KVM test: Add a subtest physical_resources_check

2009-12-01 Thread Lucas Meneghel Rodrigues
This test will test following parameters of a VM: 1) count of CPU, hard disks and NICs 2) memory size 3) model of hard disks and NICs 4) NICs' mac address 5) UUID and serial number (if defined the command in config file) Signed-off-by: Yolkfull Chow yz...@redhat.com ---

Re: [Autotest] [PATCH 1/2] Adds a test to verify resources inside a VM

2009-12-01 Thread Lucas Meneghel Rodrigues
Hi Sudhir and Yolkfull: Thanks for your work on this test! Since Yolkfull's test matches Sudhir's test functionality and extends it, I will go with it. Some points: * A failure on checking a given resource shouldn't prevent us from testing other resources. Hence, instead of TestFail()

Re: [Autotest] [PATCH 2/3] Make a standalone client to be able to use global_config.ini

2009-12-01 Thread Lucas Meneghel Rodrigues
P. Smith g...@google.com wrote: looks good. On Wed, Nov 18, 2009 at 8:45 AM, Lucas Meneghel Rodrigues l...@redhat.com wrote: Greg, would you mind giving a last review on the patchset before I check this in? On Wed, Nov 18, 2009 at 2:09 PM, Lucas Meneghel Rodrigues l...@redhat.com wrote

[PATCH] KVM test: Not execute build test by default

2009-12-01 Thread Lucas Meneghel Rodrigues
VMs that could be present on the environment, an undesirable situation. This is an intermediate step before we carry over with the control file cleanup. Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com --- client/tests/kvm/control | 20 ++-- client/tests/kvm

Re: [Autotest] [PATCH] Fix autotest client when checking only client from svn

2009-12-01 Thread Lucas Meneghel Rodrigues
jadman...@google.com wrote: This looks good to me. -- John On Tue, Dec 1, 2009 at 2:37 PM, Lucas Meneghel Rodrigues l...@redhat.com wrote: When the client was made configurable through global_config.ini, the scenario developer checking out client directory only wasn't considered

[PATCH] KVM test: Fix subtest imports

2009-12-01 Thread Lucas Meneghel Rodrigues
inserted to sys.path on the control file, don't add additional cruft to the library search path. Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com --- client/tests/kvm/kvm.py | 22 +- 1 files changed, 9 insertions(+), 13 deletions(-) diff --git a/client/tests/kvm/kvm.py b

Re: [Autotest] [PATCH 1/2] Adds a test to verify resources inside a VM

2009-12-01 Thread Lucas Meneghel Rodrigues
On Wed, 2009-12-02 at 08:59 +0530, sudhir kumar wrote: On Wed, Dec 2, 2009 at 7:51 AM, Yolkfull Chow yz...@redhat.com wrote: Looks good for me. Thanks Lucas for improving this test. Sudhir, what do you think about this? :) Needs couple of hours before I go through the patch. I will post

[PATCH] KVM test: Add PCI device assignment support

2009-11-30 Thread Lucas Meneghel Rodrigues
don't have to bother dumping this info to a file. * Code simplified to avoid duplication As it's a fairly involved feature, the more reviews we get the better. Signed-off-by: Yolkfull Chow yz...@redhat.com Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com --- client/tests/kvm

[PATCH] KVM test: Test 802.1Q vlan of nic

2009-11-30 Thread Lucas Meneghel Rodrigues
Test 802.1Q vlan of nic, config it by vconfig command. 1) Create two VMs 2) Setup guests in different vlan by vconfig and test communication by ping using hard-coded ip address 3) Setup guests in same vlan and test communication by ping 4) Recover the vlan config The subnet of vlan can be

Re: [Autotest] [PATCH 1/2] Adds a test to verify resources inside a VM

2009-11-27 Thread Lucas Meneghel Rodrigues
On Fri, 2009-11-27 at 13:14 +0530, sudhir kumar wrote: Folks, Any comments on the patch below ? I'll get to it today and comment on it, Sudhir, thanks! On Wed, Nov 25, 2009 at 11:35 AM, sudhir kumar smalik...@gmail.com wrote: This patch adds a test for verifying whether the number of cpus

Re: [PATCH] KVM test: Fix two typos in config file

2009-11-18 Thread Lucas Meneghel Rodrigues
Ok, applied, thanks! On Wed, Nov 18, 2009 at 6:55 AM, Yolkfull Chow yz...@redhat.com wrote: Signed-off-by: Yolkfull Chow yz...@redhat.com ---  client/tests/kvm/kvm_tests.cfg.sample |    4 ++--  1 files changed, 2 insertions(+), 2 deletions(-) diff --git

KVM autotest patch queue report - 11-18-2009

2009-11-18 Thread Lucas Meneghel Rodrigues
Hi folks, I am resuming sending patch queue reports for the KVM test framework. I will heavily base it on the latest autotest's patchwork status. At any time you can see the status of the incoming patches by checking http://patchwork.test.kernel.org/project/autotest/list/ Summary: 4 patches

[PATCH 2/3] Make a standalone client to be able to use global_config.ini

2009-11-18 Thread Lucas Meneghel Rodrigues
the configuration files to the client. Notes for revisors (changes from previous patchset and other stuff): * Latest comments from John adressed Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com --- client/common_lib/global_config.py| 61 + client

Re: [Autotest] [PATCH 2/3] Make a standalone client to be able to use global_config.ini

2009-11-18 Thread Lucas Meneghel Rodrigues
Greg, would you mind giving a last review on the patchset before I check this in? On Wed, Nov 18, 2009 at 2:09 PM, Lucas Meneghel Rodrigues l...@redhat.com wrote: In order to make it possible the autotest client to use the global_config.ini configuration files:  * Modified global_config.py

[PATCH 1/3] Adding AutoservInstallError to common_lib.error

2009-11-17 Thread Lucas Meneghel Rodrigues
server/autotest.py was referencing it but it didn't exist. This patch creates the error class. Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com --- client/common_lib/error.py |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/client/common_lib/error.py b/client

[PATCH 3/3] Make client behavior configurable

2009-11-17 Thread Lucas Meneghel Rodrigues
. Everything should work now. Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com --- client/bin/autotest |7 ++- client/bin/job.py | 11 --- 2 files changed, 14 insertions(+), 4 deletions(-) diff --git a/client/bin/autotest b/client/bin/autotest index 282ae9a..285be4e

[PATCH 2/3] Make a standalone client to be able to use global_config.ini

2009-11-17 Thread Lucas Meneghel Rodrigues
break autoserv. Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com --- client/common_lib/global_config.py| 61 + client/common_lib/host_protections.py | 26 -- global_config.ini |3 ++ server/autotest.py

[PATCH 3/3] Make client behavior configurable

2009-11-17 Thread Lucas Meneghel Rodrigues
. Everything should work now. Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com --- client/bin/autotest |7 ++- client/bin/job.py | 11 --- 2 files changed, 14 insertions(+), 4 deletions(-) diff --git a/client/bin/autotest b/client/bin/autotest index 282ae9a..285be4e

[PATCH 2/3] Make a standalone client to be able to use global_config.ini

2009-11-17 Thread Lucas Meneghel Rodrigues
In order to make it possible the autotest client to use the global_config.ini configuration files: * Modified global_config.py to support verifying if the configuration file is under autotest's root directory, or the client directory * Extended the autotest run method to copy over the

[PATCH 2/3] Make a standalone client to be able to use global_config.ini

2009-11-17 Thread Lucas Meneghel Rodrigues
In order to make it possible the autotest client to use the global_config.ini configuration files: * Modified global_config.py to support verifying if the configuration file is under autotest's root directory, or the client directory * Extended the autotest run method to copy over the

[PATCH 1/3] Adding AutoservInstallError to common_lib.error

2009-11-17 Thread Lucas Meneghel Rodrigues
server/autotest.py was referencing it but it didn't exist. This patch creates the error class. Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com --- client/common_lib/error.py |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/client/common_lib/error.py b/client

[PATCH 1/3] Adding AutoservInstallError to common_lib.error

2009-11-17 Thread Lucas Meneghel Rodrigues
server/autotest.py was referencing it but it didn't exist. This patch creates the error class. Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com --- client/common_lib/error.py |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/client/common_lib/error.py b/client

[PATCH] KVM test: migration subtest: Handle case where session2 does not exist

2009-11-15 Thread Lucas Meneghel Rodrigues
if the session2 object is not None before trying to use the method is_alive() Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com --- client/tests/kvm/tests/migration.py |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/client/tests/kvm/tests/migration.py b/client

[PATCH] Make a standalone client to be able to use global_config.ini

2009-11-15 Thread Lucas Meneghel Rodrigues
over the configuration files with the client. While there, fixed a small bug: server/autotest.py was making reference to an exception class not present under common_lib.error Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com --- client/common_lib/error.py |5 + client

[PATCH] Move global configuration files to client dir

2009-11-11 Thread Lucas Meneghel Rodrigues
So this way the client can also benefit from settings defined on the configuration files. Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com --- client/common_lib/global_config.py |4 +- client/global_config.ini | 90 client

[PATCH] Fix incorrect reference to client library directory

2009-11-11 Thread Lucas Meneghel Rodrigues
When checking for various client specific libraries, job code tries to reference client/lib directory, which does not exist. Fix the code to point at client/common_lib. This patch fixes autoserv and autotest regressions as of latest svn revision (3938). Signed-off-by: Lucas Meneghel Rodrigues l

Re: [Autotest] [PATCH] Make client behavior configurable: drop_caches

2009-11-11 Thread Lucas Meneghel Rodrigues
. -- John On Thu, Nov 5, 2009 at 12:23 PM, Lucas Meneghel Rodrigues l...@redhat.com wrote: Right now autotest will drop caches between:  * Test executions  * Same test iterations This change turns those into configurable options on global_config.ini. Default configuration: [CLIENT] drop_caches

[PATCH] Add ks files for RHEL5,RHEL4,RHEL3 series products

2009-11-11 Thread Lucas Meneghel Rodrigues
From: Bear by...@redhat.com Signed-off-by: Bear Yang by...@redhat.com --- client/tests/kvm/kvm_tests.cfg.sample| 54 +++--- client/tests/kvm/unattended/RHEL-3-series.ks | 39 ++ client/tests/kvm/unattended/RHEL-4-series.ks | 40

Re: [Autotest] [PATCH] Move global configuration files to client dir

2009-11-11 Thread Lucas Meneghel Rodrigues
the documentation on the website that refers to the global config. Ok, then let's revert the original patches that turn drop_caches into a global config option. Later I will think of a more elegant solution. -- John On Wed, Nov 11, 2009 at 3:24 AM, Lucas Meneghel Rodrigues l...@redhat.com wrote: So

Re: [Autotest] [PATCH] Move global configuration files to client dir

2009-11-11 Thread Lucas Meneghel Rodrigues
On Wed, 2009-11-11 at 15:59 -0800, Steve Howard wrote: On Wed, Nov 11, 2009 at 9:30 AM, John Admanski jadman...@google.com wrote: I thought about it a bit more: Maybe a better approach would be to have the global_config module find the ini file in job.autodir (so on a client it would show

Re: [PATCH] Seperate smp from extra_params and add into default VM params

2009-11-10 Thread Lucas Meneghel Rodrigues
I am OK with it, applied, thanks! On Tue, Nov 3, 2009 at 4:27 AM, Yolkfull Chow yz...@redhat.com wrote: We may need leave smp as standalone parameter of VM. Reasons I can proposal:  1) memory is a standalone parameter, so is smp  2) smp parameter is needed in some test case, say VM

Re: [Autotest] [KVM-AUTOTEST PATCH 1/6] KVM test: disable password prompt on resume for Windows guests

2009-11-10 Thread Lucas Meneghel Rodrigues
Patchset applied, thanks! On Wed, Nov 4, 2009 at 12:05 PM, Michael Goldish mgold...@redhat.com wrote: Add a command to setuprss.bat that disables the password prompt on resuming from hibernation. Note that for this change to take effect the local winutils.iso should be updated as well.

Re: [PATCH] Make client behavior configurable: drop_caches

2009-11-10 Thread Lucas Meneghel Rodrigues
solution 1) is not bad, client/global_config.ini is just slightly non intuitive, but splitting conf files does not sound like a better idea. -- John On Thu, Nov 5, 2009 at 12:23 PM, Lucas Meneghel Rodrigues l...@redhat.com wrote: Right now autotest will drop caches between: * Test executions

Re: [PATCH] [RFC]: Make some aspects of client behavior configurable

2009-11-05 Thread Lucas Meneghel Rodrigues
On Thu, 2009-11-05 at 09:01 -0800, John Admanski wrote: Well, the drop_caches configs I definitely like. As a general rule I think it's reasonable to translate most global defaults into a global config setting. Ok, great, so 'drop_caches' will be kept as is. The sysinfo changes I'm a

[PATCH] Make client behavior configurable: drop_caches

2009-11-05 Thread Lucas Meneghel Rodrigues
Right now autotest will drop caches between: * Test executions * Same test iterations This change turns those into configurable options on global_config.ini. Default configuration: [CLIENT] drop_caches: True drop_caches_between_iterations: True Signed-off-by: Lucas Meneghel Rodrigues l

[PATCH] [RFC]: Make some aspects of client behavior configurable

2009-11-04 Thread Lucas Meneghel Rodrigues
it. Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com --- client/bin/autotest|7 ++- client/bin/base_sysinfo.py | 34 +++--- client/bin/job.py | 10 +++--- client/bin/package.py |1 - global_config.ini |9 - 5

Re: [KVM-AUTOTEST][PATCH] Fix kvm_config.py -f filename mode

2009-11-03 Thread Lucas Meneghel Rodrigues
Ooops, fixed. Thanks Ryan! On Mon, Nov 2, 2009 at 9:28 PM, Ryan Harper ry...@us.ibm.com wrote: kvm_config.py supports specifying a different filename for test config.  This patch fixes the option parsing parameters. Currently it uses 'store_true' which stores the value True into the filename

Re: [Autotest] [PATCH] [RFC] KVM test: Major control file cleanup

2009-10-30 Thread Lucas Meneghel Rodrigues
On Fri, 2009-10-30 at 08:54 -0500, Ryan Harper wrote: * Lucas Meneghel Rodrigues l...@redhat.com [2009-10-28 14:48]: Ryan, Michael: I absolutely agree that the ability to debug stuff is important, but the ability to make things straightforward to use from the web interface or cli

[PATCH] KVM test: Change the way subtests are loaded

2009-10-30 Thread Lucas Meneghel Rodrigues
change the mechanism to load KVM subtests, in order to cope with the recent autoserv changes. Thanks to Ryan Harper for having noticed this issue. Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com --- client/tests/kvm/kvm.py |9 + 1 files changed, 5 insertions(+), 4 deletions

Daily git testing failure due to build problem

2009-10-29 Thread Lucas Meneghel Rodrigues
Hi folks, today's git test failed due to a build problem. Attached goes the build log. The relevant snippet I could identify is: 10/29 04:57:13 DEBUG| utils:0085| CC [M] /usr/local/autotest/tests/kvm/src/kvm_kmod/x86/i8259.o 10/29 04:57:13 ERROR| utils:0085|

Re: Daily git testing failure due to build problem

2009-10-29 Thread Lucas Meneghel Rodrigues
On Thu, 2009-10-29 at 18:07 +0100, Jan Kiszka wrote: Lucas Meneghel Rodrigues wrote: Hi folks, today's git test failed due to a build problem. Attached goes the build log. The relevant snippet I could identify is: 10/29 04:57:13 DEBUG| utils:0085| CC [M] /usr/local/autotest

Re: Daily git testing failure due to build problem

2009-10-29 Thread Lucas Meneghel Rodrigues
Ok, indeed using the -next branch solves the problems. When the next merge is done, we won't have this problem anymore. Thanks for your attention! On Thu, Oct 29, 2009 at 4:36 PM, Lucas Meneghel Rodrigues l...@redhat.com wrote: On Thu, 2009-10-29 at 18:07 +0100, Jan Kiszka wrote: Lucas

Re: [PATCH] [RFC] KVM test: Major control file cleanup

2009-10-28 Thread Lucas Meneghel Rodrigues
it into the function. Please see additional comments below. - Lucas Meneghel Rodrigues l...@redhat.com wrote: As pointed out before, the KVM reference control files could use a little clean up. This patch implements severe cleanup of the main control file by: * Refactoring

Re: [Autotest] [PATCH] [RFC] KVM test: Major control file cleanup

2009-10-28 Thread Lucas Meneghel Rodrigues
On Wed, Oct 28, 2009 at 1:43 PM, Michael Goldish mgold...@redhat.com wrote: Sounds great, except it won't allow you to debug your configuration using kvm_config.py.  So the question now is what's more important -- the ability to debug or ease of use when running from the server. Here we have 2

Re: [Autotest] [PATCH] [RFC] KVM test: Major control file cleanup

2009-10-28 Thread Lucas Meneghel Rodrigues
On Wed, Oct 28, 2009 at 1:57 PM, Michael Goldish mgold...@redhat.com wrote: One more comment on this patch: If you plan to make 'noinstall' the default build mode, then let's not run the build test at all by default.  If we run it with 'noinstall', it will just run the preprocessor and

Re: [Autotest] [PATCH] KVM Test: Add re.IGNORECASE to re.compile to verify_ip_address_ in kvm_utils.py

2009-10-28 Thread Lucas Meneghel Rodrigues
Thanks guys, applied! On Wed, Oct 28, 2009 at 7:30 AM, Cao, Chen k...@redhat.com wrote: On Wed, Oct 28, 2009 at 03:20:41AM -0400, Michael Goldish wrote: Thanks for catching this. While we're at it, why not remove the 2 occurrences of re.IGNORECASE that have no effect? I just chose to ignore

Re: [Autotest] [PATCH] KVM test: Add new program cd_hash.py

2009-10-28 Thread Lucas Meneghel Rodrigues
You do have a point. I will fix both programs to not use flags and send it to the mailing list. On Wed, Oct 28, 2009 at 4:23 PM, Michael Goldish mgold...@redhat.com wrote: - Lucas Meneghel Rodrigues l...@redhat.com wrote: A new program that evaluates hash strings, intended to help kvm

Re: [Autotest] [PATCH] [RFC] KVM test: Major control file cleanup

2009-10-28 Thread Lucas Meneghel Rodrigues
it... (I hope I won't burn my tongue with this statement). Thanks for your input! On Wed, Oct 28, 2009 at 4:18 PM, Ryan Harper ry...@us.ibm.com wrote: * Michael Goldish mgold...@redhat.com [2009-10-28 10:43]: - Lucas Meneghel Rodrigues l...@redhat.com wrote: One thing that just occurred to me

Re: [Autotest] [PATCH 1/2] KVM-test: Add execute permission to qemu-ifup script

2009-10-27 Thread Lucas Meneghel Rodrigues
Ooops fixed, thanks! On Tue, Oct 27, 2009 at 2:07 AM, Amos Kong ak...@redhat.com wrote: qemu-ifup is a script for setting network bridge. If no execute permission, always face this problem: autotest/client/tests/kvm/scripts/qemu-ifup: could not launch network script Could not initialize

[PATCH] [RFC] KVM test: Major control file cleanup

2009-10-27 Thread Lucas Meneghel Rodrigues
all stuff inside the config file is not possible, appropriate code will be added (in other example control files). Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com --- client/tests/kvm/control | 203 +++-- client/tests/kvm/kvm_build.cfg.sample | 82

[PATCH] KVM test: Unattended install: Mount isos as read only

2009-10-26 Thread Lucas Meneghel Rodrigues
Sometimes CD images can be located on read only NFS shares, so allways pass the ro option to the CD mount command on the unattended.py setup script. Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com --- client/tests/kvm/scripts/unattended.py |4 ++-- 1 files changed, 2 insertions(+), 2

[PATCH] KVM test: Add new program cd_hash.py

2009-10-26 Thread Lucas Meneghel Rodrigues
. This program replaces calc_md5sum_1m. Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com --- client/tests/kvm/calc_md5sum_1m.py | 21 -- client/tests/kvm/cd_hash.py| 54 2 files changed, 54 insertions(+), 21 deletions(-) delete mode 100755

Re: [Autotest] [PATCH] Add 'downscript=no' into kvm command line

2009-10-23 Thread Lucas Meneghel Rodrigues
Applied, thanks! On Wed, Oct 21, 2009 at 1:36 AM, Yolkfull Chow yz...@redhat.com wrote: If no downscript is assigned, add 'downscript=no' to avoid error: /etc/qemu-ifdown: could not launch network script Signed-off-by: Yolkfull Chow yz...@redhat.com ---  client/tests/kvm/kvm_vm.py |    2

[PATCH] KVM test: Leave image_boot=yes only for virtio drives

2009-10-23 Thread Lucas Meneghel Rodrigues
Much shorter and elegant fix for the issue: The option -boot on is only really required for virtio disks, also will break qemu upstream if used. Let's fix that by only adding it for virtio disks. Thanks to Michael Goldish for pointing the proper fix. Signed-off-by: Lucas Meneghel Rodrigues l

[PATCH 1/4] KVM test: Add new utility functions to kvm_utils

2009-10-22 Thread Lucas Meneghel Rodrigues
. Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com --- client/tests/kvm/calc_md5sum_1m.py |2 +- client/tests/kvm/kvm_utils.py | 105 client/tests/kvm/kvm_vm.py | 20 +--- 3 files changed, 108 insertions(+), 19 deletions(-) diff --git

[PATCH] KVM test: Fixing small bug on unattended install cfg

2009-10-22 Thread Lucas Meneghel Rodrigues
As in other tests, we should append the qemu extra options instead of replacing them. Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com --- client/tests/kvm/kvm_tests.cfg.sample |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/client/tests/kvm

[PATCH 1/3] KVM test: Add new utility functions to kvm_utils

2009-10-21 Thread Lucas Meneghel Rodrigues
that downloads a file and caches it. The reason I'm keeping it is that I want more testing before I move all needed function definitions to the autotest API * get_hash_from_file(): Extract hash string from a file containing hashes Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com --- client/tests/kvm

[PATCH 2/3] KVM test: Daily DVD test control file

2009-10-21 Thread Lucas Meneghel Rodrigues
-off-by: Lucas Meneghel Rodrigues l...@redhat.com --- client/tests/kvm/control.daily_dvd | 249 1 files changed, 249 insertions(+), 0 deletions(-) create mode 100644 client/tests/kvm/control.daily_dvd diff --git a/client/tests/kvm/control.daily_dvd b/client

[PATCH 3/3] KVM test: Extend VM.create() method to support SHA1 check

2009-10-21 Thread Lucas Meneghel Rodrigues
Also, change variable names and messages to be more generic. Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com --- client/tests/kvm/kvm_vm.py | 21 ++--- 1 files changed, 14 insertions(+), 7 deletions(-) diff --git a/client/tests/kvm/kvm_vm.py b/client/tests/kvm

[PATCH 1/2] KVM test: Adding Fedora nightly host (example)

2009-10-21 Thread Lucas Meneghel Rodrigues
This is an example Fedora nightly host definition. It lacks CD hashes because they will be verified as the DVD isos are downloaded. Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com --- client/tests/kvm/kvm_tests.cfg.sample | 17 + 1 files changed, 17 insertions(+), 0

[PATCH 2/2] KVM test: Adding new Fedora-nightly.ks unattended file

2009-10-21 Thread Lucas Meneghel Rodrigues
Also, make a tiny change on Fedora-11.ks file by setting up completely automated disk partitioning. Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com --- client/tests/kvm/unattended/Fedora-11.ks |7 ++-- client/tests/kvm/unattended/Fedora-nightly.ks | 39

Re: [Autotest] [PATCH] Test 802.1Q vlan of nic

2009-10-20 Thread Lucas Meneghel Rodrigues
On Tue, Oct 20, 2009 at 11:19 AM, Michael Goldish mgold...@redhat.com wrote: See comments below. - Dor Laor dl...@redhat.com wrote: On 10/15/2009 11:48 AM, Amos Kong wrote: Test 802.1Q vlan of nic, config it by vconfig command.    1) Create two VMs    2) Setup guests in different

Re: [Autotest] [PATCH] KVM test: Add PCI pass through test

2009-10-15 Thread Lucas Meneghel Rodrigues
On Thu, Oct 15, 2009 at 3:45 AM, Yolkfull Chow yz...@redhat.com wrote: On Wed, Oct 14, 2009 at 09:08:00AM -0300, Lucas Meneghel Rodrigues wrote: Add a new PCI pass trough test. It supports both SR-IOV virtual functions and physical NIC card pass through. Single Root I/O Virtualization (SR-IOV

[PATCH] KVM test: Add a kvm subtest guest_s4

2009-10-14 Thread Lucas Meneghel Rodrigues
This test suspends a guest OS to disk, it supports Linux and Windows. Signed-off-by: Ken Cao k...@redhat.com Signed-off-by: Yolkfull Chow yz...@redhat.com --- client/tests/kvm/kvm_tests.cfg.sample | 16 client/tests/kvm/tests/guest_s4.py| 66 + 2

Re: [Autotest] [PATCH] Add a kvm test guest_s4 which supports both Linux and Windows platform

2009-10-14 Thread Lucas Meneghel Rodrigues
On Tue, Oct 13, 2009 at 11:54 PM, Yolkfull Chow yz...@redhat.com wrote: On Tue, Oct 13, 2009 at 05:29:40PM -0300, Lucas Meneghel Rodrigues wrote: Hi Yolkfull and Chen: Thanks for your test! I have some comments and doubts to clear, most of them are about content of the messages delivered

Re: [Autotest] [PATCH] Using shutil.move to move result files in job.py

2009-10-14 Thread Lucas Meneghel Rodrigues
Ok, looks good. Commited as http://autotest.kernel.org/changeset/3844 On Mon, Oct 12, 2009 at 11:36 PM, Cao, Chen k...@redhat.com wrote: Since os.rename requires that the file is in the same partition with the dest directory, we would get a python OSError if the result directory is mounted to

Re: [Autotest] [PATCH] Test 802.1Q vlan of nic

2009-10-14 Thread Lucas Meneghel Rodrigues
Hi Amos, thanks for the patch, here are my comments (pretty much concerning only coding style): On Wed, Sep 23, 2009 at 8:19 AM, Amos Kong ak...@redhat.com wrote: Test 802.1Q vlan of nic, config it by vconfig command. 1) Create two VMs 2) Setup guests in different vlan by vconfig and test

Re: [Autotest] [PATCH] Add pass through feature test (support SR-IOV)

2009-10-14 Thread Lucas Meneghel Rodrigues
Yolkfull, I've studied about single root IO virtualization before reviewing your patch, the general approach here looks good. There were some stylistic points as far as code is concerned, so I have rebased your patch against the latest trunk, and added some explanation about the features being

Re: [Autotest] [PATCH] KVM test: Add PCI pass through test

2009-10-14 Thread Lucas Meneghel Rodrigues
FYI, Amit pointed out that the correct name for this test would be PCI device assignment, so the final version of this patch will be called PCI device assignment instead. On Wed, Oct 14, 2009 at 9:08 AM, Lucas Meneghel Rodrigues l...@redhat.com wrote: Add a new PCI pass trough test. It supports

Re: [Autotest] [PATCH] Little bug fix in pci_hotplug.py

2009-10-13 Thread Lucas Meneghel Rodrigues
Applied, thanks! On Tue, Oct 13, 2009 at 6:13 AM, Yolkfull Chow yz...@redhat.com wrote: If command executed timeout, the return value of status could be None, which is missed in judge statement: if s:   ... Thanks Jason Wang for pointing this out. Signed-off-by: Yolkfull Chow

Re: [Autotest] [PATCH] Add a kvm test guest_s4 which supports both Linux and Windows platform

2009-10-13 Thread Lucas Meneghel Rodrigues
Hi Yolkfull and Chen: Thanks for your test! I have some comments and doubts to clear, most of them are about content of the messages delivered for the user and some other details. On Sun, Sep 27, 2009 at 6:11 AM, Yolkfull Chow yz...@redhat.com wrote: For this case, Ken Cao wrote the linux part

Re: [Autotest] [PATCH 4/6] KVM test: Add unattended install script

2009-10-13 Thread Lucas Meneghel Rodrigues
On Tue, Oct 13, 2009 at 5:52 PM, Ryan Harper ry...@us.ibm.com wrote: * Lucas Meneghel Rodrigues l...@redhat.com [2009-10-09 15:41]: In order to make it possible to prepare the environment for the guests installation, we have to: +class UnattendedInstall(object): +     +    Creates

Re: [Autotest] [PATCH] Fix a bug in function create in kvm_vm

2009-10-12 Thread Lucas Meneghel Rodrigues
On Sat, 2009-10-10 at 16:48 +0800, Yolkfull Chow wrote: On Sat, Oct 10, 2009 at 04:24:45PM +0800, Yolkfull Chow wrote: On Mon, Oct 05, 2009 at 04:03:22PM -0300, Lucas Meneghel Rodrigues wrote: Hi Yolkfull! I've checked your patch, but it turns out that the comma is valid syntax

Re: [Autotest] [KVM-AUTOTEST PATCH 3/7] KVM test: new test timedrift_with_migration

2009-10-12 Thread Lucas Meneghel Rodrigues
Hi Michael, I am reviewing your patchset and have just a minor remark to make here: On Wed, Oct 7, 2009 at 2:54 PM, Michael Goldish mgold...@redhat.com wrote: This patch adds a new test that checks the timedrift introduced by migrations. It uses the same parameters used by the timedrift test to

[PATCH] KVM test: Adding Windows 7 guests and step files

2009-10-09 Thread Lucas Meneghel Rodrigues
After a bit of struggle, here goes the inclusion of windows 7 to our guest testing party. Step files included, unattended install files will follow. It seems to me that is better to keep the ISO names the same as the MSDN names, hence I am keeping the ISO names. Signed-off-by: Lucas Meneghel

[PATCH 1/6] KVM test: Added floppy and tftp options to qemu command

2009-10-09 Thread Lucas Meneghel Rodrigues
This allows you to not specify the full path in the config file, appends to the image dir. Signed-off-by: David Huff dh...@redhat.com --- client/tests/kvm/kvm_vm.py | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/client/tests/kvm/kvm_vm.py

[PATCH 2/6] KVM test: Introducing unattended install subtest

2009-10-09 Thread Lucas Meneghel Rodrigues
that. The implementation of that strategy varies trough different operating systems. This is the kvm test implementation code, client programs will follow on later patches. Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com --- client/tests/kvm/tests/unattended_install.py | 41

[PATCH 3/6] KVM test: Add unattended install files for F11 and WinXP

2009-10-09 Thread Lucas Meneghel Rodrigues
that for a later patch Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com --- client/tests/kvm/unattended/Fedora-11.ks | 41 + client/tests/kvm/unattended/winnt.bat| 12 + client/tests/kvm/unattended/winxp32.sif | 72 ++ 3 files changed

[PATCH 4/6] KVM test: Add unattended install script

2009-10-09 Thread Lucas Meneghel Rodrigues
to project policy. At this point I strongly believe the environment scripts should be rather libraries that can use full use of the autotest API, but for a first pass I believe the script is good enough. Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com --- client/tests/kvm/scripts/unattended.py

[PATCH 5/6] KVM test: Utility to make windows guests ACK end of install

2009-10-09 Thread Lucas Meneghel Rodrigues
by this process work just fine on my tests. I still haven't made my mind about shipping binaries, with the test, so in the meantime you want to check this compile the code as you wish and put it under the same deps dir. Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com --- client/tests/kvm/deps

[PATCH 6/6] KVM test: kvm_tests.cfg.sample changes for unattended

2009-10-09 Thread Lucas Meneghel Rodrigues
This patch introduces unattended install on the sample config file: * introduced the needed variables for the unattended install test * Created 2 test sets, winxp_unattended and fc11_unattended. * Makes fc11_unattended the default test set Signed-off-by: Lucas Meneghel Rodrigues l

Re: [Autotest] [PATCH 1/6] KVM test: Added floppy and tftp options to qemu command

2009-10-09 Thread Lucas Meneghel Rodrigues
FYI, patchset applied! On Fri, Oct 9, 2009 at 5:40 PM, Lucas Meneghel Rodrigues l...@redhat.com wrote: This allows you to not specify the full path in the config file, appends to the image dir. Signed-off-by: David Huff dh...@redhat.com ---  client/tests/kvm/kvm_vm.py |   12

[PATCH] KVM test: Fedora 11-64 bits step file

2009-10-06 Thread Lucas Meneghel Rodrigues
During work of creating kickstart files for fedora and answer files for windows, it's also nice to have step files for the operating systems tested. This patch adds Fedora 11 64 bit step file. Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com --- client/bin/package.py

[PATCH] Adding NAS Parallel Benchmarks (NPB) as client test

2009-10-05 Thread Lucas Meneghel Rodrigues
This new autotest module implements a benchmark for parallel processing (SMP) systems. Besides the traditional benchmarking, some sanity checks are made, in order to test effectively the SMP implementation of virtual machines. So this module at the same time is a regular benchmark, but it can be

Re: [Autotest] [PATCH] Adding NAS Parallel Benchmarks(NPB) as client test [1/2] V2

2009-10-05 Thread Lucas Meneghel Rodrigues
First of all, thanks for this client side module Chen. I believe it might be interesting for quite a lot of people doing performance testing. Here are my remarks found during the review of your code: On Mon, Sep 21, 2009 at 7:01 AM, Cao, Chen k...@redhat.com wrote: - Using NPB OpenMP

[PATCH] Refactor of setup_modules.py

2009-10-05 Thread Lucas Meneghel Rodrigues
let me know what you think about this. Complexity: Medium (Code refactor, all public API preserved) Risk: High (Core code executed by the client). Change was tested though :) Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com --- client/setup_modules.py | 306

Re: [Autotest] [KVM-AUTOTEST PATCH] fix an error of undefine variable

2009-10-05 Thread Lucas Meneghel Rodrigues
Hi Amos, thanks for the fix! It is fine, but to avoid introducing global statements, I've worked out another patch to fix that issue. Also, there was another undefined variable lying around (base_path). I've finished up the patch and sent it to the mailing list! Cheers, On Tue, Sep 22, 2009 at

[PATCH] Fixing undefined variable reference error in setup_modules.py

2009-10-05 Thread Lucas Meneghel Rodrigues
Fix an undefined variable reference error inside client/setup_modules.py - just remove code that wasn't supposed to be there. 3rd try: After IRC chat and investigation, this is a best fix than my previous patch that tried to accomplish the same fix. Signed-off-by: Lucas Meneghel Rodrigues l

Re: [Autotest] [PATCH] Fix a bug in function create in kvm_vm

2009-10-05 Thread Lucas Meneghel Rodrigues
Hi Yolkfull! I've checked your patch, but it turns out that the comma is valid syntax for the logging module. By any chance you actually had an error with it? On Mon, Sep 28, 2009 at 4:45 AM, Yolkfull Chow yz...@redhat.com wrote: Signed-off-by: Yolkfull Chow yz...@redhat.com ---  

Re: [Autotest] [KVM-AUTOTEST PATCH 1/6] KVM test: kvm_subprocess: use read_nonblocking(0) instead of read_nonblocking (0.1)

2009-10-05 Thread Lucas Meneghel Rodrigues
Patchset applied! On Tue, Sep 29, 2009 at 5:04 PM, Michael Goldish mgold...@redhat.com wrote: In get_command_status_output() and is_responsive() use read_nonblocking(0) to read the unread output before sending input (e.g. a command). The timeout is currently 0.1 because theoretically it should

Re: [Autotest] [KVM-AUTOTEST PATCH 1/4] KVM test: allow setting shell line separator string in the config file

2009-10-05 Thread Lucas Meneghel Rodrigues
Patchset applied! On Sun, Sep 20, 2009 at 12:16 PM, Michael Goldish mgold...@redhat.com wrote: The shell line separator string is appended to strings sent by sendline(). The string is controlled by the parameter shell_linesep.  It defaults to \n. Signed-off-by: Michael Goldish

[PATCH 1/6] KVM test: Added floppy and tftp options to qemu command

2009-10-05 Thread Lucas Meneghel Rodrigues
This allows you to not specify the full path in the config file, appends to the image dir. Signed-off-by: David Huff dh...@redhat.com --- client/tests/kvm/kvm_vm.py | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/client/tests/kvm/kvm_vm.py

[PATCH 2/6] KVM test: Introducing unattended install subtest

2009-10-05 Thread Lucas Meneghel Rodrigues
that. The implementation of that strategy varies trough different operating systems. This is the kvm test implementation code, client programs will follow on later patches. Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com --- client/tests/kvm/tests/unattended_install.py | 45

[PATCH 3/6] KVM test: Add unattended install files for F11 and WinXP

2009-10-05 Thread Lucas Meneghel Rodrigues
. For TAP mode networking, kickstart templating needs to be implemented, and I will leave that for a later patch Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com --- client/tests/kvm/unattended/Fedora-11.ks | 36 +++ client/tests/kvm/unattended/winnt.bat| 12 + client

[PATCH 4/6] KVM test: Add unattended install script

2009-10-05 Thread Lucas Meneghel Rodrigues
to project policy. At this point I strongly believe the environment scripts should be rather libraries that can use full use of the autotest API, but for a first pass I believe the script is good enough. Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com --- client/tests/kvm/scripts/unattended.py

<    5   6   7   8   9   10   11   12   13   >