Re: [PATCH] kvm-unit-tests: x86: pmu: call measure for every counter in check_counters_many

2014-08-26 Thread Paolo Bonzini
Il 25/08/2014 21:38, Chris J Arges ha scritto: Ah, I didn't know that. Yes disabling NMI watchdog via: echo 0 | sudo tee /proc/sys/kernel/nmi_watchdog Allows this test to pass. Would it make sense to have a check if nmi_watchdog is enabled in this test case, and skip the all counters test?

Re: [PATCH] kvm-unit-tests: x86: pmu: call measure for every counter in check_counters_many

2014-08-25 Thread Paolo Bonzini
Il 14/08/2014 22:58, Chris J Arges ha scritto: In the check_counters_many function measure was only being called on the last counter, causing the pmu test to fail. I don't understand. measure loops on all N counters and calls start_event (which in turn calls global_enable) and stop_event

Re: [PATCH] kvm-unit-tests: x86: pmu: call measure for every counter in check_counters_many

2014-08-25 Thread Chris J Arges
On 08/25/2014 11:45 AM, Paolo Bonzini wrote: Il 14/08/2014 22:58, Chris J Arges ha scritto: In the check_counters_many function measure was only being called on the last counter, causing the pmu test to fail. I don't understand. measure loops on all N counters and calls start_event

Re: [PATCH] kvm-unit-tests: x86: pmu: call measure for every counter in check_counters_many

2014-08-25 Thread Paolo Bonzini
Ok I see now where this patch doesn't make sense. With the latest kvm tree I get: sudo ./x86-run x86/pmu.flat -smp 1 -cpu host | grep -v PASS qemu-system-x86_64 -enable-kvm -device pc-testdev -device isa-debug-exit,iobase=0xf4,iosize=0x4 -display none -serial stdio -device pci-testdev

Re: [PATCH] kvm-unit-tests: x86: pmu: call measure for every counter in check_counters_many

2014-08-25 Thread Chris J Arges
On 08/25/2014 02:32 PM, Paolo Bonzini wrote: Ok I see now where this patch doesn't make sense. With the latest kvm tree I get: sudo ./x86-run x86/pmu.flat -smp 1 -cpu host | grep -v PASS qemu-system-x86_64 -enable-kvm -device pc-testdev -device isa-debug-exit,iobase=0xf4,iosize=0x4

[RESEND][PATCH] kvm-unit-tests: x86: pmu: call measure for every counter in check_counters_many

2014-08-20 Thread Chris J Arges
In the check_counters_many function measure was only being called on the last counter, causing the pmu test to fail. This ensures that measure is called for each counter in the array before calling verify_counter. Signed-off-by: Chris J Arges chris.j.ar...@canonical.com --- x86/pmu.c | 6 +++---

[PATCH] kvm-unit-tests: x86: pmu: call measure for every counter in check_counters_many

2014-08-14 Thread Chris J Arges
In the check_counters_many function measure was only being called on the last counter, causing the pmu test to fail. This ensures that measure is called for each counter in the array before calling verify_counter. Signed-off-by: Chris J Arges chris.j.ar...@canonical.com --- x86/pmu.c | 6 +++---