Re: [PATCH V2 RFC 3/3] kvm: Check system load and handle different commit cases accordingly

2012-10-30 Thread Andrew Jones
On Tue, Oct 30, 2012 at 11:27:52AM +0530, Raghavendra K T wrote: On 10/29/2012 11:24 PM, Peter Zijlstra wrote: On Mon, 2012-10-29 at 19:37 +0530, Raghavendra K T wrote: +/* + * A load of 2048 corresponds to 1:1 overcommit + * undercommit threshold is half the 1:1 overcommit + * overcommit

Re: [PATCH V2 RFC 3/3] kvm: Check system load and handle different commit cases accordingly

2012-10-30 Thread Andrew Jones
On Tue, Oct 30, 2012 at 01:01:54PM +0530, Raghavendra K T wrote: On 10/30/2012 12:04 PM, Andrew Jones wrote: On Tue, Oct 30, 2012 at 11:27:52AM +0530, Raghavendra K T wrote: On 10/29/2012 11:24 PM, Peter Zijlstra wrote: On Mon, 2012-10-29 at 19:37 +0530, Raghavendra K T wrote: +/* + * A load

Re: [PATCH V3 RFC 1/2] sched: Bail out of yield_to when source and target runqueue has one task

2012-11-26 Thread Andrew Jones
: double_rq_unlock(rq, p_rq); +out_irq: local_irq_restore(flags); - if (yielded) + if (yielded 0) schedule(); return yielded; Acked-by: Andrew Jones drjo...@redhat.com -- To unsubscribe from this list: send the line unsubscribe kvm in the body

Re: [PATCH V3 RFC 2/2] kvm: Handle yield_to failure return code for potential undercommit case

2012-11-26 Thread Andrew Jones
On Mon, Nov 26, 2012 at 05:38:04PM +0530, Raghavendra K T wrote: From: Raghavendra K T raghavendra...@linux.vnet.ibm.com yield_to returns -ESRCH, When source and target of yield_to run queue length is one. When we see three successive failures of yield_to we assume we are in potential

Re: [PATCH V3 RFC 2/2] kvm: Handle yield_to failure return code for potential undercommit case

2012-11-26 Thread Andrew Jones
On Mon, Nov 26, 2012 at 02:43:02PM +0100, Andrew Jones wrote: On Mon, Nov 26, 2012 at 05:38:04PM +0530, Raghavendra K T wrote: From: Raghavendra K T raghavendra...@linux.vnet.ibm.com yield_to returns -ESRCH, When source and target of yield_to run queue length is one. When we see three

Re: [PATCH V3 RFC 2/2] kvm: Handle yield_to failure return code for potential undercommit case

2012-11-27 Thread Andrew Jones
On Tue, Nov 27, 2012 at 03:57:25PM +0530, Raghavendra K T wrote: On 11/26/2012 07:13 PM, Andrew Jones wrote: On Mon, Nov 26, 2012 at 05:38:04PM +0530, Raghavendra K T wrote: From: Raghavendra K T raghavendra...@linux.vnet.ibm.com yield_to returns -ESRCH, When source and target of yield_to

Re: [PATCH v8] kvm: notify host when the guest is panicked

2012-08-08 Thread Andrew Jones
On Wed, Aug 08, 2012 at 10:43:01AM +0800, Wen Congyang wrote: diff --git a/Documentation/virtual/kvm/pv_event.txt b/Documentation/virtual/kvm/pv_event.txt new file mode 100644 index 000..0ebc890 --- /dev/null +++ b/Documentation/virtual/kvm/pv_event.txt @@ -0,0 +1,32 @@ +The KVM

Re: [PATCH v7 3/3] KVM: perf: kvm events analysis tool

2012-08-27 Thread Andrew Jones
On Mon, Aug 27, 2012 at 05:51:46PM +0800, Dong Hao wrote: snip +struct event_stats { + u64 count; + u64 time; + + /* used to calculate stddev. */ + double mean; + double M2; +}; How about moving the stats functions from builtin-stat.c to e.g. util/stats.c, and then

Re: [PATCH v7 3/3] KVM: perf: kvm events analysis tool

2012-08-28 Thread Andrew Jones
On Mon, Aug 27, 2012 at 01:34:36PM -0600, David Ahern wrote: On 8/27/12 9:53 AM, Andrew Jones wrote: On Mon, Aug 27, 2012 at 05:51:46PM +0800, Dong Hao wrote: snip +struct event_stats { + u64 count; + u64 time; + + /* used to calculate stddev. */ + double mean; + double M2

Re: [RFC][PATCH] Improving directed yield scalability for PLE handler

2012-09-14 Thread Andrew Jones
On Thu, Sep 13, 2012 at 04:30:58PM -0500, Andrew Theurer wrote: On Thu, 2012-09-13 at 17:18 +0530, Raghavendra K T wrote: * Andrew Theurer haban...@linux.vnet.ibm.com [2012-09-11 13:27:41]: On Tue, 2012-09-11 at 11:38 +0530, Raghavendra K T wrote: On 09/11/2012 01:42 AM, Andrew

Re: [RFC][PATCH] Improving directed yield scalability for PLE handler

2012-09-17 Thread Andrew Jones
On Fri, Sep 14, 2012 at 04:34:24PM -0400, Konrad Rzeszutek Wilk wrote: The concern I have is that even though we have gone through changes to help reduce the candidate vcpus we yield to, we still have a very poor idea of which vcpu really needs to run. The result is high cpu usage in the

Re: [RFC][PATCH] Improving directed yield scalability for PLE handler

2012-09-17 Thread Andrew Jones
On Sun, Sep 16, 2012 at 11:55:28AM +0300, Avi Kivity wrote: On 09/14/2012 12:30 AM, Andrew Theurer wrote: The concern I have is that even though we have gone through changes to help reduce the candidate vcpus we yield to, we still have a very poor idea of which vcpu really needs to run.

Re: [RFC][PATCH] Improving directed yield scalability for PLE handler

2012-09-17 Thread Andrew Jones
On Sat, Sep 15, 2012 at 09:38:54PM +0530, Raghavendra K T wrote: On 09/14/2012 10:40 PM, Andrew Jones wrote: On Thu, Sep 13, 2012 at 04:30:58PM -0500, Andrew Theurer wrote: On Thu, 2012-09-13 at 17:18 +0530, Raghavendra K T wrote: * Andrew Theurerhaban...@linux.vnet.ibm.com [2012-09-11 13:27

Re: [PATCH RFC 0/2] kvm: Improving undercommit,overcommit scenarios in PLE handler

2012-09-26 Thread Andrew Jones
On Mon, Sep 24, 2012 at 02:36:05PM +0200, Peter Zijlstra wrote: On Mon, 2012-09-24 at 17:22 +0530, Raghavendra K T wrote: On 09/24/2012 05:04 PM, Peter Zijlstra wrote: On Fri, 2012-09-21 at 17:29 +0530, Raghavendra K T wrote: In some special scenarios like #vcpu= #pcpu, PLE handler may

Re: [PATCH RFC 0/2] kvm: Improving undercommit,overcommit scenarios in PLE handler

2012-09-26 Thread Andrew Jones
On Mon, Sep 24, 2012 at 06:20:12PM +0200, Avi Kivity wrote: On 09/24/2012 06:03 PM, Peter Zijlstra wrote: On Mon, 2012-09-24 at 17:51 +0200, Avi Kivity wrote: On 09/24/2012 03:54 PM, Peter Zijlstra wrote: On Mon, 2012-09-24 at 18:59 +0530, Raghavendra K T wrote: However Rik had a

Re: [PATCH RFC 0/2] kvm: Improving undercommit,overcommit scenarios in PLE handler

2012-09-26 Thread Andrew Jones
On Wed, Sep 26, 2012 at 03:26:11PM +0200, Peter Zijlstra wrote: On Wed, 2012-09-26 at 15:20 +0200, Andrew Jones wrote: Wouldn't a clean solution be to promote a task's scheduler class to the spinner class when we PLE (or come from some special syscall for userspace spinlocks

Re: [PATCH RFC 0/2] kvm: Improving undercommit,overcommit scenarios in PLE handler

2012-09-27 Thread Andrew Jones
On Thu, Sep 27, 2012 at 03:19:45PM +0530, Raghavendra K T wrote: On 09/25/2012 08:30 PM, Dor Laor wrote: On 09/24/2012 02:02 PM, Raghavendra K T wrote: On 09/24/2012 02:12 PM, Dor Laor wrote: In order to help PLE and pvticketlock converge I thought that a small test code should be developed

Re: [PATCH] kvm: handle last_boosted_vcpu = 0 case

2012-06-22 Thread Andrew Jones
On Thu, Jun 21, 2012 at 04:56:08PM +0530, Raghavendra K T wrote: Here are the results from kernbench. PS: I think we have to only take that, both the patches perform better, than reading into actual numbers since I am seeing more variance in especially 3x. may be I can test with some more

Re: [PATCH] kvm: handle last_boosted_vcpu = 0 case

2012-06-28 Thread Andrew Jones
- Original Message - In summary, current PV has huge benefit on non-PLE machine. On PLE machine, the results become very sensitive to load, type of workload and SPIN_THRESHOLD. Also PLE interference has significant effect on them. But still it has slight edge over non PV. Hi

Re: [PATCH RFC 1/2] kvm vcpu: Note down pause loop exit

2012-07-11 Thread Andrew Jones
- Original Message - Hm, suppose we're the next-in-line for a ticket lock and exit due to PLE. The lock holder completes and unlocks, which really assigns the lock to us. So now we are the lock owner, yet we are marked as don't yield-to-us in the PLE code. Yes..

Re: [PATCH V3 RESEND RFC 0/2] kvm: Improving undercommit scenarios

2013-01-23 Thread Andrew Jones
On Tue, Jan 22, 2013 at 01:08:54PM +0530, Raghavendra K T wrote: In some special scenarios like #vcpu = #pcpu, PLE handler may prove very costly, because there is no need to iterate over vcpus and do unsuccessful yield_to burning CPU. The first patch optimizes all the yield_to by bailing

Re: [PATCH V3 RESEND RFC 1/2] sched: Bail out of yield_to when source and target runqueue has one task

2013-01-25 Thread Andrew Jones
added.(thanks Avi) Reviewed-by: Srikar Dronamraju sri...@linux.vnet.ibm.com Signed-off-by: Raghavendra K T raghavendra...@linux.vnet.ibm.com Acked-by: Andrew Jones drjo...@redhat.com Tested-by: Chegu Vinod chegu_vi...@hp.com --- kernel/sched/core.c | 25

Re: [PATCH RFC 0/2] kvm: Better yield_to candidate using preemption notifiers

2013-03-05 Thread Andrew Jones
On Mon, Mar 04, 2013 at 11:31:46PM +0530, Raghavendra K T wrote: This patch series further filters better vcpu candidate to yield to in PLE handler. The main idea is to record the preempted vcpus using preempt notifiers and iterate only those preempted vcpus in the handler. Note that the

Re: [PATCH RFC 0/2] kvm: Better yield_to candidate using preemption notifiers

2013-03-05 Thread Andrew Jones
On Tue, Mar 05, 2013 at 05:54:09PM +0530, Raghavendra K T wrote: On 03/05/2013 03:23 PM, Andrew Jones wrote: On Mon, Mar 04, 2013 at 11:31:46PM +0530, Raghavendra K T wrote: This patch series further filters better vcpu candidate to yield to in PLE handler. The main idea is to record

Re: KVM guest 100% cpu lock up

2013-03-18 Thread Andrew Jones
- Original Message - Hello, I am having an intermittent issue where one of my KVM guests is locking up and when checking the process its running @ 100% cpu. The host is CentOS 6.4 running the kernel kernel-2.6.32-358.0.1.el6.x86_64. Would it be worth attempting to compile a

Re: [PATCH RFC V10 0/18] Paravirtualized ticket spinlocks

2013-06-24 Thread Andrew Jones
On Mon, Jun 24, 2013 at 06:10:14PM +0530, Raghavendra K T wrote: Results: === base = 3.10-rc2 kernel patched = base + this series The test was on 32 core (model: Intel(R) Xeon(R) CPU X7560) HT disabled with 32 KVM guest vcpu 8GB RAM. Have you ever tried to get results with HT

Re: [PATCH RFC V9 0/19] Paravirtualized ticket spinlocks

2013-06-26 Thread Andrew Jones
On Wed, Jun 26, 2013 at 02:15:26PM +0530, Raghavendra K T wrote: On 06/25/2013 08:20 PM, Andrew Theurer wrote: On Sun, 2013-06-02 at 00:51 +0530, Raghavendra K T wrote: This series replaces the existing paravirtualized spinlock mechanism with a paravirtualized ticketlock mechanism. The series

arm: kvm-selftest

2013-07-31 Thread Andrew Jones
Hi Christoffer, I'm just confirming that I found the right repo/branch for the most recent kvmarm unit tests. I'm looking at github.com/virtualopensystems/linux-kvm-arm kvm-selftest with last commit commit b5aec35ee58c6b2d726a3e2fb56ec0e6e89976e0 Author: Christoffer Dall cd...@cs.columbia.edu

ppc kvm-unit-tests?

2013-08-21 Thread Andrew Jones
Hi Alex, I'm looking at adding arm to kvm-unit-tests. One the first things I'd like to do is clean up the kvm-unit-tests repo a bit. There's some arch-specific files (including ppc) laying around in the root dir that I'd sweep up before adding another arch to the mix. Although, checking the git

[PATCH] kvm: warn if num cpus is greater than num recommended

2013-08-22 Thread Andrew Jones
should check KVM_CAP_NR_VCPUS for the recommended number of vcpus. This patch adds a warning if a user specifies a number of cpus between the recommended and max. Signed-off-by: Andrew Jones drjo...@redhat.com --- kvm-all.c | 45 +++-- 1 file changed, 27

Re: [Qemu-devel] [PATCH] kvm: warn if num cpus is greater than num recommended

2013-08-23 Thread Andrew Jones
- Original Message - Am 22.08.2013 18:12, schrieb Eduardo Habkost: On 22/08/2013, at 12:39, Andrew Jones drjo...@redhat.com wrote: The comment in kvm_max_vcpus() states that it's using the recommended procedure from the kernel API documentation to get the max number

Re: [Qemu-devel] [PATCH] kvm: warn if num cpus is greater than num recommended

2013-08-23 Thread Andrew Jones
- Original Message - Il 22/08/2013 17:39, Andrew Jones ha scritto: The comment in kvm_max_vcpus() states that it's using the recommended procedure from the kernel API documentation to get the max number of vcpus that kvm supports. It is, but by always returning the maximum

[PATCH v2] kvm: warn if num cpus is greater than num recommended

2013-08-23 Thread Andrew Jones
for the fail case was slightly changed, 'exceeds max cpus' to 'exceeds the maximum cpus'. If this is unacceptable change for users like libvirt, then I'll need to spin a v3. Signed-off-by: Andrew Jones drjo...@redhat.com --- kvm-all.c | 69

Re: [Qemu-devel] [PATCH] kvm: warn if num cpus is greater than num recommended

2013-08-26 Thread Andrew Jones
- Original Message - Il 23/08/2013 13:33, Andrew Jones ha scritto: Does smp_cpus map to the current number of cpus, or to the number of possible cpus? If it maps to the number of possible cpus, then this is the right place. If the former, then I guess it'll take more thought

Re: [libvirt] [PATCH v2] kvm: warn if num cpus is greater than num recommended

2013-08-28 Thread Andrew Jones
- Original Message - On 08/23/2013 07:24 AM, Andrew Jones wrote: The comment in kvm_max_vcpus() states that it's using the recommended procedure from the kernel API documentation to get the max number of vcpus that kvm supports. It is, but by always returning the maximum number

[PATCH 3/3] aarch64: kvm: introduce CONFIG_KVM_MAX_VCPUS

2013-09-14 Thread Andrew Jones
Take CONFIG_KVM_MAX_VCPUS from arm32, but set the default to 8. Signed-off-by: Andrew Jones drjo...@redhat.com --- arch/arm64/include/asm/kvm_host.h | 7 ++- arch/arm64/kvm/Kconfig| 11 +++ 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/arch/arm64/include

[PATCH 1/3] arm: kvm: clamp NR_VCPUS to MAX_VCPUS

2013-09-14 Thread Andrew Jones
Signed-off-by: Andrew Jones drjo...@redhat.com --- arch/arm/kvm/arm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/kvm/arm.c b/arch/arm/kvm/arm.c index 741f66a2edbd7..9ebf8ac3a12ff 100644 --- a/arch/arm/kvm/arm.c +++ b/arch/arm/kvm/arm.c @@ -201,7 +201,7 @@ int

[PATCH 2/3] arm32: kvm: rename CONFIG_KVM_ARM_MAX_VCPUS

2013-09-14 Thread Andrew Jones
Drop the _ARM_ part of the name. We can then introduce a config option like this to aarch64 and other arches using the same name - allowing grep to show them all. Also update the help text to describe the option more completely. Signed-off-by: Andrew Jones drjo...@redhat.com --- arch/arm/include

[PATCH 0/3] KVM_MAX_VCPUS related changes

2013-09-14 Thread Andrew Jones
Andrew Jones (3): arm: kvm: clamp NR_VCPUS to MAX_VCPUS arm32: kvm: rename CONFIG_KVM_ARM_MAX_VCPUS aarch64: kvm: introduce CONFIG_KVM_MAX_VCPUS arch/arm/include/asm/kvm_host.h | 4 ++-- arch/arm/kvm/Kconfig | 8 arch/arm/kvm/arm.c| 2 +- arch

[PATCH] [RFC] x86: kvm: remove KVM_SOFT_MAX_VCPUS

2013-09-14 Thread Andrew Jones
can't think of anything other than generating more warnings[1] from qemu with guests that configure more vcpus than pcpus though. [1] Actually, until 972fc544b6034a in uq/master is merged there won't be any warnings either. Signed-off-by: Andrew Jones drjo...@redhat.com --- arch/x86/include/asm

[PATCH] x86: kvm: introduce CONFIG_KVM_MAX_VCPUS

2013-09-14 Thread Andrew Jones
Take CONFIG_KVM_MAX_VCPUS from arm32, but set the default to 255. Signed-off-by: Andrew Jones drjo...@redhat.com --- arch/x86/include/asm/kvm_host.h | 5 +++-- arch/x86/kvm/Kconfig| 10 ++ 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/arch/x86/include/asm

Re: [PATCH 1/3] arm: kvm: clamp NR_VCPUS to MAX_VCPUS

2013-09-14 Thread Andrew Jones
On Sat, Sep 14, 2013 at 07:14:02AM -0500, Alexander Graf wrote: Am 14.09.2013 um 07:10 schrieb Andrew Jones drjo...@redhat.com: Signed-off-by: Andrew Jones drjo...@redhat.com --- arch/arm/kvm/arm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/kvm

Re: [PATCH] [RFC] x86: kvm: remove KVM_SOFT_MAX_VCPUS

2013-09-16 Thread Andrew Jones
On Sun, Sep 15, 2013 at 12:03:22PM +0300, Gleb Natapov wrote: On Sat, Sep 14, 2013 at 02:16:51PM +0200, Andrew Jones wrote: This patch removes KVM_SOFT_MAX_VCPUS and uses num_online_cpus() for KVM_CAP_NR_VCPUS instead, as ARM does. While the API doc simply says KVM_CAP_NR_VCPUS should

Re: [PATCH] x86: kvm: introduce CONFIG_KVM_MAX_VCPUS

2013-09-16 Thread Andrew Jones
On Sun, Sep 15, 2013 at 12:08:38PM +0300, Gleb Natapov wrote: On Sat, Sep 14, 2013 at 02:18:49PM +0200, Andrew Jones wrote: Take CONFIG_KVM_MAX_VCPUS from arm32, but set the default to 255. Signed-off-by: Andrew Jones drjo...@redhat.com --- arch/x86/include/asm/kvm_host.h | 5

Re: [PATCH] [RFC] x86: kvm: remove KVM_SOFT_MAX_VCPUS

2013-09-16 Thread Andrew Jones
On Mon, Sep 16, 2013 at 11:55:17AM +0300, Gleb Natapov wrote: On Mon, Sep 16, 2013 at 10:22:09AM +0200, Andrew Jones wrote: [1] Actually, until 972fc544b6034a in uq/master is merged there won't be any warnings either. Signed-off-by: Andrew Jones drjo...@redhat.com

Re: [PATCH] x86: kvm: introduce CONFIG_KVM_MAX_VCPUS

2013-09-16 Thread Andrew Jones
On Mon, Sep 16, 2013 at 11:47:10AM +0300, Gleb Natapov wrote: On Mon, Sep 16, 2013 at 10:28:20AM +0200, Andrew Jones wrote: On Sun, Sep 15, 2013 at 12:08:38PM +0300, Gleb Natapov wrote: On Sat, Sep 14, 2013 at 02:18:49PM +0200, Andrew Jones wrote: Take CONFIG_KVM_MAX_VCPUS from arm32

Re: [PATCH] [RFC] x86: kvm: remove KVM_SOFT_MAX_VCPUS

2013-09-16 Thread Andrew Jones
On Mon, Sep 16, 2013 at 05:41:18PM +0300, Gleb Natapov wrote: On Mon, Sep 16, 2013 at 01:47:26PM +0200, Andrew Jones wrote: On Mon, Sep 16, 2013 at 11:55:17AM +0300, Gleb Natapov wrote: On Mon, Sep 16, 2013 at 10:22:09AM +0200, Andrew Jones wrote: [1] Actually, until 972fc544b6034a

Re: [PATCH] x86: kvm: introduce CONFIG_KVM_MAX_VCPUS

2013-09-16 Thread Andrew Jones
On Mon, Sep 16, 2013 at 05:16:20PM +0300, Gleb Natapov wrote: On Mon, Sep 16, 2013 at 02:03:33PM +0200, Andrew Jones wrote: On Mon, Sep 16, 2013 at 11:47:10AM +0300, Gleb Natapov wrote: On Mon, Sep 16, 2013 at 10:28:20AM +0200, Andrew Jones wrote: On Sun, Sep 15, 2013 at 12:08:38PM +0300

Re: [PATCH] [RFC] x86: kvm: remove KVM_SOFT_MAX_VCPUS

2013-09-17 Thread Andrew Jones
On Tue, Sep 17, 2013 at 12:36:19PM +0300, Gleb Natapov wrote: On Mon, Sep 16, 2013 at 05:22:26PM +0200, Andrew Jones wrote: On Mon, Sep 16, 2013 at 05:41:18PM +0300, Gleb Natapov wrote: On Mon, Sep 16, 2013 at 01:47:26PM +0200, Andrew Jones wrote: On Mon, Sep 16, 2013 at 11:55:17AM +0300

[PATCH v2] arm32: kvm: rename CONFIG_KVM_ARM_MAX_VCPUS

2013-09-24 Thread Andrew Jones
Drop the _ARM_ part of the name. We can then introduce a config option like this to aarch64 and other arches using the same name - allowing grep to show them all. Also update the help text to describe the option more completely. Signed-off-by: Andrew Jones drjo...@redhat.com --- v2: reword help

Re: [PATCH v2] arm32: kvm: rename CONFIG_KVM_ARM_MAX_VCPUS

2013-09-26 Thread Andrew Jones
On Wed, Sep 25, 2013 at 12:31:27PM -0700, Christoffer Dall wrote: On Tue, Sep 24, 2013 at 04:09:28PM +0200, Andrew Jones wrote: Drop the _ARM_ part of the name. We can then introduce a config option like this to aarch64 and other arches using the same name - allowing grep to show them all

[PATCH 8/9] arm: initial drop

2013-10-14 Thread Andrew Jones
-gnu dtc export QEMU=[qemu with mach-virt and virtio-testdev] ./configure --cross-prefix=arm-linux-gnu- --arch=arm make ./run_tests.sh Signed-off-by: Andrew Jones drjo...@redhat.com --- arm/boot.c| 27 arm/cstart.S | 47

[PATCH 0/9] kvm-unit-tests/arm: initial drop

2013-10-14 Thread Andrew Jones
Andrew Jones (9): remove unused files makefile and run_tests tweaks clean root dir of all x86-ness Introduce a simple iomap structure Add halt() and some error codes Introduce virtio-testdev arm: replace arbitrary divisions arm: initial drop arm: add vectors support Makefile

[PATCH 2/9] makefile and run_tests tweaks

2013-10-14 Thread Andrew Jones
- remove a redundant '-display none' - remove a redundant -g from CFLAGS - remove a useless -I../include/x86 from CFLAGS - remove lib autodep files on make clean Signed-off-by: Andrew Jones drjo...@redhat.com --- Makefile | 8 config-x86-common.mak | 16

[PATCH 3/9] clean root dir of all x86-ness

2013-10-14 Thread Andrew Jones
Remove all references to x86 from the root dir (except from in configure). Also remove references from the root dir README by moving that documentation to the x86/README, and touch up the READMEs at the same time. Signed-off-by: Andrew Jones drjo...@redhat.com --- Makefile

[PATCH 7/9] arm: replace arbitrary divisions

2013-10-14 Thread Andrew Jones
of two. Divide by 10 can be hacked up using a multiplication and shift. Signed-off-by: Andrew Jones drjo...@redhat.com --- lib/divmod.h | 20 lib/printf.c | 27 ++- 2 files changed, 34 insertions(+), 13 deletions(-) create mode 100644 lib/divmod.h diff

[PATCH 5/9] Add halt() and some error codes

2013-10-14 Thread Andrew Jones
without having to find the halt() call-site using its return address. Signed-off-by: Andrew Jones drjo...@redhat.com --- lib/errno.h| 15 +++ lib/libcflat.h | 2 ++ lib/x86/io.c | 6 ++ 3 files changed, 23 insertions(+) create mode 100644 lib/errno.h diff --git a/lib/errno.h b

[PATCH 9/9] arm: add vectors support

2013-10-14 Thread Andrew Jones
Add support for tests to manage exception handlers. Now we need kvm. Signed-off-by: Andrew Jones drjo...@redhat.com --- arm/boot.c| 29 +++ arm/cstart.S | 46 arm/run | 2 +- arm/unittests.cfg | 6

[PATCH 4/9] Introduce a simple iomap structure

2013-10-14 Thread Andrew Jones
, }, }, { .type = NULL, }, }; Also add a script scripts/gen-devtree-iomaps.pl that can generate the iomaps table from an fdt, e.g. fdtdump dtb | scripts/gen-devtree-iomaps.pl - virtio_mmio Signed-off-by: Andrew Jones drjo...@redhat.com --- README| 1 + lib/iomaps.c

[PATCH 6/9] Introduce virtio-testdev

2013-10-14 Thread Andrew Jones
virtio-testdev is a communication channel to qemu through virtio that can be used by test code to send commands. The only command currently implemented is EXIT, which allows the test code to exit with a given status code. Signed-off-by: Andrew Jones drjo...@redhat.com --- lib/bswap.h

Re: [PATCH 6/9] Introduce virtio-testdev

2013-10-15 Thread Andrew Jones
On Mon, Oct 14, 2013 at 06:23:32PM +0200, Andrew Jones wrote: virtio-testdev is a communication channel to qemu through virtio that can be used by test code to send commands. The only command currently implemented is EXIT, which allows the test code to exit with a given status code. Signed

Re: [PATCH 1/9] remove unused files

2013-10-16 Thread Andrew Jones
On Wed, Oct 16, 2013 at 03:52:43PM +0300, Gleb Natapov wrote: Copying Alex in case he has an opinion about removing powerpc. We had discussed it earlier[1], and I got the go-ahead to toss out the current code. drew [1] http://comments.gmane.org/gmane.comp.emulators.kvm.powerpc.devel/7747 --

Re: [PATCH 3/9] clean root dir of all x86-ness

2013-10-17 Thread Andrew Jones
On Wed, Oct 16, 2013 at 06:06:06PM -0700, Christoffer Dall wrote: -The exit status of the binary (and the script) is inconsistent: with -qemu-system, after the unittest is done, the exit status of qemu is 1, -different from the 'old style' qemu-kvm, whose exit status in successful

Re: [PATCH 6/9] Introduce virtio-testdev

2013-10-17 Thread Andrew Jones
On Wed, Oct 16, 2013 at 06:06:14PM -0700, Christoffer Dall wrote: There's an interesting mix of space and tab indentations in this file... I assume using the kernel coding style would be approprate here... Actually, that could be added to the readme too. (Or whichever format we choose).

Re: [PATCH 7/9] arm: replace arbitrary divisions

2013-10-17 Thread Andrew Jones
On Wed, Oct 16, 2013 at 06:06:29PM -0700, Christoffer Dall wrote: On Mon, Oct 14, 2013 at 06:23:33PM +0200, Andrew Jones wrote: arm can't do arbitrary divisions without software support. Usually libgcc would jump in here, but depending on the toolchain used that may or may not work. Luckily

Re: [PATCH 8/9] arm: initial drop

2013-10-17 Thread Andrew Jones
On Wed, Oct 16, 2013 at 06:06:35PM -0700, Christoffer Dall wrote: diff --git a/arm/boot.c b/arm/boot.c new file mode 100644 index 0..375e8708a7c54 this file's indentation is also funny, you should really check your editor configuration :) Actually the editor prefers kernel

Re: [PATCH 9/9] arm: add vectors support

2013-10-17 Thread Andrew Jones
On Wed, Oct 16, 2013 at 06:06:42PM -0700, Christoffer Dall wrote: +++ b/arm/cstart.S @@ -1,5 +1,6 @@ #define CR_B (1 7) +#define CR_V (1 13) .arm @@ -12,6 +13,13 @@ start: push{ r0-r3 } @push r3 too for 8-byte alignment mrc

Re: [PATCH 8/9] arm: initial drop

2013-10-17 Thread Andrew Jones
On Thu, Oct 17, 2013 at 12:16:18PM +0200, Andrew Jones wrote: On Wed, Oct 16, 2013 at 06:06:35PM -0700, Christoffer Dall wrote: diff --git a/arm/boot.c b/arm/boot.c new file mode 100644 index 0..375e8708a7c54 this file's indentation is also funny, you should really check

Re: [PATCH 9/9] arm: add vectors support

2013-10-20 Thread Andrew Jones
On Thu, Oct 17, 2013 at 11:58:43AM -0700, Christoffer Dall wrote: On Thu, Oct 17, 2013 at 12:38:59PM +0200, Andrew Jones wrote: On Wed, Oct 16, 2013 at 06:06:42PM -0700, Christoffer Dall wrote: +++ b/arm/cstart.S @@ -1,5 +1,6 @@ #define CR_B (1 7) +#define CR_V (1

Re: [PATCH 3/9] clean root dir of all x86-ness

2013-10-20 Thread Andrew Jones
On Thu, Oct 17, 2013 at 12:01:52PM -0700, Christoffer Dall wrote: On Thu, Oct 17, 2013 at 11:35:09AM +0200, Andrew Jones wrote: On Wed, Oct 16, 2013 at 06:06:06PM -0700, Christoffer Dall wrote: -The exit status of the binary (and the script) is inconsistent: with -qemu-system, after

Re: [PATCH 2/3] arm/arm64: KVM: MMIO support for BE guest

2013-11-12 Thread Andrew Jones
On Mon, Nov 11, 2013 at 07:41:30PM +0100, Paolo Bonzini wrote: Il 11/11/2013 19:26, Marc Zyngier ha scritto: The pull requests were clean and my life wasn't complicated much... On the other hand I'm trying to understand if there's something that can be improved because the conflict

Re: [PATCH 0/9] kvm-unit-tests/arm: initial drop

2013-11-26 Thread Andrew Jones
Sorry, just noticed this - you dropped me and the kvmarm list from your reply. On Wed, Nov 20, 2013 at 11:06:11PM +, MarĂ­a Soler Heredia wrote: Andrew Jones drjones at redhat.com writes: This series introduces arm to kvm-unit-tests. To use this you need an arm platform

[PATCH 2/9] makefile and run_tests tweaks

2013-12-04 Thread Andrew Jones
- remove a redundant '-display none' - remove a redundant -g from CFLAGS - remove a useless -I../include/x86 from CFLAGS - remove lib autodep files on make clean Signed-off-by: Andrew Jones drjo...@redhat.com --- Makefile | 8 config-x86-common.mak | 16

[PATCH 0/9 v2] kvm-unit-tests/arm: initial drop

2013-12-04 Thread Andrew Jones
/master Andrew Jones (9): remove unused files makefile and run_tests tweaks clean root dir of all x86-ness move x86's simple heap management to common code Introduce libio to common code for io read/write Introduce a simple iomap structure Add halt() and some error codes Introduce

[PATCH 9/9] arm: initial drop

2013-12-04 Thread Andrew Jones
export QEMU=[qemu with mach-virt and virtio-testdev] ./configure --cross-prefix=arm-linux-gnu- --arch=arm make ./run_tests.sh Signed-off-by: Andrew Jones drjo...@redhat.com --- v2: - add eabi utility functions needed for some toolchains, this allows us to drop the divmod hacks

[PATCH 8/9] Introduce virtio-testdev

2013-12-04 Thread Andrew Jones
virtio-testdev is a communication channel to qemu through virtio that can be used by test code to send commands. The only command currently implemented is EXIT, which allows the test code to exit with a given status code. Signed-off-by: Andrew Jones drjo...@redhat.com --- v2: - use readl/writel

[PATCH 4/9] move x86's simple heap management to common code

2013-12-04 Thread Andrew Jones
Signed-off-by: Andrew Jones drjo...@redhat.com --- config/config-x86-common.mak | 1 + lib/heap.c | 43 +++ lib/heap.h | 8 lib/x86/vm.c | 33 ++--- 4 files changed

[PATCH 3/9] clean root dir of all x86-ness

2013-12-04 Thread Andrew Jones
Remove all references to x86 from the root dir (except from in configure). Also remove references from the root dir README by moving that documentation to the x86/README, and touch up the READMEs at the same time. Signed-off-by: Andrew Jones drjo...@redhat.com --- v2: - tests' images = test

[PATCH 6/9] Introduce a simple iomap structure

2013-12-04 Thread Andrew Jones
, }, }, { .type = NULL, }, }; Also add a script scripts/gen-devtree-iomaps.pl that can generate the iomaps table from an fdt, e.g. fdtdump dtb | scripts/gen-devtree-iomaps.pl - virtio_mmio Signed-off-by: Andrew Jones drjo...@redhat.com --- v2: - switch to kernel coding style - rework fdt

[PATCH 7/9] Add halt() and some error codes

2013-12-04 Thread Andrew Jones
the problem without having to find the halt() call-site. The error codes may of course also be used with exit(). Signed-off-by: Andrew Jones drjo...@redhat.com --- v2: - keep the error numbers more consistent with the standard numbers --- lib/errno.h| 22 ++ lib/libcflat.h

[PATCH 5/9] Introduce libio to common code for io read/write

2013-12-04 Thread Andrew Jones
Signed-off-by: Andrew Jones drjo...@redhat.com --- lib/libio.c | 67 +++ lib/libio.h | 176 2 files changed, 243 insertions(+) create mode 100644 lib/libio.c create mode 100644 lib/libio.h diff --git a/lib

[PATCH 1/3] printf: support field padding

2013-12-13 Thread Andrew Jones
Support format flags for field padding, such as %08x, allowing register dumps to be easier on the eyes. Signed-off-by: Andrew Jones drjo...@redhat.com --- lib/printf.c | 84 ++-- 1 file changed, 70 insertions(+), 14 deletions(-) diff --git

[PATCH v2 0/3] kvm-unit-tests/arm: add vectors support

2013-12-13 Thread Andrew Jones
Dall] Andrew Jones (3): printf: support field padding arm: add useful headers from the linux kernel arm: vectors support arm/boot.c| 128 +-- arm/cstart.S | 168 -- arm/flat.lds

[PATCH 3/3] arm: vectors support

2013-12-13 Thread Andrew Jones
Add support for tests to use exception handlers. Signed-off-by: Andrew Jones drjo...@redhat.com --- arm/boot.c| 128 -- arm/cstart.S | 168 -- arm/flat.lds | 7 ++- arm

[PATCH 2/3] arm: add useful headers from the linux kernel

2013-12-13 Thread Andrew Jones
.h from the kernel, since we'll need bit defines from there too. Signed-off-by: Andrew Jones drjo...@redhat.com --- config/config-arm.mak | 17 ++-- lib/arm/asm-offsets.h | 27 + lib/arm/cp15.h| 36 + lib/arm/ptrace.h | 100

Re: [PATCH 2/9] makefile and run_tests tweaks

2014-01-02 Thread Andrew Jones
On Sat, Dec 28, 2013 at 10:30:03PM -0800, Christoffer Dall wrote: On Wed, Dec 04, 2013 at 05:42:50PM +0100, Andrew Jones wrote: This is a really short commit message, for anyone not super-familiar with the make system in this toolset, it makes it quite hard to understand the change. See

Re: [PATCH 4/9] move x86's simple heap management to common code

2014-01-02 Thread Andrew Jones
On Sat, Dec 28, 2013 at 10:30:24PM -0800, Christoffer Dall wrote: + + if (s != (s ~(pagesize - 1))) { you're just testing 'if (s (pagesize -1))' right? yeah, I'll simplify that. + s += pagesize; + s = ~(pagesize - 1); + p = (void *)s; + } a

Re: [PATCH 3/9] clean root dir of all x86-ness

2014-01-02 Thread Andrew Jones
On Sat, Dec 28, 2013 at 10:30:12PM -0800, Christoffer Dall wrote: clean: arch_clean - $(RM) *.o *.a .*.d lib/.*.d $(libcflat) $(cflatobjs) + $(RM) lib/.*.d $(libcflat) $(cflatobjs) so above you're referencing */.*.d and */*/.*.d but in make arch_clean we're only removing

Re: [PATCH 5/9] Introduce libio to common code for io read/write

2014-01-02 Thread Andrew Jones
On Sat, Dec 28, 2013 at 10:30:35PM -0800, Christoffer Dall wrote: diff --git a/lib/libio.c b/lib/libio.c new file mode 100644 index 0..e450e984fefb1 --- /dev/null +++ b/lib/libio.c @@ -0,0 +1,67 @@ +#include libcflat.h +#include libio.h + +void read_len(const

Re: [PATCH 6/9] Introduce a simple iomap structure

2014-01-02 Thread Andrew Jones
On Sat, Dec 28, 2013 at 10:30:54PM -0800, Christoffer Dall wrote: +struct iomap { + const char *type; + const char *compats[5]; I would name the field compatible to be more in-line with the DT-representation, but OK. it looks from the above like the array must be null terminated?

Re: [PATCH 8/9] Introduce virtio-testdev

2014-01-02 Thread Andrew Jones
On Sat, Dec 28, 2013 at 10:31:17PM -0800, Christoffer Dall wrote: + +/* + * We have to write all args; nargs, nrets, ... first to + * avoid executing token's operation until all args are in the token's ? ok + * place. Then issue the op, and then read the rets. Reading rets?

Re: [PATCH 9/9] arm: initial drop

2014-01-02 Thread Andrew Jones
On Sat, Dec 28, 2013 at 10:31:35PM -0800, Christoffer Dall wrote: On Wed, Dec 04, 2013 at 05:42:57PM +0100, Andrew Jones wrote: This is the initial arm test framework and a first simple test that checks some bootinfo. kvm isn't needed to run this test. This patch also adds a common build

Re: [PATCH 1/3] printf: support field padding

2014-01-02 Thread Andrew Jones
On Sat, Dec 28, 2013 at 10:31:44PM -0800, Christoffer Dall wrote: + +if (npad 0) { + char pad = props.pad; + if (pad == '0') /* ignore '0' flag with '-' flag */ + pad = ' '; there are only the two options, so you can drop the check if you like. true. removed.

Re: [PATCH 2/3] arm: add useful headers from the linux kernel

2014-01-02 Thread Andrew Jones
On Sat, Dec 28, 2013 at 10:31:58PM -0800, Christoffer Dall wrote: On Fri, Dec 13, 2013 at 11:58:05AM +0100, Andrew Jones wrote: We're going to need PSR bit defines and pt_regs. We'll also need pt_regs offsets in assembly code. This patch adapts the linux kernel's ptrace.h and asm-offsets

Re: [PATCH 3/3] arm: vectors support

2014-01-02 Thread Andrew Jones
On Sat, Dec 28, 2013 at 10:32:10PM -0800, Christoffer Dall wrote: On Fri, Dec 13, 2013 at 11:58:06AM +0100, Andrew Jones wrote: Add support for tests to use exception handlers. You are doing a lot more than that it seems. In fact, this is a lot of code to review at one time. I would have

Re: [PATCH 8/9] Introduce virtio-testdev

2014-01-02 Thread Andrew Jones
On Thu, Jan 02, 2014 at 09:27:18AM -0800, Christoffer Dall wrote: On Thu, Jan 02, 2014 at 05:16:56PM +0100, Andrew Jones wrote: On Sat, Dec 28, 2013 at 10:31:17PM -0800, Christoffer Dall wrote: + +/* + * We have to write all args; nargs, nrets, ... first to + * avoid executing

Re: [PATCH 5/9] Introduce libio to common code for io read/write

2014-01-02 Thread Andrew Jones
On Thu, Jan 02, 2014 at 09:19:30AM -0800, Christoffer Dall wrote: How is this going to be used here? The compat ptr stuff in the kernel deals with user space pointer iirc, but I'm not an expert on the details. Does typedef'ing a pointer to a u32 in generic code work on a 64-bit

Re: [PATCH 9/9] arm: initial drop

2014-01-02 Thread Andrew Jones
On Thu, Jan 02, 2014 at 10:09:50AM -0800, Christoffer Dall wrote: On Thu, Jan 02, 2014 at 05:40:24PM +, Peter Maydell wrote: On 2 January 2014 16:54, Andrew Jones drjo...@redhat.com wrote: On Sat, Dec 28, 2013 at 10:31:35PM -0800, Christoffer Dall wrote: On Wed, Dec 04, 2013 at 05:42

Re: [PATCH 9/9] arm: initial drop

2014-01-02 Thread Andrew Jones
On Thu, Jan 02, 2014 at 09:44:39AM -0800, Christoffer Dall wrote: My cross-compiler was generating broken code with anything less. I haven't checked later compilers yet to see if it's fixed or not. which GCC version? $ arm-linux-gnu-gcc -v Using built-in specs.

Re: [PATCH 0/9] kvm-unit-tests/arm: initial drop

2014-01-02 Thread Andrew Jones
On Sun, Dec 29, 2013 at 01:24:11AM -0800, Christoffer Dall wrote: On Mon, Oct 14, 2013 at 06:23:26PM +0200, Andrew Jones wrote: Hi Drew, This series introduces arm to kvm-unit-tests. First, it does some tidying up of the repo. Then, it adds support for virtio-testdev, which was just

  1   2   3   4   5   6   >