[Launchpad-reviewers] [Merge] ~pelpsi/launchpad-mojo-specs/+git/private:fetch-service-revision-bump-to-6 into ~launchpad/launchpad-mojo-specs/+git/private:master

2024-04-29 Thread Simone Pelosi
The proposal to merge ~pelpsi/launchpad-mojo-specs/+git/private:fetch-service-revision-bump-to-6 into ~launchpad/launchpad-mojo-specs/+git/private:master has been updated. Status: Needs review => Approved For more details, see:

[Launchpad-reviewers] [Merge] ~pelpsi/launchpad-mojo-specs/+git/private:fetch-service-revision-bump-to-6 into ~launchpad/launchpad-mojo-specs/+git/private:master

2024-04-29 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/launchpad-mojo-specs/+git/private:fetch-service-revision-bump-to-6 into ~launchpad/launchpad-mojo-specs/+git/private:master. Commit message: lp-fetch-service: bump fetch-service revision to 6 Requested reviews: Canonical Launchpad Engineering

[Launchpad-reviewers] [Merge] ~pelpsi/launchpad-buildd:handle-base64-certificate into launchpad-buildd:master

2024-04-26 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/launchpad-buildd:handle-base64-certificate into launchpad-buildd:master. Commit message: Handle Base64 certificate Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~pelpsi/launchpad

[Launchpad-reviewers] [Merge] ~pelpsi/launchpad-buildd:fix-cerf-file-permissions into launchpad-buildd:master

2024-04-24 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/launchpad-buildd:fix-cerf-file-permissions into launchpad-buildd:master. Commit message: Give to the cert file the right permissions Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net

[Launchpad-reviewers] [Merge] ~pelpsi/launchpad:add-fetch-service-certificate-to-secrets into launchpad:master

2024-04-23 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/launchpad:add-fetch-service-certificate-to-secrets into launchpad:master. Commit message: Add fetch_service_mitm_certificate to secrets Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https

[Launchpad-reviewers] [Merge] ~pelpsi/launchpad-mojo-specs/+git/private:fetch-service-charmhub-configuration into ~launchpad/launchpad-mojo-specs/+git/private:master

2024-04-23 Thread Simone Pelosi
The proposal to merge ~pelpsi/launchpad-mojo-specs/+git/private:fetch-service-charmhub-configuration into ~launchpad/launchpad-mojo-specs/+git/private:master has been updated. Status: Needs review => Approved For more details, see:

[Launchpad-reviewers] [Merge] ~pelpsi/launchpad-mojo-specs/+git/private:fetch-service-charmhub-configuration into ~launchpad/launchpad-mojo-specs/+git/private:master

2024-04-23 Thread Simone Pelosi
The proposal to merge ~pelpsi/launchpad-mojo-specs/+git/private:fetch-service-charmhub-configuration into ~launchpad/launchpad-mojo-specs/+git/private:master has been updated. Commit message changed to: lp-fetch-service: Deploy fetch-service charm from Charmhub For more details, see:

[Launchpad-reviewers] [Merge] ~pelpsi/launchpad:unembargo-buildinfo-file into launchpad:master

2024-04-23 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/launchpad:unembargo-buildinfo-file into launchpad:master. Commit message: Unembargo build info Added buildinfo to unembargoed files. LP: #2052796 Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: Bug #2052796

[Launchpad-reviewers] [Merge] ~pelpsi/launchpad-mojo-specs/+git/private:fetch-service-charmhub-configuration into ~launchpad/launchpad-mojo-specs/+git/private:master

2024-04-23 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/launchpad-mojo-specs/+git/private:fetch-service-charmhub-configuration into ~launchpad/launchpad-mojo-specs/+git/private:master. Commit message: Get fetch-service from Charmhub Requested reviews: Canonical Launchpad Engineering (launchpad) For more

[Launchpad-reviewers] [Merge] ~pelpsi/launchpad:unembargo-bug-build-info-missing into launchpad:master

2024-04-19 Thread Simone Pelosi
The proposal to merge ~pelpsi/launchpad:unembargo-bug-build-info-missing into launchpad:master has been updated. Status: Needs review => Work in progress For more details, see: https://code.launchpad.net/~pelpsi/launchpad/+git/launchpad/+merge/464705 -- Your team Launchpad code reviewers

[Launchpad-reviewers] [Merge] ~pelpsi/launchpad:unembargo-bug-build-info-missing into launchpad:master

2024-04-19 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/launchpad:unembargo-bug-build-info-missing into launchpad:master. Commit message: Unembargo build info Added buildinfo to unembargoed files. Added custom upload files to unembargoed files. Added a new endpoint buildMetadataFileUrls to retrieve

Re: [Launchpad-reviewers] [Merge] ~jugmac00/launchpad:expose-build-metadata-via-api into launchpad:master

2024-04-19 Thread Simone Pelosi
I just add there what we found during the peer programming session :) Diff comments: > diff --git a/lib/lp/snappy/interfaces/snapbuild.py > b/lib/lp/snappy/interfaces/snapbuild.py > index 52019bf..46bd205 100644 > --- a/lib/lp/snappy/interfaces/snapbuild.py > +++

[Launchpad-reviewers] [Merge] ~pelpsi/launchpad:pass-information-via-XML-RPC-API-to-the-builders into launchpad:master

2024-04-15 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/launchpad:pass-information-via-XML-RPC-API-to-the-builders into launchpad:master. Commit message: Passing certificate to the builders Builders need certificate to configure correctly env to use fetch service. Requested reviews: Launchpad code

[Launchpad-reviewers] [Merge] ~pelpsi/launchpad-buildd:pass-information-via-XML-RPC-API-to-the-builders into launchpad-buildd:master

2024-04-15 Thread Simone Pelosi
The proposal to merge ~pelpsi/launchpad-buildd:pass-information-via-XML-RPC-API-to-the-builders into launchpad-buildd:master has been updated. Status: Needs review => Work in progress For more details, see:

[Launchpad-reviewers] [Merge] ~pelpsi/launchpad-buildd:pass-information-via-XML-RPC-API-to-the-builders into launchpad-buildd:master

2024-04-15 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/launchpad-buildd:pass-information-via-XML-RPC-API-to-the-builders into launchpad-buildd:master with ~ines-almeida/launchpad-buildd:update-close-session-for-fetch-service as a prerequisite. Commit message: Pass information via XML-RPC API

[Launchpad-reviewers] [Merge] ~pelpsi/launchpad-buildd:pass-information-via-XML-RPC-API-to-the-builders into launchpad-buildd:master

2024-04-15 Thread Simone Pelosi
The proposal to merge ~pelpsi/launchpad-buildd:pass-information-via-XML-RPC-API-to-the-builders into launchpad-buildd:master has been updated. Status: Work in progress => Superseded For more details, see:

Re: [Launchpad-reviewers] [Merge] ~ines-almeida/launchpad-mojo-specs/+git/private:fetch-service-fix-typo into ~launchpad/launchpad-mojo-specs/+git/private:master

2024-04-08 Thread Simone Pelosi
Review: Approve -- https://code.launchpad.net/~ines-almeida/launchpad-mojo-specs/+git/private/+merge/463831 Your team Launchpad code reviewers is subscribed to branch ~launchpad/launchpad-mojo-specs/+git/private:master. ___ Mailing list:

Re: [Launchpad-reviewers] [Merge] ~pelpsi/launchpad:snap-component-integration into launchpad:master

2024-03-27 Thread Simone Pelosi
Thank you for your precious reviews, I firstly addressed some of your comments here, and I'm working to remove snapcraft.yaml logic to search for components as suggested by William. I will use the build files to retrieve them. I also had a chat with Przemysław, and he clarified that snap_name

[Launchpad-reviewers] [Merge] ~pelpsi/launchpad:snap-component-integration into launchpad:master

2024-03-14 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/launchpad:snap-component-integration into launchpad:master. Commit message: Add Snap Component support Reference: LP142 Snap Components are processed and uploaded to the snapcraft storage before pushing the Snap to the store. Once every component

[Launchpad-reviewers] [Merge] ~pelpsi/launchpad:launchpad-build-manager-fetch-service-support into launchpad:master

2024-03-13 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/launchpad:launchpad-build-manager-fetch-service-support into launchpad:master. Commit message: Update launchpad-buildd-manager to support Fetch Service Add configs for fetch service into launchpad-buildd-manager charm. Requested reviews

[Launchpad-reviewers] [Merge] ~pelpsi/launchpad:fetch-service-revocation-endpoint-fix into launchpad:master

2024-03-12 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/launchpad:fetch-service-revocation-endpoint-fix into launchpad:master. Commit message: Fix revocation endpoint fetch_service_control_endpoint already has the following structure: http://host:port/session Requested reviews: Launchpad code

[Launchpad-reviewers] [Merge] ~pelpsi/launchpad:requestProxyToken-function-refactor into launchpad:master

2024-03-11 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/launchpad:requestProxyToken-function-refactor into launchpad:master. Commit message: Refactor _requestProxyToken to be aligned with _requestFetchServiceSession Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see

[Launchpad-reviewers] [Merge] ~pelpsi/launchpad:refactor-requestProxyToken-function into launchpad:master

2024-03-11 Thread Simone Pelosi
The proposal to merge ~pelpsi/launchpad:refactor-requestProxyToken-function into launchpad:master has been updated. Status: Needs review => Rejected For more details, see: https://code.launchpad.net/~pelpsi/launchpad/+git/launchpad/+merge/462143 -- Your team Launchpad code reviewers is

[Launchpad-reviewers] [Merge] ~pelpsi/launchpad:refactor-requestProxyToken-function into launchpad:master

2024-03-11 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/launchpad:refactor-requestProxyToken-function into launchpad:master. Commit message: Refactor requestProxyToken function to be aligned with requestFetchServiceSession Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more

Re: [Launchpad-reviewers] [Merge] ~pelpsi/launchpad:fetch-service-session-API into launchpad:master

2024-03-06 Thread Simone Pelosi
Diff comments: > diff --git a/lib/lp/buildmaster/builderproxy.py > b/lib/lp/buildmaster/builderproxy.py > index be65e29..a1d475b 100644 > --- a/lib/lp/buildmaster/builderproxy.py > +++ b/lib/lp/buildmaster/builderproxy.py > @@ -52,26 +67,28 @@ class BuilderProxyMixin: > >

Re: [Launchpad-reviewers] [Merge] ~pelpsi/launchpad:fetch-service-session-API into launchpad:master

2024-03-05 Thread Simone Pelosi
Diff comments: > diff --git a/lib/lp/buildmaster/downloader.py > b/lib/lp/buildmaster/downloader.py > index fc16852..cee308a 100644 > --- a/lib/lp/buildmaster/downloader.py > +++ b/lib/lp/buildmaster/downloader.py > @@ -94,3 +110,24 @@ class RequestProcess(AMPChild): > ) >

Re: [Launchpad-reviewers] [Merge] ~pelpsi/launchpad:fetch-service-session-API into launchpad:master

2024-03-04 Thread Simone Pelosi
Thank you for the review Ines, I'm so sorry I forgot to push the commit in which I removed all the debugging stuff or useless comments :P -- https://code.launchpad.net/~pelpsi/launchpad/+git/launchpad/+merge/461721 Your team Launchpad code reviewers is requested to review the proposed merge of

Re: [Launchpad-reviewers] [Merge] ~pelpsi/launchpad:fetch-service-session-API into launchpad:master

2024-03-04 Thread Simone Pelosi
Diff comments: > diff --git a/lib/lp/buildmaster/downloader.py > b/lib/lp/buildmaster/downloader.py > index fc16852..cee308a 100644 > --- a/lib/lp/buildmaster/downloader.py > +++ b/lib/lp/buildmaster/downloader.py > @@ -94,3 +110,24 @@ class RequestProcess(AMPChild): > ) >

[Launchpad-reviewers] [Merge] ~pelpsi/launchpad:request-token-and-session-from-fetch-service into launchpad:master

2024-03-04 Thread Simone Pelosi
The proposal to merge ~pelpsi/launchpad:request-token-and-session-from-fetch-service into launchpad:master has been updated. Status: Work in progress => Rejected For more details, see: https://code.launchpad.net/~pelpsi/launchpad/+git/launchpad/+merge/461586 -- Your team Launchpad code

[Launchpad-reviewers] [Merge] ~pelpsi/launchpad:fetch-service-session-API into launchpad:master

2024-03-04 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/launchpad:fetch-service-session-API into launchpad:master with ~ines-almeida/launchpad:fetch-service-option-model-update as a prerequisite. Commit message: Add fetch service session API Update BuilderProxyMixin class to switch between Fetch

Re: [Launchpad-reviewers] [Merge] ~pelpsi/lp-signing:update-development-documentation into lp-signing:master

2024-03-04 Thread Simone Pelosi
Diff comments: > diff --git a/README.rst b/README.rst > index 5fc6b9b..4e52196 100644 > --- a/README.rst > +++ b/README.rst > @@ -38,6 +38,12 @@ Generate another key pair, and add the private half to > ``private_keys`` > > $ env/bin/lp-signing generate-key-pair > > +If you want to

Re: [Launchpad-reviewers] [Merge] ~pelpsi/launchpad-buildd:qastaging-documentation-improvement into launchpad-buildd:master

2024-03-01 Thread Simone Pelosi
Diff comments: > diff --git a/docs/how-to/deployment.rst b/docs/how-to/deployment.rst > index 7365bee..fbe4b22 100644 > --- a/docs/how-to/deployment.rst > +++ b/docs/how-to/deployment.rst > @@ -42,11 +42,14 @@ Testing on qastaging > >

[Launchpad-reviewers] [Merge] ~pelpsi/lp-signing:update-development-documentation into lp-signing:master

2024-03-01 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/lp-signing:update-development-documentation into lp-signing:master. Commit message: Add register-client command to the documentation Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net

[Launchpad-reviewers] [Merge] ~pelpsi/launchpad:create-new-4096-key-for-archives-with-1024-key into launchpad:master

2024-03-01 Thread Simone Pelosi
The proposal to merge ~pelpsi/launchpad:create-new-4096-key-for-archives-with-1024-key into launchpad:master has been updated. Description changed to: Required for LP130 - ESM authorization for archive snapshots:

[Launchpad-reviewers] [Merge] ~pelpsi/launchpad:create-new-4096-key-for-archives-with-1024-key into launchpad:master

2024-03-01 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/launchpad:create-new-4096-key-for-archives-with-1024-key into launchpad:master. Commit message: Add logic to update 1024 PPAs keys Cronscript to generate new 4096-bit RSA signing keys for the affected PPAs (the ones with 1024-bit key) and add

[Launchpad-reviewers] [Merge] ~pelpsi/launchpad:request-token-and-session-from-fetch-service into launchpad:master

2024-02-29 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/launchpad:request-token-and-session-from-fetch-service into launchpad:master with ~ines-almeida/launchpad:fetch-service-option-model-update as a prerequisite. Commit message: Request fetch service session NOTE: THIS IS A WIP! This message

[Launchpad-reviewers] [Merge] ~pelpsi/launchpad:request-token-and-session-from-fetch-service into launchpad:master

2024-02-29 Thread Simone Pelosi
The proposal to merge ~pelpsi/launchpad:request-token-and-session-from-fetch-service into launchpad:master has been updated. Status: Needs review => Work in progress For more details, see: https://code.launchpad.net/~pelpsi/launchpad/+git/launchpad/+merge/461586 -- Your team Launchpad

[Launchpad-reviewers] [Merge] ~pelpsi/launchpad:request-token-and-session-from-fetch-service into launchpad:master

2024-02-29 Thread Simone Pelosi
The proposal to merge ~pelpsi/launchpad:request-token-and-session-from-fetch-service into launchpad:master has been updated. Status: Work in progress => Superseded For more details, see: https://code.launchpad.net/~pelpsi/launchpad/+git/launchpad/+merge/461458 -- Your team Launchpad code

Re: [Launchpad-reviewers] [Merge] ~ines-almeida/launchpad:fetch-service-option-db-update into launchpad:db-devel

2024-02-27 Thread Simone Pelosi
Review: Approve -- https://code.launchpad.net/~ines-almeida/launchpad/+git/launchpad/+merge/461264 Your team Launchpad code reviewers is requested to review the proposed merge of ~ines-almeida/launchpad:fetch-service-option-db-update into launchpad:db-devel.

[Launchpad-reviewers] [Merge] ~pelpsi/launchpad-buildd:qastaging-documentation-improvement into launchpad-buildd:master

2024-02-22 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/launchpad-buildd:qastaging-documentation-improvement into launchpad-buildd:master. Commit message: Improve documentation for qastaging deployment Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https

Re: [Launchpad-reviewers] [Merge] ~ines-almeida/launchpad:frontpage-revamp-change-layout into ~ines-almeida/launchpad:frontpage-revamp-remove-top-project

2024-02-21 Thread Simone Pelosi
It looks good! Could you also update copyright string? (from 2004-2023 to 2004-2024) -- https://code.launchpad.net/~ines-almeida/launchpad/+git/launchpad/+merge/460819 Your team Launchpad code reviewers is requested to review the proposed merge of

[Launchpad-reviewers] [Merge] ~pelpsi/launchpad-buildd:release-236 into launchpad-buildd:master

2024-02-16 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/launchpad-buildd:release-236 into launchpad-buildd:master. Commit message: Release version 236 Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~pelpsi/launchpad-buildd/+git

[Launchpad-reviewers] [Merge] ~pelpsi/launchpad:copy-archive-publisher-missing-umask into launchpad:master

2024-02-14 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/launchpad:copy-archive-publisher-missing-umask into launchpad:master. Commit message: Add umask 022 before publish-ftpmaster.py call umask 022 is required to fix the following error: `Queue item ignored: Bad umask; expected 022, got 002` Support

Re: [Launchpad-reviewers] [Merge] ~pelpsi/launchpad-buildd:snap-components-support into launchpad-buildd:master

2024-02-01 Thread Simone Pelosi
Thank you for you review! Sure, I was not so clear. Test here is testing a build with a component and checks if the component is added correctly to the waiting files. I came up with that solution when Dimitri (xnox) asked why the `.comp` file generated by this build

[Launchpad-reviewers] [Merge] ~pelpsi/launchpad-buildd:snap-components-support into launchpad-buildd:master

2024-02-01 Thread Simone Pelosi
The proposal to merge ~pelpsi/launchpad-buildd:snap-components-support into launchpad-buildd:master has been updated. Commit message changed to: Added support for snap components `.comp` files must be added to file cache. Snap components and `.comp` file type:

[Launchpad-reviewers] [Merge] ~pelpsi/launchpad-buildd:snap-components-support into launchpad-buildd:master

2024-02-01 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/launchpad-buildd:snap-components-support into launchpad-buildd:master. Commit message: Added support for snap components `.comp` files must be added to file cache. Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more

Re: [Launchpad-reviewers] [Merge] ~ines-almeida/launchpad:increase-unittest-fetch-timeout into launchpad:master

2024-01-18 Thread Simone Pelosi
Is this change related to flaky tests ? -- https://code.launchpad.net/~ines-almeida/launchpad/+git/launchpad/+merge/458930 Your team Launchpad code reviewers is requested to review the proposed merge of ~ines-almeida/launchpad:increase-unittest-fetch-timeout into launchpad:master.

Re: [Launchpad-reviewers] [Merge] ~ines-almeida/launchpad:social-accounts-edit-view into launchpad:master

2024-01-12 Thread Simone Pelosi
Diff comments: > diff --git a/lib/lp/registry/interfaces/socialaccount.py > b/lib/lp/registry/interfaces/socialaccount.py > index 7e910cc..e8c219e 100644 > --- a/lib/lp/registry/interfaces/socialaccount.py > +++ b/lib/lp/registry/interfaces/socialaccount.py > @@ -40,6 +40,7 @@ class

Re: [Launchpad-reviewers] [Merge] ~ines-almeida/launchpad:social-accounts-ui-display-accounts into launchpad:master

2024-01-11 Thread Simone Pelosi
Diff comments: > diff --git a/lib/lp/app/browser/tales.py b/lib/lp/app/browser/tales.py > index eb5cad2..862c0bb 100644 > --- a/lib/lp/app/browser/tales.py > +++ b/lib/lp/app/browser/tales.py > @@ -3049,3 +3050,27 @@ class IRCNicknameFormatterAPI(ObjectFormatterAPI): >

[Launchpad-reviewers] [Merge] ~pelpsi/launchpad:process-death-row-lockfile-in-use-exclude-hours into launchpad:master

2023-12-15 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/launchpad:process-death-row-lockfile-in-use-exclude-hours into launchpad:master. Commit message: Lockfile in use by process-death-row-py `--all-derived` We are calling `process-death-row.py --all-derived` every hour and it shares the lockfile

[Launchpad-reviewers] [Merge] ~pelpsi/launchpad:process-death-row-lockfile-in-use into launchpad:master

2023-12-15 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/launchpad:process-death-row-lockfile-in-use into launchpad:master. Commit message: Lockfile in use by process-death-row-py `--all-derived` We are calling `process-death-row.py --all-derived` every hour and it shares the lockfile with `process-death

Re: [Launchpad-reviewers] [Merge] ~pelpsi/launchpad:social-account-interface-and-implementation into launchpad:master

2023-12-14 Thread Simone Pelosi
Diff comments: > diff --git a/lib/lp/registry/interfaces/socialaccount.py > b/lib/lp/registry/interfaces/socialaccount.py > new file mode 100644 > index 000..73b4c5b > --- /dev/null > +++ b/lib/lp/registry/interfaces/socialaccount.py > @@ -0,0 +1,90 @@ > +# Copyright 2023 Canonical Ltd.

[Launchpad-reviewers] [Merge] ~pelpsi/launchpad:social-account-interface-and-implementation into launchpad:master

2023-12-14 Thread Simone Pelosi
The proposal to merge ~pelpsi/launchpad:social-account-interface-and-implementation into launchpad:master has been updated. Commit message changed to: SocialAccount interface and implementation SocialAccount interface to reflect DB table SocialAccount: each row of this new table is storing

[Launchpad-reviewers] [Merge] ~pelpsi/launchpad:social-account-interface-and-implementation into launchpad:master

2023-12-14 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/launchpad:social-account-interface-and-implementation into launchpad:master. Commit message: SocialAccount interface and implementation SocialAccount interface to reflect DB table SocialAccount: each row of this new table is storing SocialAccount

[Launchpad-reviewers] [Merge] ~pelpsi/launchpad:copy-distroseries-translations-fix into launchpad:master

2023-10-30 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/launchpad:copy-distroseries-translations-fix into launchpad:master. Commit message: Addded translations_distroseries_copy role to launchpad-scripts charm This role is required to run copy-distroseries-translations.py script during the translations

Re: [Launchpad-reviewers] [Merge] ~pelpsi/launchpad:ftpmaster-publisher-configuration into launchpad:master

2023-10-17 Thread Simone Pelosi
Diff comments: > diff --git a/charm/launchpad-ftpmaster-publisher/config.yaml > b/charm/launchpad-ftpmaster-publisher/config.yaml > index d871574..b33716b 100644 > --- a/charm/launchpad-ftpmaster-publisher/config.yaml > +++ b/charm/launchpad-ftpmaster-publisher/config.yaml > @@ -7,6 +7,18 @@

[Launchpad-reviewers] [Merge] ~pelpsi/launchpad:ftpmaster-publisher-configuration into launchpad:master

2023-10-17 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/launchpad:ftpmaster-publisher-configuration into launchpad:master. Commit message: Added rsync configuration to ftpmaster publisher According to the legacy deployment of the publisher we added a configuration file to configure correctly rsync

[Launchpad-reviewers] [Merge] ~pelpsi/launchpad:ftpmaster-publisher-403-error into launchpad:master

2023-10-17 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/launchpad:ftpmaster-publisher-403-error into launchpad:master. Commit message: Fixed wrong archive dir Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~pelpsi/launchpad/+git

[Launchpad-reviewers] [Merge] ~pelpsi/txpkgupload:build-dropin-cache-make-compile into txpkgupload:master

2023-09-05 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/txpkgupload:build-dropin-cache-make-compile into txpkgupload:master. Commit message: Added plugincache.py file to build dropin.cache Make file will call `TWISTD_BUILD_CACHE` once the `plugincache.py` file is compiled as console_script by setup

[Launchpad-reviewers] [Merge] ~pelpsi/launchpad:typeerror-unmarshall-non-string-objects into launchpad:master

2023-08-31 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/launchpad:typeerror-unmarshall-non-string-objects into launchpad:master. Commit message: Unmarshall calls `obfuscated_structure` instead of `obfuscated_email` Calling `obfuscated_structure` gives more input control avoiding TypeError exception

[Launchpad-reviewers] [Merge] ~pelpsi/launchpad:ftpmaster-bug-fixing into launchpad:master

2023-08-11 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/launchpad:ftpmaster-bug-fixing into launchpad:master. Commit message: Created required folder srv/launchpad/ubuntu-queue/{incoming,accepted,rejected,failed} folders created in order to fix a `Permission Denied` error in the ftpmaster uploader

[Launchpad-reviewers] [Merge] ~pelpsi/launchpad:team-subscription-bug into launchpad:master

2023-08-08 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/launchpad:team-subscription-bug into launchpad:master. Commit message: Flushing db before txn.commit() and txn.abort() Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~pelpsi

[Launchpad-reviewers] [Merge] ~pelpsi/launchpad:merge-proposal-url-fix into launchpad:master

2023-08-07 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/launchpad:merge-proposal-url-fix into launchpad:master. Commit message: mp.address replaced with canonical_url(mp, rootsite="code") Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.lau

[Launchpad-reviewers] [Merge] ~pelpsi/launchpad:differentiate-git-push-message-if-mp-exists into launchpad:master

2023-08-07 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/launchpad:differentiate-git-push-message-if-mp-exists into launchpad:master. Commit message: Differentiate git push message if the MP exists Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https

[Launchpad-reviewers] [Merge] ~pelpsi/turnip:charm-build-fix into turnip:master

2023-08-03 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/turnip:charm-build-fix into turnip:master. Commit message: Fixed revision numbers Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~pelpsi/turnip/+git/turnip/+merge/448405 -- Your

[Launchpad-reviewers] [Merge] ~pelpsi/launchpad:cannot-turn-lp-subteam-to-private into launchpad:master

2023-08-03 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/launchpad:cannot-turn-lp-subteam-to-private into launchpad:master. Commit message: Added a status check if src_tab=="teammembership" teammembership should be considered only if has a status different from DEACTIV> LP: #2029487 Requ

Re: [Launchpad-reviewers] [Merge] ~pelpsi/turnip:turnip-charms-upgrade-to-focal into turnip:master

2023-07-26 Thread Simone Pelosi
Blocked by : https://code.launchpad.net/~pelpsi/ols-charm-deps/+git/wheels/+merge/447788 Once the above is merged, charm-wheels must be updated accordingly. -- https://code.launchpad.net/~pelpsi/turnip/+git/turnip/+merge/447756 Your team Launchpad code reviewers is requested to review the

[Launchpad-reviewers] [Merge] ~pelpsi/turnip:turnip-charms-upgrade-to-focal into turnip:master

2023-07-26 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/turnip:turnip-charms-upgrade-to-focal into turnip:master. Commit message: Upgraded charms to focal Updated layers to the latest commits Updated charmcraft.yaml and metadata.yaml Requested reviews: Launchpad code reviewers (launchpad-reviewers

[Launchpad-reviewers] [Merge] ~pelpsi/turnip/+git/dependencies:turnip-upgrade-to-focal into ~canonical-launchpad-branches/turnip/+git/dependencies:master

2023-07-26 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/turnip/+git/dependencies:turnip-upgrade-to-focal into ~canonical-launchpad-branches/turnip/+git/dependencies:master. Commit message: Updated wheels dependencies for focal Added dependencies required by layer-base Requested reviews: Launchpad code

[Launchpad-reviewers] [Merge] ~pelpsi/turnip:turnip-payload-upgrade-to-focal into turnip:master

2023-07-24 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/turnip:turnip-payload-upgrade-to-focal into turnip:master. Commit message: VM upgraded from bionic to focal Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~pelpsi/turnip/+git

[Launchpad-reviewers] [Merge] ~pelpsi/lpci:lpci-0.2.2 into lpci:main

2023-07-14 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/lpci:lpci-0.2.2 into lpci:main. Commit message: New release: lpci 0.2.2 Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~pelpsi/lpci/+git/lpcraft/+merge/446858 -- Your team

[Launchpad-reviewers] [Merge] ~pelpsi/launchpad:remove-f-string into launchpad:master

2023-07-13 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/launchpad:remove-f-string into launchpad:master. Commit message: Removed f-string Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~pelpsi/launchpad/+git/launchpad/+merge/446773

[Launchpad-reviewers] [Merge] ~pelpsi/launchpad:ftpmaster-charm into launchpad:master

2023-07-10 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/launchpad:ftpmaster-charm into launchpad:master. Commit message: FTPMaster charms Ftpmaster publisher and uploader. Ftpmaster publisher publishes packages to the ubuntu archives, running scripts contained in the ubuntu-archive-publishing repository

[Launchpad-reviewers] [Merge] ~pelpsi/txpkgupload:txpkgupload-charm into txpkgupload:master

2023-07-05 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/txpkgupload:txpkgupload-charm into txpkgupload:master. Commit message: Txpkgupload charm created Listens to FTP and SFTP requests, and processes uploads files into a temporary directory This is a subordinate charm, so it will need a master

[Launchpad-reviewers] [Merge] ~pelpsi/launchpad:send-bug-notifications-opsees-list-index-out-of-range into launchpad:master

2023-06-21 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/launchpad:send-bug-notifications-opsees-list-index-out-of-range into launchpad:master. Commit message: Fixed list index out of range filters_by_person[x] set was replaced every iteration. Now it's updated using the "update" se

[Launchpad-reviewers] [Merge] ~pelpsi/launchpad-layers:launchpad-publisher-parts into launchpad-layers:main

2023-06-14 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/launchpad-layers:launchpad-publisher-parts into launchpad-layers:main. Commit message: Added launchpad-publisher-parts layer Added a new layer that will be used by the publisher charm to call run-parts algorithm on a given repository with a given

Re: [Launchpad-reviewers] [Merge] txpkgupload:update-wheel-command-makefile into txpkgupload:master

2023-06-13 Thread Simone Pelosi
LGTM! -- https://code.launchpad.net/~lazr-developers/txpkgupload/+git/txpkgupload/+merge/444615 Your team Launchpad code reviewers is requested to review the proposed merge of txpkgupload:update-wheel-command-makefile into txpkgupload:master. ___

[Launchpad-reviewers] [Merge] ~pelpsi/launchpad:improve-logging-for-the-account-close-script into launchpad:master

2023-05-16 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/launchpad:improve-logging-for-the-account-close-script into launchpad:master. Commit message: Added a log that nofifies when the account is closed The new log notifies when the account is closed before committing the transaction. Requested

[Launchpad-reviewers] [Merge] ~pelpsi/launchpad:muted-subscription-bug into launchpad:master

2023-05-15 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/launchpad:muted-subscription-bug into launchpad:master. Commit message: Added new logic to filter BugNotificationRecipient filters_by_person (dictionary) is the new data structure introduced: key is the person_id and the value is a set of tuple

[Launchpad-reviewers] [Merge] ~pelpsi/lpci:conda-build-outside-env into lpci:main

2023-05-08 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/lpci:conda-build-outside-env into lpci:main. Commit message: Fixed conda-build plugin lpci conda build plugin should install and run conda-build outside of a conda environment LP: #1978717 Requested reviews: Launchpad code reviewers

[Launchpad-reviewers] [Merge] ~pelpsi/lpci:add-dev0-suffix-to-docs into lpci:main

2023-04-21 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/lpci:add-dev0-suffix-to-docs into lpci:main. Commit message: Added "dev0" suffix to docs Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~pelpsi/lpci/+git/lpcraft/+me

[Launchpad-reviewers] [Merge] ~pelpsi/lpci:release-0.1.1 into lpci:main

2023-04-21 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/lpci:release-0.1.1 into lpci:main. Commit message: Release 0.1.1 Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~pelpsi/lpci/+git/lpcraft/+merge/441655 -- Your team Launchpad code

[Launchpad-reviewers] [Merge] ~pelpsi/lpci:jobs-cannot-run-as-root into lpci:main

2023-04-20 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/lpci:jobs-cannot-run-as-root into lpci:main. Commit message: Add a root flag New root flag to choose whether to run commands as root or as default user (_lpci). Lpci runs jobs as root inside the container. However, there are some reasonable jobs

[Launchpad-reviewers] [Merge] ~pelpsi/lpci:policy-rc-preventing-services-from-running into lpci:main

2023-04-19 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/lpci:policy-rc-preventing-services-from-running into lpci:main. Commit message: Removed policy-rc.d The presence of the following file is preventing services from running in CI. LP: #1995954 Requested reviews: Launchpad code reviewers

[Launchpad-reviewers] [Merge] ~pelpsi/lpci:launch-debug-shell-on-exception into lpci:main

2023-04-17 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/lpci:launch-debug-shell-on-exception into lpci:main. Commit message: Added new debug shell Launch debug shell on exception Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net

[Launchpad-reviewers] [Merge] ~pelpsi/lpci:debug-shell-on-exception into lpci:main

2023-04-14 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/lpci:debug-shell-on-exception into lpci:main. Commit message: Added new debug shell Shell into the environment if the run fails. Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net

[Launchpad-reviewers] [Merge] ~pelpsi/lp-signing/+git/dependencies:gunicorn-upgrade-HTTP-request-smuggling-vulnerability into ~launchpad/lp-signing/+git/dependencies:master

2023-04-12 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/lp-signing/+git/dependencies:gunicorn-upgrade-HTTP-request-smuggling-vulnerability into ~launchpad/lp-signing/+git/dependencies:master. Commit message: Added talisker dependencies Added talisker dependencies to fix build issue. Requested reviews

[Launchpad-reviewers] [Merge] ~pelpsi/launchpad:remove-old-URL-from-documentation into launchpad:master

2023-04-11 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/launchpad:remove-old-URL-from-documentation into launchpad:master. Commit message: Removed outdated URL from documentation Removed outdated URL from documentation no longer working. Requested reviews: Launchpad code reviewers (launchpad

[Launchpad-reviewers] [Merge] ~pelpsi/launchpad:duplicate_ci_jobs into launchpad:master

2023-04-06 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/launchpad:duplicate_ci_jobs into launchpad:master. Commit message: Stages now depend on series Stages now is a dictionary where each key corresponds to the series and the value is the old stages array. Requested reviews: Launchpad code reviewers

[Launchpad-reviewers] [Merge] ~pelpsi/lpcraft:release-0.0.52 into lpcraft:main

2023-04-06 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/lpcraft:release-0.0.52 into lpcraft:main. Commit message: New lpcraft release 0.0.52 Fix regression from adding support to snap keys passed as strings. For these keys confinement classic must be True by default to ensure backward compatibility

[Launchpad-reviewers] [Merge] ~pelpsi/lpcraft:backward-compatibility into lpcraft:main

2023-04-06 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/lpcraft:backward-compatibility into lpcraft:main. Commit message: Forced classic to True if snaps are configured as string If snaps are configured as string the classic confinment is forced to improve backward compatibility Requested reviews

[Launchpad-reviewers] [Merge] ~pelpsi/lp-signing/+git/dependencies:gunicorn-upgrade-HTTP-request-smuggling-vulnerability into ~launchpad/lp-signing/+git/dependencies:master

2023-04-05 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/lp-signing/+git/dependencies:gunicorn-upgrade-HTTP-request-smuggling-vulnerability into ~launchpad/lp-signing/+git/dependencies:master. Commit message: Upgraded talisker to maximize compatibility with gunicorn A penetration test found that our

[Launchpad-reviewers] [Merge] ~pelpsi/lpcraft:release-0.0.51 into lpcraft:main

2023-04-05 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/lpcraft:release-0.0.51 into lpcraft:main. Commit message: New lpcraft release 0.0.51 Add support for snap's channel and confinement level. Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https

[Launchpad-reviewers] [Merge] ~pelpsi/rutabaga:update-rutabaga-readme into rutabaga:master

2023-04-04 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/rutabaga:update-rutabaga-readme into rutabaga:master. Commit message: Updated rutabaga README Updated rutabaga README to be in line with Makefile Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https

[Launchpad-reviewers] [Merge] ~pelpsi/turnip:gunicorn-upgrade-HTTP-request-smuggling-vulnerability into turnip:master

2023-04-04 Thread Simone Pelosi
The proposal to merge ~pelpsi/turnip:gunicorn-upgrade-HTTP-request-smuggling-vulnerability into turnip:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~pelpsi/turnip/+git/turnip/+merge/440169 -- Your team Launchpad code reviewers

[Launchpad-reviewers] [Merge] ~pelpsi/turnip:gunicorn-upgrade-HTTP-request-smuggling-vulnerability into turnip:master

2023-04-04 Thread Simone Pelosi
The proposal to merge ~pelpsi/turnip:gunicorn-upgrade-HTTP-request-smuggling-vulnerability into turnip:master has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~pelpsi/turnip/+git/turnip/+merge/440169 -- Your team Launchpad code reviewers

[Launchpad-reviewers] [Merge] ~pelpsi/turnip:gunicorn-upgrade-HTTP-request-smuggling-vulnerability into turnip:master

2023-04-04 Thread Simone Pelosi
The proposal to merge ~pelpsi/turnip:gunicorn-upgrade-HTTP-request-smuggling-vulnerability into turnip:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~pelpsi/turnip/+git/turnip/+merge/440169 -- Your team Launchpad code reviewers

[Launchpad-reviewers] [Merge] ~pelpsi/lpcraft:snaps-key-improved-to-specify-channel-and-classic-parameters into lpcraft:main

2023-03-31 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/lpcraft:snaps-key-improved-to-specify-channel-and-classic-parameters into lpcraft:main. Commit message: Added support for channel and classic parameters Snap keys now support channel and classic parameters. Snap key new syntax :: LP: #1995101

[Launchpad-reviewers] [Merge] ~pelpsi/turnip:gunicorn-upgrade-HTTP-request-smuggling-vulnerability into turnip:master

2023-03-31 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/turnip:gunicorn-upgrade-HTTP-request-smuggling-vulnerability into turnip:master. Commit message: Upgraded gunicorn to fix HTTP request smuggling vulnerability A penetration test found that our gunicorn version is vulnerable, version 20.1.0 should

[Launchpad-reviewers] [Merge] ~pelpsi/rutabaga/+git/dependencies:gunicorn-upgrade-HTTP-request-smuggling-vulnerability into ~canonical-launchpad-branches/rutabaga/+git/dependencies:master

2023-03-31 Thread Simone Pelosi
Simone Pelosi has proposed merging ~pelpsi/rutabaga/+git/dependencies:gunicorn-upgrade-HTTP-request-smuggling-vulnerability into ~canonical-launchpad-branches/rutabaga/+git/dependencies:master. Commit message: Upgraded gunicorn to fix HTTP request smuggling vulnerability A penetration test

  1   2   >