Re: [Launchpad-reviewers] [Merge] ~lool/git-build-recipe:fetch-pristine-tar-tags into git-build-recipe:master

I opened an alternative merge request [1] that is the same as this one except: - Tags are put in refs/tags//* instead of refs/remotes//* (to avoid potential name collisions). - I added some comments explaining why fetching is done the way it is. - I added tests. [1]

Re: [Launchpad-reviewers] [Merge] ~lool/git-build-recipe:fetch-pristine-tar-tags into git-build-recipe:master

To avoid conflicts between tags and branches, I recommend putting tags inside refs/tags/{remote}/* like this: diff --git a/gitbuildrecipe/recipe.py b/gitbuildrecipe/recipe.py index f932ca7..3b51d98 100644 --- a/gitbuildrecipe/recipe.py +++ b/gitbuildrecipe/recipe.py @@ -339,11 +339,10 @@ def

Re: [Launchpad-reviewers] [Merge] ~lool/git-build-recipe:fetch-pristine-tar-tags into git-build-recipe:master

LGTM, +1 Tested on my local machine, the tags needed by pristine-tar are fetched correctly -- https://code.launchpad.net/~lool/git-build-recipe/+git/git-build-recipe/+merge/443942 Your team Launchpad code reviewers is requested to review the proposed merge of

[Launchpad-reviewers] [Merge] ~lool/git-build-recipe:fetch-pristine-tar-tags into git-build-recipe:master

Loïc Minier has proposed merging ~lool/git-build-recipe:fetch-pristine-tar-tags into git-build-recipe:master. Commit message: https://code.launchpad.net/~lool/+recipe/linux-nvidia-tegra-sidecar-daily is failing with: fatal: ambiguous argument '60ab15c3d7a8c92ccfe8fa7f1d650f3f292141a0^{tree}':