[Launchpad-reviewers] [Merge] ~pelpsi/launchpad:add-fetch-service-certificate-to-secrets into launchpad:master

Simone Pelosi has proposed merging ~pelpsi/launchpad:add-fetch-service-certificate-to-secrets into launchpad:master. Commit message: Add fetch_service_mitm_certificate to secrets Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see:

Re: [Launchpad-reviewers] [Merge] ~tchavadar/launchpad-buildd:use-ubuntu-images-deb into launchpad-buildd:master

Yep just rebased, it was weird maybe from the fork I dont know but it should be ok now On 23-04-2024 16:53, Hector CAO wrote: > The unmerged commits list seems strange, perhaps is it work to rebase > properly >

Re: [Launchpad-reviewers] [Merge] ~tchavadar/launchpad-buildd:use-ubuntu-images-deb into launchpad-buildd:master

The unmerged commits list seems strange, perhaps is it work to rebase properly on https://code.launchpad.net/~launchpad/launchpad-buildd/+git/launchpad-buildd/+ref/master ? -- https://code.launchpad.net/~tchavadar/launchpad-buildd/+git/launchpad-buildd/+merge/464761 Your team Launchpad code

[Launchpad-reviewers] [Merge] ~pelpsi/launchpad-mojo-specs/+git/private:fetch-service-charmhub-configuration into ~launchpad/launchpad-mojo-specs/+git/private:master

The proposal to merge ~pelpsi/launchpad-mojo-specs/+git/private:fetch-service-charmhub-configuration into ~launchpad/launchpad-mojo-specs/+git/private:master has been updated. Status: Approved => Merged For more details, see:

[Launchpad-reviewers] [Merge] ~pelpsi/launchpad-mojo-specs/+git/private:fetch-service-charmhub-configuration into ~launchpad/launchpad-mojo-specs/+git/private:master

The proposal to merge ~pelpsi/launchpad-mojo-specs/+git/private:fetch-service-charmhub-configuration into ~launchpad/launchpad-mojo-specs/+git/private:master has been updated. Status: Needs review => Approved For more details, see:

[Launchpad-reviewers] [Merge] ~pelpsi/launchpad-mojo-specs/+git/private:fetch-service-charmhub-configuration into ~launchpad/launchpad-mojo-specs/+git/private:master

The proposal to merge ~pelpsi/launchpad-mojo-specs/+git/private:fetch-service-charmhub-configuration into ~launchpad/launchpad-mojo-specs/+git/private:master has been updated. Commit message changed to: lp-fetch-service: Deploy fetch-service charm from Charmhub For more details, see:

[Launchpad-reviewers] [Merge] ~ines-almeida/launchpad:fetch-service-update-build-metadata-url into launchpad:master

Ines Almeida has proposed merging ~ines-almeida/launchpad:fetch-service-update-build-metadata-url into launchpad:master. Commit message: Add DB load bulk load for `build_metadata_url` attributes when getting multiple builds This reduces the number of DB queries made in the case for where

[Launchpad-reviewers] [Merge] ~pelpsi/launchpad:unembargo-buildinfo-file into launchpad:master

Simone Pelosi has proposed merging ~pelpsi/launchpad:unembargo-buildinfo-file into launchpad:master. Commit message: Unembargo build info Added buildinfo to unembargoed files. LP: #2052796 Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: Bug #2052796 in

Re: [Launchpad-reviewers] [Merge] ~pelpsi/launchpad-mojo-specs/+git/private:fetch-service-charmhub-configuration into ~launchpad/launchpad-mojo-specs/+git/private:master

Review: Approve Looks good! Can you update the commit message to start with the model in question? I.e. ``` lp-fetch-service: Deploy fetch-service charm from Charmhub ``` Diff comments: > diff --git a/lp-fetch-service/bundle.yaml b/lp-fetch-service/bundle.yaml > index 8bd8dd3..67472ee 100644

[Launchpad-reviewers] [Merge] ~pelpsi/launchpad-mojo-specs/+git/private:fetch-service-charmhub-configuration into ~launchpad/launchpad-mojo-specs/+git/private:master

Simone Pelosi has proposed merging ~pelpsi/launchpad-mojo-specs/+git/private:fetch-service-charmhub-configuration into ~launchpad/launchpad-mojo-specs/+git/private:master. Commit message: Get fetch-service from Charmhub Requested reviews: Canonical Launchpad Engineering (launchpad) For more