Re: [Launchpad-reviewers] [Merge] ~lool/git-build-recipe:fallback-on-pristine-tar-checkout-failures into git-build-recipe:master

2023-06-01 Thread Hector CAO
Review: Needs Information great work, some questions Diff comments: > diff --git a/gitbuildrecipe/deb_util.py b/gitbuildrecipe/deb_util.py > index d0a..4724de6 100644 > --- a/gitbuildrecipe/deb_util.py > +++ b/gitbuildrecipe/deb_util.py > @@ -68,11 +69,20 @@ def

Re: [Launchpad-reviewers] [Merge] ~lool/git-build-recipe:fetch-pristine-tar-tags into git-build-recipe:master

2023-06-01 Thread Hector CAO
LGTM, +1 Tested on my local machine, the tags needed by pristine-tar are fetched correctly -- https://code.launchpad.net/~lool/git-build-recipe/+git/git-build-recipe/+merge/443942 Your team Launchpad code reviewers is requested to review the proposed merge of

Re: [Launchpad-reviewers] [Merge] ~tchavadar/launchpad-buildd:use-ubuntu-images-deb into launchpad-buildd:master

2024-04-23 Thread Hector CAO
The unmerged commits list seems strange, perhaps is it work to rebase properly on https://code.launchpad.net/~launchpad/launchpad-buildd/+git/launchpad-buildd/+ref/master ? -- https://code.launchpad.net/~tchavadar/launchpad-buildd/+git/launchpad-buildd/+merge/464761 Your team Launchpad code