Re: [Libosinfo] [libosinfo PATCH] osinfo-detect: Improve --help wording

2019-04-15 Thread Cole Robinson
On 4/15/19 4:09 AM, Fabiano Fidêncio wrote: > The "URL type" text leads to the misunderstanding that `osinfo-detect` > only works for URLs and not for local medias as well. > > Let's change the wording in order to make it clearer. > > https://gitlab.com/libosinfo/libosinfo/issues/26 > >

Re: [Libosinfo] [osinfo-db-tools PATCH] spec: Require gvfs

2019-04-15 Thread Cole Robinson
On 4/15/19 9:47 AM, Fabiano Fidêncio wrote: > GVFS is required as g_file_new_from_path() and g_file_new_from_uri() > rely on GVFS. > > Signed-off-by: Fabiano Fidêncio > --- > osinfo-db-tools.spec.in | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/osinfo-db-tools.spec.in

Re: [Libosinfo] [libosinfo PATCH] spec: Require GVFS

2019-04-15 Thread Cole Robinson
On 4/15/19 9:47 AM, Fabiano Fidêncio wrote: > GVFS is required as g_file_new_from_path() and g_file_new_from_uri() > rely on GVFS. > > Signed-off-by: Fabiano Fidêncio > --- > libosinfo.spec.in | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libosinfo.spec.in b/libosinfo.spec.in >

[Libosinfo] [libosinfo PATCH] spec: Require GVFS

2019-04-15 Thread Fabiano Fidêncio
GVFS is required as g_file_new_from_path() and g_file_new_from_uri() rely on GVFS. Signed-off-by: Fabiano Fidêncio --- libosinfo.spec.in | 1 + 1 file changed, 1 insertion(+) diff --git a/libosinfo.spec.in b/libosinfo.spec.in index 79b58dd..8118755 100644 --- a/libosinfo.spec.in +++

[Libosinfo] [osinfo-db-tools PATCH] spec: Require gvfs

2019-04-15 Thread Fabiano Fidêncio
GVFS is required as g_file_new_from_path() and g_file_new_from_uri() rely on GVFS. Signed-off-by: Fabiano Fidêncio --- osinfo-db-tools.spec.in | 1 + 1 file changed, 1 insertion(+) diff --git a/osinfo-db-tools.spec.in b/osinfo-db-tools.spec.in index f0a5fcc..8593188 100644 ---

Re: [Libosinfo] [osinfo-db PATCH] centos: Fix typo in the installation-url template

2019-04-15 Thread Christophe Fergeau
Acked-by: Christophe Fergeau On Mon, Apr 15, 2019 at 12:56:49PM +0200, Fabiano Fidêncio wrote: > The typo was introduced as part of b6f5ea9e6da. > > Signed-off-by: Fabiano Fidêncio > --- > data/install-script/centos.org/centos-kickstart-desktop.xml.in | 2 +- >

[Libosinfo] [osinfo-db PATCH] centos: Fix typo in the installation-url template

2019-04-15 Thread Fabiano Fidêncio
The typo was introduced as part of b6f5ea9e6da. Signed-off-by: Fabiano Fidêncio --- data/install-script/centos.org/centos-kickstart-desktop.xml.in | 2 +- data/install-script/centos.org/centos-kickstart-jeos.xml.in| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

[Libosinfo] [osinfo-db PATCH 1/1] Fix out-of-tree build

2019-04-15 Thread Fabiano Fidêncio
Let's set an ABS_TOPDIR and use it to run our tests, fixing then the out-of-tree build. https://gitlab.com/libosinfo/osinfo-db/issues/25 --- Makefile | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 4f6f8d4..a1bdcfe 100644 --- a/Makefile +++

Re: [Libosinfo] [libosinfo PATCH 0/3] Make osinfo-query aware of Os Variants

2019-04-15 Thread Michal Privoznik
On 4/15/19 9:58 AM, Fabiano Fidêncio wrote: Let's make osinfo-query able to also display the os variants of a specific os by passing "-f variants". By doing this we can have the os variants displayed as: fidencio@laerte ~/src/upstream/libosinfo $ ./tools/osinfo-query os -f

Re: [Libosinfo] [libosinfo PATCH 1/3] osinfo-query: Add osinfo_os_list_func to OsinfoLabel

2019-04-15 Thread Michal Privoznik
On 4/15/19 9:58 AM, Fabiano Fidêncio wrote: Let's add a new osinfo_os_list_func to OsinfoLabel. This function represents any osinfo_os_get.*_list() and can be used to get Os specific attributes list. One example of usage for this is osinfo_os_get_variant_list() and then be able to also display

[Libosinfo] [libosinfo PATCH] osinfo-detect: Improve --help wording

2019-04-15 Thread Fabiano Fidêncio
The "URL type" text leads to the misunderstanding that `osinfo-detect` only works for URLs and not for local medias as well. Let's change the wording in order to make it clearer. https://gitlab.com/libosinfo/libosinfo/issues/26 Signed-off-by: Fabiano Fidêncio --- tools/osinfo-detect.c | 2 +-

[Libosinfo] [libosinfo PATCH 3/3] osinfo-query: Print os variants information

2019-04-15 Thread Fabiano Fidêncio
Os variants information has never been added to osinfo-query and it may be useful for some apps to match the output of osinfo-query with osinfo-detect (that's what Cockpit has been doing). In order to do so, we have to: - Add a new "variants" entry to be displayed and this new entry is not

[Libosinfo] [libosinfo PATCH 2/3] osinfo-query: Add real_prop to OsinfoLabel

2019-04-15 Thread Fabiano Fidêncio
real_prop is going to be used to map a command-line option to a real option whenever we're dealing with sub-properties that happen to have the very same name as a property that's already taken into consideration. One example of this is when getting os variants. For this we'd need to get

[Libosinfo] [libosinfo PATCH 0/3] Make osinfo-query aware of Os Variants

2019-04-15 Thread Fabiano Fidêncio
Let's make osinfo-query able to also display the os variants of a specific os by passing "-f variants". By doing this we can have the os variants displayed as: fidencio@laerte ~/src/upstream/libosinfo $ ./tools/osinfo-query os -f short-id,name,vendor,id,variants name="Fedora 29" Short ID

[Libosinfo] [libosinfo PATCH 1/3] osinfo-query: Add osinfo_os_list_func to OsinfoLabel

2019-04-15 Thread Fabiano Fidêncio
Let's add a new osinfo_os_list_func to OsinfoLabel. This function represents any osinfo_os_get.*_list() and can be used to get Os specific attributes list. One example of usage for this is osinfo_os_get_variant_list() and then be able to also display the os variants when querying for an Os.