On Mon, Nov 08, 2010 at 08:10:51PM -0600, Jordan Ayers wrote:
Miscellaneous cleanup to build.pl. Mostly removal of dead code, with
a few spelling / German-English fixes.
LGPLv3+/MPL
Pushed, thanks!
D.
___
LibreOffice mailing list
On Mon, 08 Nov 2010 12:42:24 -0500, Kevin Hunter wrote:
Here's another set of patches. Caolán, I think I've done a little
better on the comments this time, but probably not yet perfect.
accessibility/
Thanks, I am taking this one. Will review then push as
appropriate. Looking good so far.
Pushed all patches but #4 which does nothing but removing
#--- lines between functions,
which *I personally* don't consider buggy.
Otherwise mostly good. Please make sure to not remove the newlines after
the last vi modeline. There were a few of that that I
On Mon, 08 Nov 2010 12:43:45 -0500, Kevin Hunter hunt...@gmail.com wrote:
Hullo List,
Another RTL_CONST patch, also against accessibility/ .
Pushed, thanks
Sebastian
pgp3oHLdWa5bJ.pgp
Description: PGP signature
___
LibreOffice mailing list
On Tue, 2010-11-09 at 02:19 +0100, Jan Holesovsky wrote:
If it is not desirable, I'll update the hook so that it fixes just the
lines where the committer introduces the trailing whitespace, and won't
touch the rest of the whitespace errors - should I?
Hmm, yeah, I think just stripping the
On Fri, 2010-11-05 at 00:38 -0700, John LeMoyne Castle wrote:
Dang, I was hoping it would stop counting at least some punctuation as a
word.(period). Don't know what to say other than test before and after.
Just some random thought here: would you be able to write some unit
tests for this?
Noel Power wrote:
No, I don't mean setting up an OOO build ;-) but just checking against a
OOO330m13 dev build ( that can downloaded from openoffice.org )
OIC, I was making it too hard - rooted around at OOo and found the debs...
Thanks -- LeMoyne
--
View this message in context:
Hi guys,
I mistakenly pushed Mattias patch this morning... that shouldn't harm,
but I though it would be good for you to know it for later
investigations.
On Sat, 2010-11-06 at 14:14 +1100, Mattias Johnsson wrote:
On 6 November 2010 12:13, John LeMoyne Castle j...@mail2lee.com wrote:
Hi
At 4:03am -0500 Tue, 09 Nov 2010, Sebastian Spaeth wrote:
Please make sure to not remove the newlines after the last vi
modeline. There were a few of that that I had to fix.
Ah, of course. That's my editor doing an automatic job. I'll update
the settings for this project.
Thanks, mate.
Hi,
I have updated the bin/g script so that it is now possible to use it for
cloning the repos. This might be particularly useful when you want to
have your branch in a separate location, but use your main repo as the
reference to save your inet traffic.
Let's say you have your 'master' repo in
On Tue, 2010-11-09 at 04:30 -0800, John LeMoyne Castle wrote:
Noel Power wrote:
I wonder if the recent rebase to OOO330m13 is the culprit, would be
interesting if you could test against the corresponding oracle dev build
Yes, I see that test would be useful.
Not about to setup an
On Mon, 2010-11-08 at 12:50 -0500, Kevin Hunter wrote:
Hi List,
A patch to remove large blocks of already commented code.
Yup, pushed, thanks. Though I dropped the last hunk which for some
reason removes the final newline.
C.
___
LibreOffice
Se non visualizzi correttamente questa email clicca qui
Clicca qui per accedere ai servizi finanziariMutui - Prestiti - Leasing - cambializzati - prestiti aziendali - vitalizi - fidejussioni - assistenza alle aziende in crisi - informazioni commerciali - recupero crediti
Novità!!!
Noel Power wrote:
I wonder if the recent rebase to OOO330m13 is the culprit, would be
interesting if you could test against the corresponding oracle dev build
Yes, I see that test would be useful.
Not about to setup an OOO build, but will consider it if you think that
would be useful
On Tue, 2010-11-09 at 01:48 +0500, Alexander O. Anisimov wrote:
Hi all,
I have done some clean up the code in libs-core: remove bogus
comments, refresh comments containing a reference to the bug tracker,
All good IMO, I like expanding the issue references to the headline of
those, much
On Tue, 2010-11-09 at 04:30 -0800, John LeMoyne Castle wrote:
Noel Power wrote:
I wonder if the recent rebase to OOO330m13 is the culprit, would be
interesting if you could test against the corresponding oracle dev build
Yes, I see that test would be useful.
Not about to setup an
Hi Flo, all,
recent changes to url strings in LibO, for completeness sake - and
no need for any setup here, server-side.
Cheers,
-- Thorsten
From da9762a0da84a061fd2adadfdb51295357d5e270 Mon Sep 17 00:00:00 2001
From: Thorsten Behrens tbehr...@novell.com
Date: Wed, 3 Nov 2010 11:48:47 +0100
On Mon, 2010-11-08 at 16:48 -0500, Kevin Hunter wrote:
Hullo again,
Some more easy hack RTL code.
Looks good, pushed. As an aside the testtools dir is part of the build
and tests the bridges automatically as part of the build. Though only
for your own platform of course.
C.
On Mon, 2010-11-08 at 14:59 +0100, Sebastian Spaeth wrote:
There was #ifdef'd test code depending on WITH_CORE being defined (which
is never set in our build system). It is described as test code that
will core dump for sure. So let's remove this and write proper cppunit
tests instead. All
At 12:44pm -0500 Tue, 09 Nov 2010, Kevin Hunter wrote:
Here are four more patch conversions from createFromAscii to
RTL_CONST... applied against:
basebmp/
binfilter/
bridges/
connectivity/
I apologize, I temporarily forgot about the automatic whitespace
handling and flat committed those
Miklos Vajna wrote:
2) I'm attaching two patches:
a) Avoid the usage of git-branch (usual problem: git-branch is a git
porcelain command so its output may change any time without notice).
b) Don't check if master is checkout out, check if the branch is the
same as the branch of build.git,
Is it correct to have the RTL_CONSTASCII_USTRINGPARAM directly in the *.hxx
file.
If so, why not do that also at other places?
MPL 1.1 / GPLv3+ / LGPLv3+
Joost
diff --git a/svx/source/inc/docrecovery.hxx b/svx/source/inc/docrecovery.hxx
index 4f1f256..c6e4117 100644
---
On Mon, 2010-11-08 at 23:46 +0100, Gert Faller wrote:
Hi,
Following the hints of Michael Meeks in :
'https://bugs.freedesktop.org/show_bug.cgi?id=30944', here a first try in
writer.
It's 'raw code' : just wondering if it satisfies the required functionality.
It looks good to me anyway.
Kevin Hunter wrote:
My last contribution of the day, with two RTL patches for canvas/
and chart2/ .
Seems the basebmp parts were already applied - used the canvas ones.
Many thanks for the cleanup - as per the discussion around trailing
whitespace changes, did not commit those.
Cheers,
--
Selon Caolán McNamara caol...@redhat.com:
It looks good to me anyway. Just need to handle more gracefully hitting
cancel IMO and I reckon we could pretty much stuff it in as is.
C.
Hi,
yes of course, checks must be added, it's just 'raw code'.
Whatever,this function is expected in calc to.
Hi Hanno,
Hanno Meyer-Thurow píše v Ne 07. 11. 2010 v 23:09 +0100:
There is an undefined $setup_vars array used in solenv/bin/ooinstall.
Attached is a patch to use the equvalent values from the global $ENV
array.
I have pushed that to master, and when cherry-picking to
libreoffice-3-3, I
Jan Holesovsky píše v St 10. 11. 2010 v 05:11 +0100:
I have pushed that to master, and when cherry-picking to
...now with the 'pushed' subject line ;-)
Regards,
Kendy
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
On Wed, 10 Nov 2010 05:29:34 +0100, Jan Holesovsky wrote:
1) if the user specifies max-cpus, do we want max-jobs to default to
max-cpus? Because that does make sense afaict.
The buildsystem is a bit strange in this regard ;-) There are 2 levels
of what is done in parallel - one on the
On Tue, Nov 09, 2010 at 03:11:40PM -0500, Kevin Hunter wrote:
At 12:44pm -0500 Tue, 09 Nov 2010, Kevin Hunter wrote:
Here are four more patch conversions from createFromAscii to
RTL_CONST... applied against:
basebmp/
binfilter/
bridges/
connectivity/
I apologize, I temporarily forgot
Lovely :o)
2010-11-10 07:30 keltezéssel, Joseph Powers írta:
Ok, I removed high-contrast support from two base classes: SvImpLBox
SvTreeListBox. And then spent the next two days cleaning up the mess. The
code builds and seems to run fine on my Mac.
Joe P
LGPL 3 if you want.
KAMI
On Tue, Nov 09, 2010 at 09:30:22PM +0100, Joost Eekhoorn wrote:
Is it correct to have the RTL_CONSTASCII_USTRINGPARAM directly in the *.hxx
file.
If so, why not do that also at other places?
MPL 1.1 / GPLv3+ / LGPLv3+
Joost
Pushed, thanks!
D.
On Tue, Nov 09, 2010 at 10:24:20PM +, Wols Lists wrote:
Cheers,
Wol
Looks fine. Pushed.
From cb03ee788ea81661ae83ae611806c6050d16af57 Mon Sep 17 00:00:00 2001
-// use keys and indexes for excat postioning
Would that mean positioning of a dead cat (aka ex-parrot)? :-D
D.
32 matches
Mail list logo
