Re: [Libreoffice] Location of SfxPoolItem.Type() method

2010-11-21 Thread David Tardon
On Sun, Nov 21, 2010 at 12:21:08AM +1100, Mattias Johnsson wrote: Hello all, I've been trying to fix a bug in the search and replace code, and after a bit of hacking have discovered that in findattr.cxx there's a function int CmpAttr( const SfxPoolItem rItem1, const SfxPoolItem rItem2 )

Re: [Libreoffice] [PUSHED] RTL_CONSTASCII_USTRINGPARAM for libs-core/framework

2010-11-21 Thread David Tardon
On Sun, Nov 21, 2010 at 08:39:42AM +0100, Julien Nabet wrote: Hello, Here's a patch for libs-core/framework Julien. (LGPLv3+ / MPL) Thanks, pushed. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [Libreoffice] feature/rip-build-repo - branch for removal of the need of the 'build' repo

2010-11-21 Thread Norbert Thiebaud
kendy, here are the patches I have so far on the rip-build-repo branch 0001: the sed to remove bootstrap from the git url and replace it by one of the other repos name didn't work on MacOS... I was too lazy to figure-out why, so I used bash varaible substitution instead :-) 0002: the ./dowmload

Re: [Libreoffice] [PUSHED] some cleanup #if 0 deletion

2010-11-21 Thread David Tardon
On Sat, Nov 20, 2010 at 11:20:34PM +0100, Pierre-André Jacquod wrote: Hello, was just tired to try reading code like: #if 0 read a lot here #else cool I will be compiled #endif So I started to track it down systematically. Just hope I was not to much aggressive. So I

[Libreoffice] Use sal_Unicode or RTL_CONSTASCII_USTRINGPARAM for single unicode character?

2010-11-21 Thread Joost Eekhoorn
Hi, CONTEXT: For single characters I see often sal_Unicode( '/' ) used and sometimes OUString( sal_Unicode( '/' ). Examples (for adding one space): - aDefaultPageName += sal_Unicode( ' ' ); - sAuthor += OUString( sal_Unicode( ' ' ); sal_Unicode is defined in ./sal/inc/rtl/ustring.hxx In

[Libreoffice] calc: some code deletion and comments translation

2010-11-21 Thread Pierre-André Jacquod
Hello, have done as well some small comment translations. regards From c29ea5e11ccc679166b5a0c5be2df925328465fb Mon Sep 17 00:00:00 2001 From: pjacquod pjacq...@alumni.ethz.ch Date: Sun, 21 Nov 2010 12:06:01 +0100 Subject: [PATCH] remove dead code in calc core data and some comments translation

[Libreoffice] [PATCH] RTL_CONSTASCII_USTRINGPARAM in svx

2010-11-21 Thread Joost Eekhoorn
MPL 1.1 / GPLv3+ / LGPLv3+ Joost diff --git a/svx/source/xml/xmlexport.cxx b/svx/source/xml/xmlexport.cxx index 467cc97..c4e6e10 100644 --- a/svx/source/xml/xmlexport.cxx +++ b/svx/source/xml/xmlexport.cxx @@ -228,7 +228,7 @@ sal_Bool SvxDrawingLayerImport( SdrModel* pModel, const

[Libreoffice] further removing of dead code

2010-11-21 Thread Pierre-André Jacquod
Hello, here in components some other pieces to delete. Again some small parts in case I was to generous in deleting. regards From 1535d5e774e7d1ef08696344be8fcdfc6828f2c3 Mon Sep 17 00:00:00 2001 From: pjacquod pjacq...@alumni.ethz.ch Date: Sun, 21 Nov 2010 12:10:15 +0100 Subject: [PATCH 1/5]

[Libreoffice] [PATCH] RTL_CONSTASCII_USTRINGPARAM for libs-core/scripting + SAL_N_ELEMENTS (last one ?)

2010-11-21 Thread Julien Nabet
Hello, Here's a patch for libs-core/scripting + 1 patch for filter_msfilter (I thought i did it before but i must have deleted it by mistake). It seems, by reading the result of grep, it's the last SAL_N_ELEMENTS macro to put in place. So it would be a task to put in Completed_easy_hacks.

[Libreoffice] C2U 61 time defined and with 2 differed meanings

2010-11-21 Thread Joost Eekhoorn
Hi, CONTEXT: I like short naming, thus I find RTL_CONSTASCII_USTRINGPARAM far too long. But the there is C2U. That is defined 61 times and sometimes as: #define C2U(cChar) OUString::createFromAscii(cChar) and on other places as: #define C2U(cChar)

[Libreoffice] [PATCH] RTL_CONSTASCII_USTRINGPARAM for libs-core/svx

2010-11-21 Thread Julien Nabet
Hello, Here's a patch for libs-core/svx Julien. (LGPLv3+ / MPL) libs_core_svx.txt.bz2 Description: application/bzip ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] RTL_CONSTASCII_USTRINGPARAM for libs-core/vbahelper

2010-11-21 Thread Julien Nabet
Hello, Here's a patch for libs-core/vbahelper Julien. (LGPLv3+ / MPL) libs_core_vbahelper.txt.bz2 Description: application/bzip ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Fwd: [PATCH] RTL_CONSTASCII_USTRINGPARAM for libs-core/vbahelper

2010-11-21 Thread Julien Nabet
Sorry, I just noticed that git diff even on a subdirectory didn't make a diff only on this subdirectory. For example : i made a git diff in clone/libs-core/vbahelper/source but the diff includes the changes i made in clone/libs-core/vbahelper/svx/source and all the others I made today. Sorry

[Libreoffice] Fwd: [PATCH] RTL_CONSTASCII_USTRINGPARAM for libs-core/vbahelper

2010-11-21 Thread Julien Nabet
Sorry, I just noticed that git diff even on a subdirectory didn't make a diff only on this subdirectory. For example : i made a git diff in clone/libs-core/vbahelper/source but the diff includes the changes i made in clone/libs-core/vbahelper/svx/source and all the others I made today. Sorry

Re: [Libreoffice] [PUSHED] Re: [PATCH 02/12] RTL_CONSTASCII_USTRINGPARAM in components cui options

2010-11-21 Thread Wols Lists
On 18/11/10 13:36, Kevin Hunter wrote: As I assume you're using a regex, you might consider catching this by doing the search and replace in series. Here's an example: 1. Catch the 'OUString +?= ...createFromAscii...' case and replace with 'OUString var( RTL...)' search:

Re: [Libreoffice] Fwd: [PATCH] RTL_CONSTASCII_USTRINGPARAM for libs-core/vbahelper

2010-11-21 Thread Norbert Thiebaud
On 11/21/10, Julien Nabet serval2...@yahoo.fr wrote: Sorry, I just noticed that git diff even on a subdirectory didn't make a diff only on this subdirectory. For example : i made a git diff in clone/libs-core/vbahelper/source but the diff includes the changes i made in

[Libreoffice] [EasyHacks] cppcheck of entire code at http://libreoffice.boldandbusted.com/

2010-11-21 Thread someone
Howdy. To help with EasyHack cppcheck cleanliness, I've set up automated reporting on http://libreoffice.boldandbusted.com/ . Here will live a report generated from a complete scan of the entire LO codebase, generated every 4-6 hours, against a fresh update from the various git repos with LO code.

Re: [Libreoffice] [EasyHacks] cppcheck of entire code at http://libreoffice.boldandbusted.com/

2010-11-21 Thread someone
I should also caution you that, at least for my Firefox, this page may make your browser creak under its weight. Another reason to crush bugs! :) Cheers, Jesse Adelman Bold and Busted LLC Brisbane, CA USA On Sun, 21 Nov 2010 19:38 -0800, some...@boldandbusted.com wrote: Howdy. To help with

[Libreoffice] [LO 3.3.0b3] Enable experimental (unstable) features?

2010-11-21 Thread NoOp
No answers for this on the user list, so I'll ask here: LibreOffice 3.3.0 OOO330m12 (Build:2) libreoffice-build 3.2.99.3 Tools|Options|LibreOffice|General: - Enable experimental (unstable) features Does anyone know what this enables? ___ LibreOffice

Re: [Libreoffice] [PUSHED] Re: [PATCH 02/12] RTL_CONSTASCII_USTRINGPARAM in components cui options

2010-11-21 Thread Kevin Hunter
At 4:58pm -0500 Sun, 21 Nov 2010, Wols Lists wrote: On 18/11/10 13:36, Kevin Hunter wrote: As I assume you're using a regex, you might consider catching this by doing the search and replace in series. Here's an example: 1. Catch the 'OUString +?= ...createFromAscii...' case and replace with

Re: [Libreoffice] Suggestion needed for External Edit functionality.

2010-11-21 Thread surensp...@gmail.com
Hi Thorsten, Mon, Nov 15, 2010 at 5:40 PM, Thorsten Behrens t...@documentfoundation.org wrote: surensp...@gmail.com wrote: 1) Making it work in all OS/platforms: [...] Hi Suren, wow, great progress! For the editing, one easy way out would be to use the SystemShellExecute service, which

[Libreoffice] Building problem, sc/source/ui/src/optdlg.src gives syntax error

2010-11-21 Thread Joost Eekhoorn
Hi, PROBLEM 1: I am trying to make again, but it fails on ./sc/source/ui/src/optdlg.src I did remove the unxlngx6.pro in the sc, and did the build there locally and it gave: Making:ui.srs { ^ f4101: optdlg.src, line 118: Warning in the object (Type: FixedLine): Resources without name

Re: [Libreoffice] Building problem, sc/source/ui/src/optdlg.src gives syntax error

2010-11-21 Thread Kevin Hunter
At 1:16am -0500 Mon, 22 Nov 2010, Joost Eekhoorn wrote: PROBLEM 2: Will have to let someone else respond to problem 1, but I believe problem 2 to be fairly simple to solve: The problem I had on the previous build: I had a good build and did an install, but the I could not run the program

Re: [Libreoffice] [PUSHED] RTL_CONSTASCII_USTRINGPARAM in svx

2010-11-21 Thread David Tardon
On Mon, Nov 22, 2010 at 07:37:28AM +0100, David Tardon wrote: On Sun, Nov 21, 2010 at 02:58:35PM +0100, Joost Eekhoorn wrote: MPL 1.1 / GPLv3+ / LGPLv3+ Joost The patch contains duplicate changes for svx/source/fmcomp/fmgridif.cxx and svx/source/gengal/gengal.cxx .-) Otherwise good.

Re: [Libreoffice] [PUSHED] RTL_CONSTASCII_USTRINGPARAM for libs-core/scripting + SAL_N_ELEMENTS (last one ?)

2010-11-21 Thread David Tardon
On Sun, Nov 21, 2010 at 04:20:26PM +0100, Julien Nabet wrote: Hello, Here's a patch for libs-core/scripting + 1 patch for filter_msfilter (I thought i did it before but i must have deleted it by mistake). It seems, by reading the result of grep, it's the last SAL_N_ELEMENTS macro to put in

Re: [Libreoffice] [EasyHacks] cppcheck of entire code at http://libreoffice.boldandbusted.com/

2010-11-21 Thread someone
On Sun, 21 Nov 2010 19:38 -0800, some...@boldandbusted.com wrote: Howdy. To help with EasyHack cppcheck cleanliness, I've set up automated reporting on http://libreoffice.boldandbusted.com/ . Here will live a report generated from a complete scan of the entire LO codebase, generated every

Re: [Libreoffice] Building problem, sc/source/ui/src/optdlg.src gives syntax error

2010-11-21 Thread Pierre-André Jacquod
On 11/22/2010 07:16 AM, Joost Eekhoorn wrote: Hi, PROBLEM 1: I am trying to make again, but it fails on ./sc/source/ui/src/optdlg.src I did remove the unxlngx6.pro http://unxlngx6.pro in the sc, and did the build there locally and it gave: Making:ui.srs { ^ f4101: