Re: [Libreoffice] [PUSHED] [REALLY] __cdecl - SAL_CALL (calc/components/ure/writer)

2011-06-10 Thread Thorsten Behrens
Looks pushed for real now. -- Thorsten pgp85k3dkcF02.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] Complete fix for fdo#32684

2011-06-10 Thread Thorsten Behrens
-- Thorsten pgpL8OqmQK6QX.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] Lotuswordpro : Found duplicate if expressions in xfbookmarkref.cxx:75:85

2011-06-10 Thread Thorsten Behrens
-- Thorsten pgpuXHZnnaE22.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [GSoC 2011][svgexport] I need some help on exporting all selected slides task

2011-06-10 Thread Thorsten Behrens
Ariel Constenla-Haile wrote: I guess the export filter will get a reference to the document model, so he will need to get the SubController [1] Model - Controller - SubController Hi Ariel, neat! I'm always amazed about the depth of your API knowledge! :) Marco - were you able to make

Re: [Libreoffice] which mailing list for extension writers?

2011-06-10 Thread Thorsten Behrens
Christian Andersson wrote: Hi there, a short question, I'm writing an extension to libreoffice, and I wonder which mailing lsit I should use for api questions, etc Please ask here - or even better, poke us on irc #libreoffice-dev Cheers, -- Thorsten pgpxV5FCNx0QE.pgp Description: PGP

Re: [Libreoffice] Replacing ByteString with rtl::OString

2011-06-10 Thread Thorsten Behrens
Chr. Rossmanith wrote: I encountered the problem that rtl::OString::valueOf() won't eat sal_Int16. Solution A: cast argument Solution B: add support for sal_Int16 to rtl::OString::valueOf() Solution B would add ambiguities wrt. to valueOf( sal_Unicode c ), and likely break (some) platforms.

Re: [Libreoffice] [PATCH] replace OpenOffice.org and StarOffice references with LibreOffice

2011-06-10 Thread Thorsten Behrens
Michael Meeks wrote: None with me, as long as you commit Michael's nice patch with his attribution too ;-) [ I assume Michael that this is under the MPL/LGPLv3 + (?) ] Hi Michael - please, can you confirm your patch is under said license? Thanks, -- Thorsten pgpAbPMW7zuid.pgp

Re: [Libreoffice] Patch for Bug 35938 - EasyHack: UI - Picture Caption dialog not remembering Separator textbox value

2011-06-10 Thread Thorsten Behrens
Jeff Aigner wrote: I'm new to contributing here, so greetings to all! Attached is a patch for bug 35938. It changes the Picture Caption dialog to remember the last-used value of the caption separator text. Hi Jeff, can you please confirm your patch is under LGPLv3+/MPL license? Thanks, --

Re: [Libreoffice] programmable control of document recovery

2011-06-10 Thread Thorsten Behrens
Christian Andersson wrote: Is it possible via the api to decide which documents should be recoverable after a crash? Seems that info is stored in the configuration - places to peek into for insight include framework/source/services/autorecovery.cxx and

Re: [Libreoffice] warning: the use of `tmpnam' is dangerous, better use `mkstemp'

2011-06-10 Thread Caolán McNamara
On Thu, 2011-06-09 at 23:43 +0200, Jesús Corrius wrote: On Thu, Jun 9, 2011 at 11:24 PM, Julien Nabet serval2...@yahoo.fr wrote: In the Unix man of tmpnam, we can read this : BUGS Never use this function. Use mkstemp(3) or tmpfile(3) instead. The best option probably (don't

[Libreoffice] [REVIEW] fix for default windows Traditional Chinese font

2011-06-10 Thread Caolán McNamara
So, reading http://blogs.linux.ie/caolan/2011/02/09/small-libreoffice-font-dropdown-list-improvements/comment-page-1/#comment-157304 I see a complaint that LibreOffice now even choose 'Microsoft YaHei' for Traditional Chinese locale in Windows. And indeed YaHei (微软雅黑) is a Simplified Chinese font,

Re: [Libreoffice] [REVIEW] [PUSHED] fix for default windows Traditional Chinese font

2011-06-10 Thread Tor Lillqvist
think we should consider this as a low-hanging for to cherry-pick to 3-4 Cherry-picked, thanks! --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [Libreoffice-ux-advise] Performance improvements for calcs' sheet actions

2011-06-10 Thread Michael Meeks
Hi Christophe, On Wed, 2011-06-08 at 00:18 +0200, Christoph Noack wrote: Let's add some more issues ... and thoughts :-) Nice input indeed :-) thanks. True. Of course, there is some magic on some platforms to let the progress indicators appear continuously updated, but the most sane

Re: [Libreoffice] [REVIEW] fix for default windows Traditional Chinese font

2011-06-10 Thread Tseng, Cheng-Chia
I have checked the commit. There are some comments below: 方正明體 do not used commonly on Windows, only Sun StarSuite provides this font. AR PL Mingti2L Big5, 文鼎PL細上海宋Uni; AR PL ShanHeiSun Uni has been abandoned. Now they have been integrated into AR PL UMing TW. AR PL UMIng series has three gylph

Re: [Libreoffice] [REVIEW] fix for default windows Traditional Chinese font

2011-06-10 Thread Tseng, Cheng-Chia
Plus, there are one Chinese font which is polular on Linux platform now, please consider to include it in CJK_HEADING, CJK_PRESENTATION. That is 文泉驛微米黑 (WenQuanYi Micro Hei ) for TW and HK (文泉驿微米黑 for CN). It looks like 微軟正黑體, so I think it is better to place it after 微軟正黑體. -- Sincerely, by

Re: [Libreoffice] [REVIEW] fix for default windows Traditional Chinese font

2011-06-10 Thread Caolán McNamara
On Fri, 2011-06-10 at 17:26 +0800, Tseng, Cheng-Chia wrote: I have checked the commit. There are some comments below: 方正明體 do not used commonly on Windows, only Sun StarSuite provides this font. AR PL Mingti2L Big5, 文鼎PL細上海宋Uni; AR PL ShanHeiSun Uni has been abandoned. Now they have been

Re: [Libreoffice] [REVIEW] [PUSHED] Fix for fdo#37622

2011-06-10 Thread Katarina Machalkova
Ok. This is the last one for today. Here is the bug https://bugs.freedesktop.org/show_bug.cgi?id=37622 and here is the commit I'd like to cherry-pick to the -3-4 branch http://cgit.freedesktop.org/libreoffice/calc/commit/?id=099fd0fd91485797362 259e45b1a971dda0511a3 The old code

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

2011-06-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Bug 35673 depends on bug 37622, which changed state. Bug 37622 Summary: xls file loses formatting https://bugs.freedesktop.org/show_bug.cgi?id=37622 What|Old Value |New Value

Re: [Libreoffice] [GSoC 2011][svgexport] I need some help on exporting all selected slides task

2011-06-10 Thread Marco
On Wed, 08 Jun 2011 13:18:27 +0200, Ariel Constenla-Haile ariel.constenla.ha...@googlemail.com wrote: Hello Thorsten, On Wednesday 08 June 2011, 05:29, Thorsten Behrens wrote: Marco wrote: I hoped to get some type of object or container that let me to find the selected thumbnail slides

Re: [Libreoffice] [GSoC 2011][svgexport] I need some help on exporting all selected slides task

2011-06-10 Thread Marco
On Thu, 09 Jun 2011 10:14:52 +0200, Alexander Thurgood alex.thurg...@gmail.com wrote: Le 08/06/11 12:31, Marco a écrit : Hi Marco, Hi Christian, thanks to point out this documentation! :) I 'll read it as soon as possible. There is an unpublished interface called :

Re: [Libreoffice] [GSoC 2011][svgexport] I need some help on exporting all selected slides task

2011-06-10 Thread Marco
On Wed, 08 Jun 2011 12:23:25 +0200, Christian Lippka c...@lippka.com wrote: Am 08.06.2011 12:16, schrieb Marco: but as I said aSelection internal type seems to be void So from which controller should I get the XSelectionSupplier interface ? You talk about an xModel object where should I get it

Re: [Libreoffice] [GSoC 2011][svgexport] I need some help on exporting all selected slides task

2011-06-10 Thread Marco
On Fri, 10 Jun 2011 08:28:04 +0200, Thorsten Behrens t...@documentfoundation.org wrote: Ariel Constenla-Haile wrote: I guess the export filter will get a reference to the document model, so he will need to get the SubController [1] Model - Controller - SubController Hi Ariel, neat! I'm

[Libreoffice] with gbuild how to set a dependency of a cppunit test on a res file ?

2011-06-10 Thread Caolán McNamara
i.e. from one of the tinderboxes it looks like I want a dependency from the sw (at least, probably the sc as well) cppunit test on the .res file of that module. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [Libreoffice] with gbuild how to set a dependency of a cppunit test on a res file ?

2011-06-10 Thread Norbert Thiebaud
On Fri, Jun 10, 2011 at 6:12 AM, Caolán McNamara caol...@redhat.com wrote: i.e. from one of the tinderboxes it looks like I want a dependency from the sw (at least, probably the sc as well) cppunit test on the .res file of that module. Ah, I remember now. I got that issue in starmath and I

Re: [Libreoffice] with gbuild how to set a dependency of a cppunit test on a res file ?

2011-06-10 Thread Bjoern Michaelsen
Hi Caolán, On Fri, 10 Jun 2011 12:12:05 +0100 Caolán McNamara caol...@redhat.com wrote: i.e. from one of the tinderboxes it looks like I want a dependency from the sw (at least, probably the sc as well) cppunit test on the .res file of that module. I assume you need the .res file(s) at

Re: [Libreoffice] with gbuild how to set a dependency of a cppunit test on a res file ?

2011-06-10 Thread Norbert Thiebaud
On Fri, Jun 10, 2011 at 6:25 AM, Norbert Thiebaud nthieb...@gmail.com wrote: On Fri, Jun 10, 2011 at 6:12 AM, Caolán McNamara caol...@redhat.com wrote: i.e. from one of the tinderboxes it looks like I want a dependency from the sw (at least, probably the sc as well) cppunit test on the .res

[Libreoffice] How to add new commands for Math

2011-06-10 Thread Rodolfo
Hi. I'm new here at LibO development. I have interest on improve the Math component of LibreOffice by adding some new commands into it: things like a wide inverted breve for description of an arc between points A and B. In order to do so, I've been looking changing files with WideVec in

Re: [Libreoffice] [PUSHED] [PATCH] fdo#32263 - Config file location

2011-06-10 Thread Petr Mladek
Noel Power píše v Čt 09. 06. 2011 v 20:14 +0100: Hmm, do we really want to use $HOME/.config/libreoffice by default? well, don't blame the messenger or in this case the patch pusher ;-) But, it seems since we are a freedesktop application ( and we do already have support for XDG_CONFIG_HOME

Re: [Libreoffice] [GSoC 2011][svgexport] I need some help on exporting all selected slides task

2011-06-10 Thread Thorsten Behrens
Marco wrote: but I don know how to get such a component context object. So if you could give me some hint would be great! ::comphelper::getProcessComponentContext() (from comphelper/processfactory.hxx). Didn't check whether you'll actually get the XSelectionSupplier there - and I personally

Re: [Libreoffice] [GSoC 2011][svgexport] I need some help on exporting all selected slides task

2011-06-10 Thread Thorsten Behrens
Marco wrote: (2) I see that the Export Dialog has a Selection check box. I guess that its role is to let the user choose if he/she wants to export the whole presentation or only the selected slides. However I don't know yet, if/how the state of such check box is passed to the svg export

Re: [Libreoffice] [PATCH] replace OpenOffice.org and StarOffice references with LibreOffice

2011-06-10 Thread Michael Münch
Am Freitag, den 10.06.2011, 08:36 +0200 schrieb Thorsten Behrens: Michael Meeks wrote: None with me, as long as you commit Michael's nice patch with his attribution too ;-) [ I assume Michael that this is under the MPL/LGPLv3 + (?) ] Hi Michael - please, can you confirm your patch

Re: [Libreoffice] How to add new commands for Math

2011-06-10 Thread Michael Meeks
Hi there, On Fri, 2011-06-10 at 08:56 -0300, Rodolfo wrote: Hi. I'm new here at LibO development. Welcome ! :-) fantastic to have you. I have interest on improve the Math component of LibreOffice by adding some new commands into it: things like a wide inverted breve for description

Re: [Libreoffice] [PATCH] replace OpenOffice.org and StarOffice references with LibreOffice

2011-06-10 Thread Thorsten Behrens
Michael Münch wrote: Just an idea, would a wiki page where you can list that your contributions until removal from that page will be under license x/y sufficient? Or is it not reliable enough that the edit is from the same person sending a patch. Hi Michael, because of the problems you

[Libreoffice] [REVIEW]fix for fdo#37872

2011-06-10 Thread Markus Mohrhard
Hello, this patch is for https://bugs.freedesktop.org/show_bug.cgi?id=37872 . I discussed the underlying problem with Kohei and we agreed that we should not allow points in range names any more. There are even more problems with points in range names than discussed in this bug report because

Re: [Libreoffice] [REVIEWED] [PUSHED] fix for fdo#37872

2011-06-10 Thread Kohei Yoshida
On Fri, 2011-06-10 at 16:27 +0200, Markus Mohrhard wrote: this patch is for https://bugs.freedesktop.org/show_bug.cgi?id=37872 . I discussed the underlying problem with Kohei and we agreed that we should not allow points in range names any more. There are even more problems with points in

Re: [Libreoffice] Duplicate code: libs-core/framework/test/typecfg/cfgview.cxx

2011-06-10 Thread Michael Meeks
On Thu, 2011-06-02 at 22:07 +0200, Chr. Rossmanith wrote: CFGView::impl_generateFilter{Modul}?ListHTML(). Shall I continue or is it only a test? I guess I'd look at the makefiles to see if it is linked into the main binary at all (apparently a git grep for cfgview show it is not).

Re: [Libreoffice] [PATCH][PUISHED] List structure cleaning in impress

2011-06-10 Thread Petr Mladek
Rafael Dominguez píše v St 08. 06. 2011 v 22:07 -0430: I have pushed it with the following changes: = 1. 0001-Replace-List-for-std-vector-sd-FrameView.patch replaced +rViews.push_back( new ::sd::FrameView( mpDoc ) ); with

[Libreoffice] [REVIEW] Fix for #fdo36719

2011-06-10 Thread Kohei Yoshida
Here is another bug fix I'd like to push to the -3-4 branch. https://bugs.freedesktop.org/show_bug.cgi?id=36719 Opening a document with a pivot table that is linked to a invalid database source crashes Calc in various places. The attached patch fixes this. The changes are mostly simple things

Re: [Libreoffice] Master build Seg faults in starmath test

2011-06-10 Thread John LeMoyne Castle
Caolan, I saw your related posts here and on bug 37668. You have an amazing eye to spot that very not obvious sign extension error as the difference between 64 bit OK and 32 not OK. Thanks for making the connection explicit here. My first attempt failed (later?) in tail_build within

Re: [Libreoffice] [REVIEW] Fix for #fdo36719

2011-06-10 Thread Norbert Thiebaud
On Fri, Jun 10, 2011 at 12:23 PM, Kohei Yoshida kyosh...@novell.com wrote: Here is another bug fix I'd like to push to the -3-4 branch. https://bugs.freedesktop.org/show_bug.cgi?id=36719 Opening a document with a pivot table that is linked to a invalid database source crashes Calc in various

Re: [Libreoffice] [REVIEWED] [PUSHED] Fix for a crash during Multiple Operations

2011-06-10 Thread Kohei Yoshida
On Fri, 2011-06-10 at 16:25 -0400, Kohei Yoshida wrote: P.S. BTW, Tor already gave me his sign-off on IRC and cherry-picked this to the -3-4 branch while writing this mail, so no review is needed. ;-) Setting the right tags... -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com

Re: [Libreoffice] [PATCH] Bug 33293 - [EasyHack] Make starting count of worksheets configurable

2011-06-10 Thread Albert Thuswaldner
Hi, It took some time to fix this. I moved stuff to a new computer, had some build problems, implemented some changes (see below), and had a fair share of bugs to straighten out. But now I think I'm finished with this feature patch. Please have a look - Changed the option tab page to defaults. -

Re: [Libreoffice] [PATCH] Bug 33293 - [EasyHack] Make starting count of worksheets configurable

2011-06-10 Thread Miklos Vajna
On Fri, Jun 10, 2011 at 10:34:39PM +0200, Albert Thuswaldner albert.thuswald...@gmail.com wrote: --- /dev/null +++ b/sc/source/ui/optdlg/tpdefaults.cxx @@ -0,0 +1,87 @@ +/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */

[Libreoffice] Easy Hack Completed - Remove non-compiled / dead code

2011-06-10 Thread Júlio Hoffimann
Hi devs, One more Easy Hack completed: http://wiki.documentfoundation.org/Development/Easy_Hacks#remove_non-compiled_.2F_dead_code Someone finished it, there is no results in mine regex here. Regards, Júlio. P.S.: Are you having problems with TDF Wiki? My account is not logging anymore, i'm

[Libreoffice] [PATCH] Removes mail function from make_installer.pl

2011-06-10 Thread Samuel Cantrell
I created a patch that I believe deletes the mail function from mail_installer.pl and related modules, per the item listed on the Easy Hacks wiki page. I ran make and make dev-install and it works...however, if there's something else I should run to ensure that the code is functioning properly,

[Libreoffice] QA-hints ? - question for devs !

2011-06-10 Thread Cor Nouws
Hi all, Quite regular I have the feeling that at least me would be helped a bit by doing QA if there is some hint-list.. I mean, it is not often that I make time to install a nightly build and really start using it. And then it feels a bit pointless just to do some often easy work - after

Re: [Libreoffice] Patch for Bug 35938 - EasyHack: UI - Picture Caption dialog not remembering Separator textbox value

2011-06-10 Thread Jeff Aigner
The patch I provided for Bug 35938 is licensed under LGPLv3+/MPL. Jeff Aigner On 06/10/2011 01:42 AM, Thorsten Behrens wrote: Jeff Aigner wrote: I'm new to contributing here, so greetings to all! Attached is a patch for bug 35938. It changes the Picture Caption dialog to remember the

[Libreoffice] [PATCH] Removes zoom button from default standard toolbar

2011-06-10 Thread Samuel Cantrell
I've created a couple patches that remove the zoom button from the standard bar by default. (That is, they are still present, so if a user so chooses to, he can add them, but they're not shown by default.) One patch applies to Calc, and the other to Writer. To apply them, you have to cd into