[Libreoffice-commits] .: Branch 'libreoffice-3-5' - oox/source

2012-02-23 Thread Andras Timar
oox/source/xls/viewsettings.cxx |8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) New commits: commit bd2145e740b61b69cda6456d483bcd62883e2fe3 Author: Noel Power noel.po...@novell.com Date: Wed Feb 22 15:08:21 2012 + force imported xlsx active tab to be shown bnc#748198

[Libreoffice-commits] .: fpicker/source

2012-02-23 Thread Stephan Bergmann
fpicker/source/win32/misc/resourceprovider.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 18339dbc452d6e074ed4e94cc47db1249600a48d Author: Matus Kukan matus.ku...@gmail.com Date: Thu Feb 23 08:07:15 2012 +0100 fix build on Windows: use OUString diff

[Libreoffice-commits] .: libxml2/makefile.mk

2012-02-23 Thread Petr Mladek
libxml2/makefile.mk |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 5f7667e9c193f281c344fb38408028235c871a15 Author: Petr Mladek pmla...@suse.cz Date: Thu Feb 23 11:10:53 2012 +0100 set back rpath to ure/lib for libxml on MAC The library is installed

[Libreoffice-commits] .: ucb/source xmlhelp/source

2012-02-23 Thread Thomas Arnhold
ucb/source/ucp/file/filglob.cxx |3 --- ucb/source/ucp/file/shell.cxx |4 xmlhelp/source/cxxhelp/inc/util/Decompressor.hxx |4 xmlhelp/source/cxxhelp/provider/databases.hxx |6 --

[Libreoffice-commits] .: i18npool/inc i18npool/source svtools/source

2012-02-23 Thread Eike Rathke
i18npool/inc/i18npool/lang.h|1 + i18npool/source/isolang/isolang.cxx |1 + svtools/source/misc/langtab.src |1 + 3 files changed, 3 insertions(+) New commits: commit 082b2bca9f82e760c0092bde3d46242c446ebdb8 Author: Eike Rathke er...@redhat.com Date: Thu Feb 23 12:25:18

[Libreoffice-commits] .: l10ntools/source

2012-02-23 Thread Andras Timar
l10ntools/source/helpex.cxx |1 - 1 file changed, 1 deletion(-) New commits: commit aee538eb752325846966eb440e424126e00531af Author: Andras Timar ati...@suse.com Date: Thu Feb 23 12:36:06 2012 +0100 do not print .\n to console diff --git a/l10ntools/source/helpex.cxx

[Libreoffice-commits] .: reportbuilder/util

2012-02-23 Thread Michael Stahl
reportbuilder/util/makefile.mk |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 7b72d62a7180db7e5fd1831d0455dee59fee1edb Author: Michael Stahl mst...@redhat.com Date: Thu Feb 23 12:34:21 2012 +0100 reportbuilder: untested fix for WITH_LANG build

[Libreoffice-commits] .: solenv/bin

2012-02-23 Thread Stephan Bergmann
solenv/bin/macosx-change-install-names.pl |1 + 1 file changed, 1 insertion(+) New commits: commit 55cece225238e634b8a8ebd0445a9aca4c5c57eb Author: Stephan Bergmann sberg...@redhat.com Date: Thu Feb 23 12:43:25 2012 +0100 Add shl/LOADER/URELIB to make --without-sytem-libxml work on

[Libreoffice-commits] .: clucene/configs clucene/source

2012-02-23 Thread Caolán McNamara
clucene/configs/_clucene-config-LINUX.h | 112 ++ clucene/configs/_clucene-config-MSVC.h| 112 ++ clucene/configs/_clucene-config-generic.h |2 clucene/configs/clucene-config-MSVC.h | 148 ++

[Libreoffice-commits] .: clucene/patches clucene/source

2012-02-23 Thread Caolán McNamara
clucene/patches/clucene-gcc-atomics.patch | 20 clucene/source/Makefile |1 + 2 files changed, 21 insertions(+) New commits: commit 419cceda368284743e8fcd873d7bec94423cc37c Author: Caolán McNamara caol...@redhat.com Date: Thu Feb 23 12:10:41 2012

[Libreoffice-commits] .: clucene/patches

2012-02-23 Thread Caolán McNamara
clucene/patches/clucene-gcc-atomics.patch | 11 +++ 1 file changed, 11 insertions(+) New commits: commit 235db83d4c4a18eaa0b183f6ef891e7d2dc12e26 Author: Caolán McNamara caol...@redhat.com Date: Thu Feb 23 12:38:42 2012 + another problematic _CL_HAVE_GCC_ATOMIC_FUNCTIONS

[Libreoffice-commits] .: 4 commits - comphelper/inc comphelper/source editeng/inc editeng/source oox/source sw/inc sw/source writerfilter/source

2012-02-23 Thread Cédric Bosdonnat
comphelper/inc/comphelper/TypeGeneration.hxx |1 comphelper/source/property/TypeGeneration.cxx |2 editeng/inc/editeng/memberids.hrc |2 editeng/source/items/frmitems.cxx | 48 ++ oox/source/vml/vmldrawing.cxx

[Libreoffice-commits] .: clucene/configs clucene/Library_clucene.mk

2012-02-23 Thread Caolán McNamara
clucene/Library_clucene.mk|7 --- clucene/configs/_clucene-config-generic.h |8 2 files changed, 8 insertions(+), 7 deletions(-) New commits: commit 3b18642d62dad7128420f1d59f632acf5057da2b Author: Caolán McNamara caol...@redhat.com Date: Thu Feb 23

[Libreoffice-commits] .: sc/source

2012-02-23 Thread Michael Meeks
sc/source/filter/xml/XMLChangeTrackingImportHelper.cxx | 33 +++-- 1 file changed, 15 insertions(+), 18 deletions(-) New commits: commit f881540b3295c17286f8003c7b897907bf9f57cb Author: Catalin Iacob iacobcata...@gmail.com Date: Thu Feb 23 12:57:22 2012 + cppcheck: fix

[Libreoffice-commits] .: Makefile

2012-02-23 Thread Stephan Bergmann
Makefile |1 + 1 file changed, 1 insertion(+) New commits: commit 284069dd0be5ecd700f61e7c5b7e6b3d78065aa6 Author: Stephan Bergmann sberg...@redhat.com Date: Thu Feb 23 13:58:52 2012 +0100 clucene missing from gbuild_modules diff --git a/Makefile b/Makefile index 4899664..72f1174

[Libreoffice-commits] .: sw/source

2012-02-23 Thread Cédric Bosdonnat
sw/source/core/unocore/unoframe.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit fda2c3639de6b673faf2ccd84b6d4318e592fbf0 Author: Cédric Bosdonnat cedric.bosdonnat@free.fr Date: Thu Feb 23 14:29:51 2012 +0100 WaE: aPosition is an unused parameter diff

[Libreoffice-commits] .: vcl/unx

2012-02-23 Thread Caolán McNamara
vcl/unx/generic/printer/ppdparser.cxx | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) New commits: commit 825d31d5f11364bea4184cabb538f8b6575d5795 Author: Caolán McNamara caol...@redhat.com Date: Thu Feb 23 14:10:15 2012 + ensure ppd translation indexes are valid

[Libreoffice-commits] .: salhelper/source

2012-02-23 Thread Michael Meeks
salhelper/source/gcc3.map |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) New commits: commit 6aace905c0929adf79d0cfa146f168d75cc2e953 Author: Michael Meeks michael.me...@suse.com Date: Thu Feb 23 14:27:29 2012 + add ia32 non-virtual thunks to linker map diff --git

[Libreoffice-commits] .: solenv/bin

2012-02-23 Thread Caolán McNamara
solenv/bin/modules/installer/parameter.pm | 62 +++--- 1 file changed, 56 insertions(+), 6 deletions(-) New commits: commit 249059454f35a55bd7f6756d2b361f8c3e07c8e0 Author: Caolán McNamara caol...@redhat.com Date: Thu Feb 23 14:27:53 2012 + Revert Replace

[Libreoffice-commits] .: Branch 'libreoffice-3-5' - 2 commits - extensions/source

2012-02-23 Thread Noel Power
extensions/source/ole/unoconversionutilities.hxx | 67 --- 1 file changed, 26 insertions(+), 41 deletions(-) New commits: commit 39d26132445c158b4035b689e8939c8e7fb2d4ee Author: Joachim Lingner j...@openoffice.org Date: Thu Feb 23 12:38:36 2012 + default

[Libreoffice-commits] .: clucene/Package_source.mk clucene/source

2012-02-23 Thread Caolán McNamara
clucene/Package_source.mk |2 +- clucene/source/Makefile |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) New commits: commit c31e1bae8e9ba6cc90f4585f5d8aeab29cb5263a Author: Caolán McNamara caol...@redhat.com Date: Thu Feb 23 15:06:10 2012 + fix for cross-compiling

[Libreoffice-commits] .: Branch 'libreoffice-3-5' - 3 commits - sw/source

2012-02-23 Thread Caolán McNamara
sw/source/core/doc/doclay.cxx |3 +++ sw/source/core/docnode/ndcopy.cxx |2 +- sw/source/core/unocore/unotext.cxx | 21 + 3 files changed, 25 insertions(+), 1 deletion(-) New commits: commit 2d5231041203f2471c4d2f052dde6f4808fa8344 Author: Michael Stahl

[Libreoffice-commits] .: libcroco/makefile.mk

2012-02-23 Thread Stephan Bergmann
libcroco/makefile.mk | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) New commits: commit 37f527e9892904f49879635d96670a7e4838ec4c Author: Stephan Bergmann sberg...@redhat.com Date: Thu Feb 23 16:26:23 2012 +0100 Tentative libcroco fix for Mac OS X

[Libreoffice-commits] .: Branch 'libreoffice-3-4' - 2 commits - extensions/source

2012-02-23 Thread Noel Power
extensions/source/ole/unoconversionutilities.hxx | 67 --- 1 file changed, 26 insertions(+), 41 deletions(-) New commits: commit 21f1ed4c20b6409037ac215ec96abcacd581660e Author: Joachim Lingner j...@openoffice.org Date: Thu Feb 23 15:47:49 2012 + default

[Libreoffice-commits] .: 4 commits - connectivity/source cppuhelper/inc cppu/inc scp2/source solenv/bin sw/source

2012-02-23 Thread Korrawit Pruegsanusak
connectivity/source/drivers/mozab/mozillasrc/makefile.mk | 14 +- cppu/inc/typelib/typedescription.h |2 cppuhelper/inc/cppuhelper/factory.hxx| 12 +- scp2/source/ooo/file_library_ooo.scp |5 solenv/bin/build.pl

[Libreoffice-commits] .: tools/inc tools/source unusedcode.easy

2012-02-23 Thread Caolán McNamara
tools/inc/tools/string.hxx |7 --- tools/source/string/strimp.cxx | 86 --- tools/source/string/tstring.cxx | 13 - tools/source/string/tustring.cxx | 86 +++ unusedcode.easy |4 -

[Libreoffice-commits] .: binfilter/bf_svtools

2012-02-23 Thread Stephan Bergmann
binfilter/bf_svtools/source/misc/svt_ehdl.cxx |4 ++-- binfilter/bf_svtools/source/misc1/svt_svtdata.cxx |2 +- 2 files changed, 3 insertions(+), 3 deletions(-) New commits: commit 0593ef5c57daa85f5982e57d11618b631aa5692d Author: Stephan Bergmann sberg...@redhat.com Date: Thu Feb

[Libreoffice-commits] .: 3 commits - basic/source chart2/source fpicker/source salhelper/source sccomp/source sfx2/source svl/source svtools/source svx/source sysui/source tools/inc ucbhelper/workben

2012-02-23 Thread Stephan Bergmann
basic/source/runtime/basrdll.cxx |2 +- basic/source/sbx/sbxscan.cxx |2 +- chart2/source/tools/RessourceManager.cxx |2 +- fpicker/source/office/iodlg.cxx |2 +- fpicker/source/office/iodlgimp.cxx|2 +-

[Libreoffice-commits] .: wizards/com

2012-02-23 Thread Julien Nabet
wizards/com/sun/star/wizards/ui/ControlScroller.java |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit bad98a1aa71e1a76c6ca4033f82168fe5b098b64 Author: Julien Nabet serval2...@yahoo.fr Date: Thu Feb 23 20:00:40 2012 +0100 fdo#46339: Fix Query Wizard by putting

[Libreoffice-commits] .: salhelper/inc

2012-02-23 Thread Stephan Bergmann
salhelper/inc/salhelper/thread.hxx |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) New commits: commit 2d15260688aca175b5ce19d6b65cacf177c14532 Author: Stephan Bergmann sberg...@redhat.com Date: Thu Feb 23 20:19:20 2012 +0100 Fix comment diff --git

[Libreoffice-commits] .: Branch 'libreoffice-3-5' - wizards/com

2012-02-23 Thread Julien Nabet
wizards/com/sun/star/wizards/ui/ControlScroller.java |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit b3a326c16127c9f696e6e4e264729991c4ef4981 Author: Julien Nabet serval2...@yahoo.fr Date: Thu Feb 23 20:00:40 2012 +0100 fdo#46339: Fix Query Wizard by putting

[Libreoffice-commits] .: 3 commits - desktop/source editeng/source tools/inc

2012-02-23 Thread Caolán McNamara
desktop/source/app/officeipcthread.cxx |6 -- editeng/source/editeng/editobj.cxx | 15 --- tools/inc/tools/string.hxx |3 +-- 3 files changed, 13 insertions(+), 11 deletions(-) New commits: commit 0a45b102953a86ea3f26ffd5740f791b3f752f08 Author: Caolán

[Libreoffice-commits] .: sal/Executable_cppunittester.mk

2012-02-23 Thread Tor Lillqvist
sal/Executable_cppunittester.mk |8 1 file changed, 8 deletions(-) New commits: commit cf2dede2132eef56bda324396ede7ee61d8f4a2b Author: Tor Lillqvist t...@iki.fi Date: Thu Feb 23 23:09:31 2012 +0200 No need to compile it as Objective-C++ for iOS any more diff --git

[Libreoffice-commits] .: oox/inc oox/source unusedcode.easy

2012-02-23 Thread Matus Kukan
oox/inc/oox/helper/attributelist.hxx | 14 --- oox/inc/oox/helper/propertymap.hxx |5 --- oox/inc/oox/xls/commentsbuffer.hxx |2 - oox/inc/oox/xls/drawingbase.hxx |2 - oox/inc/oox/xls/formulaparser.hxx|6 oox/inc/oox/xls/sheetdatabuffer.hxx | 14

[Libreoffice-commits] .: oox/inc oox/source

2012-02-23 Thread Eike Rathke
oox/inc/oox/helper/propertymap.hxx |2 ++ oox/source/helper/propertymap.cxx | 24 2 files changed, 26 insertions(+) New commits: commit 29b1914fad754ed94e61179f09aac50f1657f2e0 Author: Eike Rathke er...@redhat.com Date: Fri Feb 24 01:03:55 2012 +0100

[Libreoffice-commits] .: src/xlsrecord.py

2012-02-23 Thread Kohei Yoshida
src/xlsrecord.py |8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) New commits: commit 32d8a9f6e45f5ea74ffe3e26f02b02d310b73686 Author: Kohei Yoshida kohei.yosh...@suse.com Date: Thu Feb 23 21:38:37 2012 -0500 Worked a little on dumping AreaFormat. diff --git

[Libreoffice-commits] .: src/xlsrecord.py src/xlsstream.py

2012-02-23 Thread Kohei Yoshida
src/xlsrecord.py | 29 ++--- src/xlsstream.py |4 ++-- 2 files changed, 28 insertions(+), 5 deletions(-) New commits: commit b262254d0ef440a31883faa51f9c61f4e1fead71 Author: Kohei Yoshida kohei.yosh...@suse.com Date: Thu Feb 23 22:39:27 2012 -0500 Dump a

[Libreoffice-commits] .: Branch 'libreoffice-3-5' - 4 commits - libcroco/makefile.mk libxml2/prj libxslt/prj solenv/bin

2012-02-23 Thread Norbert Thiebaud
libcroco/makefile.mk | 11 +-- libxml2/prj/d.lst |2 ++ libxslt/prj/d.lst |5 + solenv/bin/macosx-change-install-names.pl |1 + 4 files changed, 17 insertions(+), 2 deletions(-) New commits: commit

[Libreoffice-commits] .: 10 commits - sc/inc sc/Library_sc.mk sc/source

2012-02-23 Thread Kohei Yoshida
sc/Library_sc.mk |1 sc/inc/dpsave.hxx| 23 ++ sc/inc/dptabsrc.hxx |2 sc/inc/dputil.hxx| 46 + sc/source/core/data/dpobject.cxx |7 sc/source/core/data/dpoutput.cxx | 12 - sc/source/core/data/dpsave.cxx |

[Libreoffice-commits] .: 2 commits - salhelper/source sal/osl

2012-02-23 Thread Stephan Bergmann
sal/osl/unx/thread.c| 70 +--- salhelper/source/thread.cxx | 11 +- 2 files changed, 11 insertions(+), 70 deletions(-) New commits: commit fd7912d0b58c71dd15d23d99aa7b8ca157d2aeb1 Author: Stephan Bergmann sberg...@redhat.com Date: Fri Feb

[Libreoffice-commits] .: fpicker/source

2012-02-23 Thread Stephan Bergmann
fpicker/source/win32/misc/resourceprovider.cxx |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) New commits: commit 9133fd623f2271da92a8a9f905f4c9c61a3de956 Author: Stephan Bergmann sberg...@redhat.com Date: Thu Feb 23 18:03:13 2012 +0100 Rewrite fix to use the same

[PATCH] Fix windows build

2012-02-23 Thread Matúš Kukan
Hi there, I got: c:/git/libo/fpicker/source/win32/misc/resourceprovider.cxx(125) : error C2666: 'SimpleResMgr::SimpleResMgr' : 2 overloads have similar conversions C:/git/libo/solver/wntmsci12.pro/inc\tools/simplerm.hxx(76): could be 'SimpleResMgr::SimpleResMgr(const rtl::OUString

Re: incomplete end of file 3.5 version

2012-02-23 Thread Ravi Sharma
Yes, I reported a bug with a test file. regards, Ravi D. Sharma On Wed, Feb 22, 2012 at 7:32 PM, Eike Rathke er...@redhat.com wrote: Hi ravi, On Wednesday, 2012-02-22 06:48:26 -0800, ravi wrote: So, suggest me, should i register a bug? Yes, please, and attach a smallest possible test

Re: Windows tinderbox on private branch

2012-02-23 Thread Jan Holesovsky
Hi Lionel, On 2012-02-20 at 13:24 +0100, Lionel Elie Mamane wrote: Would it be possible to have a Windows tinderbox build a private branch of mine? It would roughly be libreoffice-3-5 plus most of my commits to master. As we talked on the IRC, I don't really want to load the current Windows

Re: [PATCH][PUSHED] Fix windows build

2012-02-23 Thread Stephan Bergmann
On 02/23/2012 09:04 AM, Matúš Kukan wrote: I got: c:/git/libo/fpicker/source/win32/misc/resourceprovider.cxx(125) : error C2666: 'SimpleResMgr::SimpleResMgr' : 2 overloads have similar conversions C:/git/libo/solver/wntmsci12.pro/inc\tools/simplerm.hxx(76): could be

Re: MinGW-Port: Problems with UnoUrlResolver

2012-02-23 Thread Helmar Spangenberg
Am Mittwoch, 22. Februar 2012, 11:56:13 schrieb Michael Meeks: On Wed, 2012-02-22 at 11:39 +0100, Stephan Bergmann wrote: I doubt that Helmar's application only uses C-based sal API after initial setup. In which case that wrapper would buy you nothing. So - the question would be

Re: Has the time come to get rid of the delivering of public headers?

2012-02-23 Thread Michael Meeks
On Thu, 2012-02-23 at 01:22 +0100, Bjoern Michaelsen wrote: It is neither an anachronism or has something to do with building over the network. Nobody sane did that on Windows anyway Surely that is what Hamburg release engineering did for years :-) But for things like sw or sc, the

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-02-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Noel Power nopo...@novell.com changed: What|Removed |Added Depends on||46498 --- Comment #197

RE: Visual Studio cppu::bootstrap exception on 3.5.

2012-02-23 Thread Martin Thoma
Thanks for your reply. On 02/22/2012 12:13 PM, Martin Thoma wrote: To exclude errors in our application, we created a new project and inserted the source from /sdk/examples/DevelopersGuide/ProfUNO/SimpleBootstrap_cpp/SimpleBootstrap_ cp p.cxx = this works fine in LO 3.4.5., but

RE: Visual Studio cppu::bootstrap exception on 3.5.

2012-02-23 Thread Martin Thoma
In the past, if we did something wrong here, there was a could not include file or DLL not found error, but now everything compiles without warnings or errors (so the headers should be ok) and the DLLs are found and loaded correctly as well. I do not exclude that we made something

Re: [Libreoffice-commits] .:

2012-02-23 Thread Thomas Arnhold
Thanks for fixing it :) On 02/22/2012 02:43 PM, Lubos Lunak wrote: On Tuesday 21 of February 2012, Stephan Bergmann wrote: On 02/21/2012 08:57 PM, Thomas Arnhold wrote: commit 45ad6029e1422c659e627bb30ecda50ccb61060c ... @@ -174,12 +174,7 @@ static sal_Bool lcl_IsLess( const ScDPDataMember*

build 3.5 source on windows got error

2012-02-23 Thread 胡其图
when I build 3.5.0.3 source on windows, and stop in wizards model and got some errors like this libreoffice-core-3.5.0.3\wizards\com\sun\star\wizards\common\Desktop.java:32: 软件包(package) com.sun.star.beans 不存在(does not exits)

build 3.5 source on windows got error

2012-02-23 Thread 胡其图
when I build 3.5.0.3 source on windows, and stop in wizards model and got some errors like thislibreoffice-core-3.5.0.3\wizards\com\sun\star\wizards\common\Desktop.java:32: 软件包(package) com.sun.star.beans 不存在(does not

const*const - what is the purpose of this?

2012-02-23 Thread Noel Grandin
Hi I'm seeing declarations like this scattered around the SW module: e.g. in sw/inc/swtable.hxx at line 301 static SwTable * FindTable( SwFrmFmt const*const pFmt ); As far as I can tell from my limited C++ knowledge, this is the same as the more common definition: static SwTable *

Re: [PATCH][PUSHED] Fix windows build

2012-02-23 Thread Stephan Bergmann
On 02/23/2012 10:56 AM, Stephan Bergmann wrote: On 02/23/2012 09:04 AM, Matúš Kukan wrote: I got: c:/git/libo/fpicker/source/win32/misc/resourceprovider.cxx(125) : error C2666: 'SimpleResMgr::SimpleResMgr' : 2 overloads have similar conversions

Re: const*const - what is the purpose of this?

2012-02-23 Thread Jesús Corrius
On Thu, Feb 23, 2012 at 9:04 AM, Noel Grandin n...@peralex.com wrote: Hi I'm seeing declarations like this scattered around the SW module: e.g. in sw/inc/swtable.hxx at line 301  static SwTable * FindTable( SwFrmFmt const*const pFmt ); As far as I can tell from my limited C++ knowledge,

Re: Has the time come to get rid of the delivering of public headers?

2012-02-23 Thread Bjoern Michaelsen
On Thu, Feb 23, 2012 at 10:07:21AM +, Michael Meeks wrote: But for things like sw or sc, the lack of encapsulation and the need to include 75% of all the public headers in each and every compile (e.g. via sw/inc/doc.hxx) and reparse those are a real killer. Ok - so, at least

Re: [PUSHED][EasyHack] #44681 port to CLucene from java/Lucene

2012-02-23 Thread Caolán McNamara
On Tue, 2012-02-21 at 10:21 +0100, G.H.M.Valkenhoef, van wrote: Great to hear that it works that it will make it into master :-). Any thoughts on this one: 3) When creating the CLucene FileReader (HelpIndexer.cxx), the path is converted to plain ASCII, that's probably dangerous. There is

Re: build 3.5 source on windows got error

2012-02-23 Thread Michael Meeks
Hi there, On Thu, 2012-02-23 at 10:43 +0800, huqitu du wrote: when I build 3.5.0.3 source on windows, and stop in wizards model and got some errors like this libreoffice-core-3.5.0.3\wizards\com\sun\star\wizards\common \Desktop.java:32: 软件包(package) com.sun.star.beans 不存在(does not exits)

[REVIEW 3-5] frame duplication regressions fdo#40599 fdo#46482 plus fix anchor handling in SwXText::convertToTextFrame()

2012-02-23 Thread Michael Stahl
On 20/02/12 10:47, Miklos Vajna wrote: Hi, See http://cgit.freedesktop.org/libreoffice/core/commit/?id=9592f56323de27f9e1d890ee6259a5f4f328cbd3 It's an issue in the Writer UNO API, so it affects at least docx and RTF import, an RTF reproducer is attached. If some importer already worked

Re: Has the time come to get rid of the delivering of public headers?

2012-02-23 Thread Michael Meeks
On Thu, 2012-02-23 at 11:24 +0100, Bjoern Michaelsen wrote: Fixing the root problem might involve a git hook that gives you an angry stare for 30 seconds everytime you add more lines to a 1.5KLOC hxx than you remove from it. Heh ;-) IMHO a weighted stare-length based on how many times

Re: [PATCH][PUSHED] Fix windows build

2012-02-23 Thread Michael Meeks
On Thu, 2012-02-23 at 10:56 +0100, Stephan Bergmann wrote: Yes, fix should be good. With the newly added rtl::OUString ctor, a string literal can now implicitly be converted to an rtl::OUString, which can lead to ambiguities. In this case, SimpleResMgr has ctors that take either a char

Re: MinGW-Port: Problems with UnoUrlResolver

2012-02-23 Thread Michael Meeks
On Thu, 2012-02-23 at 11:07 +0100, Helmar Spangenberg wrote: In the meantime I am a step further - having found some very annoying things: The recent MinGW cross tool chain supplied for SuSE 12.1 (64bit) seems to be broken - at least with regards to the LibreOffice code. Are you not

Re: Has the time come to get rid of the delivering of public headers?

2012-02-23 Thread Bjoern Michaelsen
On Thu, Feb 23, 2012 at 11:14:03AM +, Michael Meeks wrote: I guess we'd want to encourage someone to take over from August on the include-what-you-use front, but - that seems to suggest adding more includes to compiling code so ... ;-) ... and then the next step is to slice-and-dice

Re: Has the time come to get rid of the delivering of public headers?

2012-02-23 Thread Michael Meeks
On Thu, 2012-02-23 at 12:30 +0100, Bjoern Michaelsen wrote: ... and then the next step is to slice-and-dice god-objects like SwDoc in small little one object, one job parts so that some part of code concerning page layout doesnt have to care about how fields are maanged (and reparse all

Re: MinGW-Port: Problems with UnoUrlResolver

2012-02-23 Thread Michael Stahl
On 23/02/12 11:07, Helmar Spangenberg wrote: What came to my mind: Since I moved the LibreOffice directories, could it be possible that I have to adjust one or more ini-files? Furthermore, which environment variables are used setting up the local context? Until now I did some experiments

Re: const*const - what is the purpose of this?

2012-02-23 Thread Stephan Bergmann
On 02/23/2012 11:23 AM, Jesús Corrius wrote: On Thu, Feb 23, 2012 at 9:04 AM, Noel Grandinn...@peralex.com wrote: I'm seeing declarations like this scattered around the SW module: e.g. in sw/inc/swtable.hxx at line 301 static SwTable * FindTable( SwFrmFmt const*const pFmt ); As far as I

Re: const*const - what is the purpose of this?

2012-02-23 Thread Michael Stahl
On 23/02/12 13:15, Stephan Bergmann wrote: On 02/23/2012 11:23 AM, Jesús Corrius wrote: On Thu, Feb 23, 2012 at 9:04 AM, Noel Grandinn...@peralex.com wrote: I'm seeing declarations like this scattered around the SW module: e.g. in sw/inc/swtable.hxx at line 301 static SwTable * FindTable(

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-02-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Noel Power nopo...@novell.com changed: What|Removed |Added Depends on||46165 --- Comment #198

[PUSHED] Fix cppcheck possible null dereference in ScMyCellInfo::CreateCell.

2012-02-23 Thread Michael Meeks
Hi there, On Wed, 2012-02-22 at 21:16 +0100, Catalin Iacob wrote: It's safe to remove the check since CreateCell is only called by CreateContentAction, CreateGeneratedActions and SetDependencies in the same file and those in turn are only called by CreateChangeTrack only if pDoc is not NULL.

[REVIEW 3-4.3-5, 3-5-1] fdo#46165

2012-02-23 Thread Noel Power
don't know if it is too late for libreoffice-3-5-1 or not :-) But... in anycase it seems my previous patch http://cgit.freedesktop.org/libreoffice/components/commit/?h=libreoffice-3-4id=ab802aee181ca6df397ca53e461d5f53808cef9d

[REVIEWED] Remove unused code

2012-02-23 Thread Michael Meeks
On Wed, 2012-02-22 at 22:06 +0100, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy That is most odd; I wouldn't expect unusedcode.easy to list virtual methods, particularly ones (possibly?) required to implement XComponent: // XComponent -

Re: const*const - what is the purpose of this?

2012-02-23 Thread Lubos Lunak
On Thursday 23 of February 2012, Noel Grandin wrote: Hi I'm seeing declarations like this scattered around the SW module: e.g. in sw/inc/swtable.hxx at line 301 static SwTable * FindTable( SwFrmFmt const*const pFmt ); As far as I can tell from my limited C++ knowledge, this is the same

Re: [PATCH][PUSHED] Fix windows build

2012-02-23 Thread Lubos Lunak
On Thursday 23 of February 2012, Stephan Bergmann wrote: On 02/23/2012 10:56 AM, Stephan Bergmann wrote: On 02/23/2012 09:04 AM, Matúš Kukan wrote: The patch helped me to build on Windows but I did not push because I don't know what really was the problem, how my change helped to solve

Re: [PUSHED][REVIEWED] Remove unused code

2012-02-23 Thread Caolán McNamara
On Thu, 2012-02-23 at 13:03 +, Michael Meeks wrote: Any thoughts Caolan ? callcatcher is right, this is a *pure* virtual, i.e. the = 0 of virtual void dispose() = 0; Everything that inherits from it has to implement a ::dispose so there's a virtual method slot created for dispose and

Re: MinGW-Port: Problems with UnoUrlResolver

2012-02-23 Thread Helmar Spangenberg
Am Donnerstag, 23. Februar 2012, 11:24:00 schrieb Michael Meeks: On Thu, 2012-02-23 at 11:07 +0100, Helmar Spangenberg wrote: In the meantime I am a step further - having found some very annoying things: The recent MinGW cross tool chain supplied for SuSE 12.1 (64bit) seems to be broken -

Re: .: 14 commits - binaryurp/source comphelper/inc comphelper/Library_comphelp.mk comphelper/prj comphelper/source configmgr/source cui/Library_cui.mk cui/prj cui/source dbaccess/source desktop/Libra

2012-02-23 Thread Michael Stahl
hi Stephan, On 23/02/12 10:48, Stephan Bergmann wrote: +void salhelper::Thread::launch() { +SAL_INFO(salhelper.thread, launch name_); +// Assumption is that osl::Thread::create returns normally iff it causes +// osl::Thread::run to start executing: looks like this assumption

Re: MinGW-Port: Problems with UnoUrlResolver

2012-02-23 Thread Helmar Spangenberg
Am Donnerstag, 23. Februar 2012, 14:48:14 schrieb Helmar Spangenberg: Are you not using Fridrich's toolchain / bits from here: https://build.opensuse.org/project/show?project=windows%3Amingw%3Awin32 All the best, Michael. Ah - I did not know about that URL

Re: [PATCH] Replace make_absolute_path with rel2abs in solenv

2012-02-23 Thread Caolán McNamara
On Sun, 2012-02-19 at 14:39 +, Tim Retout wrote: These three patches remove some home-grown path manipulation from solenv, and replace it with functions shipped with the Perl core. Sorry, I had revert part of this because under windows we were no longer getting any install sets generated.

Re: const*const - what is the purpose of this?

2012-02-23 Thread Noel Grandin
Thanks for the link, but that doesn't explain the usage. As I read it, the FindTable declaration means that the data-structure pointed to is read-only, and that the pointer value itself is also read-only. But making a pointer value read-only is something only useful to the internals of a

Fwd: LOADays 2012

2012-02-23 Thread Florian Effenberger
Hello, unfortunately, I won't find time, so I forward it with approval of Toshaan. Should someone of you be interested, ping him directly. Thanks, Florian Original Message Subject:LOADays 2012 Date: Tue, 21 Feb 2012 02:15:56 +0100 From: Toshaan Bharvani

windows build error in NeonLockStore because of salhelper::Thread

2012-02-23 Thread Noel Grandin
Hi Seeing the error below - anybody have any ideas? Regards, Noel Grandin $ make ucb cd ucb /opt/lo/bin/make -j 8 -rs gb_PARTIALBUILD=T /cygdrive/e/libo/ucb/StaticLibrary_odma_lib.mk:37: [ WARN ] !!! [ WARN ] !!! ucb/source/ucp/odma/odma_lib is linked in by Library/iucpodma1.lib

how do I fix messages held for approval?

2012-02-23 Thread Noel Grandin
Hi All of my messages from my n...@peralex.com account are being held for approval. My noelgran...@gmail.com account does not seem to have this problem. Is there something I can do to fix this? (given that I'm +- 5 metres away from the guy administering our email). Regards, Noel Grandin

[REVIEWED 3-4.3-5, 3-5-1] fdo#46165

2012-02-23 Thread Michael Meeks
On Thu, 2012-02-23 at 13:03 +, Noel Power wrote: don't know if it is too late for libreoffice-3-5-1 or not :-) But... in anycase it seems my previous patch ... I have reverted my attempt and ported the patch. I tested the samples from fdo#38441 and fdo#46165 and all are working

Re: [PATCH][PUSHED] Fix windows build

2012-02-23 Thread Stephan Bergmann
On 02/23/2012 12:22 PM, Michael Meeks wrote: On Thu, 2012-02-23 at 10:56 +0100, Stephan Bergmann wrote: Yes, fix should be good. With the newly added rtl::OUString ctor, a string literal can now implicitly be converted to an rtl::OUString, which can lead to ambiguities. In this case,

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-02-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 46165, which changed state. Bug 46165 Summary: getDataArray fails in LO 3.4.4, 3.4.5, 3.5.0 https://bugs.freedesktop.org/show_bug.cgi?id=46165 What|Old Value |New Value

Re: About fdo#46339 Query Wizard fails to open, (post fdo#42543 fix?)

2012-02-23 Thread Caolán McNamara
On Wed, 2012-02-22 at 14:09 -0800, julien2412 wrote: Hello, I took a look on this bug and let some comments. Now I propose 2 ways (which are quite the same) to solve it here : https://bugs.freedesktop.org/show_bug.cgi?id=46339#c6 I tested, just made the Wizard Query window appear (not

Re: [PUSHED][REVIEW 3-5] frame duplication regressions fdo#40599 fdo#46482 plus fix anchor handling in SwXText::convertToTextFrame()

2012-02-23 Thread Caolán McNamara
On Thu, 2012-02-23 at 12:01 +0100, Michael Stahl wrote: i've found 2 (relatively obscure, i actually found fdo#46482 myself) regressions that have the same root cause which is a change in SwDoc::CopyFlyInFlyImpl for OOo 3.2, and so i would propose to backport all 3 patches together to

Re: [REVIEWED] glib needed only when enable_librsvg, gettext only when enable_librsvg or cross-compile

2012-02-23 Thread Korrawit Pruegsanusak
Hello Michael, [re-adding the list in cc, sorry for missing] On Tue, Feb 21, 2012 at 22:20, Michael Meeks michael.me...@suse.com wrote: On Tue, 2012-02-21 at 21:32 +0700, Korrawit Pruegsanusak wrote:        I don't think you need to worry about that in scp2; your patch looks fine. Can you

-std=c++0x vs -std=gnu++0x

2012-02-23 Thread Lubos Lunak
Hello, commit 437fe5a11f68d1848c49121394f16f09611b made me notice that we actually build with -std=c++0x and not -std=gnu++0x, which I think would make more sense and be consistent with the case when we do not build in C++0x mode. If you look at the gcc manpage for the description of

Re: [Unfinished Patch] List of bookmarks in the file picker

2012-02-23 Thread Cedric Bosdonnat
Hello Martin, It's good to see some news from you here on the mailing-list :) On Thu, 2012-02-23 at 16:35 +0100, Martin Richard wrote: We have been able to do most of the work, but unfortunately we're now lacking time, so I send the patch without the latest modifications we wanted to do in

Re: About fdo#46339 Query Wizard fails to open, (post fdo#42543 fix?)

2012-02-23 Thread Jan Holesovsky
Hi Caolán, Julien, On 2012-02-23 at 15:10 +, Caolán McNamara wrote: https://bugs.freedesktop.org/show_bug.cgi?id=46339#c6 I tested, just made the Wizard Query window appear (not more), both worked. I don't know which solution is good or perhaps both are wrong and it should be

Re: [PATCH] Replace make_absolute_path with rel2abs in solenv

2012-02-23 Thread Michael Meeks
On Thu, 2012-02-23 at 14:37 +, Caolán McNamara wrote: On Sun, 2012-02-19 at 14:39 +, Tim Retout wrote: These three patches remove some home-grown path manipulation from solenv, and replace it with functions shipped with the Perl core. Sorry, I had revert part of this because under

Re: windows build error in NeonLockStore because of salhelper::Thread

2012-02-23 Thread Stephan Bergmann
On 02/23/2012 02:46 PM, Noel Grandin wrote: $ make ucb cd ucb /opt/lo/bin/make -j 8 -rs gb_PARTIALBUILD=T /cygdrive/e/libo/ucb/StaticLibrary_odma_lib.mk:37: [ WARN ] !!! [ WARN ] !!! ucb/source/ucp/odma/odma_lib is linked in by Library/iucpodma1.lib StaticLibrary/odma_lib.lib [ WARN ] !!! [

minutes of ESC call ...

2012-02-23 Thread Michael Meeks
* Present: + Lionel, Norbert, Andras, David, Christian, Michael, Eike, Kendy, Stephan, Bjoern, Caolan, Markus, Rainer, Petr, Thorsten * Completed Action Items + finding a better way for JRE warning disable in 3.5.1 if possible (Stephan) + find eager

Re: About fdo#46339 Query Wizard fails to open, (post fdo#42543 fix?)

2012-02-23 Thread julien2412
Thank you Jan and Caolan, I'll commit+push it on master tonight after my day work. What about 3.5 ? Is it ok to push it too ? Julien. -- View this message in context: http://nabble.documentfoundation.org/About-fdo-46339-Query-Wizard-fails-to-open-tp3768030p3770252.html Sent from the Dev

Re: -std=c++0x vs -std=gnu++0x

2012-02-23 Thread Stephan Bergmann
On 02/23/2012 05:08 PM, Lubos Lunak wrote: commit 437fe5a11f68d1848c49121394f16f09611b made me notice that we actually build with -std=c++0x and not -std=gnu++0x, which I think would make more sense and be consistent with the case when we do not build in C++0x mode. If you look at the

Re: [PATCH] Replace make_absolute_path with rel2abs in solenv

2012-02-23 Thread Tim Retout
On 23 February 2012 14:37, Caolán McNamara caol...@redhat.com wrote: On Sun, 2012-02-19 at 14:39 +, Tim Retout wrote: These three patches remove some home-grown path manipulation from solenv, and replace it with functions shipped with the Perl core. Sorry, I had revert part of this

Re: [PATCH] glib needed only when enable_librsvg, gettext only when enable_librsvg or cross-compile

2012-02-23 Thread Tor Lillqvist
But I don't know how to check for cross-compiling for 'gettext', or is it related at all? I think it was so that gettext is needed by cross_toolset because gettext is needed by glib and glib-genmarshal (as a *build* platform binary) is needed when building glib (for the *host* platform). Hmm.

Re: About fdo#46339 Query Wizard fails to open, (post fdo#42543 fix?)

2012-02-23 Thread Caolán McNamara
On Thu, 2012-02-23 at 08:35 -0800, julien2412 wrote: Thank you Jan and Caolan, I'll commit+push it on master tonight after my day work. What about 3.5 ? Is it ok to push it too ? Push it to master and I'll cherry-pick it for 3-5 C. ___

  1   2   3   4   >