Re: Gerrit: mark patches as waiting for review

2017-01-03 Thread Khaled Hosny
On Tue, Jan 03, 2017 at 11:11:04AM +0100, Bjoern Michaelsen wrote: > Hi, > > On Tue, Jan 03, 2017 at 11:04:59AM +0100, Bjoern Michaelsen wrote: > > As discussed in the other mail: > > > > > > https://gerrit.libreoffice.org/#/q/status:open+-label:Code-Review%253E1+-ownerin:Committers > > > >

[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - vcl/win

2017-01-02 Thread Khaled Hosny
vcl/win/gdi/salfont.cxx | 110 ++-- 1 file changed, 61 insertions(+), 49 deletions(-) New commits: commit f420f4c2e84deb182e4f675c1a0d45bede110ff2 Author: Khaled Hosny <khaledho...@eglug.org> Date: Sun Jan 1 19:44:25 2017 + Rever

[Libreoffice-commits] core.git: vcl/inc vcl/win

2017-01-01 Thread Khaled Hosny
Author: Khaled Hosny <khaledho...@eglug.org> Date: Sun Jan 1 22:20:22 2017 +0200 The mfFontScale[n] is always 1.0 Change-Id: Ica2e67632f5bfe1f70ba7b2d7502257b47d053ce Reviewed-on: https://gerrit.libreoffice.org/32592 Tested-by: Jenkins <c...@libreoffice.org>

[Libreoffice-commits] core.git: vcl/source

2017-01-01 Thread Khaled Hosny
vcl/source/font/PhysicalFontCollection.cxx |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) New commits: commit 7633cbb0e84d20a36b2972c6fd5c0d5a5d6280a3 Author: Khaled Hosny <khaledho...@eglug.org> Date: Sun Jan 1 18:10:09 2017 +0200 Use FindMetricCompatibleFont(

Re: Need help for building

2017-01-01 Thread Khaled Hosny
On Sun, Jan 01, 2017 at 03:06:05PM +0100, Regina Henschel wrote: > Hi Mike, > > Kaganski Mike schrieb: > > On 12/31/2016 3:59 PM, Regina Henschel wrote: > > > my last build was in August. Now I tried a new build, but it fails. I > > > have started with > > > git pull -r > > > > I may remember

[Libreoffice-commits] core.git: vcl/inc vcl/unx

2016-12-30 Thread Khaled Hosny
/genpspgraphics.cxx |3 -- 5 files changed, 10 insertions(+), 45 deletions(-) New commits: commit f2a5e6dc8f9c79b31ca1044fac8caa0130205e3c Author: Khaled Hosny <khaledho...@eglug.org> Date: Fri Dec 30 11:02:18 2016 +0200 Get rid of GlyphMetric class All we need is Rectang

[Libreoffice-commits] core.git: vcl/source

2016-12-30 Thread Khaled Hosny
vcl/source/helper/canvastools.cxx |8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) New commits: commit f28d9aaea39f9a2b50c6b9ae36c466771ab72a92 Author: Khaled Hosny <khaledho...@eglug.org> Date: Fri Dec 30 02:04:47 2016 +0200 Use existing basegfx::fround()

[Libreoffice-commits] core.git: 3 commits - vcl/inc vcl/unx

2016-12-29 Thread Khaled Hosny
deletions(-) New commits: commit a7c51323b7343f82b5aea6098f5d5e31a8bad0e9 Author: Khaled Hosny <khaledho...@eglug.org> Date: Thu Dec 29 22:15:01 2016 +0200 Drop check for ancient FontConfig releases FontConfig 2.4.1 that fixes this bug was released 10 years ago. Cha

[Libreoffice-commits] core.git: svl/source

2016-12-25 Thread Khaled Hosny
svl/source/config/ctloptions.cxx | 39 +-- 1 file changed, 1 insertion(+), 38 deletions(-) New commits: commit 23b92427e3c77fa8d04679ddcaf2dbd3e3580c5d Author: Khaled Hosny <khaledho...@eglug.org> Date: Thu Dec 22 23:12:14 2016 +0200 Enable “c

[Libreoffice-commits] core.git: cui/uiconfig

2016-12-24 Thread Khaled Hosny
cui/uiconfig/ui/optlanguagespage.ui |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 466e59d015826c0b60b1e4d3811192c39f9d191d Author: Khaled Hosny <khaledho...@eglug.org> Date: Thu Dec 22 17:14:04 2016 +0200 Remove another user-visible “CTL”

[Libreoffice-commits] core.git: vcl/source

2016-12-24 Thread Khaled Hosny
vcl/source/font/PhysicalFontCollection.cxx | 35 ++--- 1 file changed, 32 insertions(+), 3 deletions(-) New commits: commit f16d17df9d33ad96d053abe2d9212b0c2850c19f Author: Khaled Hosny <khaledho...@eglug.org> Date: Wed Dec 21 20:16:14 2016 +0200 Make sure

[Libreoffice-commits] core.git: vcl/unx

2016-12-23 Thread Khaled Hosny
vcl/unx/generic/print/genprnpsp.cxx | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) New commits: commit 6aa482428ec301cfe45672d38b038fc92de7c4a7 Author: Khaled Hosny <khaledho...@eglug.org> Date: Fri Dec 23 18:46:01 2016 +0200 Make these SAL_INFO’s a bit more

Re: Crash test update

2016-12-23 Thread Khaled Hosny
Can some decipher these emails? They are pretty cryptic and refer to a URL that does not tell much as well and the crashlog.txt file there is always empty. Should I just ignore them and assume that people who know what this is are already taking care of it? On Fri, Dec 23, 2016 at 04:18:27PM

Re: Build Fail

2016-12-23 Thread Khaled Hosny
On Fri, Dec 23, 2016 at 08:33:29PM +0530, Tamsil Amani wrote: > I was trying to fix an easyhack #32347 and submitted a patch in which I > made changes only in the strings thus no logical changes were made to the > code. > The build completed successfully on my system (Ubuntu 16.04LTS) however it >

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - vcl/source

2016-12-22 Thread Khaled Hosny
vcl/source/gdi/CommonSalLayout.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit f804c7d0d36997db6bbbcb3b5619adf3f0064d1e Author: Khaled Hosny <khaledho...@eglug.org> Date: Thu Dec 22 20:31:39 2016 +0200 Fix glyph Y offset Typ

[Libreoffice-commits] core.git: vcl/source

2016-12-22 Thread Khaled Hosny
vcl/source/gdi/CommonSalLayout.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 3f4263f2a3725895a4b761ac483070d60d71631c Author: Khaled Hosny <khaledho...@eglug.org> Date: Thu Dec 22 20:31:39 2016 +0200 Fix glyph Y offset Typ

Re: [Libreoffice-commits] core.git: Take advantage of Unicode, people

2016-12-22 Thread Khaled Hosny
On Thu, Dec 22, 2016 at 10:42:09AM +0100, Stephan Bergmann wrote: > For one, breaks tests. Please fix ASAP. Also the original string used single quote while the new one is using double quotes, if this is intestinal then it needs better rationale than what the commit message provides. > For

[Libreoffice-commits] core.git: chart2/qa

2016-12-21 Thread Khaled Hosny
| 64 - chart2/qa/extras/xshape/data/reference/tdf90839-4.xml | 64 - 5 files changed, 575 insertions(+), 575 deletions(-) New commits: commit 8960d05164f0ec097c1c4a1a3c4795230479f5d1 Author: Khaled Hosny <khaledho...@eglug.org> Date: Tue Dec 20 19:07:56 2016 +0200 Re

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - vcl/win

2016-12-21 Thread Khaled Hosny
vcl/win/gdi/salfont.cxx | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) New commits: commit 064773ecc3bfba37c80c2f9c6fccde35395a57c0 Author: Khaled Hosny <khaledho...@eglug.org> Date: Tue Dec 20 23:35:28 2016 +0200 tdf#104733: Don't ignore OpenType-CFF fons on W

[Libreoffice-commits] core.git: vcl/win

2016-12-20 Thread Khaled Hosny
vcl/win/gdi/salfont.cxx |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) New commits: commit 72002992a3c5213882fa4d60c7cd8fab10f0b009 Author: Khaled Hosny <khaledho...@eglug.org> Date: Tue Dec 20 23:35:28 2016 +0200 tdf#104733: Don't ignore OpenType-CFF fons on W

Re: Smoketest failure

2016-12-20 Thread Khaled Hosny
On Mon, Dec 12, 2016 at 08:29:42AM +0200, Khaled Hosny wrote: > On Mon, Dec 12, 2016 at 01:30:55AM +0200, Khaled Hosny wrote: > > I had the same failure also with --enable-debug. I tried to follow the > > instructions in smoketest/README to debug this failure, but opining

[Libreoffice-commits] core.git: smoketest/CppunitTest_smoketest.mk

2016-12-20 Thread Khaled Hosny
smoketest/CppunitTest_smoketest.mk |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit 574524604cfd73c25f3a95d2d09205e8e665082a Author: Khaled Hosny <khaledho...@eglug.org> Date: Tue Dec 20 19:18:36 2016 +0200 Fix smoketest under right-to-left l

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - vcl/source

2016-12-20 Thread Khaled Hosny
vcl/source/gdi/CommonSalLayout.cxx |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) New commits: commit 5e63617ef934d3602bbc22f0f01c77b024347e60 Author: Khaled Hosny <khaledho...@eglug.org> Date: Tue Dec 20 01:36:34 2016 +0200 tdf#103765: Round positions i

[Libreoffice-commits] core.git: vcl/source

2016-12-19 Thread Khaled Hosny
vcl/source/gdi/CommonSalLayout.cxx |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) New commits: commit 9eb4b14ffa57cd7bbdf0fc43096f5f1e65c8e388 Author: Khaled Hosny <khaledho...@eglug.org> Date: Tue Dec 20 01:36:34 2016 +0200 tdf#103765: Round positions i

Re: About Python version

2016-12-17 Thread Khaled Hosny
On Sat, Dec 17, 2016 at 04:22:53PM +0100, jan iversen wrote: > > So I wonder what Python version should be used for LO master sources? > > I used --enable-python=internal but my config.log displays some 2.7 ref, see > > https://bugs.documentfoundation.org/show_bug.cgi?id=103363#c15 > > > I had

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - vcl/source vcl/win

2016-12-16 Thread Khaled Hosny
vcl/source/gdi/CommonSalLayout.cxx |5 - vcl/win/gdi/winlayout.cxx | 16 +--- 2 files changed, 9 insertions(+), 12 deletions(-) New commits: commit a813623240ac9614c8b2b8b890b9eb83663c72c1 Author: Khaled Hosny <khaledho...@eglug.org> Date: Fri Dec 16 09

Re: [libreoffice-l10n] Re: Getting rid of 'oldref' in the help files

2016-12-16 Thread Khaled Hosny
On Fri, Dec 16, 2016 at 05:51:41PM +0100, khagaroth wrote: > > there are many ways how to describe the same thing in html ('s and 's > > vs. and vs. 's with css vs. who-knows-what) > > CSS is the preferred way, its the same as with styles and direct formatting > in Writer. CSS is preferred for

[Libreoffice-commits] core.git: vcl/source vcl/win

2016-12-16 Thread Khaled Hosny
vcl/source/gdi/CommonSalLayout.cxx |3 ++- vcl/win/gdi/winlayout.cxx | 16 +--- 2 files changed, 7 insertions(+), 12 deletions(-) New commits: commit ab291ac3b8576a086cab60ffb64d60b046a271a2 Author: Khaled Hosny <khaledho...@eglug.org> Date: Fri Dec 16 09:16:2

[Libreoffice-commits] core.git: vcl/source

2016-12-16 Thread Khaled Hosny
vcl/source/gdi/CommonSalLayout.cxx | 45 + 1 file changed, 12 insertions(+), 33 deletions(-) New commits: commit 0c49ab77067413901f8e2956fbdbc45671384b73 Author: Khaled Hosny <khaledho...@eglug.org> Date: Wed Dec 14 17:51:33 2016 +0200 Si

[Libreoffice-commits] core.git: vcl/win

2016-12-15 Thread Khaled Hosny
vcl/win/gdi/winlayout.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 1fbfe5cbc288ead6bba9d30ddb849dcb41a0d5e0 Author: Khaled Hosny <khaledho...@eglug.org> Date: Fri Dec 16 08:54:45 2016 +0200 Fix typo from 6c436ba09cb35235ce6f4065cf74c9a6ff

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - vcl/inc vcl/source vcl/win

2016-12-15 Thread Khaled Hosny
deletions(-) New commits: commit d85003a8af8b454b34eea0ac67c8dd9184a0b6d3 Author: Khaled Hosny <khaledho...@eglug.org> Date: Thu Dec 15 02:47:13 2016 +0200 tdf#104159: Re-enable OpenGL glyph caching on Windows Reviewed-on: https://gerrit.libreoffice.org/32026 Tested-by: J

[Libreoffice-commits] core.git: vcl/inc vcl/source vcl/win

2016-12-15 Thread Khaled Hosny
9cf20b5f0473db0b4dd2dcf607b7884f40762995 Author: Khaled Hosny <khaledho...@eglug.org> Date: Thu Dec 15 02:47:13 2016 +0200 tdf#104159: Re-enable OpenGL glyph caching on Windows Change-Id: Icafec05a8cf4428d806efcb286addf3042fcf021 Reviewed-on: https://gerrit.libreoffice.org/32026 Tested-by: Jenk

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - vcl/win

2016-12-15 Thread Khaled Hosny
vcl/win/gdi/salfont.cxx | 48 ++-- 1 file changed, 42 insertions(+), 6 deletions(-) New commits: commit 641b3461dd57b73807f7f55fa2d9b08fb777ed20 Author: Khaled Hosny <khaledho...@eglug.org> Date: Thu Dec 15 17:17:17 2016 +0200 tdf#10453

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - vcl/win

2016-12-15 Thread Khaled Hosny
vcl/win/gdi/salfont.cxx | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) New commits: commit fcbbd6089da7e60bf616041517a2aee3017ae448 Author: Khaled Hosny <khaledho...@eglug.org> Date: Thu Dec 15 09:59:59 2016 +0200 tdf#103514: Try harder to ignore non-SFNT

[Libreoffice-commits] core.git: vcl/win

2016-12-15 Thread Khaled Hosny
vcl/win/gdi/salfont.cxx | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) New commits: commit ef4b9032de55e6b1b182e4ead1bbe6e590df296e Author: Khaled Hosny <khaledho...@eglug.org> Date: Thu Dec 15 09:59:59 2016 +0200 tdf#103514: Try harder to ignore non-SFNT

[Libreoffice-commits] core.git: vcl/source

2016-12-13 Thread Khaled Hosny
vcl/source/outdev/text.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 24ece87ed4ce14cd14c26d4fb6c2e7f7e8f24b80 Author: Khaled Hosny <khaledho...@eglug.org> Date: Wed Dec 14 05:55:50 2016 +0200 Typo Cha

[Libreoffice-commits] core.git: canvas/source drawinglayer/source include/vcl vcl/source

2016-12-13 Thread Khaled Hosny
| 259 --- 5 files changed, 5 insertions(+), 259 deletions(-) New commits: commit d538d3d84172a74dfe97d59a6d3daf9a45459cab Author: Khaled Hosny <khaledho...@eglug.org> Date: Mon Dec 12 15:00:05 2016 +0200 This fallback code makes no sense any more Ito pr

[Libreoffice-commits] core.git: vcl/quartz

2016-12-12 Thread Khaled Hosny
vcl/quartz/ctfonts.cxx | 13 + 1 file changed, 13 insertions(+) New commits: commit 04a77bfa9c5a3da6d99ee6ad8d4802638b7d76fa Author: Khaled Hosny <khaledho...@eglug.org> Date: Mon Dec 12 14:51:32 2016 +0200 Don’t return false for blank

Re: Smoketest failure

2016-12-11 Thread Khaled Hosny
On Mon, Dec 12, 2016 at 01:30:55AM +0200, Khaled Hosny wrote: > I had the same failure also with --enable-debug. I tried to follow the > instructions in smoketest/README to debug this failure, but opining > workdir/Zip/smoketestdoc.sxw and clicking on “start smoketest” (or any of &g

Smoketest failure

2016-12-11 Thread Khaled Hosny
I’m trying to get into the habit of running make check before pushing changes out (I got used to not doing even make because I always had test failures). Long story short, all is fine now except for one failure in smoketest: (anonymous namespace)::Test::test finished in: 75133ms

[Libreoffice-commits] core.git: drawinglayer/source editeng/source include/vcl vcl/source

2016-12-10 Thread Khaled Hosny
|2 10 files changed, 11 insertions(+), 60 deletions(-) New commits: commit 9db5cfc889403e923a41dc88b07d0c973d227552 Author: Khaled Hosny <khaledho...@eglug.org> Date: Thu Dec 8 07:17:00 2016 +0200 Drop ComplexDisabled flags that does n

[Libreoffice-commits] core.git: vcl/source

2016-12-10 Thread Khaled Hosny
vcl/source/gdi/pdfwriter_impl.cxx | 12 1 file changed, 12 deletions(-) New commits: commit d5e7e817980bfce29196dc55a20270201f77c673 Author: Khaled Hosny <khaledho...@eglug.org> Date: Thu Dec 8 07:04:27 2016 +0200 Drop a hack for Type 1, the future i

Re: [Libreoffice-qa] minutes of ESC call ...

2016-12-10 Thread Khaled Hosny
On Thu, Dec 08, 2016 at 04:56:07PM +, Michael Meeks wrote: > + who else needs a Mac ? ... answers on a post-card. I think I can make use of one, if it can get here easily. I currently use the same Mac laptop for both Linux and Mac development, not the most productive setup.

[Libreoffice-commits] core.git: vcl/inc vcl/source

2016-12-10 Thread Khaled Hosny
files changed, 11 insertions(+), 18 deletions(-) New commits: commit 869368e94dcfe393b0d06b1c1de18b5ce0d08d3d Author: Khaled Hosny <khaledho...@eglug.org> Date: Thu Dec 8 07:00:02 2016 +0200 Drop SalLayout::IsSpacingGlyph() Replace it with a check from ICU that actually makes

Re: [Libreoffice-qa] Minutes of the Design Hangout: 2016-Dec-08

2016-12-10 Thread Khaled Hosny
On Thu, Dec 08, 2016 at 12:47:30PM +0100, 'Heiko Tietze' via Khaled Hosny wrote: > Present: Kendy, Samuel, Heiko > > Tickets > > * Bullet lists defaults >+ https://bugs.documentfoundation.org/show_bug.cgi?id=92657 >+ Option 1: Replace OpenSymbol as default for bu

[Libreoffice-commits] core.git: vcl/inc vcl/win

2016-12-10 Thread Khaled Hosny
vcl/inc/salglyphid.hxx|8 vcl/win/gdi/winlayout.cxx |2 +- 2 files changed, 1 insertion(+), 9 deletions(-) New commits: commit a7b9af59ea331cbc5495d2eb0f89ce6e6105ab09 Author: Khaled Hosny <khaledho...@eglug.org> Date: Thu Dec 8 06:21:23 2016 +0200 GF_VERT i

[Libreoffice-commits] core.git: vcl/inc vcl/quartz vcl/source vcl/unx vcl/win

2016-12-10 Thread Khaled Hosny
a597dc833966aba23d4b677e5bcd6f74b979fc9d Author: Khaled Hosny <khaledho...@eglug.org> Date: Thu Dec 8 05:57:40 2016 +0200 sal_GlyphId is a simple glyph id now No more cleverness. Change-Id: I760c602802961b37728c6987c4ade14fb02ca034 Reviewed-on: https://gerrit.libreoffice.org/31819

[Libreoffice-commits] core.git: vcl/inc vcl/quartz vcl/source vcl/unx

2016-12-10 Thread Khaled Hosny
/genpspgraphics.cxx |4 ++-- 6 files changed, 14 insertions(+), 9 deletions(-) New commits: commit 0fb0a564bf9cb0f721e812ac4bfa70e951827bdd Author: Khaled Hosny <khaledho...@eglug.org> Date: Thu Dec 8 05:38:08 2016 +0200 Don’t encode font fallback level in the glyph id Cha

[Libreoffice-commits] core.git: vcl/inc vcl/quartz vcl/source vcl/unx vcl/win

2016-12-10 Thread Khaled Hosny
+++-- vcl/unx/generic/print/text_gfx.cxx |2 - vcl/win/gdi/winlayout.cxx |6 ++-- 12 files changed, 34 insertions(+), 61 deletions(-) New commits: commit 57d248bcec3c6ae3fa1a943a9fd92c566239787f Author: Khaled Hosny <khaledho...@eglug.

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - svx/uiconfig

2016-12-10 Thread Khaled Hosny
svx/uiconfig/ui/findreplacedialog.ui |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit a7717bb371744ca311c5956346bc3a8a6d9807b0 Author: Khaled Hosny <khaledho...@eglug.org> Date: Sat Dec 10 16:35:26 2016 +0200 Remove superfluous jargon from user v

[Libreoffice-commits] core.git: svx/uiconfig

2016-12-10 Thread Khaled Hosny
svx/uiconfig/ui/findreplacedialog.ui |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 9fb706f9fe216f6157b9052bc42a0601d8ae52d5 Author: Khaled Hosny <khaledho...@eglug.org> Date: Sat Dec 10 16:35:26 2016 +0200 Remove superfluous jargon from user v

Re: minutes of ESC call ...

2016-12-10 Thread Khaled Hosny
On Thu, Dec 08, 2016 at 04:56:07PM +, Michael Meeks wrote: > + who else needs a Mac ? ... answers on a post-card. I think I can make use of one, if it can get here easily. I currently use the same Mac laptop for both Linux and Mac development, not the most productive setup.

[Libreoffice-commits] core.git: vcl/inc vcl/source vcl/win

2016-12-09 Thread Khaled Hosny
vcl/inc/sallayout.hxx|2 -- vcl/source/gdi/sallayout.cxx |5 - vcl/win/gdi/salfont.cxx |7 +++ 3 files changed, 3 insertions(+), 11 deletions(-) New commits: commit 289124284f98bbea442871455cf7da5fe9ef3aae Author: Khaled Hosny <khaledho...@eglug.org> Date:

[Libreoffice-commits] core.git: vcl/inc

2016-12-09 Thread Khaled Hosny
vcl/inc/sallayout.hxx | 40 +++- 1 file changed, 23 insertions(+), 17 deletions(-) New commits: commit 9774b71017bea62dfbff235886daf7c454bcd0d0 Author: Khaled Hosny <khaledho...@eglug.org> Date: Thu Dec 8 04:46:32 2016 +0200 Minor Cha

[Libreoffice-commits] core.git: vcl/inc vcl/unx

2016-12-09 Thread Khaled Hosny
+-- vcl/unx/generic/print/text_gfx.cxx | 125 ++--- 6 files changed, 72 insertions(+), 285 deletions(-) New commits: commit b157b82a6d924ebed1683b90bc9d59bbe2603451 Author: Khaled Hosny <khaledho...@eglug.org> Date: Thu Dec 8 04:13:26 2016 +0200 Use Gly

[Libreoffice-commits] core.git: vcl/headless vcl/inc vcl/quartz vcl/source vcl/unx vcl/win

2016-12-09 Thread Khaled Hosny
++ vcl/win/gdi/salfont.cxx| 12 +--- 20 files changed, 70 insertions(+), 84 deletions(-) New commits: commit bebee55d197176f009668628de0d9945c26af8ad Author: Khaled Hosny <khaledho...@eglug.org> Date: Thu Dec 8 03:01:14 2016 +0200 Use GlyphItem i

[Libreoffice-commits] core.git: vcl/inc vcl/quartz vcl/source vcl/unx vcl/win

2016-12-09 Thread Khaled Hosny
| 81 +++ 11 files changed, 151 insertions(+), 229 deletions(-) New commits: commit b894104a0b02a9b074c76feb925389d7bee6a493 Author: Khaled Hosny <khaledho...@eglug.org> Date: Thu Dec 8 00:43:09 2016 +0200 Pass GlyphItem around We have this nice str

Re: Budgeting & investing in features ...

2016-12-09 Thread Khaled Hosny
On Wed, Dec 07, 2016 at 12:12:37PM +, Michael Meeks wrote: > Is there some debilitating performance problem that slows us > all down that could be improved with an investment of time ? > > Is there something that badly needs doing, but is too hard, > dull, etc. to have

Re: Minutes of the Design Hangout: 2016-Dec-08

2016-12-08 Thread Khaled Hosny
On Thu, Dec 08, 2016 at 12:47:30PM +0100, 'Heiko Tietze' via Khaled Hosny wrote: > Present: Kendy, Samuel, Heiko > > Tickets > > * Bullet lists defaults >+ https://bugs.documentfoundation.org/show_bug.cgi?id=92657 >+ Option 1: Replace OpenSymbol as default for bu

[Libreoffice-commits] core.git: Branch 'feature/glyphid-cleanup' - 50 commits - accessibility/inc accessibility/source basctl/source basic/source bin/removetooltip_markups.sh chart2/source config_host

2016-12-08 Thread Khaled Hosny
Rebased ref, commits from common ancestor: commit d6a83d3ac9d85e85633bc42b4d91a126e7a5d5ed Author: Khaled Hosny <khaledho...@eglug.org> Date: Thu Dec 8 07:17:00 2016 +0200 Drop ComplexDisabled flags that does nothing There is no such thing as simple text layout in this bra

[Libreoffice-commits] core.git: Branch 'feature/glyphid-cleanup' - 12 commits - drawinglayer/source editeng/source include/vcl vcl/headless vcl/inc vcl/quartz vcl/source vcl/unx vcl/win

2016-12-08 Thread Khaled Hosny
Rebased ref, commits from common ancestor: commit 185b30b364a42d520b90432dfbe79d4d9d320406 Author: Khaled Hosny <khaledho...@eglug.org> Date: Thu Dec 8 07:17:00 2016 +0200 Drop ComplexDisabled flags that does nothing There is no such thing as simple text layout in this bra

[Libreoffice-commits] core.git: Branch 'feature/glyphid-cleanup' - 2 commits - drawinglayer/source editeng/source include/vcl vcl/source

2016-12-07 Thread Khaled Hosny
Rebased ref, commits from common ancestor: commit 16beef11eedac53ef59e24e4648bc132c604e511 Author: Khaled Hosny <khaledho...@eglug.org> Date: Thu Dec 8 07:17:00 2016 +0200 Drop ComplexDisabled flags that does nothing There is no such thing as simple text layout in this bra

[Libreoffice-commits] core.git: Branch 'feature/glyphid-cleanup' - 12 commits - drawinglayer/source editeng/source include/vcl sdext/source vcl/headless vcl/inc vcl/quartz vcl/source vcl/unx vcl/win

2016-12-07 Thread Khaled Hosny
Rebased ref, commits from common ancestor: commit 3faa1780b46dcb3522f16f45caee23efa08ba2c0 Author: Khaled Hosny <khaledho...@eglug.org> Date: Thu Dec 8 07:17:00 2016 +0200 Drop ComplexDisabled flags that does nothing There is no such thing as simple text layout in this bra

[Libreoffice-commits] core.git: Branch 'feature/glyphid-cleanup' - 12 commits - drawinglayer/source editeng/source include/vcl vcl/headless vcl/inc vcl/quartz vcl/source vcl/unx vcl/win

2016-12-07 Thread Khaled Hosny
Rebased ref, commits from common ancestor: commit 14979bbb886643a34d48097bfefd0db1efce62e0 Author: Khaled Hosny <khaledho...@eglug.org> Date: Thu Dec 8 07:17:00 2016 +0200 Drop ComplexDisabled flags that does nothing There is no such thing as simple text layout in this bra

[Libreoffice-commits] core.git: Changes to 'feature/glyphid-cleanup'

2016-12-07 Thread Khaled Hosny
New branch 'feature/glyphid-cleanup' available with the following commits: commit 948bfe4c5000ec3a479dd1550dd038aa0c84 Author: Khaled Hosny <khaledho...@eglug.org> Date: Thu Dec 8 07:17:00 2016 +0200 Drop ComplexDisabled flags that does nothing There is no such thing as

Re: gbuildtojson

2016-12-06 Thread Khaled Hosny
On Tue, Dec 06, 2016 at 11:58:08PM +0200, Maxim Monastirsky wrote: > Hi Bjoern, > > On Tue, 2016-12-06 at 15:22 +0100, Bjoern Michaelsen wrote: > > and this commit: > > > >  https://cgit.freedesktop.org/libreoffice/core/commit/?id=237a1b79a1d > > 5af10434c2b93cfc83c1c8e55a9d5 > > > > says: > >

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - configure.ac vcl/source

2016-12-02 Thread Khaled Hosny
configure.ac |2 +- vcl/source/gdi/CommonSalLayout.cxx |5 + 2 files changed, 2 insertions(+), 5 deletions(-) New commits: commit d63b9a335a83250b4e0dc4514f484f131f35fda2 Author: Khaled Hosny <khaledho...@eglug.org> Date: Fri Dec 2 08:06:08 2016

[Libreoffice-commits] core.git: configure.ac vcl/source

2016-12-02 Thread Khaled Hosny
configure.ac |2 +- vcl/source/gdi/CommonSalLayout.cxx |5 + 2 files changed, 2 insertions(+), 5 deletions(-) New commits: commit b9fe5dc791f56df55495d171ae901a246907c68b Author: Khaled Hosny <khaledho...@eglug.org> Date: Fri Dec 2 08:06:08 2016

[Libreoffice-commits] core.git: include/unotools unotools/Library_utl.mk unotools/source vcl/inc vcl/unx

2016-12-02 Thread Khaled Hosny
/fontconfig.cxx |5 - vcl/unx/generic/fontmanager/fontmanager.cxx | 62 ++- 6 files changed, 27 insertions(+), 206 deletions(-) New commits: commit 5d7a1ddf36eb0774a3d11e9c0dba59562d3e0c11 Author: Khaled Hosny <khaledho...@eglug.org> Date: Fri Dec 2 05:45:58 2016

Re: Requiring HarfBuzz 0.9.42?

2016-12-01 Thread Khaled Hosny
On Mon, Nov 28, 2016 at 03:27:18PM +0200, Khaled Hosny wrote: > I currently have code that depends on a feature and new API introduced > in HarfBuzz 0.9.42. The API use is behind a build time check, but the > code elsewhere really assumes the behaviour enabled by this API. So > techni

[Libreoffice-commits] core.git: vcl/unx

2016-12-01 Thread Khaled Hosny
vcl/unx/generic/fontmanager/helper.cxx | 114 - 1 file changed, 114 deletions(-) New commits: commit 01dcaa31f44aaf684cdfaff8af73aeafbbbd0aa3 Author: Khaled Hosny <khaledho...@eglug.org> Date: Fri Dec 2 03:08:15 2016 +0200 Unused code Cha

[Libreoffice-commits] core.git: vcl/inc vcl/unx

2016-12-01 Thread Khaled Hosny
(-) New commits: commit ff8a29d01afef082741871c7ac40f635a5e2bfad Author: Khaled Hosny <khaledho...@eglug.org> Date: Fri Dec 2 02:50:26 2016 +0200 Always use FontConfig in UNX I know Solaris is a snowflake, but it is 2016 already and I think it can handle FontConfig suc

[Libreoffice-commits] core.git: vcl/inc vcl/Library_vcl.mk vcl/unx

2016-12-01 Thread Khaled Hosny
- vcl/unx/generic/fontmanager/fontmanager.cxx | 58 -- vcl/unx/generic/fontmanager/helper.cxx |2 7 files changed, 11 insertions(+), 804 deletions(-) New commits: commit babf6d5e53516e80e8e3f2485796ebfaeb20e9c1 Author: Khaled Hosny <khaledho...@eglug.org> Date: Fri Dec 2 02:14:2

[Libreoffice-commits] core.git: configure.ac include/vcl vcl/inc vcl/Library_vcl.mk vcl/quartz vcl/source vcl/unx vcl/win

2016-12-01 Thread Khaled Hosny
dacd0e94199f154cac5875ec06430df6947e251b Author: Khaled Hosny <khaledho...@eglug.org> Date: Thu Dec 1 08:27:01 2016 +0200 Unused code Change-Id: Idfc964930c242d752a78cd109d75d809bce4de11 Reviewed-on: https://gerrit.libreoffice.org/31470 Tested-by: Jenkins <c...@libreo

[Libreoffice-commits] core.git: vcl/inc vcl/win

2016-12-01 Thread Khaled Hosny
: commit 6c436ba09cb35235ce6f4065cf74c9a6ff14a4bd Author: Khaled Hosny <khaledho...@eglug.org> Date: Thu Dec 1 03:33:30 2016 +0200 Kill old Windows layout engines Change-Id: I33f8322a6371150698bf926165fb6dddb9d4092c Reviewed-on: https://gerrit.libreoffice.org/31452

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - vcl/win

2016-11-30 Thread Khaled Hosny
vcl/win/gdi/winlayout.cxx |5 + 1 file changed, 5 insertions(+) New commits: commit c7e7a634cf5941fffd97102fe4252aee7445e36b Author: Khaled Hosny <khaledho...@eglug.org> Date: Wed Nov 30 14:42:19 2016 +0200 tdf#104013: Band aid for overzealous clipping Cha

[Libreoffice-commits] core.git: vcl/inc vcl/source vcl/unx

2016-11-30 Thread Khaled Hosny
| 112 5 files changed, 4 insertions(+), 276 deletions(-) New commits: commit b32dfbff56089c2ea3be07afce6a1e60777deb4b Author: Khaled Hosny <khaledho...@eglug.org> Date: Tue Nov 29 22:24:56 2016 +0200 More dead code Cha

[Libreoffice-commits] core.git: vcl/win

2016-11-30 Thread Khaled Hosny
vcl/win/gdi/winlayout.cxx |5 + 1 file changed, 5 insertions(+) New commits: commit ba3e52699bc05911bc1f9e3cbd5d1332902c736a Author: Khaled Hosny <khaledho...@eglug.org> Date: Wed Nov 30 14:42:19 2016 +0200 tdf#104013: Band aid for overzealous clipping Cha

[Libreoffice-commits] core.git: vcl/source

2016-11-29 Thread Khaled Hosny
vcl/source/gdi/pdfwriter_impl.cxx | 560 -- vcl/source/gdi/pdfwriter_impl.hxx |3 2 files changed, 563 deletions(-) New commits: commit 70ecf1919e3e3b9509ff55b2265b3d98d2a5f1aa Author: Khaled Hosny <khaledho...@eglug.org> Date: Tue Nov 29 11:51:2

[Libreoffice-commits] core.git: vcl/headless vcl/inc vcl/quartz vcl/source vcl/unx vcl/win

2016-11-29 Thread Khaled Hosny
changed, 22 insertions(+), 153 deletions(-) New commits: commit 2e0ab512592e2e134faf9612a293fb8fdd0527d0 Author: Khaled Hosny <khaledho...@eglug.org> Date: Tue Nov 29 13:39:37 2016 +0200 Strip down GetEmbedFontData to what is really used The only remaining user is EmbeddedFonts

[Libreoffice-commits] core.git: vcl/headless vcl/inc vcl/quartz vcl/source vcl/unx vcl/win

2016-11-29 Thread Khaled Hosny
1ee56fc9f446bad5853b121a3c5b137c1d00bbf4 Author: Khaled Hosny <khaledho...@eglug.org> Date: Tue Nov 29 10:41:53 2016 +0200 SalGraphics::GetFontEncodingVector() is a noop now Change-Id: Id706fa242277a0ea7ba44f52eab4a56e404bd2fa Reviewed-on: https://gerrit.libreoffice.org/31372

[Libreoffice-commits] core.git: vcl/unx

2016-11-29 Thread Khaled Hosny
vcl/unx/generic/print/genpspgraphics.cxx | 30 +- 1 file changed, 5 insertions(+), 25 deletions(-) New commits: commit 63ca9554f24194521cfbc7fa90bfef37ea7759c1 Author: Khaled Hosny <khaledho...@eglug.org> Date: Tue Nov 29 08:25:57 2016 +0200 Use Freety

[Libreoffice-commits] core.git: chart2/source include/svtools include/tools include/vcl sc/source sd/source svtools/source vcl/inc vcl/qa vcl/quartz vcl/source vcl/unx vcl/win

2016-11-29 Thread Khaled Hosny
|5 vcl/win/gdi/salfont.cxx | 199 ++- 33 files changed, 146 insertions(+), 694 deletions(-) New commits: commit 74314b11a4b5a2887bd1ff19bdcfb3572b09240c Author: Khaled Hosny <khaledho...@eglug.org> Date: Tue Nov 29 08:34:29 2016

[Libreoffice-commits] core.git: vcl/inc vcl/unx

2016-11-29 Thread Khaled Hosny
: Khaled Hosny <khaledho...@eglug.org> Date: Tue Nov 29 08:17:25 2016 +0200 Drop assigned but never used parameter Change-Id: If043960898b6388df7a5ecf5fe34172ed08bba9f Reviewed-on: https://gerrit.libreoffice.org/31344 Tested-by: Jenkins <c...@libreoffice.org>

Requiring HarfBuzz 0.9.42?

2016-11-28 Thread Khaled Hosny
I currently have code that depends on a feature and new API introduced in HarfBuzz 0.9.42. The API use is behind a build time check, but the code elsewhere really assumes the behaviour enabled by this API. So technically we can use lower HarfBuzz versions, but practically the result will be wrong

[Libreoffice-commits] core.git: vcl/source

2016-11-28 Thread Khaled Hosny
vcl/source/gdi/sallayout.cxx | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) New commits: commit 265c953584f8a1e3a832dd92dc2198056438b418 Author: Khaled Hosny <khaledho...@eglug.org> Date: Mon Nov 28 08:03:02 2016 +0200 Use range for loop Cha

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - vcl/source

2016-11-27 Thread Khaled Hosny
vcl/source/gdi/CommonSalLayout.cxx | 76 +++-- 1 file changed, 32 insertions(+), 44 deletions(-) New commits: commit 8715f20644483df9fd26b5656f4f64c4ca9f5411 Author: Khaled Hosny <khaledho...@eglug.org> Date: Mon Nov 28 07:53:29 2016 +0200 Simplify

[Libreoffice-commits] core.git: vcl/inc vcl/source

2016-11-27 Thread Khaled Hosny
f246542d1f61b5253189676688f59e5f952267a1 Author: Khaled Hosny <khaledho...@eglug.org> Date: Mon Nov 28 06:43:29 2016 +0200 Simplify things a bit * Drop SortGlyphItems() and update the Kashida insertion code not depend on that sorting. * IS_DIACRITIC flag can now be based solely on the General Ca

[Libreoffice-commits] core.git: vcl/inc vcl/unx

2016-11-26 Thread Khaled Hosny
vcl/inc/sallayout.hxx |2 -- vcl/unx/generic/print/glyphset.hxx |2 -- 2 files changed, 4 deletions(-) New commits: commit 84c5999372ca4af1c79ab3134fda1d67d4ea95d6 Author: Khaled Hosny <khaledho...@eglug.org> Date: Sat Nov 26 22:46:35 2016 +0200 Unused typed

Re: Windows linking errors after removing old Graphite code

2016-11-26 Thread Khaled Hosny
On Sat, Nov 26, 2016 at 07:53:15PM +, Kaganski Mike wrote: > 11/26/2016 10:43 PM, Noel Grandin пишет: > > the windows buildbots are currently broken, and it very much looks > > like this stuff is the reason, e.g. see > > > >

Re: Windows linking errors after removing old Graphite code

2016-11-26 Thread Khaled Hosny
On Sat, Nov 26, 2016 at 09:43:50PM +0200, Noel Grandin wrote: > the windows buildbots are currently broken, and it very much looks like > this stuff is the reason, e.g. see > > http://ci.libreoffice.org/job/lo_tb_master_win64_dbg/lastBuild/console I saw this earlier today, but the Gerrit builds

[Libreoffice-commits] core.git: 2 commits - vcl/inc vcl/README.vars vcl/source

2016-11-26 Thread Khaled Hosny
d76bd987ca2b853b85a9464787ae1fdc19321f5b Author: Khaled Hosny <khaledho...@eglug.org> Date: Sat Nov 26 20:10:21 2016 +0200 Do not check for SAL_NO_COMMON_LAYOUT any more It has no effect except on Windows, and this will go out soon. Cha

[Libreoffice-commits] core.git: vcl/inc vcl/source

2016-11-26 Thread Khaled Hosny
vcl/inc/CommonSalLayout.hxx | 17 +- vcl/inc/sallayout.hxx|8 - vcl/source/gdi/sallayout.cxx | 279 --- 3 files changed, 15 insertions(+), 289 deletions(-) New commits: commit 3dab9849115284f9a126356e2354ad7fb8557663 Author: Khaled Hosny

Re: Windows linking errors after removing old Graphite code

2016-11-26 Thread Khaled Hosny
On Fri, Nov 25, 2016 at 05:12:03PM +0100, Michael Stahl wrote: > On 24.11.2016 22:04, Khaled Hosny wrote: > > I’m getting linking after removing the old Graphite integration: > > https://gerrit.libreoffice.org/#/c/31143/ > > > > But I’m getting unexpected linking error

[Libreoffice-commits] core.git: include/vcl sw/source vcl/inc vcl/Library_vcl.mk vcl/quartz vcl/source

2016-11-26 Thread Khaled Hosny
commits: commit d761d952f460e1943e94c5a7556b3b01d2259666 Author: Khaled Hosny <khaledho...@eglug.org> Date: Fri Nov 25 14:00:07 2016 +0200 Kill old Core Text layout engine Change-Id: If80d65899255d8be72f374fbec232d103a08a006 Reviewed-on: https://gerrit.libreoffice.org

[Libreoffice-commits] core.git: 2 commits - vcl/inc vcl/unx

2016-11-26 Thread Khaled Hosny
insertions(+), 1229 deletions(-) New commits: commit 30ebc895c95ee66adf172717249aa1789b309eff Author: Khaled Hosny <khaledho...@eglug.org> Date: Fri Nov 25 09:19:15 2016 +0200 There is one font file type now Change-Id: I47b6f36de5c77cfdf831a2b3ce10b973159520b1 Reviewed-on:

[Libreoffice-commits] core.git: vcl/inc vcl/unx

2016-11-26 Thread Khaled Hosny
368de904974b18dc5a8d237e046c0ed005f7c85d Author: Khaled Hosny <khaledho...@eglug.org> Date: Thu Nov 24 09:21:56 2016 +0200 Kill PspFontLayout It should never get used any way. CairoTextRender::GetTextLayout() returns nullptr for the unlikely even that there is no Freetypefont for the requested fallback lev

[Libreoffice-commits] core.git: vcl/headless vcl/inc vcl/quartz vcl/source vcl/unx vcl/win

2016-11-26 Thread Khaled Hosny
59859a8aaa75384159e315ee2577d5cc7e2aa6e8 Author: Khaled Hosny <khaledho...@eglug.org> Date: Thu Nov 24 01:32:11 2016 +0200 ServerFontLayout is already gone Kill DrawServerFontLayout, and rename DrawSalLayout to DrawTextLayout, in parity with GetTextLayout. Cha

[Libreoffice-commits] core.git: include/vcl vcl/source vcl/unx

2016-11-26 Thread Khaled Hosny
: commit 8c173ce9ba4d90770cd85b148fe3122a097396a7 Author: Khaled Hosny <khaledho...@eglug.org> Date: Thu Nov 24 01:12:17 2016 +0200 DisableGlyphProcessing flag is never set now Change-Id: I4a56c5d7490dd78f5cb72f2b821fb43c93f64b2d Reviewed-on: https://gerrit.libreoffice.org

[Libreoffice-commits] core.git: vcl/CustomTarget_afm_hash.mk vcl/inc vcl/Library_vcl.mk vcl/Module_vcl.mk vcl/unx

2016-11-26 Thread Khaled Hosny
abe4d7bd0a1ec4b5a31cc5622080952e4cd53ebf Author: Khaled Hosny <khaledho...@eglug.org> Date: Thu Nov 24 00:53:05 2016 +0200 Kill code for Type 1 fonts on Unix We already ignore them, so this is unreachable code now. Change-Id: I6fd4699d8175344c36253bf4bf9c024b8986da31 Reviewed-on:

<    2   3   4   5   6   7   8   9   10   11   >