[PUSHED] String to OUString (SfxStringItem and related)

2013-06-18 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4280 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4280 To unsubscribe, visit

[PUSHED] Migrate CheckFields unit test to python

2013-06-18 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4294 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4294 To unsubscribe, visit

[PUSHED libreoffice-4-0] resolved fdo#65082 RATE function should not find roots = -1

2013-06-18 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4327 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4327 To unsubscribe, visit

[PUSHED libreoffice-3-6] resolved fdo#65082 RATE function should not find roots = -1

2013-06-18 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4328 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4328 To unsubscribe, visit

[PUSHED] fdo#39468 Comment translation GER-ENG in sw/source/ui/uiview...

2013-06-17 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4296 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4296 To unsubscribe, visit

[PUSHED] fdo#43460 chart2: use isEmpty()

2013-06-17 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4315 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4315 To unsubscribe, visit

[PUSHED] Remove useless attributions in starmath

2013-06-17 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4282 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4282 To unsubscribe, visit

[PUSHED] fdo#65108 clean-up headers(global/local) perl script

2013-06-17 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4306 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4306 To unsubscribe, visit

[PUSHED] fdo#63690 - replace RTL_CONTEXT_ macros with SAL_INFO

2013-06-17 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4286 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4286 To unsubscribe, visit

[PUSHED] fdo#43460 configmgr: use isEmpty()

2013-06-17 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4317 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4317 To unsubscribe, visit

[PUSHED] fdo#43460 startmath,codemaker: use isEmpty()

2013-06-17 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4318 Approvals: Noel Power: Verified; Looks good to me, approved Marcos Souza: Looks good to me, but someone else must approve -- To view,

[PUSHED] Translate German comments, delete some WS and correct format...

2013-06-17 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4319 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4319 To unsubscribe, visit

[PUSHED] Translate German comments, correct some WS

2013-06-17 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4320 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4320 To unsubscribe, visit

[PUSHED] fdo#43460 dbaccess: use isEmpty()

2013-06-17 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4321 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4321 To unsubscribe, visit

[PUSHED] Remove micro optimisation

2013-06-17 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4322 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4322 To unsubscribe, visit

[PUSHED] fdo#43460 forms: use isEmpty()

2013-06-17 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4323 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4323 To unsubscribe, visit

[PUSHED] fdo#43460 oox: use isEmpty()

2013-06-17 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4324 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4324 To unsubscribe, visit

[PUSHED] cppcheck: fix operatorEqVarError (in lotuswordpro)

2013-06-14 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4281 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4281 To unsubscribe, visit

[PUSHED libreoffice-4-0] fdo#64656 RTF import: handle levelnumbers without leveltext

2013-06-14 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4219 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4219 To unsubscribe, visit

[PUSHED libreoffice-4-0] remove chart listener when chart is deleted, fdo#64639

2013-05-27 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4045 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4045 To unsubscribe, visit

[PUSHED libreoffice-3-6] remove chart listener when chart is deleted, fdo#64639

2013-05-27 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4046 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4046 To unsubscribe, visit

[PUSHED libreoffice-4-0] range names need to be checked upper case, fdo#64031

2013-05-27 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4050 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4050 To unsubscribe, visit

[REVERTED libreoffice-3-6] Revert remove chart listener when chart is deleted, fdo#646...

2013-05-27 Thread Noel Power (via Code Review)
Noel Power has reverted this change. Change subject: Revert remove chart listener when chart is deleted, fdo#64639 .. Patch Set 2: Reverted This patchset was reverted in change: I94a960aa923abeac4d89eb0169d5c2e01ec943c1 --

[ABANDONED libreoffice-3-6] Revert remove chart listener when chart is deleted, fdo#646...

2013-05-27 Thread Noel Power (via Code Review)
Noel Power has abandoned this change. Change subject: Revert remove chart listener when chart is deleted, fdo#64639 .. Patch Set 1: Abandoned ha somehow I thought the revert actually reverted not sent another patch to gerrit

[PATCH libreoffice-4-0] fix wildcard handling regression( for basic functions like D...

2013-05-20 Thread Noel Power (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3975 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/75/3975/1 fix wildcard handling regression( for basic functions like Dir ) fdo#64536 Tweak another fallout from

[PUSHED] fdo#63878 fix the zoom bug on RTL sheet

2013-05-20 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3954 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3954 To unsubscribe, visit

[PATCH libreoffice-4-0] Revert fdo#63878 fix the zoom problem when the sheet are RT...

2013-05-17 Thread Noel Power (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3932 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/32/3932/1 Revert fdo#63878 fix the zoom problem when the sheet are RTL This reverts commit

[PATCH libreoffice-4-0] hopefully this fixed the strange autorecovery related datalo...

2013-05-09 Thread Noel Power (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3832 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/32/3832/1 hopefully this fixed the strange autorecovery related dataloss fdo#42899 also this is a fix for bnc#817477

[PUSHED] coverity#983096: Resource leak

2013-05-08 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3818 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3818 To unsubscribe, visit

[PUSHED] coverity#983036/37/38: Resource leak

2013-05-08 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3819 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3819 To unsubscribe, visit

[PUSHED] coverity#982460: Explicit null dereferenced

2013-05-08 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3823 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3823 To unsubscribe, visit

[PUSHED] coverity#982973: Resource leak

2013-05-08 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3821 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3821 To unsubscribe, visit

[PATCH libreoffice-4-0] fix for fdo#51300

2013-05-07 Thread Noel Power (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3814 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/14/3814/1 fix for fdo#51300 Hopefully a better choice for defaults will minimise the chance of a bad colour combination

[PUSHED libreoffice-4-0] fdo#64048 - fix calc/VBA clearcontents regression.

2013-05-03 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3744 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3744 To unsubscribe, visit

[PATCH libreoffice-4-0] fdo#63659 sigh fix brain lapse, missing break

2013-04-22 Thread Noel Power (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3551 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/51/3551/1 fdo#63659 sigh fix brain lapse, missing break Change-Id: I02ab972cfad577423585d25587b925b5b1153506 (cherry

[PATCH libreoffice-4-0] implement MultiPage, Page TabStrip import for oox

2013-04-18 Thread Noel Power (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3456 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/56/3456/1 implement MultiPage, Page TabStrip import for oox Change-Id: I1912c9550c12a971fcc7fdbc8bd623f18ccc40b8

[PATCH libreoffice-4-0] fix Frame import for oox filter

2013-04-18 Thread Noel Power (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3457 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/57/3457/1 fix Frame import for oox filter Change-Id: Ie165b509ea7668a3064e16b537bf2e51345324ba (cherry picked from commit

[PATCH libreoffice-4-0] fix fdo#63659 restore handling of ZOOM MID, MID_VALUESET M...

2013-04-18 Thread Noel Power (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3458 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/58/3458/1 fix fdo#63659 restore handling of ZOOM MID, MID_VALUESET MID_TYPE sub parmas Change-Id:

[PATCH libreoffice-4-0] follow on fix for fdo#62090 ensure out of range startpos is ...

2013-04-16 Thread Noel Power (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3409 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/09/3409/1 follow on fix for fdo#62090 ensure out of range startpos is handled Change-Id:

[PATCH libreoffice-4-0] fix for fdo#62090 Mid function regression

2013-04-16 Thread Noel Power (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3408 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/08/3408/1 fix for fdo#62090 Mid function regression Change-Id: Ia6a73d6a44a34345b512922037d01b8b40ac24a8 (cherry picked

[PUSHED libreoffice-3-6] fdo#39066: using UNO_QUERY instead of UNO_QUERY_THROW displa...

2013-04-10 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3304 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3304 To unsubscribe, visit

[PUSHED libreoffice-4-0] fdo#39066: using UNO_QUERY instead of UNO_QUERY_THROW displa...

2013-04-10 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3303 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3303 To unsubscribe, visit

[PATCH libreoffice-4-0] prepend Validation.Formula1 results with '=' for anything no...

2013-04-05 Thread Noel Power (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3206 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/06/3206/1 prepend Validation.Formula1 results with '=' for anything not a address Change-Id:

[PATCH libreoffice-4-0] Added and fixed various vba API

2013-04-05 Thread Noel Power (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3207 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/07/3207/1 Added and fixed various vba API Added OLEObject.LinkedCell Added ComboBox.LinkedCell Added Validation.Type

[PATCH libreoffice-4-0] squash NoSuchElementExceptions when modifying keybindings

2013-04-05 Thread Noel Power (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3208 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/08/3208/1 squash NoSuchElementExceptions when modifying keybindings Change-Id: I37882845660929e0001a834b6685a4087dfb465f

[PATCH libreoffice-4-0] fix selection change event firing

2013-04-05 Thread Noel Power (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3210 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/10/3210/1 fix selection change event firing Change-Id: I64e8b684dd5462e1a742ba47b5480951b4e3a4c4 --- M sc/inc/viewuno.hxx

[PATCH libreoffice-4-0] fix 'Visible' property for XControlShape(s) Foreach support ...

2013-04-05 Thread Noel Power (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3209 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/09/3209/1 fix 'Visible' property for XControlShape(s) Foreach support for CommandBars Seems now we need to additionally

[PATCH libreoffice-4-0] hacky fix for export of cell anchored flipped custom shapes

2013-03-26 Thread Noel Power (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3064 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/64/3064/1 hacky fix for export of cell anchored flipped custom shapes On export it is assumed the translate co-ords are

[PUSHED] coverity#704931 Explicit null dereferenced

2013-03-21 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2881 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2881 To unsubscribe, visit

[PUSHED] reduce space needed by comments in sw/source/core

2013-03-21 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2880 -- To view, visit https://gerrit.libreoffice.org/2880 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

[PUSHED libreoffice-4-0-2] deb#703486: Keep migrating more user extensions after one fa...

2013-03-21 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2878 Approvals: Noel Power: Verified; Looks good to me, approved Fridrich Strba: Looks good to me, but someone else must approve -- To

[PUSHED] remove unused code svtools/bmpmaker

2013-03-21 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2868 Approvals: Noel Power: Verified; Looks good to me, approved LibreOffice gerrit bot: Verified Thomas Arnhold: Verified; Looks good to

[PUSHED libreoffice-3-6-6] fixed a possible crasher

2013-03-21 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2895 Approvals: Noel Power: Verified; Looks good to me, approved Petr Mladek: Verified; Looks good to me, but someone else must approve

[PUSHED] allow to use internal python for build-stuff on Mac

2013-03-20 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2849 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2849 To unsubscribe, visit

[PUSHED libreoffice-4-0] resolved rhbz#919020 Basic CDbl() and CSng() scan localized ...

2013-03-20 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2859 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2859 To unsubscribe, visit

[PUSHED] simplify OUString assignments

2013-03-20 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2863 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2863 To unsubscribe, visit

[PUSHED] Replace String with OUString (unotools)

2013-03-20 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2864 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2864 To unsubscribe, visit

[PUSHED] coverity#704618 Explicit null dereferenced

2013-03-20 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2866 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2866 To unsubscribe, visit

[PUSHED] Related to coverity#704822 (Explicit null dereference)

2013-03-20 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2872 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2872 To unsubscribe, visit

[PUSHED] coverity#704774 Explicit null dereferenced

2013-03-20 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2870 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2870 To unsubscribe, visit

[PUSHED libreoffice-4-0] fdo#60769 implement odf export of multi-paragraph comment ra...

2013-03-20 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2873 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2873 To unsubscribe, visit

[PUSHED] coverity#704628/704629/704630 Explicit null dereferenced

2013-03-20 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2869 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2869 To unsubscribe, visit

[PUSHED] coverity#735374 Copy-paste error

2013-03-19 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2798 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2798 To unsubscribe, visit

[PUSHED] coverity#982271 Copy-paste error

2013-03-19 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2802 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2802 To unsubscribe, visit

[PUSHED] coverity#735375 Copy-paste error

2013-03-19 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2799 Approvals: Noel Power: Verified; Looks good to me, approved Joren De Cuyper: Looks good to me, but someone else must approve -- To

[PUSHED] Remove RTL_CONSTASCII_(U)STRINGPARAM in sw (2)

2013-03-19 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2837 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2837 To unsubscribe, visit

[PUSHED libreoffice-4-0] odk: fix IDL documentation:

2013-03-19 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2842 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2842 To unsubscribe, visit

[PUSHED libreoffice-4-0] Template Manager: fixed search edit field position

2013-03-19 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2844 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2844 To unsubscribe, visit

[PUSHED libreoffice-4-0] Template manager: moved the controls into a proper TabPage t...

2013-03-19 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2843 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2843 To unsubscribe, visit

[PUSHED libreoffice-4-0] Template Manager: fixed TabStops for the toolbars

2013-03-19 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2845 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2845 To unsubscribe, visit

[PATCH libreoffice-4-0] bnc#805071 fix object assigment problems when default member...

2013-03-15 Thread Noel Power (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2756 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/56/2756/1 bnc#805071 fix object assigment problems when default members present Change-Id:

[PATCH libreoffice-4-0] detect follow-on default member of default member object bnc...

2013-03-15 Thread Noel Power (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2758 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/58/2758/1 detect follow-on default member of default member object bnc#809017 Change-Id:

[PATCH libreoffice-4-0] unittest and test data for bnc#809017

2013-03-15 Thread Noel Power (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2759 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/59/2759/1 unittest and test data for bnc#809017 Change-Id: I3ccae692db44bb3ce41b371f0b511a9db7181bf4 --- M

[PATCH libreoffice-4-0] bnc#798309 inherit group style from parent

2013-03-13 Thread Noel Power (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2695 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/95/2695/1 bnc#798309 inherit group style from parent Change-Id: Ie4f1d244f1c9b4935305742d12cabaee3e38647c (cherry picked

[PATCH libreoffice-4-0-2] fix for fdo#62111 - don't count non-default empty rows as ro...

2013-03-13 Thread Noel Power (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2700 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/00/2700/1 fix for fdo#62111 - don't count non-default empty rows as rows to repeat Change-Id:

[PATCH libreoffice-3-6] bnc#798309 inherit group style from parent

2013-03-13 Thread Noel Power (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2701 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/01/2701/1 bnc#798309 inherit group style from parent Change-Id: Ie4f1d244f1c9b4935305742d12cabaee3e38647c --- M

[PATCH libreoffice-3-6] bnc#798309 inherit group style from parent

2013-03-13 Thread Noel Power (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2702 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/02/2702/1 bnc#798309 inherit group style from parent Change-Id: I8acba22750b8b06b9c20607884629899ad180425 --- M

[ABANDONED libreoffice-3-6] bnc#798309 inherit group style from parent

2013-03-13 Thread Noel Power (via Code Review)
Noel Power has abandoned this change. Change subject: bnc#798309 inherit group style from parent .. Patch Set 1: Abandoned gah I've submitted a new version that squashes a further commit, please use that instead -- To view,

[PATCH libreoffice-4-0] Fix Set/Let mixup ( from String - OUString rework ) fdo#607...

2013-03-13 Thread Noel Power (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2705 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/05/2705/1 Fix Set/Let mixup ( from String - OUString rework ) fdo#60752 Change-Id:

[PATCH libreoffice-4-0-2] Fix Set/Let mixup ( from String - OUString rework ) fdo#607...

2013-03-13 Thread Noel Power (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2706 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/06/2706/1 Fix Set/Let mixup ( from String - OUString rework ) fdo#60752 Change-Id:

[PATCH libreoffice-4-0] make sure basic IDE cut/copy buttons on toolbar are refreshe...

2013-03-13 Thread Noel Power (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2708 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/08/2708/1 make sure basic IDE cut/copy buttons on toolbar are refreshed fdo#30545 Change-Id:

[PATCH libreoffice-4-0] fix fdo#38385 - accept as valid 'start' and 'end' tokens for...

2013-03-13 Thread Noel Power (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2709 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/09/2709/1 fix fdo#38385 - accept as valid 'start' and 'end' tokens for lineborders Change-Id:

[PATCH libreoffice-4-0] fix for fdo#62111 - don't count non-default empty rows as ro...

2013-03-12 Thread Noel Power (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2681 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/81/2681/1 fix for fdo#62111 - don't count non-default empty rows as rows to repeat Change-Id:

[PUSHED libreoffice-4-0-1] one more fix for error bar import, fdo#60083

2013-02-27 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2438 Approvals: Noel Power: Verified; Looks good to me, approved Michael Meeks: Looks good to me, but someone else must approve -- To view,

[PUSHED libreoffice-4-0-1] remove the copied cond format cell attr entries, fdo#60306

2013-02-27 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2439 Approvals: Noel Power: Verified; Looks good to me, approved Michael Meeks: Looks good to me, but someone else must approve -- To view,

[PATCH libreoffice-4-0] add more missing adodb constants

2013-02-12 Thread Noel Power (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2106 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/06/2106/1 add more missing adodb constants Change-Id: Ia43e1c63aa3a1f72deaa20351f9fe59fcc021b62 (cherry picked from

[PATCH libreoffice-4-0] fix basic access to nested uno structures fdo#60117

2013-02-11 Thread Noel Power (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2099 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/99/2099/1 fix basic access to nested uno structures fdo#60117 Although basic might appear to correctly change nested

[PATCH libreoffice-4-0] fix for fdo#60065

2013-02-06 Thread Noel Power (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2003 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/03/2003/1 fix for fdo#60065 squash errors trying to gain object for rhs ( where no object yet exists ( Change-Id:

[PATCH libreoffice-4-0] correctly handle repeated row heights for empty rows ( fdo#5...

2013-02-06 Thread Noel Power (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2004 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/04/2004/1 correctly handle repeated row heights for empty rows ( fdo#59973 ) it seems both xls xlsx export suffer from

Change in core[libreoffice-4-0]: Hyperlink is an optional property, fdo#58858

2013-02-01 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1941 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1941 To unsubscribe, visit

Change in core[master]: Hyperlink is an optional property, fdo#58858

2013-01-31 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1930 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1930 To unsubscribe, visit

Change in core[libreoffice-4-0-0]: Resolving crash in wizards fdo#59931 by NULL checking

2013-01-29 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1913 Approvals: Stephan Bergmann: Looks good to me, but someone else must approve Noel Power: Verified; Looks good to me, approved Tor

[PATCH] Change in core[libreoffice-4-0]: don't use ScDrawLayer::GetObjDataTab to get Anchor fix for f...

2013-01-25 Thread Noel Power (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1828 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/28/1828/1 don't use ScDrawLayer::GetObjDataTab to get Anchor fix for fdo#59325 Seems ScDrawLayer::GetObjDataTab was used

[PATCH] Change in core[libreoffice-4-0-0]: don't use ScDrawLayer::GetObjDataTab to get Anchor fix for f...

2013-01-25 Thread Noel Power (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1837 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/37/1837/1 don't use ScDrawLayer::GetObjDataTab to get Anchor fix for fdo#59325 Seems ScDrawLayer::GetObjDataTab was used

[PUSHED] fdo#56098 Paste Special options after cut incorrect

2013-01-25 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1671 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1671 To unsubscribe, visit

[PUSHED] Change in core[libreoffice-4-0]: reset automatic row height flag after import, fdo#59193

2013-01-25 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1831 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1831 To unsubscribe, visit

[PUSHED] Change in core[libreoffice-4-0]: fdo#58562: Ensure internal data is always used when pasting ...

2013-01-25 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1835 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1835 To unsubscribe, visit

[PUSHED] sc test XSheetOutline

2013-01-25 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1794 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1794 To unsubscribe, visit

[PUSHED] Change in core[libreoffice-4-0]: resolved fdo#59819 write correct OOXML function name mapping

2013-01-25 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1854 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1854 To unsubscribe, visit

[PUSHED] Change in core[libreoffice-4-0]: bnc#798271: Don't delete the PropertyMapEntry instance prema...

2013-01-25 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1858 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1858 To unsubscribe, visit

  1   2   >