Re: [Libreoffice] [PATCH] Fix bug where an opening quote mark is treated as a word

2010-11-09 Thread Cedric Bosdonnat
On Fri, 2010-11-05 at 00:38 -0700, John LeMoyne Castle wrote: Dang, I was hoping it would stop counting at least some punctuation as a word.(period). Don't know what to say other than test before and after. Just some random thought here: would you be able to write some unit tests for this?

Re: [Libreoffice] [PATCH] Fix bug where an opening quote mark is treated as a word

2010-11-09 Thread John LeMoyne Castle
Noel Power wrote: No, I don't mean setting up an OOO build ;-) but just checking against a OOO330m13 dev build ( that can downloaded from openoffice.org ) OIC, I was making it too hard - rooted around at OOo and found the debs... Thanks -- LeMoyne -- View this message in context:

Re: [Libreoffice] [PATCH] Fix bug where an opening quote mark is treated as a word

2010-11-09 Thread Cedric Bosdonnat
Hi guys, I mistakenly pushed Mattias patch this morning... that shouldn't harm, but I though it would be good for you to know it for later investigations. On Sat, 2010-11-06 at 14:14 +1100, Mattias Johnsson wrote: On 6 November 2010 12:13, John LeMoyne Castle j...@mail2lee.com wrote: Hi

Re: [Libreoffice] [PATCH] Fix bug where an opening quote mark is treated as a word

2010-11-09 Thread Noel Power
On Tue, 2010-11-09 at 04:30 -0800, John LeMoyne Castle wrote: Noel Power wrote: I wonder if the recent rebase to OOO330m13 is the culprit, would be interesting if you could test against the corresponding oracle dev build Yes, I see that test would be useful. Not about to setup an

Re: [Libreoffice] [PATCH] Fix bug where an opening quote mark is treated as a word

2010-11-09 Thread John LeMoyne Castle
Noel Power wrote: I wonder if the recent rebase to OOO330m13 is the culprit, would be interesting if you could test against the corresponding oracle dev build Yes, I see that test would be useful. Not about to setup an OOO build, but will consider it if you think that would be useful

Re: [Libreoffice] [PATCH] Fix bug where an opening quote mark is treated as a word

2010-11-09 Thread Noel Power
On Tue, 2010-11-09 at 04:30 -0800, John LeMoyne Castle wrote: Noel Power wrote: I wonder if the recent rebase to OOO330m13 is the culprit, would be interesting if you could test against the corresponding oracle dev build Yes, I see that test would be useful. Not about to setup an

Re: [Libreoffice] [PATCH] Fix bug where an opening quote mark is treated as a word

2010-11-08 Thread Noel Power
On Fri, 2010-11-05 at 18:13 -0700, John LeMoyne Castle wrote: Hi all, [...] Still new to git but I am sure I saw and built and ran the old txtedt.cxx and still no LSQEW. Feelin' a bit lost ... I can think of some other options for trying to find what fixed the LSQEW but I feel like I'm

Re: [Libreoffice] [PATCH] Fix bug where an opening quote mark is treated as a word

2010-11-05 Thread Cedric Bosdonnat
Hi Mattias, On Fri, 2010-11-05 at 10:38 +1100, Mattias Johnsson wrote: There isn't a bug report in the LO tracker, but there are quite a few in the OO.o issue tracker. The basic issue number is 89042, with 97116, 102270, 107241, 113375, and 108072 marked as duplicates. Hum, I saw that one...

Re: [Libreoffice] [PATCH] Fix bug where an opening quote mark is treated as a word

2010-11-05 Thread Mattias Johnsson
On 5 November 2010 20:16, Cedric Bosdonnat cedric.bosdonnat@free.fr wrote: Hi Mattias, On Fri, 2010-11-05 at 10:38 +1100, Mattias Johnsson wrote: There isn't a bug report in the LO tracker, but there are quite a few in the OO.o issue tracker. The basic issue number is 89042, with 97116,

Re: [Libreoffice] [PATCH] Fix bug where an opening quote mark is treated as a word

2010-11-05 Thread John LeMoyne Castle
Hi all, Ok, after getting over a short-term dislike of Word Count - with a new found appreciation for some of the developer comments in OOo issuezilla - I had a new idea for a test plan. Perhaps turning on the Scanner clipping has *accidentally* fixed the quote problem as well. Although I

Re: [Libreoffice] [PATCH] Fix bug where an opening quote mark is treated as a word

2010-11-05 Thread Mattias Johnsson
On 6 November 2010 12:13, John LeMoyne Castle j...@mail2lee.com wrote: Hi all, Ok, after getting over a short-term dislike of Word Count - with a new found appreciation for some of the developer comments in OOo issuezilla - I had a new idea for a test plan.  Perhaps turning on the Scanner

Re: [Libreoffice] [PATCH] Fix bug where an opening quote mark is treated as a word

2010-11-04 Thread Mattias Johnsson
On 4 November 2010 23:38, Mattias Johnsson m.t.johns...@gmail.com wrote: After spending a number of hours learning more about unicode than I ever wanted to know, I've fixed the bug where the word counter in Writer counts an opening quote mark (unicode symbol 0x201C) as an extra word. Turns

Re: [Libreoffice] [PATCH] Fix bug where an opening quote mark is treated as a word

2010-11-04 Thread Cedric Bosdonnat
Hi Mattias, On Thu, 2010-11-04 at 23:38 +1100, Mattias Johnsson wrote: Patch attached. It's a very minimal change, so it's probably safe to push into the 3.3 branch as well as master. It seems that you forgot to actually attach the patch ;) Regards, -- Cédric Bosdonnat LibreOffice hacker

Re: [Libreoffice] [PATCH] Fix bug where an opening quote mark is treated as a word

2010-11-04 Thread Mattias Johnsson
Yes, I spotted that after I sent it, and resent with the attachment :-) However, I still forgot to mention: code is contributed under MPL 1.1 / GPLv3+ / LGPLv3+ licenses. In my defence, it's pretty late here :-P On 4 November 2010 23:49, Cedric Bosdonnat cedric.bosdonnat@free.fr wrote: Hi

Re: [Libreoffice] [PATCH] Fix bug where an opening quote mark is treated as a word

2010-11-04 Thread Mattias Johnsson
On 5 November 2010 02:29, Cedric Bosdonnat cedric.bosdonnat@free.fr wrote: Hi Mattias, On Thu, 2010-11-04 at 23:41 +1100, Mattias Johnsson wrote: Patch attached. It's a very minimal change, so it's probably safe to push into the 3.3 branch as well as master. Do you have some bug