Pierre-André Jacquod wrote:
So here the patch...
Thanks for a review and an ack before I push it.
Looks good, thanks a lot - pushed it right away.
Cheers,
-- Thorsten
pgpph39MLsIeY.pgp
Description: PGP signature
___
LibreOffice mailing list
Hello,
On 05/03/2012 11:30 AM, Thorsten Behrens wrote:
So what I suggest is a more defensive fix (or some larger review
across the code is in order): make GetLineArrow() return the
B2DPolyPolygon right away, and have *that one* be empty (i.e. not a
Since I do not intend to become a specialist
Pierre-André Jacquod wrote:
back again after a while.
Hi Pierre-André, welcome back! :)
It happens that basegfx::GetLineArrow(...) (also defined within
msdffimp.cxx, line 1102) does not create a valid polygon when
eLineEnd has the value mso_lineNoEnd...
In the switch(eLineEnd), this goes
Hello,
back again after a while.
On 02/15/2012 11:30 AM, Thorsten Behrens wrote:
Fixed with d37abad97d72bae0fd0269de12e94c7a7d3fd7e1 - but, if you
like, would be cool to chase down why in the first place the ppt
import creates polygons with empty sub-paths, that looks like a
worthwhile
Pierre-André Jacquod wrote:
B2DTuple(const B2DTuple rTup)
...
Here you dereference the null pointer, which crash.
Ok, the basic attitude would be to let B2DTuple be Null-pointer
consistent: (checking that rTup is not NULL), but is it really a
good idea?
Hi Pierre-André,
no, what's
Or should I look higher in the hierarchy, saying that a NULL point
in a B2DPolygon has nothing to do and disallow it ?
Yes, the calling code somehow accesses invalid elements. Let me have
a look.
Fixed with d37abad97d72bae0fd0269de12e94c7a7d3fd7e1 - but, if you
like, would be cool to
hello,
Fixed with d37abad97d72bae0fd0269de12e94c7a7d3fd7e1 - but, if you
thanks
import creates polygons with empty sub-paths, that looks like a
worthwhile optimization - code is around
filter/source/msfilter/msdffimp.cxx probably.
as soon as I have more spare time, I will have a try.
