[PATCH] String to OUString

2013-09-05 Thread Thomas Arnhold (via Code Review)
Hello Andrzej J.R. Hunt, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/5817 to look at the new patch set (#2). Change subject: String to OUString .. String to OUString And removed

[PUSHED] XubString to OUString

2013-09-04 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/5802 Approvals: LibreOffice gerrit bot: Verified Thomas Arnhold: Michael Stahl: Looks good to me, approved -- To view, visit

[PUSHED] Remove more unused methods

2013-09-04 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/5789 Approvals: LibreOffice gerrit bot: Verified Thomas Arnhold: Verified; Looks good to me, approved Marcos Souza: Looks good to me, but

[PATCH] Remove more unused methods

2013-09-03 Thread Thomas Arnhold (via Code Review)
Hello LibreOffice gerrit bot, Marcos Souza, I'd like you to reexamine a rebased change. Please visit https://gerrit.libreoffice.org/5757 to look at the new rebased patch set (#2). Change subject: Remove more unused methods

[PUSHED] Remove more unused methods

2013-09-03 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/5757 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/5757 To unsubscribe,

[PUSHED] remove OUString wrap for string literals

2013-06-29 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4624 Approvals: LibreOffice gerrit bot: Verified Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit

[PUSHED] fdo#43460 shell,vcl,xmlreader: use isEmpty()

2013-06-24 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/ Approvals: LibreOffice gerrit bot: Verified Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit

[PUSHED] Replace invalid doxygen commands: thrown - throws

2013-06-03 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4136 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4136 To unsubscribe,

[PUSHED] fdo#39468 Comment translation GER-ENG in sw/source/ui/uno

2013-06-02 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4129 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4129 To unsubscribe,

[PATCH] Make use of IsStarSymbol()

2013-05-28 Thread Thomas Arnhold (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4077 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/77/4077/1 Make use of IsStarSymbol() Change-Id: I7a2e3a6f11bbaaaff50e8163e4ce3e2583b1d03c --- M

[PATCH] fdo#60724 change spelling error REMOVEABLE - REMOVABLE II

2013-05-28 Thread Thomas Arnhold (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4078 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/78/4078/1 fdo#60724 change spelling error REMOVEABLE - REMOVABLE II Change-Id: I0057b9174af6a83f3fde0e27c3a91a4aeca95873

[PATCH] fdo#39468 - translate German comments

2013-05-28 Thread Thomas Arnhold (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4079 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/79/4079/1 fdo#39468 - translate German comments Change-Id: I1324c2682873112fa7702b94fcaceab6de0b94d1 --- M

[PATCH] fdo#63351 make use of ZoomSlider in StarMath

2013-05-27 Thread Thomas Arnhold (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4053 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/53/4053/1 fdo#63351 make use of ZoomSlider in StarMath In collaboration with Marcos Souza marcos.souza@gmail.com :)

[PUSHED] fix OUString conversion

2013-05-26 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4035 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4035 To unsubscribe,

[PATCH] be case-insensitive for open/starsymbol comparison

2013-05-23 Thread Thomas Arnhold (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4015 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/15/4015/1 be case-insensitive for open/starsymbol comparison Change-Id: I7a342c809a723f5f9c03271c6145d9c367cea6de --- M

[PUSHED] fdo#39468 Comment translation GER-ENG

2013-05-20 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3965 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3965 To unsubscribe,

[PUSHED] Changed compareTo to startsWith

2013-05-19 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3956 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3956 To unsubscribe,

[PUSHED] fdo#39468 Translate German comments - graphicfilter

2013-05-19 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3955 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3955 To unsubscribe,

[PUSHED] fdo#39468 Comment translation GER-ENG in sw/source/ui/ribbar...

2013-05-19 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3924 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3924 To unsubscribe,

[PUSHED] Update pch

2013-05-09 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3831 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3831 To unsubscribe,

[PUSHED] Remove useless commented out code.

2013-04-27 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3631 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3631 To unsubscribe,

[PATCH] fdo#63749: #118845# corrected missing ressource for gallery ...

2013-04-20 Thread Thomas Arnhold (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3507 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/07/3507/1 fdo#63749: #118845# corrected missing ressource for gallery theme htmlexpo (cherry picked from commit

[PUSHED] Update pch

2013-04-17 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3427 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3427 To unsubscribe,

[PUSHED] fdo#62096 - replace some O(U)String compareTo with ==

2013-04-17 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3422 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3422 To unsubscribe,

[PATCH] fix Serbian dictionary makefile

2013-04-17 Thread Thomas Arnhold (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3428 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/dictionaries refs/changes/28/3428/1 fix Serbian dictionary makefile Change-Id: I49e678fc586c2352e9df805e8e32e645605144da --- M

[ABANDONED] fix Serbian dictionary makefile

2013-04-17 Thread Thomas Arnhold (via Code Review)
Thomas Arnhold has abandoned this change. Change subject: fix Serbian dictionary makefile .. Patch Set 1: Abandoned hrm... -- To view, visit https://gerrit.libreoffice.org/3428 To unsubscribe, visit

[PATCH] update dictionaries

2013-04-17 Thread Thomas Arnhold (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3429 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/29/3429/1 update dictionaries Change-Id: I0f693266b7c3621f885acbe450f4faead3d8284f --- M dictionaries 1 file changed, 0

[PUSHED] update dictionaries

2013-04-17 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3429 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3429 To unsubscribe,

[PUSHED] fdo#43157 - Clean up OSL_ASSERT, DBG_ASSERT

2013-04-17 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3423 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3423 To unsubscribe,

[PUSHED] General cleanup of OfficeBeans

2013-04-16 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3413 Approvals: Noel Grandin: Looks good to me, but someone else must approve Thomas Arnhold: Verified; Looks good to me, approved -- To

[PATCH] scp: remove unused macros

2013-04-16 Thread Thomas Arnhold (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3410 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/10/3410/1 scp: remove unused macros Change-Id: I48ac97bd6ac8cbd534e50c617f3d54ff10bd2908 --- M scp2/macros/macro.pl M

[PUSHED] fdo#39468 Translate German comments V2 - vcl/source/edit/{te...

2013-04-16 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3162 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3162 To unsubscribe,

[PUSHED] remove dead class SfxResourceManager

2013-04-15 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3393 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3393 To unsubscribe,

[PUSHED] Removal of Dead code

2013-04-15 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3392 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3392 To unsubscribe,

[PUSHED] Simple string cleanup in backingwindow.cxx

2013-04-15 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3377 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3377 To unsubscribe,

[PUSHED] remove dead code

2013-04-12 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3361 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3361 To unsubscribe,

[PUSHED] fdo#39468 Comment translation GER-ENG in sw/source/ui/wrtsh/...

2013-04-10 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3319 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3319 To unsubscribe,

[PATCH] fdo#63350 math: move stardard toolbar to the left

2013-04-10 Thread Thomas Arnhold (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3323 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/23/3323/1 fdo#63350 math: move stardard toolbar to the left Change-Id: I8f57d46737315caa41f7488e82262067a35f5253 --- M

[ABANDONED] fdo#63350 math: move stardard toolbar to the left

2013-04-10 Thread Thomas Arnhold (via Code Review)
Thomas Arnhold has abandoned this change. Change subject: fdo#63350 math: move stardard toolbar to the left .. Patch Set 1: Abandoned hrm this should be libreoffice-4-0 -- To view, visit https://gerrit.libreoffice.org/3323

[PATCH libreoffice-4-0] fdo#63350 math: move stardard toolbar to the left

2013-04-10 Thread Thomas Arnhold (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3324 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/24/3324/1 fdo#63350 math: move stardard toolbar to the left Change-Id: Ibadd1dff90383fb0a285a9cb94cc0050906e3f24 --- M

[PUSHED] fdo#39468: Translated German comments in filter

2013-04-03 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3178 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3178 To unsubscribe,

[PUSHED] fdo#39468 Translate German in DBG_ASSERT and OSL_ENSURE in t...

2013-04-03 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3163 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3163 To unsubscribe,

[PATCH] fdo#62525: use cow_wrapper for ViewInformation2D

2013-04-03 Thread Thomas Arnhold (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3183 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/83/3183/1 fdo#62525: use cow_wrapper for ViewInformation2D Change-Id: Ide3bce3257c9fed7bbda7276dfb55fa179d74fdd --- M

[PATCH] fdo#58807 bring Beep() for basic back

2013-04-03 Thread Thomas Arnhold (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3184 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/84/3184/1 fdo#58807 bring Beep() for basic back The functionality was removed by fdo#48549. This partially reverts

[ABANDONED] fdo#58807 bring Beep() for basic back

2013-04-03 Thread Thomas Arnhold (via Code Review)
Thomas Arnhold has abandoned this change. Change subject: fdo#58807 bring Beep() for basic back .. Patch Set 1: Abandoned -- To view, visit https://gerrit.libreoffice.org/3184 To unsubscribe, visit

[PATCH libreoffice-4-0] fdo#58807 bring Beep() for basic back

2013-04-03 Thread Thomas Arnhold (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3185 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/85/3185/1 fdo#58807 bring Beep() for basic back The functionality was removed by fdo#48549. This partially reverts

[PUSHED libreoffice-4-0] Keep semantics, but improve readibility.

2013-04-03 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3186 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3186 To unsubscribe,

[PATCH] unotools: remove some unused items

2013-04-03 Thread Thomas Arnhold (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3191 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/91/3191/1 unotools: remove some unused items Change-Id: I95bcac6a3ff8cf4644c9d1596c75cac2d9cd94fe --- M

[PUSHED] fdo#43157 - Clean up OSL_ASSERT, DBG_ASSERT

2013-04-03 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3179 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3179 To unsubscribe,

[PATCH] Revert Revert reduce some uglyness

2013-04-02 Thread Thomas Arnhold (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3171 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/71/3171/1 Revert Revert reduce some uglyness The header guard seems to solve the problem. This reverts commit

[PUSHED] vcl: convert some fprintf to SAL_INFO

2013-04-02 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3143 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3143 To unsubscribe,

[ABANDONED] API CHANGE: drop rtl::O[U]StringBuffer::{charAt, setCharAt}

2013-04-02 Thread Thomas Arnhold (via Code Review)
Thomas Arnhold has abandoned this change. Change subject: API CHANGE: drop rtl::O[U]StringBuffer::{charAt,setCharAt} .. Patch Set 1: Abandoned -- To view, visit https://gerrit.libreoffice.org/3155 To unsubscribe, visit

[PATCH] Remove RTL_CONSTASCII_(U)STRINGPARAM in bridges

2013-04-02 Thread Thomas Arnhold (via Code Review)
Hello LibreOffice gerrit bot, Luboš Luňák, I'd like you to reexamine a rebased change. Please visit https://gerrit.libreoffice.org/3139 to look at the new rebased patch set (#2). Change subject: Remove RTL_CONSTASCII_(U)STRINGPARAM in bridges

[PATCH] Remove SvtInternalOptions

2013-04-02 Thread Thomas Arnhold (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3180 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/80/3180/1 Remove SvtInternalOptions * only Get/SetCurrentTempURL were used, but only for compatibility reasons, to remove

[PUSHED] Comment translation GER-ENG in sw/source/ui/utlui/ (Part 3)

2013-04-01 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3144 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3144 To unsubscribe,

[PATCH] API CHANGE: drop rtl::O[U]StringBuffer::{charAt,setCharAt}

2013-04-01 Thread Thomas Arnhold (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3155 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/55/3155/1 API CHANGE: drop rtl::O[U]StringBuffer::{charAt,setCharAt} As a follow up of fdo#41474. See:

[PUSHED] Multiple typo fixes, small code changes

2013-03-31 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3135 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3135 To unsubscribe,

[PUSHED] fdo#62096 Replace O(U)String compareTo with ==

2013-03-31 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3136 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3136 To unsubscribe,

[PUSHED] Remove commented code in component.cxx (odk)

2013-03-31 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3137 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3137 To unsubscribe,

[PUSHED] Comment translation GER-ENG in sw/source/ui/utlui/ PART2

2013-03-31 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3129 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3129 To unsubscribe,

[PUSHED] Remove commented code in odk/examples

2013-03-31 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3138 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3138 To unsubscribe,

[PATCH] vcl: convert some fprintf to SAL_INFO

2013-03-31 Thread Thomas Arnhold (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3143 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/43/3143/1 vcl: convert some fprintf to SAL_INFO Change-Id: I4b9a20e62e8e137a1bfaa1c654307f15c33e3d3c --- M

[PATCH] fdo#58807 bring Beep() for basic back

2013-03-30 Thread Thomas Arnhold (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3124 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/24/3124/1 fdo#58807 bring Beep() for basic back The functionality was removed by fdo#48549. This partially reverts

[PATCH] drawinglayer depends on o3tl_inc

2013-03-30 Thread Thomas Arnhold (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3125 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/25/3125/1 drawinglayer depends on o3tl_inc Change-Id: I9dab86e62eb34819be1564b3d7be50cf6acb6f73 --- M

[ABANDONED] drawinglayer depends on o3tl_inc

2013-03-30 Thread Thomas Arnhold (via Code Review)
Thomas Arnhold has abandoned this change. Change subject: drawinglayer depends on o3tl_inc .. Patch Set 1: Abandoned Not needed. Thanks David :) -- To view, visit https://gerrit.libreoffice.org/3125 To unsubscribe, visit

[PATCH] OSL_FAIL - SAL_WARN

2013-03-29 Thread Thomas Arnhold (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3121 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/21/3121/1 OSL_FAIL - SAL_WARN Change-Id: I1871e5e3a319b2d5177ae4bd470046c022c14eb7 --- M

[PUSHED] Comment translation GER-ENG in sw/source/ui/utlui/ (Part1)

2013-03-29 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3101 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3101 To unsubscribe,

[PUSHED] String::AppendAscii cleanup in dbaccess

2013-03-28 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3068 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3068 To unsubscribe,

[PUSHED] Cleanup comments and some translations in style.cxx

2013-03-26 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3062 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3062 To unsubscribe,

[PUSHED] Translate German comments, fix some ws

2013-03-26 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3063 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3063 To unsubscribe,

[PUSHED] fdo#39468 Translate German comments - vcl/source/control/

2013-03-26 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2966 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2966 To unsubscribe,

[PATCH] fdo#62525: use cow_wrapper for FontAttribute

2013-03-26 Thread Thomas Arnhold (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3074 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/74/3074/1 fdo#62525: use cow_wrapper for FontAttribute Change-Id: Ic07da7c7cf225a910e6f0fa4f6d20c4700e7ec7a --- M

[PATCH] fdo#62525: use cow_wrapper for FillHatchAttribute

2013-03-26 Thread Thomas Arnhold (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3073 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/73/3073/1 fdo#62525: use cow_wrapper for FillHatchAttribute Change-Id: I1581b4bca6f14bd27af12ff40a4f4c0fe08af133 --- M

[PUSHED] Translate German comments, fix some whitespace

2013-03-25 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2916 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2916 To unsubscribe,

[PATCH] Fix spelling errors and typos: 'unkown' change to 'unknown'

2013-03-25 Thread Thomas Arnhold (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3030 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/30/3030/1 Fix spelling errors and typos: 'unkown' change to 'unknown' Change-Id:

[ABANDONED] [draft] use pragma once

2013-03-24 Thread Thomas Arnhold (via Code Review)
Thomas Arnhold has abandoned this change. Change subject: [draft] use pragma once .. Patch Set 3: Abandoned Not as easy as it seems. Clashes with Windows headers at least. Why ever... -- To view, visit

[PUSHED] General comment cleanup for demo/test vcl apps

2013-03-23 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2921 Approvals: Tor Lillqvist: Verified; Looks good to me, approved Thomas Arnhold: -- To view, visit https://gerrit.libreoffice.org/2921

[PUSHED] Improve size and positions of widgets for CustomAnimationDia...

2013-03-23 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2932 -- To view, visit https://gerrit.libreoffice.org/2932 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

[PUSHED] fdo#39468 Translate German comments - vcl/win/source/app

2013-03-23 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2938 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2938 To unsubscribe,

[PATCH] wip

2013-03-23 Thread Thomas Arnhold (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2944 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/44/2944/1 wip Change-Id: I23427e1e3bfb583ef10123577ebec76af617f917 --- M vcl/inc/vcl/bitmap.hxx M

[PATCH] fdo#62525: use cow_wrapper for SdrShadowAttribute

2013-03-23 Thread Thomas Arnhold (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2945 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/45/2945/1 fdo#62525: use cow_wrapper for SdrShadowAttribute Thanks to Thorsten. Change-Id:

[ABANDONED] wip

2013-03-23 Thread Thomas Arnhold (via Code Review)
Thomas Arnhold has abandoned this change. Change subject: wip .. Patch Set 1: Abandoned ... -- To view, visit https://gerrit.libreoffice.org/2944 To unsubscribe, visit https://gerrit.libreoffice.org/settings

[PATCH] fdo#62525: use cow_wrapper for SdrShadowAttribute

2013-03-23 Thread Thomas Arnhold (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2946 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/46/2946/1 fdo#62525: use cow_wrapper for SdrShadowAttribute Thanks to Thorsten. Change-Id:

[ABANDONED] fdo#62525: use cow_wrapper for SdrShadowAttribute

2013-03-23 Thread Thomas Arnhold (via Code Review)
Thomas Arnhold has abandoned this change. Change subject: fdo#62525: use cow_wrapper for SdrShadowAttribute .. Patch Set 1: Abandoned bla -- To view, visit https://gerrit.libreoffice.org/2945 To unsubscribe, visit

[PATCH] fdo#62525: use cow_wrapper for FillBitmapAttribute

2013-03-23 Thread Thomas Arnhold (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2948 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/48/2948/1 fdo#62525: use cow_wrapper for FillBitmapAttribute Change-Id: I0f666d4baaf6dc4e9f7ea30a518a8904f01d749f --- M

[PATCH] fdo#62525: use cow_wrapper for FillGradientAttribute

2013-03-23 Thread Thomas Arnhold (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2951 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/51/2951/1 fdo#62525: use cow_wrapper for FillGradientAttribute Change-Id: I85a9864820f49da8ebcc4a7d2c80a3c9d0c13b27 --- M

[PUSHED] Change duplicate short-cut Alt-I-U

2013-03-23 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2943 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2943 To unsubscribe,

[PATCH] fdo#62525: use cow_wrapper for FillGradientAttribute

2013-03-23 Thread Thomas Arnhold (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2954 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/54/2954/1 fdo#62525: use cow_wrapper for FillGradientAttribute a xmlsecurity/workben/signaturetest.cxx.wo

[PUSHED] fdo#39468 Translate German Comments - salframe.cxx

2013-03-23 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2931 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2931 To unsubscribe,

[PUSHED] fdo#39468 Translate German comments - vcl/win/source/gdi/

2013-03-23 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2937 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2937 To unsubscribe,

[PATCH] basic: Remove non working AboutStarBasic

2013-03-21 Thread Thomas Arnhold (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2899 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/99/2899/1 basic: Remove non working AboutStarBasic The content of this function was commented out since the first import.

[PATCH] clean up DBG_ERRORn

2013-03-21 Thread Thomas Arnhold (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2900 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/00/2900/1 clean up DBG_ERRORn Those were DBG_ERRORn before and were falsely changed to OSL_TRACE by me. See:

[PUSHED] Comment translation GER-ENG in sw/source/ui/wrtsh/

2013-03-21 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2902 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2902 To unsubscribe,

[PUSHED] Comment translation - GER-ENG in sw/source/ui/wrtsh/wrtsh1.c...

2013-03-21 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2883 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2883 To unsubscribe,

[PATCH] this looks better

2013-03-20 Thread Thomas Arnhold (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2874 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/74/2874/1 this looks better Change-Id: I10af9ff8513f8f583867d0d6a18af03b3b5b1a28 --- M

[PUSHED] automated removal of RTL_CONSTASCII_USTRINGPARAM for quoted ...

2013-03-19 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2832 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2832 To unsubscribe,

[PATCH] removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings ...

2013-03-19 Thread Thomas Arnhold (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2835 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/35/2835/1 removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings declarations

[PUSHED] removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings ...

2013-03-19 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2835 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2835 To unsubscribe,

[PUSHED] fdo#38838, String to OUString, in dbaccess/source/ui/browser

2013-03-14 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2538 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2538 To unsubscribe,

[PUSHED] fdo#38838, String to OUString in dbaccess

2013-03-14 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2386 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2386 To unsubscribe,

  1   2   >