Re: [Libreoffice] [REVIEW] Fixing layout breakage in pivot table dialog

2011-09-07 Thread Kohei Yoshida
On Tue, 2011-08-30 at 16:55 -0400, Kohei Yoshida wrote: Hi there, I'd like to have http://cgit.freedesktop.org/libreoffice/core/commit/?id=8bf60230255e0e8da66cafff578f148858cee4ca cherry-picked to the 3.4 branch. A patch for this commit is attached as well for convenience. ...

Re: [Libreoffice] [REVIEW] Fixing layout breakage in pivot table dialog

2011-09-01 Thread Jan Holesovsky
Hi Kohei, On 2011-08-30 at 16:55 -0400, Kohei Yoshida wrote: http://cgit.freedesktop.org/libreoffice/core/commit/?id=8bf60230255e0e8da66cafff578f148858cee4ca cherry-picked to the 3.4 branch. A patch for this commit is attached as well for convenience. This fixes a slight layout problem

Re: [Libreoffice] [REVIEW] Fixing layout breakage in pivot table dialog

2011-09-01 Thread Kohei Yoshida
Hi Kendy, On Thu, 2011-09-01 at 11:59 +0200, Jan Holesovsky wrote: The patch generally looks fine - I just wonder, why there is the vertical compression, and why only on XP? Isn't the root cause something in vcl? The thing is, I don't even know this vertical compression is a defect. It may

[Libreoffice] [REVIEW] Fixing layout breakage in pivot table dialog

2011-08-30 Thread Kohei Yoshida
Hi there, I'd like to have http://cgit.freedesktop.org/libreoffice/core/commit/?id=8bf60230255e0e8da66cafff578f148858cee4ca cherry-picked to the 3.4 branch. A patch for this commit is attached as well for convenience. This fixes a slight layout problem in the main pivot table dialog, where