https://bugs.documentfoundation.org/show_bug.cgi?id=130795
Commit Notification changed:
What|Removed |Added
Whiteboard|target:7.3.0 inReleaseNotes |target:7.3.0
https://bugs.documentfoundation.org/show_bug.cgi?id=130795
--- Comment #35 from Commit Notification
---
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":
https://git.libreoffice.org/core/commit/938c899831bd5b165b2b7db3945867a1ce155483
tdf#150452: Revert
https://bugs.documentfoundation.org/show_bug.cgi?id=130795
--- Comment #37 from Commit Notification
---
Xisco Fauli committed a patch related to this issue.
It has been pushed to "libreoffice-7-4":
https://git.libreoffice.org/core/commit/3d415a3d1ccd89d29a58a52a1d569f6ccff28416
tdf#150452:
https://bugs.documentfoundation.org/show_bug.cgi?id=130795
--- Comment #36 from Commit Notification
---
Xisco Fauli committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":
https://git.libreoffice.org/core/commit/dbfa68a56f087f06ac325a442c6cb0e99f3ecd53
tdf#150452:
https://bugs.documentfoundation.org/show_bug.cgi?id=130795
Commit Notification changed:
What|Removed |Added
Whiteboard|target:7.3.0 inReleaseNotes |target:7.3.0
https://bugs.documentfoundation.org/show_bug.cgi?id=130795
Commit Notification changed:
What|Removed |Added
Whiteboard|target:7.3.0 inReleaseNotes |target:7.3.0
https://bugs.documentfoundation.org/show_bug.cgi?id=130795
Xisco Faulí changed:
What|Removed |Added
See Also||https://bugs.documentfounda
https://bugs.documentfoundation.org/show_bug.cgi?id=130795
stragu changed:
What|Removed |Added
Whiteboard|target:7.3.0|target:7.3.0 inReleaseNotes
https://bugs.documentfoundation.org/show_bug.cgi?id=130795
Xisco Faulí changed:
What|Removed |Added
Resolution|WORKSFORME |FIXED
--- Comment #33 from Xisco
https://bugs.documentfoundation.org/show_bug.cgi?id=130795
Elmar changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
https://bugs.documentfoundation.org/show_bug.cgi?id=130795
Xisco Faulí changed:
What|Removed |Added
See Also||https://bugs.documentfounda
https://bugs.documentfoundation.org/show_bug.cgi?id=130795
--- Comment #31 from Xisco Faulí ---
(In reply to Luboš Luňák from comment #30)
> Changes for bug #139444 now avoid use of SharedStringPool::intern() here
> altogether, and it's reasonably fast.
>
> I don't know if we still need
https://bugs.documentfoundation.org/show_bug.cgi?id=130795
--- Comment #30 from Luboš Luňák ---
Changes for bug #139444 now avoid use of SharedStringPool::intern() here
altogether, and it's reasonably fast.
I don't know if we still need libcuckoo after this, keeping this open in case
Noel wants
https://bugs.documentfoundation.org/show_bug.cgi?id=130795
--- Comment #29 from Julien Nabet ---
Created attachment 175094
--> https://bugs.documentfoundation.org/attachment.cgi?id=175094=edit
perf flamegraph
Thank you Noel for the patches!
For those interested, here's a brand new Flamegraph
https://bugs.documentfoundation.org/show_bug.cgi?id=130795
Julien Nabet changed:
What|Removed |Added
Attachment #174931|0 |1
is obsolete|
https://bugs.documentfoundation.org/show_bug.cgi?id=130795
Julien Nabet changed:
What|Removed |Added
Attachment #158062|0 |1
is obsolete|
https://bugs.documentfoundation.org/show_bug.cgi?id=130795
--- Comment #28 from Noel Grandin ---
After doing several rounds of optimisation to the uppercase machinery, I can
get it to be __almost__ as fast as using the SharedStringPool :-)
Possibly there is some stuff that could be done with
https://bugs.documentfoundation.org/show_bug.cgi?id=130795
--- Comment #27 from Luboš Luňák ---
That said, looking at the profiling of the comment #25 code, the majority of
time spent there is not spent actually uppercasing the string, it's spent in
lock contention and the i18n classes
https://bugs.documentfoundation.org/show_bug.cgi?id=130795
--- Comment #26 from Luboš Luňák ---
No, that's the code I had in mind, I assumed that intern() would be slower than
using the string directly, as was the case with bug #144249.
--
You are receiving this mail because:
You are the
https://bugs.documentfoundation.org/show_bug.cgi?id=130795
--- Comment #25 from Noel Grandin ---
(In reply to Luboš Luňák from comment #21)
> The real problem here is not that SharedStringPool would be slow, but that
> ScTable::ValidQuery()/QueryEvaluator calls it at all. If you look at how
https://bugs.documentfoundation.org/show_bug.cgi?id=130795
--- Comment #24 from Luboš Luňák ---
> So we could also remove the brand new lib dependency on cuckoo (unless it
> could be used for something else?)
I think so.
> Kohei was in the trio Calc experts (Eike, Kohei, Markus), so I suppose
https://bugs.documentfoundation.org/show_bug.cgi?id=130795
Julien Nabet changed:
What|Removed |Added
CC||er...@redhat.com
--- Comment #23
https://bugs.documentfoundation.org/show_bug.cgi?id=130795
--- Comment #22 from Luboš Luňák ---
(The relevant commit for bug #144249 being
https://git.libreoffice.org/core/commit/d0316985db22efd6708dffa173eaabb430f6b9a8,
I did not CC the bugreport on that one. And I don't know if I'll have the
https://bugs.documentfoundation.org/show_bug.cgi?id=130795
Luboš Luňák changed:
What|Removed |Added
CC||l.lu...@collabora.com
--- Comment
https://bugs.documentfoundation.org/show_bug.cgi?id=130795
--- Comment #20 from Xisco Faulí ---
it takes
real0m17,823s
user0m26,524s
sys 0m1,320s
with the commit from comment 18, while it takes
real0m28,101s
user0m38,720s
sys 0m7,812s
without it. Nice improvement
--
https://bugs.documentfoundation.org/show_bug.cgi?id=130795
--- Comment #19 from Julien Nabet ---
Created attachment 174931
--> https://bugs.documentfoundation.org/attachment.cgi?id=174931=edit
perf flamegraph
Here's the Flamegraph retrieved on pc Debian x86-64 with master sources updated
https://bugs.documentfoundation.org/show_bug.cgi?id=130795
--- Comment #18 from Commit Notification
---
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":
https://git.libreoffice.org/core/commit/3749d9af3745c0eaff7239e379578e4e2af89e9d
tdf#130795 use
https://bugs.documentfoundation.org/show_bug.cgi?id=130795
--- Comment #17 from Noel Grandin ---
(In reply to Timur from comment #16)
> On fileopen we see "Adapt row height" so it indicates where time is spent.
Not in this case, profiler says time is now all over the place.
https://bugs.documentfoundation.org/show_bug.cgi?id=130795
--- Comment #16 from Timur ---
Linux 7.3+, same system:
Pre fix 1st time:
real0m36,454s
user0m58,049s
sys 0m3,584s
Pre fix 2st time:
real0m33,827s
user0m52,990s
sys 0m2,951s
Post-fix
https://bugs.documentfoundation.org/show_bug.cgi?id=130795
--- Comment #15 from Commit Notification
---
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":
https://git.libreoffice.org/core/commit/41a46a306f40a7296c56bdeea0ba8a6d630aa15c
dynamic_cast ->
https://bugs.documentfoundation.org/show_bug.cgi?id=130795
Commit Notification changed:
What|Removed |Added
Whiteboard||target:7.3.0
--
You are
https://bugs.documentfoundation.org/show_bug.cgi?id=130795
Timur changed:
What|Removed |Added
Version|4.4 all versions|6.2.0.3 release
--
You are receiving
https://bugs.documentfoundation.org/show_bug.cgi?id=130795
Timur changed:
What|Removed |Added
Keywords||regression
--
You are receiving this
https://bugs.documentfoundation.org/show_bug.cgi?id=130795
Timur changed:
What|Removed |Added
OS|Linux (All) |All
--
You are receiving this mail
https://bugs.documentfoundation.org/show_bug.cgi?id=130795
Timur changed:
What|Removed |Added
Blocks||125077
Referenced Bugs:
https://bugs.documentfoundation.org/show_bug.cgi?id=130795
--- Comment #14 from Timur ---
Linux 5.2 m:
real0m31,827s
user0m18,338s
sys 0m0,799s
Linux 6.0 m:
real0m39,547s
user0m21,360s
sys 0m1,238s
Linux 6.2 pre 1e55a47e89a9d9d6cf9cb3993484022aaf2c097b (time spent on
https://bugs.documentfoundation.org/show_bug.cgi?id=130795
Timur changed:
What|Removed |Added
See Also|https://bugs.documentfounda |
https://bugs.documentfoundation.org/show_bug.cgi?id=130795
Telesto changed:
What|Removed |Added
See Also||https://bugs.documentfounda
https://bugs.documentfoundation.org/show_bug.cgi?id=130795
Xisco Faulí changed:
What|Removed |Added
See Also||https://bugs.documentfounda
https://bugs.documentfoundation.org/show_bug.cgi?id=130795
Xisco Faulí changed:
What|Removed |Added
CC||noelgran...@gmail.com
--- Comment
https://bugs.documentfoundation.org/show_bug.cgi?id=130795
--- Comment #12 from Julien Nabet ---
Created attachment 158062
--> https://bugs.documentfoundation.org/attachment.cgi?id=158062=edit
Flamegraph
Here's a Flamegraph retrieved on pc Debian x86-64 with master sources updated
today.
--
https://bugs.documentfoundation.org/show_bug.cgi?id=130795
Xisco Faulí changed:
What|Removed |Added
Version|6.1 all versions|4.4 all versions
--- Comment #11
https://bugs.documentfoundation.org/show_bug.cgi?id=130795
Xisco Faulí changed:
What|Removed |Added
Keywords|bibisectRequest, regression |bibisected, bisected
--- Comment
https://bugs.documentfoundation.org/show_bug.cgi?id=130795
Xisco Faulí changed:
What|Removed |Added
Keywords||bibisectRequest, regression
https://bugs.documentfoundation.org/show_bug.cgi?id=130795
--- Comment #8 from Xisco Faulí ---
(In reply to Elmar from comment #6)
> How come v6.0 is so much faster?
> When check edit/links, shows that the setting is "manual" - so should it not
> check that and ignore the links?
> v6.0 also has
https://bugs.documentfoundation.org/show_bug.cgi?id=130795
Xisco Faulí changed:
What|Removed |Added
Version|5.2 all versions|4.4 all versions
--- Comment #7
https://bugs.documentfoundation.org/show_bug.cgi?id=130795
--- Comment #6 from Elmar ---
How come v6.0 is so much faster?
When check edit/links, shows that the setting is "manual" - so should it not
check that and ignore the links?
v6.0 also has a progress bar - not shown in v7
(at least one
https://bugs.documentfoundation.org/show_bug.cgi?id=130795
--- Comment #5 from Julien Nabet ---
(In reply to Xisco Faulí from comment #4)
> @Julien, would it be possible to have a perfchart for this issue ?
No pb, I'll do it after my daytime job.
--
You are receiving this mail because:
You
https://bugs.documentfoundation.org/show_bug.cgi?id=130795
Xisco Faulí changed:
What|Removed |Added
CC||serval2...@yahoo.fr
--- Comment
https://bugs.documentfoundation.org/show_bug.cgi?id=130795
Xisco Faulí changed:
What|Removed |Added
Version|7.0.0.0.alpha0+ Master |5.2 all versions
--- Comment #3
https://bugs.documentfoundation.org/show_bug.cgi?id=130795
Xisco Faulí changed:
What|Removed |Added
Keywords||perf
CC|
51 matches
Mail list logo
