[Libreoffice-bugs] [Bug 116936] Firebird SDBC should implement XRowUpdate interface

https://bugs.documentfoundation.org/show_bug.cgi?id=116936 Robert Großkopf changed: What|Removed |Added Blocks||154426 Referenced Bugs:

[Libreoffice-bugs] [Bug 116936] Firebird SDBC should implement XRowUpdate interface

https://bugs.documentfoundation.org/show_bug.cgi?id=116936 --- Comment #21 from QA Administrators --- Dear Lionel Elie Mamane, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not

[Libreoffice-bugs] [Bug 116936] Firebird SDBC should implement XRowUpdate interface

https://bugs.documentfoundation.org/show_bug.cgi?id=116936 --- Comment #20 from Julien Nabet --- (In reply to Lionel Elie Mamane from comment #14) > So, I'm sitting with btomi96 right now... The firebird driver says it > supports only read-only in ODatabaseMetaData::supportsResultSetConcurrency

[Libreoffice-bugs] [Bug 116936] Firebird SDBC should implement XRowUpdate interface

https://bugs.documentfoundation.org/show_bug.cgi?id=116936 --- Comment #19 from Julien Nabet --- With: m_nResultSetConcurrency(css::sdbc::ResultSetConcurrency::UPDATABLE) instead of m_nResultSetConcurrency(css::sdbc::ResultSetConcurrency::READ_ONLY) + empty implementation of

[Libreoffice-bugs] [Bug 116936] Firebird SDBC should implement XRowUpdate interface

https://bugs.documentfoundation.org/show_bug.cgi?id=116936 --- Comment #18 from Julien Nabet --- It seems we need to implement com/sun/star/sdbc/XResultSetUpdate.hpp I'll keep on this lead. -- You are receiving this mail because: You are the assignee for the

[Libreoffice-bugs] [Bug 116936] Firebird SDBC should implement XRowUpdate interface

https://bugs.documentfoundation.org/show_bug.cgi?id=116936 --- Comment #17 from Julien Nabet --- After having waited for the whole build whereas I just added some traces on dbaccess part, the pb is m_xDelegatorResultSetUpdate isn't defined. Here are the console logs: m_nResultSetConcurrency ==

[Libreoffice-bugs] [Bug 116936] Firebird SDBC should implement XRowUpdate interface

https://bugs.documentfoundation.org/show_bug.cgi?id=116936 --- Comment #16 from Julien Nabet --- About "support record deletion and insertion, see the IDL interface", is it related to XRowUpdate interface? -- You are receiving this mail because: You are the assignee for the

[Libreoffice-bugs] [Bug 116936] Firebird SDBC should implement XRowUpdate interface

https://bugs.documentfoundation.org/show_bug.cgi?id=116936 --- Comment #15 from Julien Nabet --- (In reply to Lionel Elie Mamane from comment #14) > So, I'm sitting with btomi96 right now... The firebird driver says it > supports only read-only in ODatabaseMetaData::supportsResultSetConcurrency

[Libreoffice-bugs] [Bug 116936] Firebird SDBC should implement XRowUpdate interface

https://bugs.documentfoundation.org/show_bug.cgi?id=116936 --- Comment #14 from Lionel Elie Mamane --- So, I'm sitting with btomi96 right now... The firebird driver says it supports only read-only in ODatabaseMetaData::supportsResultSetConcurrency in DatabaseMetaData.cxx That's why... That

[Libreoffice-bugs] [Bug 116936] Firebird SDBC should implement XRowUpdate interface

https://bugs.documentfoundation.org/show_bug.cgi?id=116936 --- Comment #13 from Julien Nabet --- (In reply to Lionel Elie Mamane from comment #9) > It should be ThisDatabaseDocument everywhere, without (). > > For the read-only thing, btomi96? Typing this on windbg: bp `resultset.cxx:987` then

[Libreoffice-bugs] [Bug 116936] Firebird SDBC should implement XRowUpdate interface

https://bugs.documentfoundation.org/show_bug.cgi?id=116936 --- Comment #12 from Lionel Elie Mamane --- The said wrapper code seems to be in dbaccess/source/core/api/datacolumn.cxx and does exactly what I suggested (call XRowUpdate with the column number filled in, passing the value). -- You

[Libreoffice-bugs] [Bug 116936] Firebird SDBC should implement XRowUpdate interface

https://bugs.documentfoundation.org/show_bug.cgi?id=116936 --- Comment #11 from Lionel Elie Mamane --- (In reply to Julien Nabet from comment #10) > there's no driver in connectivity which implements this. > But let's say Firebird would be the first one. Oh. It definitely works with other

[Libreoffice-bugs] [Bug 116936] Firebird SDBC should implement XRowUpdate interface

https://bugs.documentfoundation.org/show_bug.cgi?id=116936 --- Comment #10 from Julien Nabet --- (In reply to Lionel Elie Mamane from comment #7) > For column, the interface is > css::sdb::XColumnUpdate > https://api.libreoffice.org/docs/idl/ref/ >

[Libreoffice-bugs] [Bug 116936] Firebird SDBC should implement XRowUpdate interface

https://bugs.documentfoundation.org/show_bug.cgi?id=116936 --- Comment #9 from Lionel Elie Mamane --- It should be ThisDatabaseDocument everywhere, without (). For the read-only thing, btomi96? -- You are receiving this mail because: You are the assignee for the

[Libreoffice-bugs] [Bug 116936] Firebird SDBC should implement XRowUpdate interface

https://bugs.documentfoundation.org/show_bug.cgi?id=116936 --- Comment #8 from Julien Nabet --- (In reply to Lionel Elie Mamane from comment #6) > Did you put the macro in the ODB file, not in a more general (e.g. > user-wide) location? Oups! I made the change, I got this error now: BASIC

[Libreoffice-bugs] [Bug 116936] Firebird SDBC should implement XRowUpdate interface

https://bugs.documentfoundation.org/show_bug.cgi?id=116936 --- Comment #7 from Lionel Elie Mamane --- For column, the interface is css::sdb::XColumnUpdate https://api.libreoffice.org/docs/idl/ref/interfacecom_1_1sun_1_1star_1_1sdb_1_1XColumnUpdate.html#a9e6ad31e91c912e9f1dfa7480d9e312a

[Libreoffice-bugs] [Bug 116936] Firebird SDBC should implement XRowUpdate interface

https://bugs.documentfoundation.org/show_bug.cgi?id=116936 --- Comment #6 from Lionel Elie Mamane --- Did you put the macro in the ODB file, not in a more general (e.g. user-wide) location? -- You are receiving this mail because: You are the assignee for the

[Libreoffice-bugs] [Bug 116936] Firebird SDBC should implement XRowUpdate interface

https://bugs.documentfoundation.org/show_bug.cgi?id=116936 --- Comment #5 from Julien Nabet --- I got: "BASIC runtime error. Object variable not set." at the line 4: DBDocUI = ThisDatabaseDocument.currentController Idem if I put: DBDocUI = ThisDatabaseDocument().currentController About column,

[Libreoffice-bugs] [Bug 116936] Firebird SDBC should implement XRowUpdate interface

https://bugs.documentfoundation.org/show_bug.cgi?id=116936 --- Comment #4 from Lionel Elie Mamane --- To test: create a firebird-embedded database; put some data in it Create a Basic macros like and run the Tst macro Sub ensureConnection() Dim DBDocUI as Object DBDocUI =

[Libreoffice-bugs] [Bug 116936] Firebird SDBC should implement XRowUpdate interface

https://bugs.documentfoundation.org/show_bug.cgi?id=116936 --- Comment #3 from Julien Nabet --- Created attachment 154151 --> https://bugs.documentfoundation.org/attachment.cgi?id=154151=edit First patch draft Here's a first draft of patch which can be applied locally with a plain "git apply

[Libreoffice-bugs] [Bug 116936] Firebird SDBC should implement XRowUpdate interface

https://bugs.documentfoundation.org/show_bug.cgi?id=116936 --- Comment #2 from Lionel Elie Mamane --- You go the right direction, but I doubt it will be 100% a straight copy/paste of updateXXX to setXXX. btomi, you want to mentor Julien through this? -- You are receiving this mail because:

[Libreoffice-bugs] [Bug 116936] Firebird SDBC should implement XRowUpdate interface

https://bugs.documentfoundation.org/show_bug.cgi?id=116936 --- Comment #1 from Julien Nabet --- Just to be sure to understand, it would mean: copy paste template void OPreparedStatement::setValue(sal_Int32 nIndex, const T& nValue, ISC_SHORT nType) from PreparedStatement.cxx into ResultSet.cxx

[Libreoffice-bugs] [Bug 116936] Firebird SDBC should implement XRowUpdate interface

https://bugs.documentfoundation.org/show_bug.cgi?id=116936 Lionel Elie Mamane changed: What|Removed |Added Blocks||116970

[Libreoffice-bugs] [Bug 116936] Firebird SDBC should implement XRowUpdate interface

https://bugs.documentfoundation.org/show_bug.cgi?id=116936 Michael Meeks changed: What|Removed |Added Status|UNCONFIRMED |NEW

[Libreoffice-bugs] [Bug 116936] Firebird SDBC should implement XRowUpdate interface

https://bugs.documentfoundation.org/show_bug.cgi?id=116936 Lionel Elie Mamane changed: What|Removed |Added CC|